| 00:18.26 | znf | I've killed it twice on my druid |
| 00:18.30 | znf | the first time I got 4 epics |
| 00:18.35 | znf | the 2nd time I got 1 :P |
| 00:18.44 | znf | on my priest I get nothing |
| 00:22.34 | nevcairiel | i got 4 items during beta, not sure i even did it on live |
| 00:23.24 | znf | I do it for the easy calling |
| 00:23.42 | znf | The "defend bastion" one has that mob giving 80% |
| 00:23.50 | znf | if you wait around for someone else to come summon, you can get 100% |
| 00:24.00 | znf | and you also get the 3x rare coins from that encounter |
| 00:24.01 | znf | it's easy mode :P |
| 00:28.25 | Chipzz | yeah same deal for me, easy calling |
| 00:50.34 | *** join/#wowuidev Seerah (~umsin@2600:1700:aac0:82e0:490:191c:66c9:1cd2) |
| 00:50.34 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 01:16.21 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:a189:ce96:8585:d4a2) |
| 04:02.45 | *** part/#wowuidev Seerah (~umsin@2600:1700:aac0:82e0:490:191c:66c9:1cd2) |
| 09:49.03 | *** join/#wowuidev Sharparam (~Sharparam@solaire.sharparam.com) |
| 11:26.28 | *** join/#wowuidev Treeston (~stolenleg@unaffiliated/stolenlegacy) |
| 11:49.33 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 13:38.45 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 14:43.19 | *** join/#wowuidev Kalroth (~Kalroth@knas.io) |
| 16:10.43 | *** join/#wowuidev Yuyuli (~Yuyuli@85-127-144-177.dsl.dynamic.surfer.at) |
| 16:49.58 | *** join/#wowuidev Meorawr (~Meorawr@cpc157781-rdng31-2-0-cust996.15-3.cable.virginm.net) |
| 17:28.49 | *** join/#wowuidev cirdan_ (~cirdan@2601:85:4601:4d60:f64d:30ff:fe60:210d) |
| 17:59.11 | *** join/#wowuidev Crosshash (c64a2302@198.74.35.2) |
| 17:59.11 | *** mode/#wowuidev [+o Crosshash] by ChanServ |
| 18:37.41 | Yuyuli | hey crosshash i have two questions, is COMMODITY_PURCHASED supposed to exist (its in the api docs, but it's not used) and i was playing with animations, and when i animated an Editbox on which i set the text to be highlighted, the highlight would not inherent the alpha of the animation but the font would, so i had to highlight the text after the animation finished instead. Is that a bug or a limitation |
| 18:42.12 | Crosshash | Looks like it was supplanted by COMMODITY_PURCHASE_SUCCEEDED |
| 18:43.55 | Crosshash | I don't know about the editbox. Probably the highlight was missed. |
| 18:45.12 | Yuyuli | here is a gif of the editbox highlight issue https://i.imgur.com/fzVauea.gifv |
| 18:45.35 | Yuyuli | looks like translation also doesn't work |
| 18:46.46 | Yuyuli | would be nice if that was fixed in a future update ^^ |
| 18:47.21 | Crosshash | Yeah, I don't expect any animations to work with the highlight |
| 18:47.37 | Yuyuli | though it's not that big of a deal, as it prolly would look strange even if it worked correctly, and highlighting after most of the animation is done is fine too |
| 19:17.24 | Chipzz | Crosshash: wrt bindings, the API currently provides SetBindingClick / SetBindingItem / SetBindingMacro / SetBindingSpell . is there an API to set the script for a binding like SetBindingScript, and if not, would it make sense to have that? |
| 19:18.22 | nevcairiel | you could just make a button and bind to that, with all the possibilities |
| 19:19.21 | Chipzz | that's not exactly what I meant |
| 19:20.02 | Chipzz | SetBindingClick has (key, ButtonName, mouse_button) signature |
| 19:20.17 | Chipzz | SetBindingScript would have (command, script) signature |
| 19:20.40 | Chipzz | it would set the script to be executed as you would specify it in Bindings.xml |
| 19:22.02 | Chipzz | SetBindingClick could then be implemented as a pure lua function in terms of SetBindingScript |
| 19:25.12 | Meorawr | I think that idea would have pretty significant security issues given the bindings cache has no concept of taint - unless it assumed all script bindings should be loaded insecurely. |
| 19:25.30 | Meorawr | (Which would then mean implementing SetBindingClick in terms of a script wouldn't work, I think) |
| 19:50.35 | Chipzz | SetBindingClick could still be implemented in terms of SetBindingScript on the C side |
| 19:51.05 | Chipzz | and you can specify binding scripts in Bindings.xml too, so not sure how relevant taint is? |
| 19:55.22 | Meorawr | The security of scripts loaded from Bindings.xml files depends upon whether or not it's an insecure addon loading them or not; for example the binding scripts loaded by the commentator stuff aren't tainted at creation, whereas anything supplied by an addon would. |
| 19:56.24 | Meorawr | Problem is the bindings cache doesn't have any concept of knowing whether or not a binding was/wasn't set by an addon, so presumably for your idea to work it'd have to assume that all script bindings should be treated as insecure otherwise you could literally just create a script binding that'd conditionally cast a spell. |
| 19:58.40 | Meorawr | Which is a sensible assumption for the client to have to make, but it makes reimplementing anything like SetBindingClick in terms of a script binding impossible. |
| 19:59.31 | Meorawr | Plus I'm personally not seeing what this idea even solves given the complexity of the changes required - the bindings cache format wouldn't exactly support custom scripts at all in its current incarnation. |
| 20:00.48 | Meorawr | Also there's the other problem of how do you represent a custom script binding in the keybindings UI without declaring a Binding element in XML? |
| 20:01.25 | Meorawr | Would be problematic is a user loaded a weakaura that installed a script binding to delete all the users' gear when spacebar is pressed without any way in the keybindings UI to unset said binding. |
| 20:02.36 | Meorawr | Not that the problem couldn't already exist with current functionality, but it requires a few extra hoops - a custom script binding would be "permanent" in a sense as it'd presumably persist even after the addon that installed it were disabled. |
| 20:05.34 | Chipzz | I'm currently in an instance but the last part of what you said makes no sense |
| 20:05.39 | Chipzz | you have to reread what I said |
| 20:05.50 | Chipzz | 20:20 < Chipzz> SetBindingScript would have (command, script) signature |
| 20:06.13 | Chipzz | SetBindingScript would cbange the script bound to a *command*, not to a *key* |
| 20:06.29 | Chipzz | and there is currently no way to create new bindings |
| 20:07.48 | Meorawr | So the intent would be that it just replaces the script executed by a binding? |
| 20:09.33 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ea6:bb00:4103:346b:f75e:8d44) |
| 20:12.23 | Chipzz | yes |
| 20:12.24 | Chipzz | also |
| 20:12.39 | Chipzz | the problem you describe with weakauras is one that exists now too? |
| 20:12.46 | Meorawr | What does adding this solve? |
| 20:12.57 | Meorawr | Like compared to just having a Binding element in XML call out to a loadstring'd global. |
| 20:13.17 | Crosshash | Yeah, why can't you just add your script to Bindings.xml? |
| 20:14.16 | Meorawr | (Also I'd nitpick over the name and suggest that if it's not intended to be persistent it should be SetOverrideBindingScript for consistency) |
| 20:18.48 | Chipzz | CreateFrame("Button", "mybutton"); SetBindingClick(key, "mybutton", evilscript); |
| 20:19.31 | Meorawr | Yeah the "it being worse" was conditional upon a custom script binding actually being persisted to the bindings cache. |
| 20:19.39 | Meorawr | Since disabling the addon that installed it wouldn't remove the binding. |
| 20:19.46 | Chipzz | Crosshash: why does Frame:SetScript exist? can't you set it from XML? :) |
| 20:24.02 | *** join/#wowuidev alestane (~nevin@pool-98-118-117-32.bstnma.fios.verizon.net) |
| 20:24.02 | *** mode/#wowuidev [+v alestane] by ChanServ |
| 20:28.37 | Chipzz | SetBindingClick just feels like an unnecessary kludge IMO |
| 20:29.26 | Chipzz | yes you can local button = CreateFrame("Button"); button:SetScript("OnClick", function() end) |
| 20:29.32 | Chipzz | but why? |
| 20:29.49 | Chipzz | it also feels out of line with how the script is specified in Bindings.xml |
| 20:33.17 | Chipzz | Meorawr: my question is: what does SetBindingClick solve as opposed to a proposed SetBindingScript? none of SetBindingClick / SetBindingItem / SetBindingMacro / SetBindingSpell would need to exist |
| 20:35.08 | Chipzz | I'm also not sure about your argument about taint; I don't know the exact implementation of taint but it is a feature of the lua VM, I'm not sure the problems you're describing exist at all? |
| 20:35.40 | Chipzz | why would a normal .xml file be able to be loaded as secure/ non-secure and Bindings.xml wouldn't? |
| 20:36.58 | Meorawr | I'm not seeing how they'd suddenly not need to exist, given those named functions actually persist their bindings and perform privileged actions. |
| 20:37.55 | Meorawr | You couldn't remove SetBindingSpell and expect addons to use SetBindingScript since there's nothing then stopping an addon just doing SetBindingScript("JUMP", [[if something() then CastSpellByName("Frostbolt") end]]) |
| 20:38.47 | Meorawr | Unless I'm misinterpreting what you're aiming this function to actually do - perhaps an example of the precise problem you're trying to solve would help. |
| 20:45.50 | nevcairiel | SetBindingClick can function entirely without XML, which is a key function for many ad-hoc dynamic button creation things, requiring XML again would be a huge step backwards |
| 20:47.24 | nevcairiel | sure you dont get your bindings into the default binding UI then, but you can certainly make your own |
| 20:49.12 | nevcairiel | in short, you can emulate your proposed function with what we have just fine. The opposite would not be true. |
| 20:50.24 | nevcairiel | I wouldnt care if its offered additionally, but the security concern Meo brings up would limit it to running entirely insecure code |
| 20:52.14 | nevcairiel | (as SetScript would as well) |
| 20:53.44 | Yuyuli | does this channel have a chat history somewhere |
| 20:53.52 | nevcairiel | ~logs |
| 20:53.52 | purl | All conversations are logged to http://purl.rikers.org/%23wowuidev/ Lines starting with spaces are not logged. Logs are updated daily. |
| 20:54.03 | Yuyuli | thanks |
| 20:54.26 | Yuyuli | oh boy |
| 20:54.56 | Meorawr | Yeah it has maybe a little bit of logged history. |
| 20:54.57 | Meorawr | Just a bit. |
| 20:55.16 | nevcairiel | and it only updates daily, so nothing from today yet |
| 20:57.56 | pompy | does outlook.office365.com redirect for anyone? (safe) |
| 20:58.29 | Maldivia | redirects to the login page |
| 20:59.32 | pompy | for what? |
| 20:59.40 | Maldivia | MS login |
| 21:00.04 | pompy | its redirecting me to a corp business site login page and says its powered by pingidentity |
| 21:00.26 | pompy | that's on my phone, not doing it on my desktop |
| 21:00.32 | Maldivia | that's because you have some cookies then |
| 21:01.05 | pompy | maybe, I've never been to the page its redirecting me to though, weird |
| 21:01.14 | pompy | and outlook.live.com looks a tad different now as well |
| 21:01.24 | Yuyuli | logged me fine into my olympia account |
| 21:01.34 | Maldivia | well, I usually use outlook.office.com -- without the 365 |
| 21:02.03 | Maldivia | for me, it forwards to https://login.microsoftonline.com/...oauth and then back after logging in |
| 22:02.08 | *** join/#wowuidev Seerah (~umsin@2600:1700:aac0:82e0:d0af:843c:950:b4f1) |
| 22:02.08 | *** mode/#wowuidev [+o Seerah] by ChanServ |