| 00:16.45 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 00:24.49 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 00:24.49 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 02:19.22 | *** part/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 02:38.27 | *** join/#wowuidev yalb (xsbot@lua/bot/yalb) |
| 03:16.54 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 03:16.55 | *** topic/#wowuidev is 8.3 ToC: 80300 || 1.13 ToC: 11303 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 03:24.01 | *** join/#wowuidev Gethe (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 03:30.41 | *** join/#wowuidev Kalroth (~Kalroth@knas.io) |
| 04:01.36 | *** join/#wowuidev Gethe_ (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 04:47.04 | *** join/#wowuidev stevie_ (~stevie@ip24-253-167-220.ri.ri.cox.net) |
| 04:55.39 | stevie_ | Hey, I'm trying to backport a AddOn from WOTLK to Classic. One of the feature it had was heal prediction and so i'm trying to implement libhealcomm-4.0 in it. I have it pretty close to working, but for some reason am having a trouble with self not being consistent throughout the events. I'm new to Lua - lines 26 and 37 are what I'm referring to https://dpaste.org/U4Ss - If it isn't enough information |
| 04:55.45 | stevie_ | lemme know |
| 04:57.53 | stevie_ | Also to add to that, Event registered via RegisterEvent correctly get the self information I'm referring to |
| 04:59.46 | Chipzz | stevie_: nothing inconsistent, just a coding mistake |
| 04:59.57 | Chipzz | <PROTECTED> |
| 05:00.03 | Chipzz | this is the problem |
| 05:00.09 | stevie_ | I was figuring that |
| 05:00.18 | stevie_ | what's wrong with that? |
| 05:00.24 | Chipzz | self: invokes a method on self (the first one) |
| 05:01.14 | Chipzz | it's basically syntactic sugar for UnitEventHandlers.UpdateIncoming(self, ...) |
| 05:01.23 | Chipzz | but since you're also passing self |
| 05:01.32 | Chipzz | you're really calling UnitEventHandlers.UpdateIncoming(self, self, ...) |
| 05:02.06 | stevie_ | ah ok |
| 05:02.19 | Chipzz | basically using : is calling an instance method, while using . is calling a static method (in C/C++ terms) |
| 05:03.40 | Chipzz | object:foo(...) == object.foo(object, ...) |
| 05:05.05 | stevie_ | oh ok that makes sense |
| 05:06.21 | Chipzz | I think the fix is to change line 33 to UnitEventHandlers.UpdateIncoming(self, ...) |
| 05:08.51 | stevie_ | I tried that change, it still appears to print the same values |
| 05:09.37 | Chipzz | TBH the rest of your code makes little sense to me either |
| 05:09.53 | stevie_ | It's definietly all over the place |
| 05:10.12 | Chipzz | 1st of all, the event on line 25 is the name of a WoW event |
| 05:10.30 | Chipzz | HealComm_HealUpdated definitely is not a WoW event |
| 05:11.25 | stevie_ | https://dpaste.org/R8mY |
| 05:11.26 | stevie_ | is the full code |
| 05:11.59 | stevie_ | begins on line 326, registering the events is on 609 |
| 05:12.41 | Chipzz | 2nd, the self on line 25 is a WoW frame. I don't see you adding a UpdateIncoming method to any frame, so I would expect self:UpdateIncoming on line 33 to throw an error |
| 05:13.19 | Chipzz | (more specifically I would expect self.UpdateIncoming to equal nil thus it throwing an error about trying to call nil |
| 05:15.27 | stevie_ | right, so i'm trying to catch the healcomm event and assumed healcomm triggers OnEvent |
| 05:15.54 | stevie_ | then pass the frame to the handler to then update the prediction bar |
| 05:19.44 | Chipzz | line 32 will not be called from line 27 |
| 05:20.28 | Chipzz | line 368 in your 2nd paste, that's an example that will be called from OnEvent |
| 05:20.41 | Chipzz | UNIT_AURA being an actual WoW event |
| 05:22.51 | stevie_ | oh ok, so OnEvent only works with actual WoW Events and it's still being triggered by the RegisterCallback in the original paste? |
| 05:23.58 | stevie_ | I tried putting the LibHealComm in it's namespace but was struggling to be able to provide it the frame context reliably - so I tried this |
| 05:24.07 | stevie_ | in it's own* |
| 05:28.34 | Chipzz | I'm trying to follow the code flow but I'm not familiar with LibHealComm |
| 05:33.08 | stevie_ | no worries, i appreciate your help |
| 05:33.48 | Chipzz | amount = (libCHC:GetHealAmount(targetGUID, healType, nil) or 0) * (libCHC:GetHealModifier(targetGUID) or 1) |
| 05:33.54 | Chipzz | is that a line you wrote yourself? |
| 05:34.24 | stevie_ | no, was using HealCommClassic as a reference of how to implement it |
| 05:34.31 | Chipzz | that looks like it should be libCHC. instead of libCHC: in both cases |
| 05:36.15 | stevie_ | everything "seems to work as intended", I just haven't be able to get access to self.Graphics from within UpdateIncoming |
| 05:36.59 | stevie_ | the closest I got was the naive approach of just calling IguanaRaidFrames as it were and interating IguanaRaidFrames[i].Graphics over it |
| 05:43.29 | Chipzz | what's confusing me is I'm not sure where libCHC is actually being called |
| 05:43.52 | Chipzz | you register callbacks on libCHC, but I don't see anything actually invoking these callbacks |
| 05:44.09 | stevie_ | oh, line 20 in the 2nd paste |
| 05:45.10 | Chipzz | no |
| 05:45.25 | Chipzz | that's you importing libCHC |
| 05:45.37 | Chipzz | that doesn't actually call any functions on libCHC |
| 05:46.57 | Chipzz | but then again I'm not familiar with libCHC; maybe libCHC creates a frame internally too which also has an OnEvent script handler |
| 05:50.07 | stevie_ | Yeah, I tried to align what I saw in HealCommClassic w/ it's doc https://www.wowace.com/projects/libhealcomm-4-0/pages/api |
| 05:50.23 | stevie_ | But I know for sure I am missing something crucial |
| 05:53.41 | Chipzz | yeah libHeallComm has its own internal frame listening for events |
| 05:58.07 | Chipzz | ok so coming back to your original question: self not being consistent |
| 05:58.10 | Chipzz | that makes sense |
| 06:00.22 | Chipzz | https://github.com/hekto/HealComm/blob/master/libs/LibHealComm-4.0/LibHealComm-4.0.lua#L2075 - to line 2087 |
| 06:00.46 | Chipzz | you can see LibHealComm creates its own internal frame |
| 06:01.28 | Chipzz | LibHealComm's OnEvent calls https://github.com/hekto/HealComm/blob/master/libs/LibHealComm-4.0/LibHealComm-4.0.lua#L1568 |
| 06:01.46 | Chipzz | which fires HealComm_HealUpdated |
| 06:03.28 | Chipzz | HealComm.callbacks:Fire("HealComm_HealUpdated", sourceGUID, spellID, pending.bitType, endTime, destGUID) |
| 06:03.46 | Chipzz | note how there is no frame, nor event being passed to the callback |
| 06:04.27 | Chipzz | your code has: |
| 06:04.30 | Chipzz | function UnitEventHandlers.HealComm_HealUpdated(self, event, casterGUID, spellID, healType, endTime, ...) |
| 06:06.16 | Chipzz | the problem really is you're confusing 2 things: LibHealComm callbacks and event callbacks from your own OnEvent |
| 06:07.53 | Chipzz | UnitEventHandlers[event](self, ...) (line 633 from your 2nd paste) will only ever call functions like function UnitEventHandlers.UNIT_AURA(self, unit) (line 368) |
| 06:08.04 | Chipzz | this is one codepath |
| 06:08.27 | *** join/#wowuidev Fisker (~Fisker-@185.109.91.253) |
| 06:09.34 | Chipzz | function UnitEventHandlers.HealComm_HealUpdated(self, event, casterGUID, spellID, healType, endTime, ...) is an entirely different codepath altogether, that doesn't even pass through your OnEvent |
| 06:14.16 | Chipzz | I suspect the self there will be the LibCallback internal callback table (HealComm.callbacks) since that's what :Fire is invoked on |
| 06:16.59 | stevie_ | thank you for linking that. I think you're right, I definietly need to dig deeper on how it's putting itself together |
| 06:17.52 | Chipzz | https://github.com/hekto/HealComm/blob/master/libs/LibHealComm-4.0/libs/CallbackHandler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua#L64 |
| 06:18.02 | Chipzz | https://github.com/hekto/HealComm/blob/master/libs/LibHealComm-4.0/libs/CallbackHandler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua#L29 |
| 06:18.30 | Chipzz | so not the internal callback table either I guess |
| 06:20.08 | Chipzz | also idly wonders why people make such a mess embedding dependencies... libs/CallbackHandler-1.0/CallbackHandler-1.0/ ... *sigh* :P |
| 06:33.44 | *** join/#wowuidev Gethe (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 06:52.38 | AcidWeb | btw that is 6 months old LibHealComm-4.0 |
| 06:53.37 | AcidWeb | minor 67 |
| 06:53.43 | AcidWeb | and current version is 91 |
| 07:08.40 | Chipzz | I doubt that's pertinent to their issues though |
| 07:15.24 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 07:32.54 | *** join/#wowuidev A-KO (~ako@2605:a601:a72b:900:7da2:9629:189a:3469) |
| 08:01.30 | *** join/#wowuidev greedom (~greedom@2001:16b8:2e69:5100:984b:9c7a:516e:1725) |
| 08:08.24 | *** join/#wowuidev Kalroth_ (~Kalroth@knas.io) |
| 08:11.01 | *** join/#wowuidev xyphoid (~xiw@unaffiliated/xyphoid) |
| 10:49.19 | *** join/#wowuidev p3lim (~p3lim@unaffiliated/p3lim) |
| 11:32.09 | *** join/#wowuidev greedom (~greedom@2001:16b8:2e69:5100:984b:9c7a:516e:1725) |
| 12:06.23 | *** join/#wowuidev DiscordB1 (~DiscordB@schwingendesphoenix.org) |
| 13:08.32 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 13:28.46 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 14:30.45 | *** join/#wowuidev Andols (~yaaic@2a00:801:42b:df96:9d17:4f47:a5d:3589) |
| 15:56.32 | *** join/#wowuidev greedom (~greedom@2001:16b8:2e69:5100:984b:9c7a:516e:1725) |
| 16:23.17 | *** join/#wowuidev Meorawr (~Meorawr@cpc157779-rdng31-2-0-cust890.15-3.cable.virginm.net) |
| 16:24.30 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 17:38.21 | *** join/#wowuidev Crosshash (c64a2302@198.74.35.2) |
| 17:38.22 | *** mode/#wowuidev [+o Crosshash] by ChanServ |
| 17:38.47 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 17:42.00 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 17:42.01 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 18:03.49 | *** join/#wowuidev Fisker (~Fisker-@185.109.91.253) |
| 18:20.22 | *** join/#wowuidev greedom (~greedom@2001:16b8:2e69:5100:984b:9c7a:516e:1725) |
| 21:19.23 | *** join/#wowuidev IrcBridge_ (~IrcBridge@host-95-142-47-227.hosted-by-vdsina.ru) |
| 22:08.06 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:57.14 | *** join/#wowuidev p3lim (~p3lim@unaffiliated/p3lim) |
| 23:10.59 | *** join/#wowuidev p3lim (~p3lim@unaffiliated/p3lim) |
| 23:30.49 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:e42e:2e8b:a7cd:5e7a) |
| 23:46.09 | *** join/#wowuidev A-KO (~ako@2605:a601:a72b:900:b947:ffb7:d82c:5279) |