| 00:10.07 | *** join/#wowuidev Sintacks (~Syntax@unaffiliated/sintacks) |
| 01:31.27 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 01:31.27 | *** topic/#wowuidev is BC Dinner Sign Up: https://bit.ly/2mV8xKi || WoW Classic Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.2.5 ToC: 80205 || 1.13 ToC: 11302 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 05:41.39 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:340:d972:d2a7:2e3f:5f8e:6213) |
| 06:29.38 | jadiilelz | why would and EditBox lose focus during OnTextChanged? |
| 06:30.03 | jadiilelz | that seems highly odd to me but maybe i don't understand intended behavior |
| 06:43.56 | jadiilelz | https://github.com/jadissa/wow/blob/master/_retail_/vars/ui.lua#L284 |
| 07:36.20 | *** join/#wowuidev Cairenn (~Karen@MMOI/Administratrix/Cairenn) |
| 07:36.20 | *** mode/#wowuidev [+o Cairenn] by ChanServ |
| 08:06.59 | Novacrash | GetActionCount() was broken in this patch right? or changed |
| 08:09.20 | Ennea | Novacrash, changed, yes |
| 08:09.32 | Ennea | i'd like to know if that was intentional too, but... dunno who to ask D: |
| 08:12.43 | Ennea | can't even post in https://us.forums.blizzard.com/en/wow/t/classic-patch-1-13-3-lua-api-change/384543 because i'm EU and don't have a level 10 character on US servers ~_~ |
| 08:12.55 | Ennea | fucking hell |
| 08:13.41 | Novacrash | I think @TheDanW is the person to ask, if he pops his head in sometime |
| 08:13.58 | Ennea | i already have. he said he hasn't worked on WoW in over a year |
| 08:14.17 | Novacrash | oh really? didn't know |
| 08:15.04 | Novacrash | I made a ghetto func to replace it so it works for now, not a great solution though |
| 08:15.10 | Ennea | anybody in US region here that could ask in the linked thread what the hell happened to GetActionCount? |
| 08:15.25 | Ennea | does it read the tooltips and then scan the bags? :p |
| 08:16.32 | Novacrash | it just looks for reagents and soulshards, since that what I was missing |
| 08:16.33 | Novacrash | https://pastebin.com/UYaPyx1f |
| 08:16.44 | Novacrash | I'm no pro coder, but yeah it seems to work |
| 08:16.59 | Ennea | ah, that's a bit less dynamic |
| 08:17.18 | Novacrash | sometimes it doesn't update strait away becaus I think the bags don't update before certain things, but it works mostly |
| 08:17.37 | Ennea | i actually found some addon for reagent counts for classic where the author didn't know GetActionCount existed i guess. it scanned spell tooltips for SPELL_REAGENTS or whatever the string is called, then scanned bags for the names following that |
| 08:17.45 | Ennea | which i reckon would work quite well actually |
| 08:18.06 | Ennea | i think the most elegant solution is a mapping of spell id -> reagent id(s) |
| 08:18.17 | Ennea | which i'll probably end up doing.. i dunno |
| 08:18.22 | Ennea | i still hope the change is not intended |
| 08:18.33 | Ennea | knowing blizzard's weird shenanigans with classic, it probably is... |
| 08:19.44 | nevcairiel | i'll certainly not add weird hacks for broken functions |
| 08:20.00 | Ennea | yea, that's what i thought ;D |
| 08:20.40 | Ennea | anyway, if the change is intended, it's half-assed, since IsConsumableAction still returns true for all those spells |
| 08:21.30 | nevcairiel | half-assed seems right for many classic changes :D |
| 08:21.44 | Novacrash | yeah figured nev, I use bartender |
| 08:21.52 | Novacrash | but couldn't live without the soulshards :P |
| 08:24.13 | Ennea | nevcairiel, yes, sadly... |
| 08:24.23 | Ennea | :/ |
| 08:25.31 | nevcairiel | it doesnt even make sense to remove intentionally, since an addon can easily restore it, its just annoying |
| 08:25.46 | Novacrash | yeah, so most likely a bug |
| 08:26.15 | Ennea | hopefully a bug.. |
| 08:26.56 | nevcairiel | the only reason for "intentional" being would be that they dont want the default UI to show it, and instead of changing the default action bar code they changed the API - which wouldn't be the first time they used that route, affecting all addons because they wanted to default UI to change behavior |
| 08:27.04 | Novacrash | if it is then gl getting a niche bug like that fixed, still waiting for the custom macro icons bug fix they promised like 4 years ago |
| 08:27.49 | Ennea | nevcairiel, the default ui already doesn't show it |
| 08:27.55 | Ennea | they handled that in ActionButton.lua iirc |
| 08:28.09 | *** join/#wowuidev mitch0 (~mitch@84-236-14-107.pool.digikabel.hu) |
| 08:28.24 | Ennea | so the only reason left to remove that functionality would be "hurr durr #nochanges" |
| 08:28.26 | nevcairiel | then they wont even know its broken and will never fix it :D |
| 08:28.27 | Ennea | Novacrash, what bug is that? |
| 08:28.33 | Ennea | nevcairiel, yea, probably :< |
| 08:29.09 | nevcairiel | luckily overriding GetActionCount should be somewhat safe |
| 08:29.18 | nevcairiel | so an addon could do that to restore i t |
| 08:29.20 | Novacrash | custom macro icons a couple expansions ago suddenly tuned blamk, there's some blue posts saying they we're going to fix it from years ago |
| 08:29.26 | Ennea | hm, you think so? i considered that yesterday |
| 08:29.36 | Ennea | i thought it would be pretty unsafe, since its action button stuff |
| 08:29.45 | Ennea | Novacrash, oh.. great |
| 08:30.24 | Novacrash | I put GetActionCount into it's own addon is exactly how I fix it yeah |
| 08:30.36 | Novacrash | but it's ghetto.. |
| 08:31.11 | Ennea | it really is ghetto as hell |
| 08:32.08 | nevcairiel | it might be risky if you use the default action bars, but with bartender at least it'll be fine, you cant taint a ddons |
| 08:32.41 | Novacrash | yeah it works, but on conjur spells it doesn't update until the next button update |
| 08:32.42 | Ennea | so i might be fucked since i use the default ones ;D |
| 08:32.43 | nevcairiel | and bartender is a clean re-implementation of the action bar stuff, it doesnt refer to any blizzard code that may remain secure |
| 08:32.49 | Novacrash | I think the bags don't update fast enough or something |
| 08:32.55 | Novacrash | every normal spell it works fine |
| 08:33.18 | Ennea | i'm considering removing blizz stuff in my addon and replacing it using your LAB, nev |
| 08:33.19 | nevcairiel | so SPELL_UPDATE_CHARGES also doesnt fire properly anymore then |
| 08:33.33 | Ennea | oh shit.. |
| 08:33.46 | Ennea | i'll have to check that once i'm home |
| 08:33.47 | Ennea | ugh |
| 08:33.59 | Novacrash | if I summon a pet or whatever it works, if I conjur a healthstone/soulstone it updates later on |
| 08:34.29 | Novacrash | the healthstone itself updates fine, showing I have 1 |
| 08:34.36 | Novacrash | but the spell to cast it showing the shards doesn't |
| 08:34.36 | nevcairiel | sounds like a mess |
| 08:34.40 | Ennea | ^ |
| 08:34.41 | Ennea | :/ |
| 08:34.49 | nevcairiel | that definitely worked last week when i tested something on my warlock :D |
| 08:34.53 | Ennea | guess i'll level a US char to 10 to be able to post on their forums, lol |
| 08:36.23 | Novacrash | level it on retail Ennea lol |
| 08:36.26 | Ennea | nevcairiel, does bt4 use LAB, or did you create LAB after bt? |
| 08:36.33 | Ennea | Novacrash, i don't have retail installed |
| 08:36.36 | nevcairiel | bt uses it, of course |
| 08:36.38 | Ennea | although.. hm |
| 08:36.47 | Ennea | i guess i could install it till "playable" |
| 08:37.04 | Ennea | retail chars also only need to be level 10 for forum use? |
| 08:37.11 | Ennea | that is a good idea, Novacrash. thanks |
| 08:37.34 | Ennea | nevcairiel, remember when i asked some questions about LAB? specifically about keydown vs keyup and all that? |
| 08:37.35 | nevcairiel | definitely faster then leveling a classic char, but you need a US license, or can starter accoutns still use forums? |
| 08:37.51 | Ennea | ohhh, right. us have their own subs |
| 08:37.52 | Ennea | ugh |
| 08:37.52 | Ennea | wtf |
| 08:38.08 | Ennea | how are we supposed to get in touch with devs? D: |
| 08:38.22 | nevcairiel | dont worry, they dont read US forums either |
| 08:38.28 | Ennea | ... |
| 08:38.36 | Novacrash | the ping texture bars that show green/red dissapeared on most logins too, is that bt related nev? |
| 08:39.08 | Novacrash | or is that the default blizz bar |
| 08:39.17 | nevcairiel | bt mostly kills the main bottom bar |
| 08:39.27 | Ennea | i'm guessing bt just takes blizzard's ping frame..? |
| 08:39.54 | Novacrash | think it 's part of the blizzard art bar actually |
| 08:40.07 | Novacrash | yeah it is |
| 08:40.27 | Novacrash | if I untick then retick enable in bt the colors come back |
| 08:40.38 | Novacrash | just seems to dissapear sometimes |
| 08:40.51 | nevcairiel | i think i added it to the art bar, but i dont use the art bar, so i would never notice if it breaks :D |
| 08:40.57 | Novacrash | hehe |
| 08:41.00 | Ennea | nevcairiel, so anyway, regarding the keydown/keyup thing. how does bt handle this? can you use actions on keydown, like the default? |
| 08:41.24 | nevcairiel | yes |
| 08:41.32 | Novacrash | is bt getting a keyring soon btw nev? :) |
| 08:41.57 | nevcairiel | the only annoying part is that when its set to on-keydown that it triggers the actions on drag, but fixing that is annoying so i never bothered |
| 08:42.00 | Ennea | how did you solve the issue i ran into? when setting an action button to react on down as opposed to up using LAB, dragging it would also activate it |
| 08:42.06 | Ennea | oh |
| 08:42.13 | Ennea | :D |
| 08:42.39 | Ennea | so does bt just always activates buttons on drag, or is keyup the default? |
| 08:43.05 | Ennea | *activate |
| 08:45.09 | nevcairiel | up is default |
| 08:45.49 | Ennea | i see |
| 08:46.08 | Ennea | yea, i think i'll be using LAB to rebuild default action buttons for my addon then |
| 08:46.14 | Ennea | so i can safely overwrite GetActionCount |
| 08:46.36 | Ennea | hm.. must not forget about stance buttons |
| 08:46.42 | Ennea | well, i got a rogue alt now, so i probably won't :D |
| 08:46.54 | nevcairiel | you could just keep those how they are now |
| 08:46.56 | Novacrash | those vanish and blind reagents :p |
| 08:47.05 | nevcairiel | they are not action buttons, they work differently |
| 08:47.47 | Ennea | hm |
| 08:47.52 | Ennea | does bt also use the default stance buttons, then? |
| 08:48.06 | nevcairiel | it makes its own, but not through LAB |
| 08:48.12 | Ennea | interesting |
| 08:48.17 | Ennea | i'll look into that, thank you |
| 08:48.43 | nevcairiel | the only buttons that BT re-uses from the original are micromenu and bags |
| 08:49.01 | nevcairiel | oh and the extra action button, but classic doesnt have that |
| 08:51.33 | Ennea | extra action button ._. |
| 08:51.35 | Ennea | what the hell is that? |
| 08:52.34 | Novacrash | Ennea if you end up making a better GetActionCount override than one I posted let me know |
| 08:53.10 | Ennea | will do |
| 08:53.30 | Novacrash | extra action button is for specially abilitys, like boss mechanics, quests etc |
| 08:53.37 | Ennea | ah, i see |
| 08:53.38 | Novacrash | it's a dynamic buttong for a bunch of diff spells |
| 08:53.42 | Ennea | and it's just one? |
| 08:53.46 | Novacrash | yep |
| 08:53.46 | Ennea | buttong \o/ |
| 08:53.52 | Novacrash | lul |
| 08:53.56 | Novacrash | my typing is the best |
| 08:57.51 | Novacrash | actually hmm I didn't even post the right one, this is the right one https://pastebin.com/QmWGm7Bk |
| 08:57.59 | Novacrash | has all the reagent id's in it |
| 10:15.27 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 12:41.01 | *** join/#wowuidev harl (~harl@unaffiliated/harl) |
| 13:03.23 | *** join/#wowuidev Yuyuli (~Yuyuli@85-127-63-68.dsl.dynamic.surfer.at) |
| 13:31.37 | *** join/#wowuidev schnoggo (~lonkoenig@73.94.207.128) |
| 15:11.49 | *** join/#wowuidev Cairenn (~Karen@MMOI/Administratrix/Cairenn) |
| 15:11.49 | *** mode/#wowuidev [+o Cairenn] by ChanServ |
| 17:02.57 | *** join/#wowuidev magey (themage@magey.org) |
| 17:05.08 | *** part/#wowuidev magey (themage@magey.org) |
| 17:52.02 | Ennea | any rogues here? my alt isn't even level 10 yet, so.. i'd like to know, when GetActionCount still did what it was supposed to. for the poisons that require a vial and more than one of a given reagent, like this one: https://classic.wowhead.com/spell=8687/instant-poison-ii did GetActionCount return the number of reagents you had, or the number of uses you'd get out of your reagents? |
| 17:52.15 | Ennea | so.. if you had 3 dust of decay and a leaded vial.. 1 or 3? |
| 17:52.18 | Ennea | i'm guessing 1 |
| 17:54.02 | nevcairiel | number of uses, generally |
| 17:54.11 | nevcairiel | anything else would be useless |
| 17:55.07 | Ennea | yea, that's what i thought. just wanted to make sure |
| 17:55.26 | Ennea | oh, i'm just realizing |
| 17:55.42 | Ennea | the poison stuff is actually.. tradeskill stuff? that creates items for the rogue to use? |
| 17:55.53 | Ennea | i thought it was spells/skills. huh.. |
| 17:56.11 | Ennea | now the multiple reagent requirements make more sense ;D |
| 18:23.58 | *** join/#wowuidev Andols (~yaaic@c83-255-17-124.bredband.comhem.se) |
| 18:33.20 | *** join/#wowuidev Andols (~yaaic@c83-255-17-124.bredband.comhem.se) |
| 18:53.10 | Ennea | nevcairiel, regarding what we talked about earlier today, is SPELL_UPDATE_CHARGES supposed to fire when the amount of reagents i have for a certain spell changes? looking at ActionButton.lua, it looks like that's the case |
| 18:53.25 | Ennea | but i can tell you, it doesn't on classic right now. assuming it should when i put my teleportation runes in the bank |
| 18:54.50 | nevcairiel | that was the point, its supposed to, but apparently they broke that as well |
| 18:55.16 | nevcairiel | not sure if any other events would update the count |
| 18:56.31 | Ennea | i'm still wondering if that shit was intended D: |
| 19:10.20 | nevcairiel | we might never know |
| 19:10.30 | nevcairiel | Dan works on secretz, T² left us |
| 19:16.51 | Ennea | nevcairiel, even though SPELL_UPDATE_CHARGES doesn't seem to fire, something else is triggering ActionButton_UpdateCount when i place my runes in the bank |
| 19:16.53 | Ennea | or take them out of it |
| 19:16.55 | Ennea | so this seems.. fine |
| 19:17.26 | Ennea | now the question is just how i'm gonna release this. i was thinking a libstub library. but it has no functions of its own, it just replaces GetActionCount. thoughts on that, nevcairiel? |
| 19:18.27 | Ennea | also, if anybody would like to review the code. and for Novacrash: https://pastebin.com/b1m5RyAA |
| 19:18.36 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 19:18.36 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 19:25.13 | foxlit | (a) LibStub is accomplishing nothing useful there (b) Your hooking logic can break other hooks (c) Better hope nobody clobbers your orig_ global (d) It'd be nicer if your code realized that they fixed the issue and removed itself gracefully. Workaround code in addons tends to overstay its usefulness. (e) You're iterating through bag slots. Did something happen to GetItemCount? |
| 19:26.27 | Ennea | oh damn, GetItemCount is a thing |
| 19:27.12 | Ennea | yea, i agree libstub doesn't accomplish anything useful. the idea was that it could be bundled with other addons |
| 19:27.36 | nevcairiel | well its not written like that :D |
| 19:27.43 | Ennea | do you have any suggestions for more "safe" hooking logic? i guess i could attach the copy to a frame that i own |
| 19:28.00 | Ennea | as for having my code realize they fixed it.. i'm not sure how |
| 19:28.32 | Ennea | except check that the original function returns not 0 for something i know should not be 0, at which point i already did everything i need to replace the original |
| 19:28.48 | Ennea | nevcairiel, well, so far i'm just using it to make sure i don't rehook GetActionCount :) |
| 19:28.53 | Ennea | or re-write it to orig_GetActionCount i guess |
| 19:29.30 | nevcairiel | but if you ever want to update it, ie. increase the version, you would still do that |
| 19:30.04 | Ennea | hm, perhaps i misunderstood libstub api |
| 19:30.36 | Ennea | does NewLibrary not only return a second argument if my library has already been created, but with a lower minor version? |
| 19:31.16 | Ennea | in which case the code would run again, but i would not assign the reference of GetActionCount to orig_GetActionCount again |
| 19:31.27 | Ennea | making sure that orig_GetActionCount will always point to blizzard's implementation |
| 19:31.58 | foxlit | (which triggers (b): if someone hooks GetActionCount between the first version of this running and the second version of this running, this discards that hook) |
| 19:32.24 | Ennea | yea, that makes sense |
| 19:32.30 | Ennea | but what would be a good way to not run into that? |
| 19:34.32 | foxlit | if you intend this code to be included in other addons, don't replace the original function and simply provide your own fixed version. |
| 19:35.13 | nevcairiel | i would simply provide a standalone addon that people can install if they are interested in the data |
| 19:35.17 | foxlit | if you want to swap out the API from under everyone requiring no actual code changes, just release it as a separate addon. |
| 19:35.27 | Ennea | yea, i had considered both.. hm |
| 19:35.52 | Ennea | the problem with the standalone addon is: if this is not a bug but intended, people would need my addon (or another solution) for addons like bt4 to work again |
| 19:35.57 | Ennea | which i find poopy |
| 19:36.06 | Ennea | i guess not overwriting the original is the best choice here |
| 19:38.37 | foxlit | making the pasted code work as it intends isn't impossible, but requires more careful thinking about what it does. |
| 19:40.50 | Ennea | as it intends? |
| 19:41.00 | Ennea | you mean having the code check if the original is fixed again? |
| 19:41.54 | foxlit | no, just the embeddable library+replacing a global API function part. |
| 19:42.16 | Ennea | ah |
| 19:43.56 | *** join/#wowuidev kd3 (~kd3@unaffiliated/kd3) |
| 19:44.34 | foxlit | (In general, I think that replacing API functions, particularly those used by addons, isn't really a good approach) |
| 19:46.14 | Ennea | i agree, generally |
| 19:46.35 | Ennea | but this is an api function that was broken without notice, in a very inconsistent and shitty way |
| 19:46.50 | Ennea | and perhaps even consciously |
| 19:46.59 | Ennea | so who knows if it will be "fixed" again |
| 19:47.16 | Ennea | so i feel like replacing it in such a way that it does its intended job is.. acceptable |
| 19:48.28 | foxlit | has it been more than two weeks since it broke? |
| 19:48.31 | Ennea | nah |
| 19:48.42 | Ennea | but it's classic. do you expect them to fix it in that timeframe? :) |
| 19:48.59 | Ennea | nevcairiel, with LAB, is there any half decent way to replace one of those metatable methods without breaking anything horribly? |
| 19:49.05 | Ennea | if not, i'll stick with the callbacks i guess |
| 19:49.13 | nevcairiel | dont do any of that |
| 19:49.16 | Ennea | gotcha |
| 19:49.35 | Ennea | i'm guessing it will also affect other addons using LAB, if there are any? |
| 19:49.45 | Ennea | i just wasn't sure. still in the process of wrapping my head around metatables |
| 19:51.28 | foxlit | no idea what classic patch schedule looks like. |
| 19:52.33 | Ennea | i don't think there is one |
| 19:53.03 | Ennea | the patch was basically just a late addition of the keyring, which was intended for phase 2 initially. and the removal of channel addon messages |
| 19:53.08 | Ennea | and some other small things i guess |
| 19:53.23 | Ennea | i wish we could get a full changelog.. |
| 19:53.57 | foxlit | you know who gets full change logs? ff14 :P |
| 19:54.10 | Ennea | i'm aware ;) |
| 19:54.13 | Ennea | played it for a while |
| 19:54.40 | Ennea | and it's a good game. but nothing will replace vanilla/classic wow for me, ever |
| 19:54.54 | *** join/#wowuidev magey (themage@magey.org) |
| 20:12.56 | *** join/#wowuidev Elmoe_ (~Elmoe@24.18.143.238) |
| 20:13.19 | *** join/#wowuidev LexSfX (~lexlexlex@216-71-194-85.dyn.novuscom.net) |
| 20:33.47 | Ennea | "The name of your project contains words or phrases that are not allowed: |
| 20:33.47 | Ennea | - Game version numbers: 1.0." |
| 20:33.48 | Ennea | lol curse |
| 20:34.01 | Ennea | well, here's the lib if anybody wants to grab it https://github.com/Ennea/LibClassicSpellActionCount-1.0 |
| 20:34.05 | Ennea | while i figure out how to put this on curse.. |
| 20:40.29 | foxlit | Ennea: if I had to write that, I'd do something like: https://pastebin.com/fqUrueDq |
| 20:41.08 | foxlit | (or https://pastebin.com/BpYR4Wjm ) |
| 20:42.44 | Ennea | hm.. yea, that looks pretty elegant |
| 20:43.42 | Ennea | can drop the "or 0" on GetItemCount also, since it returns 0 for item ids that don't exist or ones you don't have |
| 20:44.42 | Ennea | thanks for that suggestion ^_^ i guess i'll stick with the library though :) |
| 20:44.58 | foxlit | (and https://pastebin.com/s1PP9j0m for the non-hooking version) |
| 20:47.11 | Ennea | for the non-hooking one, i just ended up using libstub |
| 20:47.47 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:340:d972:e70f:d88e:dfcd:4e15) |
| 21:00.14 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 23:11.18 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 23:28.24 | *** join/#wowuidev Cruciformer (~jkj@kahluamod.com) |
| 23:32.06 | Cruciformer | Any op wanna change the /topic? 1.13 ToC is now 11303 |
| 23:32.44 | Cruciformer | Also does anyone know of a list of changes between 11302 and 11303? |