| 00:11.33 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 00:46.17 | *** join/#wowuidev Funkeh`` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 00:56.20 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:a849:3a06:61d:2621) |
| 00:56.20 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 02:16.55 | *** join/#wowuidev Andols2 (~yaaic@m83-185-88-192.cust.tele2.se) |
| 02:20.25 | *** join/#wowuidev Andols (~yaaic@78-70-44-4-no170.tbcn.telia.com) |
| 02:51.08 | *** join/#wowuidev Gethe (~Gethe@98.156.187.225) |
| 03:24.35 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 03:35.35 | *** part/#wowuidev Seerah (~umsin@2601:3c2:80:1380:a849:3a06:61d:2621) |
| 03:52.18 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:a5e7:4a5f:51b:a474) |
| 05:13.24 | *** join/#wowuidev DiscordB2 (~DiscordB@schwingendesphoenix.org) |
| 05:41.16 | *** join/#wowuidev Shadnix_ (foobar@p4FEFC06C.dip0.t-ipconnect.de) |
| 05:41.43 | *** join/#wowuidev Andols2 (~yaaic@m83-185-88-192.cust.tele2.se) |
| 06:36.28 | *** join/#wowuidev mitch0 (~mitch@188-143-56-4.pool.digikabel.hu) |
| 09:16.53 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 13:43.05 | *** join/#wowuidev Tercioo (~Tercioo@181.214.38.19) |
| 14:05.58 | *** join/#wowuidev Sintacks (~Syntax@75-109-21-127.chlncmtk01.res.dyn.suddenlink.net) |
| 14:27.45 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 16:07.42 | Stanzilla_ | https://newsroom.fb.com/news/2019/03/keeping-passwords-secure/ |
| 16:21.47 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 16:30.53 | *** join/#wowuidev Kesava (~kesava@unaffiliated/sliker) |
| 16:36.21 | *** join/#wowuidev Locustt (~Locust@167-179-143-83.a7b38f.mel.nbn.aussiebb.net) |
| 16:43.19 | *** join/#wowuidev Locustt (~Locust@167-179-143-83.a7b38f.mel.nbn.aussiebb.net) |
| 16:43.25 | *** join/#wowuidev Kesava_ (~kesava@unaffiliated/sliker) |
| 17:00.14 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:24.28 | *** join/#wowuidev kd3 (~quassel@unaffiliated/kd3) |
| 17:26.26 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 17:50.56 | *** join/#wowuidev Caleb| (~Caleb|@WoWUIDev/WoWAce/EnsidiaFails/Caleb) |
| 18:19.54 | *** join/#wowuidev TSquare (~tomthomps@198.74.35.2) |
| 18:19.54 | *** mode/#wowuidev [+o TSquare] by ChanServ |
| 19:05.53 | Gnarfoz | Mr_Rabies: I'm interested in bridges |
| 19:06.35 | Gnarfoz | also, in any proof whatsoever that any data I care about is being transferred to Microsoft (secretly, no less) |
| 19:15.32 | mikma | jeff? |
| 19:23.33 | Gnarfoz | human trafficking! |
| 19:23.43 | Gnarfoz | also, the dude abides |
| 19:52.45 | *** join/#wowuidev Andols (~yaaic@78-70-44-4-no170.tbcn.telia.com) |
| 20:04.33 | TSquare | @Chipzz Sorry what was the issue? (I tried it on live, and didn't see any error or anything) |
| 20:15.05 | TSquare | oh do you mean the object type is "animation" and not TextureCoordTranslation? |
| 20:19.36 | Chipzz | TSquare: yes, it's not creating the correct object |
| 20:20.00 | Chipzz | that or TextureCoordTranslation is returning an incorrect value for GetObjectType |
| 20:20.12 | Chipzz | but I suspect the former |
| 20:20.24 | TSquare | does it work properly when you use the animation? |
| 20:20.48 | Chipzz | didn't check, was using this for introscpection purposes |
| 20:21.10 | Chipzz | but the returned object does not have the same methods as a TextureCoordTranslation created from XML |
| 20:21.38 | *** join/#wowuidev Gethe (~Gethe@98.156.187.225) |
| 20:27.11 | TSquare | ahh I see. It is looking for "TextureCoord" without the translation part when creating. but the type name is "TextureCoordTranslation" |
| 20:27.39 | TSquare | hmm ... I'm not sure which way to fix this that would do the least damage |
| 20:27.46 | Chipzz | and then it falls back to Animation type as a default |
| 20:27.50 | TSquare | yea |
| 20:28.18 | Chipzz | I don't think TextureCoordTranslation is actually used in any Blizzard code, and I doubt that code path is used b y 3rd party addons since it doesn't actually work :) |
| 20:28.36 | TSquare | well it does it you use "TextureCoord" |
| 20:28.46 | Chipzz | which btw doesn't make any sense, Animation feels like an abstract type to me, how can that be instantiated or be useful in any way? |
| 20:29.02 | TSquare | Sorry, I don't understand |
| 20:29.41 | Chipzz | make 2 cases in the switch statement with TextureCoord doing what it does now but also generate a warning or sth? |
| 20:30.29 | TSquare | I see, yea. Yea. The fallback is odd |
| 20:30.33 | Chipzz | let me put it this way: what effect would a bare Animation have if played? isn't the effect supposed to be defined by the subclasses like TextureCoordTranslation? |
| 20:31.07 | Chipzz | unless I'm overlooking sth Animation should be abstract, no? |
| 20:33.51 | Chipzz | s/effect supposed to be defined/behaviour supposed to be implemented/ |
| 20:34.49 | foxlit | It just fires relevant script handlers so you can implement your own stuff. |
| 20:35.08 | Chipzz | hmyeah, but how would that be useful? |
| 20:35.36 | Chipzz | and couldn't the same be achieved by using any type of Animation? |
| 20:36.21 | Chipzz | I suppose it could be used as some kind of timer, but meh, there are better ways to achieve that? |
| 20:37.13 | foxlit | maybe you want an animation to tint the texture red. |
| 20:37.18 | Chipzz | foxlit: there also isn't any kind of event that fires on every tick of the Animation; if there were, you could implement your own stuff, but there isn't |
| 20:39.06 | Chipzz | foxlit: tinting the texture red could make sense, but the only event that makes sense would be OnFinished; and the same could be achieved with C_Timer? |
| 20:39.15 | foxlit | it has OnUpdate, you know. |
| 20:39.41 | Chipzz | hhhhhhmkay |
| 20:40.24 | foxlit | for all descendant types, you'd have to set up something that didn't have any additional effects, which seems like a bother. |
| 20:41.03 | Chipzz | yeah, but for OnUpdate you could just use OnUpdate from a Frame |
| 20:41.27 | Chipzz | unless there's a difference between OnUpdate from Animation and Frame |
| 20:43.27 | foxlit | using the native type lets you sequence the animation within groups/use the built-in delay (and probably easing) logic. |
| 20:44.30 | foxlit | I assume it only fires OnUpdate while the animation plays. |
| 20:45.08 | Chipzz | I guess you have a point, but I'm not entirely convinced how necessary it is and if anyone even uses it this way at all |
| 20:45.26 | Chipzz | but I guess it can stay then |
| 20:50.10 | Chipzz | but unless Animation starts supporting intrinsics, I'm not sure there's much point in having the fallback in :CreateAnimation() |
| 21:07.00 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:5862:65dc:75af:85d3) |
| 21:07.00 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 21:15.20 | TSquare | I think the safer change would be to alter one of the strings |
| 21:16.54 | TSquare | Since the XML name and the type are TextureCoordTranslation, I'm thinking of changing the lua create function to be the same |
| 21:17.37 | TSquare | Chipzz: Since that is what you thought was supposed to work I guessing that would be the most intuitive change |
| 21:18.09 | Chipzz | TSquare: it's the same behaviour as :CreateFrame() so it makes sense :) |
| 21:18.10 | TSquare | I'll wait until tomorrow to make the change, in case someone has a better idea |
| 21:18.37 | Chipzz | like I said, have a TextureCoord fallback wouldn't hurt :) |
| 21:18.44 | Chipzz | to not break existing code |
| 21:19.03 | Chipzz | unless it's not a nested if/then/else but some kind of dictionary |
| 21:19.20 | Chipzz | but I guess even that would allow the fallback |
| 21:19.35 | TSquare | it is a nested if/else, it's just that when someone looks at this code a year from now it could be odd |
| 21:19.56 | TSquare | I try to limit the breakage, but I want to make the code clean when I can |
| 21:20.37 | Chipzz | if ( == "TextureCoord") // Fallback for earlier inconsistent code |
| 21:21.26 | TSquare | You wouldn't believe how much that type of code an build up :) |
| 21:21.34 | Chipzz | TSquare: actually this just occured to me |
| 21:22.13 | Chipzz | TSquare: if you :CreateAnimation("UnknownAnimation") it will return an Animation anyway - errr nope, not a valid solution either, my bad |
| 21:22.15 | TSquare | I feel like I'm constantly scraping barnacles off the code, and I just hate adding them. But you are probably correct |
| 21:23.05 | Chipzz | this isn't a big deal for me, like I said, I was using it for introspection (which is why I also think having the exact type names makes sense) |
| 21:23.22 | TSquare | it should be fixed, and it is fine to have both for a while |
| 21:23.29 | Chipzz | but I doubt anyone was using the TextureCoord name anyway since it was undocumented |
| 21:23.29 | TSquare | it's pretty trivial |
| 21:24.40 | Chipzz | TSquare: how do you feel about :CreateAnimation("UnknownAnimation") returning an Animation? does that make sense? shouldn't it throw an error? |
| 21:37.31 | ThiefMaster | ugh, why does "deposit all reagents" do NOTHING if the reagent bank is full, even if some stuff could be stacked on top of items already in the reagent banl? :< |
| 21:59.08 | Mr_Rabies | it shouldn't |
| 21:59.31 | Mr_Rabies | or it should deposit the stuff that can stack, at least |
| 22:00.23 | Mr_Rabies | i have uhhh adibags set to deposit reagents automatically i think? and it definitely will stack the stuff that it can |
| 22:44.58 | *** join/#wowuidev kd3 (~quassel@unaffiliated/kd3) |