| 00:13.16 | foxlit | rtable.concat doesn't take a separator arg :/ |
| 00:37.35 | foxlit | (not the range indexes; boo, hiss) |
| 01:13.00 | *** join/#wowuidev Exality (~4e9a8338@13.95.215.2) |
| 01:19.48 | *** join/#wowuidev purl (ibot@rikers.org) |
| 01:19.48 | *** topic/#wowuidev is 7.3.x ToC: 70300 || http://pastebin.com || Battletags: http://goo.gl/2bm7n || This channel is logged, via purl |
| 02:37.44 | *** join/#wowuidev yalb (xsbot@lua/bot/yalb) |
| 02:52.36 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:3d2c:a1de:4e08:3142) |
| 02:52.36 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 02:58.02 | *** join/#wowuidev Ermad (~Ermad@pool-96-246-137-114.nycmny.fios.verizon.net) |
| 03:56.00 | *** join/#wowuidev [TOM_RUS] (~kvirc@95-29-199-38.broadband.corbina.ru) |
| 05:02.57 | *** part/#wowuidev Seerah (~umsin@2601:3c2:80:1380:3d2c:a1de:4e08:3142) |
| 05:56.36 | *** join/#wowuidev ShadniX (dagger@p5B3D27C7.dip0.t-ipconnect.de) |
| 07:33.42 | *** join/#wowuidev modernist (~mke@2a00:23c5:3481:ed00:74ee:c4d5:1fe:d9b3) |
| 07:57.06 | *** join/#wowuidev tunekey (~tunekey@unaffiliated/tunekey) |
| 08:02.36 | *** join/#wowuidev VIad (~Vlad@cm-84.213.146.58.getinternet.no) |
| 08:08.12 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 08:37.25 | *** join/#wowuidev modernist (~mke@2a00:23c5:3481:ed00:74ee:c4d5:1fe:d9b3) |
| 08:42.23 | *** join/#wowuidev modernist (~mke@2a00:23c5:3481:ed00:74ee:c4d5:1fe:d9b3) |
| 09:02.19 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 09:05.56 | *** join/#wowuidev brykrys (~Bryan@WoWUIDev/Norganna/Dev/Brykrys) |
| 09:49.21 | *** join/#wowuidev Kinesia (~Kinesia@115-64-111-2.tpgi.com.au) |
| 10:02.53 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 10:53.29 | *** join/#wowuidev modernis_ (~mke@2a00:23c5:3481:ed00:20f0:1c81:d3d9:2314) |
| 10:57.51 | *** join/#wowuidev eke00372__ (~eke00372@unaffiliated/eke00372) |
| 11:30.15 | *** join/#wowuidev eke003732_ (~eke00372@unaffiliated/eke00372) |
| 11:47.15 | *** join/#wowuidev schlumpf (~schlumpf@95.90.229.83) |
| 11:54.19 | *** join/#wowuidev Kinesia (~Kinesia@115-64-111-2.tpgi.com.au) |
| 13:00.37 | *** join/#wowuidev leo_ (~leo@84.217.172.58) |
| 13:00.52 | *** join/#wowuidev leo_ (~leo@84.217.172.58) |
| 13:01.39 | *** join/#wowuidev leothar (~leothar@84.217.172.58) |
| 13:03.50 | leothar | So... if you use C_EquipmentSet.ModifyEquipmentSet during the EQUIPMENT_SETS_CHANGED event that is called when you create a new equipment set, the game crashes. Does anyone know of a way to get around that? |
| 13:04.35 | nevcairiel | don't do that? :) |
| 13:05.32 | leothar | But it's the same event when you create, delete or change a set... |
| 13:18.35 | *** join/#wowuidev leothar (~leothar@84.217.172.58) |
| 13:24.39 | Andols | Wait until the next game to do it? |
| 13:24.57 | Andols | Next frame |
| 13:49.24 | *** join/#wowuidev [TOM_RUS] (~kvirc@95-29-199-38.broadband.corbina.ru) |
| 15:14.51 | *** join/#wowuidev modernist (~mke@2a00:23c5:3481:ed00:a524:2f69:f75:e162) |
| 15:17.04 | *** join/#wowuidev [TOM_RUS] (~kvirc@95-29-199-38.broadband.corbina.ru) |
| 15:17.11 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 15:44.36 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 15:53.18 | *** join/#wowuidev modernis_ (~mke@host217-42-246-127.range217-42.btcentralplus.com) |
| 16:03.52 | *** join/#wowuidev ShadniX (dagger@p4FF9FFBC.dip0.t-ipconnect.de) |
| 16:15.44 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:42.00 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 18:14.35 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:64f9:56d6:4219:6d7f) |
| 18:14.35 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 18:19.07 | *** join/#wowuidev Constie (~Constie@185-113-98-134.cust.bredband2.com) |
| 18:26.59 | Fisker | Hey Seerah |
| 18:27.08 | Seerah | hihi |
| 18:27.34 | Fisker | For free? |
| 18:43.15 | *** join/#wowuidev modernist (~mke@2a00:23c5:3481:ed00:5c26:cee9:afd2:19ec) |
| 20:12.43 | *** join/#wowuidev NickG365 (~NickG365@cortex.starlabs.theflash.rocks) |
| 20:26.32 | *** join/#wowuidev Semlar (~semlar@72.189.128.149) |
| 20:30.55 | Semlar | leothar: it sounds like you're calling a function that triggers the same event you're responding to in a loop |
| 20:34.23 | leothar | Semlar: I don't think so, it didn't happen when the event was called by deleting or modifying an existing set |
| 20:34.45 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 20:35.12 | Semlar | so C_EquipmentSet.ModifyEquipmentSet doesn't trigger EQUIPMENT_SETS_CHANGED? |
| 20:35.22 | leothar | I think it's more like the event is called a frame before the set actually exists. It's just scary that it crashed the entire game rather than throwing a lua error or something |
| 20:35.33 | Semlar | because it sounds like an event that would be triggered from calling that |
| 20:35.52 | leothar | I don't think it does no, at least not more than once |
| 20:36.03 | Semlar | it doesn't have to be more than once |
| 20:36.33 | leothar | right |
| 20:36.35 | Semlar | if you're calling that function in response to that event, and it triggers that event, you're just going to be stuck in an infinite loop |
| 20:36.56 | Semlar | what are you trying to do |
| 20:36.59 | leothar | yes, but there's no infinite loop the other time the event triggers where I use C_EquipmentSet.ModifyEquipmentSet |
| 20:37.19 | leothar | I'm trying to automatically set the icon of a set depending on its name whenever modified or created |
| 20:37.53 | leothar | works perfectly fine when changing the name of a set, or even deleting another set, but when I create a new one the game crashes |
| 20:38.20 | Semlar | you might try tracking which sets you've already modified in a table so you don't rerun the same code on them the next time the event fires |
| 20:40.06 | Semlar | can you paste your code on ghostbin.com or something |
| 20:40.10 | leothar | how would that prevent the game from crashing? :P |
| 20:40.25 | leothar | sure, one sec |
| 20:40.34 | Semlar | by not running in an infinite loop |
| 20:41.34 | leothar | but if C_EquipmentSet.ModifyEquipmentSet triggered the event it would give me an infinite loop every time the event fires - that isn't happening |
| 20:42.25 | Semlar | not if your other code is putting the game into a state where it doesn't run the function again |
| 20:42.38 | leothar | hmm what do you mean? |
| 20:43.20 | Semlar | if you're only calling the function when the name doesn't match something, and then you rename it in a way that the condition isn't met, it won't call the function again even if it's responding to the event |
| 20:43.49 | Semlar | i haven't seen your code so i can't really say what it's doing |
| 20:45.28 | leothar | Semlar: https://pastebin.com/6T3hhz3p |
| 20:46.46 | leothar | I since moved it to a slash command so I had to undo a bunch of changes, if there's a lua error I probably missed something but this basically what I tried to do earlier |
| 20:50.15 | leothar | this is* |
| 20:50.42 | Semlar | well i can tell you C_EquipmentSet.ModifyEquipmentSet is firing EQUIPMENT_SETS_CHANGED |
| 20:51.01 | leothar | interesting |
| 20:51.12 | Semlar | you can easily check this with /etrace by calling the function |
| 20:51.25 | leothar | how come there isn't an infinite loop each time then? |
| 20:52.13 | Semlar | i don't know what you're testing it with so i'm not sure what conditions are being met |
| 20:52.32 | Semlar | i would think virtually all of these would trigger an infinite loop |
| 20:53.05 | Semlar | you don't seem to be checking if they're already set the way you want them to look before trying to modify them |
| 20:53.07 | leothar | but they don't if I trigger my updateSets() function from a slash command, or even when it triggers from the event as long as I'm not creating a new set |
| 20:53.21 | leothar | yeah of course, just trying to understand why it's being inconsistent :D |
| 20:53.50 | Semlar | if your slash command is just running this function it's not causing a loop because it's not responding to the event |
| 20:53.57 | Semlar | you're just running the function |
| 20:54.04 | leothar | oh that is true, good point |
| 20:54.39 | leothar | I mean an easy solultion would be to check if the icon is set or not and only then actually change it, I guess I will do that |
| 20:55.20 | leothar | thanks for your help, I had no idea /etrace was a thing |
| 20:56.14 | Semlar | etrace and fstack are pretty important slash commands if you're going to be making addons |
| 20:56.36 | leothar | I know about fstack! |
| 20:57.31 | Semlar | you might be able to get away with just unregistering the event from the frame at the start of the function and reregistering it at the end, but that might not work if the event is delayed |
| 20:58.37 | Semlar | in your eventHandler just do self:UnreigsterEvent("EQUIPMENT_SETS_CHANGED") before updateSets() and self:RegisterEvent("EQUIPMENT_SETS_CHANGED") after it |
| 20:59.35 | Semlar | if it still crashes you'll probably have to do something that takes more effort |
| 21:00.36 | leothar | I was just gonna write a simple function that checks if the old icon is the new icon or not before attempting to change it |
| 21:01.02 | Semlar | it doesn't hurt to unregister the event while you're running this anyway |
| 21:01.10 | leothar | I guess not |
| 21:02.44 | Semlar | it doesn't always work, i've run into situations where it still responds to an event i've unregistered if i reregister it within the same frame |
| 21:05.35 | leothar | now there is no infinite loop but it taints the entire PaperDollFrame instead :D |
| 21:06.23 | nebula | taint happens, it's only when you taint secure things that it matters |
| 21:07.00 | leothar | well it breaks the entire equipment set manager |
| 21:07.10 | Semlar | you can try unregistering the event from that frame while you run your stuff |
| 21:07.22 | foxlit | nebula: as opposited to tainting tainted things? :P |
| 21:07.25 | Semlar | it shouldn't be breaking anything unless you're running this in combat |
| 21:07.39 | foxlit | s/it// |
| 21:07.57 | Semlar | i mean it could still break things later, but not immediately |
| 21:08.48 | nebula | yea yea, as opposed to tainting shit that doesn't care if it's tainted |
| 21:10.08 | Semlar | try PaperDollEquipmentManagerPane:UnregisterEvent("EQUIPMENT_SETS_CHANGED") before you run your function and register it again afterwards |
| 21:10.40 | leothar | I'll try that |
| 21:11.17 | nevcairiel | calling an API which triggers an event usually doesnt propagate taint beyond the event border |
| 21:11.40 | Semlar | he's modifying the equipment sets |
| 21:11.59 | leothar | this just made it worse |
| 21:12.21 | Semlar | what exactly is it doing that you think it's being tainted |
| 21:12.41 | leothar | BugSack is giving me "11x FrameXML\PaperDollFrame.lua:1420: bad argument #1 to 'pairs' (table expected, got nil)" |
| 21:12.56 | nevcairiel | thats not taint, you broke something else :) |
| 21:13.16 | leothar | seems like C_EquipmentSet.GetEquipmentSetIDs() is returning nil |
| 21:13.46 | Semlar | i don't really see how that's even possible unless modifying equipment sets is triggering a different event |
| 21:14.05 | leothar | it seems even clicking the cogwheel button triggers the event |
| 21:14.15 | leothar | and during that time I get these errors |
| 21:14.18 | Semlar | did you reregister the event |
| 21:14.22 | leothar | yes |
| 21:14.30 | leothar | if I just create a new set it ironically works flawlessly |
| 21:14.34 | leothar | same with deleting |
| 21:14.42 | leothar | pressing the cogwheel = errors and then everything is broken |
| 21:15.32 | Semlar | mysterious |
| 21:16.14 | Semlar | i need to go to the store, i'm running out of food |
| 21:18.48 | Semlar | it sounds like whatever you're doing is somehow removing the ID of the set that it thinks is supposed to be currently selected in the equipment manager |
| 21:18.57 | leothar | and I need to go to bed |
| 21:19.16 | leothar | thanks for your help either way |
| 21:19.24 | Semlar | sure |
| 21:19.40 | nevcairiel | firing the same event from within a event is always a bit of an odd thing and can mess with state, sometimes its best to just avoid that |
| 21:20.01 | nevcairiel | and just use a timer to update it on the next frame or something like that |
| 21:20.03 | leothar | yeah, this doesn't seem worth the trouble |
| 21:20.32 | Semlar | https://www.townlong-yak.com/framexml/live/PaperDollFrame.lua#2028 this is what the error is stemming from |
| 21:20.58 | Semlar | it's tracking what set is supposed to be currently selected |
| 21:21.15 | Semlar | you're doing something that's making the currently selected setID invalid for the function that it's calling on it later |
| 21:21.41 | leothar | interesting |
| 21:22.18 | Semlar | you could set the selected setID to nil which would stop that error but will definitely taint this, although i'm not sure what consequences that will have |
| 21:22.56 | Semlar | there's probably a better solution |
| 21:25.15 | leothar | I think the solution is slash command since this was all just for my own personal addon and it doesn't need to be perfect |
| 21:25.42 | leothar | I was just tired of pasting /run ModifyEquipmentSet() macros on all my alts |
| 21:26.35 | Semlar | if it's just something that needs to run once when you log in you could do it on PLAYER_LOGIN, maybe with a delay |
| 21:27.17 | leothar | I'll just type my slash command after making my sets to set the icons now, it's np :) |
| 21:27.29 | leothar | would have been neat if it was automagic but too much effort |
| 21:27.52 | Semlar | you could have it pick the icon when you type the name into the box |
| 21:29.05 | leothar | I have no idea how to even start writing that code |
| 21:29.20 | leothar | I really need to sleep now, thank you for all the help Semlar! |
| 21:29.27 | Semlar | have fun |
| 21:29.52 | Semlar | you'd have to find the icon picker function in the framexml |
| 21:30.26 | Semlar | and hook the text box so when you type into it it runs your function to check if the text matches the name you're looking for, and if it does then select the right icon for it |
| 21:34.22 | *** join/#wowuidev jleclanche (uid155154@HearthSim/Founder/Adys) |
| 22:04.54 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 22:10.00 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 22:32.19 | *** join/#wowuidev tunekey (~tunekey@unaffiliated/tunekey) |
| 22:32.28 | *** join/#wowuidev nimhfree (~scott@99-117-102-71.lightspeed.sntcca.sbcglobal.net) |
| 23:17.14 | *** join/#wowuidev Andols (~yaaic@m77-218-225-17.cust.tele2.se) |
| 23:23.11 | *** join/#wowuidev Andols2 (~yaaic@62-20-145-33-no170.tbcn.telia.com) |