| 00:44.32 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 00:47.27 | sylvanaar | I am so amazingly bad at DPS. I really must be missing something very fundamental - because it is the same if I play balance druid or whatever mage |
| 01:09.32 | *** join/#wowuidev Thunder_Child (TC@2600:3c01::f03c:91ff:feae:2e8b) |
| 01:09.32 | *** join/#wowuidev Freddie (freddie@strange.wafflemonster.org) |
| 01:09.32 | *** join/#wowuidev Thunder_Child (TC@WoWUIDev/PITA/TC) |
| 01:19.19 | *** join/#wowuidev purl (ibot@rikers.org) |
| 01:19.19 | *** topic/#wowuidev is Happy Holidays! || 7.3.x ToC: 70300 || http://pastebin.com || Battletags: http://goo.gl/2bm7n || #WoWUIDev-commits: CIA & JIRA bots reporting || This channel is logged, via purl |
| 01:51.24 | *** join/#wowuidev Corrodias (~no@97.80.80.101) |
| 02:30.47 | *** join/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 02:30.47 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 04:33.47 | *** part/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 05:41.42 | *** join/#wowuidev Andols2 (~yaaic@m83-185-240-248.cust.tele2.se) |
| 05:42.41 | *** join/#wowuidev ShadniX (dagger@p4FF9F050.dip0.t-ipconnect.de) |
| 06:31.58 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 07:19.54 | *** join/#wowuidev aprok (~Albrecht@x5ce033b7.dyn.telefonica.de) |
| 07:21.57 | *** part/#wowuidev aprok (~Albrecht@x5ce033b7.dyn.telefonica.de) |
| 07:22.21 | *** join/#wowuidev Andols2 (~yaaic@m83-185-240-248.cust.tele2.se) |
| 07:41.08 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 08:03.33 | *** join/#wowuidev VIad (~Vlad@cm-84.213.146.58.getinternet.no) |
| 08:14.30 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 08:18.01 | *** join/#wowuidev Ellypse (~Ellypse@213.246.214.170) |
| 08:23.51 | *** join/#wowuidev Exality (~Exality@78.154.131.56) |
| 08:31.35 | *** join/#wowuidev Exality_ (~Exality@78.154.131.56) |
| 08:34.01 | *** join/#wowuidev Exality1 (~Exality@78.154.131.56) |
| 08:37.56 | *** join/#wowuidev karl_w_w (~karl_w_w@110-175-132-56.tpgi.com.au) |
| 09:16.09 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 09:17.54 | *** join/#wowuidev Elmoe (~Elmoe@24.18.131.251) |
| 09:41.20 | *** join/#wowuidev dano5 (~dano5@163.109-247-80.customer.lyse.net) |
| 10:51.03 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 11:21.57 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 11:34.18 | *** join/#wowuidev Andols2 (~yaaic@193.10.192.82) |
| 11:48.35 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 11:50.32 | *** join/#wowuidev Andols2 (~yaaic@m83-185-240-248.cust.tele2.se) |
| 11:53.19 | *** join/#wowuidev Ellypse (~Ellypse@213.246.214.170) |
| 12:01.04 | Stanzilla | ABC |
| 12:01.07 | Stanzilla | always be casting |
| 12:01.25 | Stanzilla | only move if you have to |
| 12:01.26 | Stanzilla | etc |
| 12:03.07 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 12:26.25 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 12:36.47 | *** join/#wowuidev Andols (~yaaic@m83-185-240-248.cust.tele2.se) |
| 12:38.36 | *** join/#wowuidev Andols2 (~yaaic@193.10.192.82) |
| 12:43.03 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 13:10.27 | *** join/#wowuidev aprok (~Albrecht@x5ce033b7.dyn.telefonica.de) |
| 13:53.13 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 13:55.44 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 14:14.32 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 14:19.26 | *** join/#wowuidev ikcerog (~ikcerog@12.165.188.171) |
| 14:21.47 | *** join/#wowuidev Andols2 (~yaaic@m83-185-247-209.cust.tele2.se) |
| 14:22.38 | *** join/#wowuidev Andols (~yaaic@193.10.192.82) |
| 14:24.16 | *** join/#wowuidev Andols2 (~yaaic@m83-185-247-209.cust.tele2.se) |
| 14:40.02 | *** join/#wowuidev Andols (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 14:55.09 | *** join/#wowuidev harl (~harl@unaffiliated/harl) |
| 15:05.01 | *** join/#wowuidev harl (~harl@unaffiliated/harl) |
| 15:06.02 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 16:14.28 | *** join/#wowuidev stolenlegacy (~stolenleg@213-47-49-27.cable.dynamic.surfer.at) |
| 16:14.28 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 17:41.12 | *** join/#wowuidev stolenlegacy_ (~stolenleg@213-47-49-27.cable.dynamic.surfer.at) |
| 17:41.13 | *** join/#wowuidev stolenlegacy_ (~stolenleg@unaffiliated/stolenlegacy) |
| 18:08.17 | *** join/#wowuidev ikcerog (~ikcerog@12.165.188.171) |
| 18:11.19 | TheDanW | Funkeh`: i'll get a deprecated function in - as for returning a table that is the preferred way now, it's easier to read and maintain than select(11, SomeFunc) for example |
| 18:12.57 | TheDanW | Chipzz: it was a considerable amount effort to create the infrastructure for documentation, we can't easily go back through 13 years of API to flesh out everything |
| 18:13.48 | Alram | go have xmas vacation dan |
| 18:13.55 | Alram | they can wait until january |
| 18:14.46 | TheDanW | Chipzz: i also don't think you understand what purpose C_ModelInfo serves if you think it's poorly designed |
| 18:15.37 | TheDanW | Gethe: good catch, thanks |
| 18:17.06 | TheDanW | Resike: first i've heard of it, i'll check with QA |
| 18:17.48 | TheDanW | Alram: you're stuck with me all week ;p |
| 18:18.51 | Gethe | TheDanW: <3 |
| 18:20.36 | AcidWeb | TheDanW: I presume that lack of subzone names on some battlegrounds is something that will not change? |
| 18:21.08 | Alram | go home and enjoy take-home alpha like your colleagues :P |
| 18:23.00 | TheDanW | AcidWeb: i'm not sure, that's more of a data thing |
| 18:25.07 | AcidWeb | Well considering that they are missing in all MoP BGs + "HillsbradFoothillsBG" I don't expect that will be ever added ð |
| 18:25.20 | TheDanW | yeah, i wouldn't hold my breathe |
| 18:51.26 | *** join/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 18:51.26 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 19:01.34 | *** part/#wowuidev aprok (~Albrecht@x5ce033b7.dyn.telefonica.de) |
| 19:23.02 | *** join/#wowuidev schlumpf (~schlumpf@ip5f5ae540.dynamic.kabel-deutschland.de) |
| 20:28.48 | *** join/#wowuidev dano5 (~dano5@163.109-247-80.customer.lyse.net) |
| 20:57.07 | *** join/#wowuidev stolenlegacy (~stolenleg@213-47-49-27.cable.dynamic.surfer.at) |
| 21:01.12 | *** join/#wowuidev ChanServ (ChanServ@services.) |
| 21:01.12 | *** mode/#wowuidev [+o ChanServ] by cherryh.freenode.net |
| 22:00.01 | *** join/#wowuidev dano5 (~dano5@163.109-247-80.customer.lyse.net) |
| 22:28.51 | Funkeh` | TheDanW you're going to start changing APIs to return tables? |
| 22:29.25 | Funkeh` | this does not sound efficient to me :p |
| 22:37.21 | Funkeh` | I'd much prefer the efficiency of defining the variables, instead of using select, or a table, but maybe that's just me. Not to mention the flexibility of naming it whatever you want, and not not doing 10 table accesses if you're using 10 vars. |
| 22:38.15 | Funkeh` | I really hope prettyness is not the reason you chose to do this |
| 22:39.15 | foxlit | being able to add seamlessly add additional returns is a nice benefit, though. |
| 22:39.37 | Funkeh` | you can do that fine if you're not paranoid about the order |
| 22:40.04 | Funkeh` | or just change the order next expansion |
| 22:41.40 | foxlit | both these approaches such. You can break existing code, or you can break logical ordering, or you can do both at different times. |
| 22:42.26 | Funkeh` | the question remains is that what he wants to gain by doing this, or is it because he saw a select call and had a fit |
| 22:43.47 | Simca | they started this in WoD |
| 22:43.56 | Simca | all new API since WoD return tables, with a few exceptions |
| 22:44.06 | Funkeh` | wat |
| 22:44.29 | Simca | it's especially common amongst the C_* named stuff |
| 22:44.54 | Funkeh` | Maybe you've been looking at different diffs than I've been looking at |
| 22:45.22 | foxlit | maybe; who knows what you've been looking at. |
| 22:45.42 | Simca | diffs don't give the full picture either, as there are several new APIs they don't use |
| 22:45.55 | Simca | that is one of the main benefits of this approach |
| 22:46.12 | Simca | previously we did not have any way to figure out argument names if blizzard didn't reference them |
| 22:46.19 | Simca | though, i suppose that is solved now by api documentation |
| 22:46.27 | Funkeh` | that's the entire point of the api docs |
| 22:46.58 | Simca | this trend started before the docs existed, and i was very glad for it when i was figuring out stuff in beta |
| 22:47.01 | foxlit | (most of the meaty garrison stuff returns tables. Returning 15 values seems meh.) |
| 22:47.41 | Funkeh` | So it's just being used for API with large amounts of returns? |
| 22:48.00 | Simca | i mean i've never seen a table return with less than 4 entries |
| 22:48.30 | TheDanW | return tables isn't inefficient, it's more complicated than that, but for the most part the impact is negligible, yes you'll create more garbage but the allocation and deallocation has already been optimized, you really only have to pay more for for a more complex traversal |
| 22:48.40 | TheDanW | but these aren't complex enough for that to really matter |
| 22:50.23 | foxlit | evil plan: kidnap all of your nicely-allocated returns and never let them go. |
| 22:50.36 | Funkeh` | well if you're going to start doing it for API like GetSpellInfo, I'd recommend you analyze common use cases, in that situation, you should add GetSpellName |
| 22:51.37 | Funkeh` | It would be great to have that for the EJ call also, since 99% of our use case is a translated name |
| 22:52.16 | foxlit | How often do you need localized tables that you can't just eat the miniscule runtime penalty for the table return? :) |
| 22:52.18 | Funkeh` | C_EncounterJournal.GetSectionName |
| 22:52.51 | foxlit | <PROTECTED> |
| 22:53.35 | Funkeh` | the longer it takes the longer our UI will take to draw, which if you open in combat can take some time |
| 22:54.02 | Funkeh` | before the fix to loading addons in combat, we couldn't, since we hit the run time limit |
| 22:55.14 | Simca | i don't know if there are ever more than like 2 spell names on the UI at once though for WA |
| 22:55.32 | Funkeh` | s/UI/GUI |
| 22:55.36 | Simca | but it is possible there could be some cases where it mattered slightly, like if you were doing a spell browser or something... |
| 22:57.41 | Funkeh` | TheDanW what do you think? |
| 22:58.18 | foxlit | Dunno. I haven't hit a case where sane API usage (i.e. not "give me all the localized text in the game, please") results in a noticable penalty from the API's choices of return types. |
| 22:58.35 | Funkeh` | in the case of spell ids, we already have GetSpellTexture(id) which is nice, as it shaves a few ms off when all you want is the texture |
| 22:58.46 | Funkeh` | however wanting the name is far more common :p |
| 23:17.15 | TheDanW | we usually try to balance it |
| 23:17.23 | TheDanW | if there's a cost to look up the data |
| 23:17.27 | TheDanW | then we might return more |
| 23:17.38 | TheDanW | if theres very little cost to look it up, we might break it apart more |
| 23:17.58 | TheDanW | some functions have more or less thought behind them and end up returning far too much |
| 23:18.02 | TheDanW | or too little |
| 23:18.08 | TheDanW | but that's the general guideline |
| 23:18.39 | TheDanW | in most cases localized text is cheap |
| 23:18.44 | TheDanW | fwiw |
| 23:19.23 | Funkeh` | thanks |
| 23:19.57 | Funkeh` | I would put forward GetSectionName as a request, but in reality we use SpellInfo way more than EJ info, so if I was to make said request it would be for spell name |
| 23:22.55 | tz | I used to use EJ heavily, back when I could actually work out the distance between the player and an encounter... having boss-specific macros/talents automatically swapped out was super useful |
| 23:22.59 | tz | shakes his fist |
| 23:28.55 | Funkeh` | TheDanW: now that I remember, what was with the incosistency with 1 or 2 of the return values? |
| 23:29.41 | Funkeh` | https://pastebin.com/q9T4VmaH the 11th arg of 12 being the glaring one |
| 23:32.33 | foxlit | Funkeh`: https://wow.gamepedia.com/API_EJ_GetSectionInfo << api docs to the rescue? |
| 23:34.04 | foxlit | maybe the "don't display a special icon for this section" return got translated to assigning a nil to whatever key is used to indicate that a special icon should be displayed. |
| 23:34.31 | Funkeh` | well the new return has two values of 0, the old one has one value of zero |
| 23:37.53 | foxlit | that sounds like the model-displaying stuff got split. |
| 23:39.33 | foxlit | i.e. displayInfo -> (uiModelSceneID, creatureDisplayID), and you're looking at a non-creature section. |
| 23:41.19 | foxlit | https://www.townlong-yak.com/framexml/ptr/Blizzard_APIDocumentation#s:c_encounterjournal.getsection << new stuff is in docs, too |
| 23:41.36 | foxlit | so they split off the flag icons to a separate function and added a bunch of keys to the section return. |
| 23:54.14 | *** join/#wowuidev dano5 (~dano5@163.109-247-80.customer.lyse.net) |
| 23:54.20 | Simca | yeah UI model scenes are a new clientside thing |
| 23:54.35 | Simca | they power mount/pet journal, encounter journal, and some other places |