IRC log for #wowroster on 20080125

00:43.39*** part/#wowroster Anax|Work (n=cwells@216.207.124.226)
01:16.08*** join/#wowroster Xcantion (n=webmaste@p57B77F2D.dip.t-dialin.net)
05:26.40*** join/#wowroster robboplus (n=no@unaffiliated/robboplus)
06:55.18*** join/#wowroster PleegWat|Work (n=ple@82-148-206-57.fiber.unet.nl)
06:55.18*** mode/#wowroster [+o PleegWat|Work] by ChanServ
07:48.58*** join/#wowroster Kyubi (n=Jabberwo@ks300470.kimsufi.com)
07:49.12KyubiHello
10:17.32*** join/#wowroster TopManiac (n=webmaste@p57B757DD.dip.t-dialin.net)
11:56.19*** join/#wowroster poetter (n=poetter@e177119161.adsl.alicedsl.de)
13:18.21*** join/#wowroster Diska (n=blubblup@sara0202.ka.sara.nl)
13:18.27Diskaeya
16:03.46DiskaPleegWat, the keys addon ought to work properly for pre-tbc keys right?
16:04.17PleegWat|Workwell, the english ones.
16:04.20PleegWat|WorkThere's no defs for the rest
16:04.27PleegWat|Workor, I didn't translate them
16:04.56Diskak, my roster is English so I ought to work, but I'm not getting anything yet
16:05.33PleegWat|Workgreat timing. It's high time I went home
16:05.35Diskabut I'll look into it a bit myself
16:05.37PleegWat|WorkCan I get back to you tonight?
16:05.39Diskahehe
16:05.49Diskasure :)
16:05.56DiskaI'll post on the forum if I find anything
16:06.14PleegWat|WorkI hope the code is rather simple. The caching removes a layer of complexity, and it uses memberslist for display
16:06.45*** join/#wowroster Zanix|Work (n=Zanix@71.216.154.51)
16:06.45*** mode/#wowroster [+o Zanix|Work] by ChanServ
16:09.53Diskagood morning zanix :)
16:10.00Zanix|Workmorning
17:12.35*** join/#wowroster fewyn (n=fewyn@rrcs-24-73-143-17.se.biz.rr.com)
17:43.31*** join/#wowroster tuaguild (n=Charles_@74.230.182.80)
17:43.47*** part/#wowroster tuaguild (n=Charles_@74.230.182.80)
20:19.54*** join/#wowroster Diska (n=blubblup@cybertron.demon.nl)
20:19.56Diskaeya
20:23.54Zanix|Workyeaeah
20:27.33Diskasigh...freenode keeps reminding me about identifying myself...now if only there were ever any staff members online to help me recover my nickname >.<
20:28.06Zanix|Workindeed
20:50.14*** join/#wowroster PleegWat (n=PleegWat@leegwater-68.demon.nl)
20:50.16*** mode/#wowroster [+o PleegWat] by ChanServ
20:51.05DiskaZanix: I did reupload my CP file
20:51.18Zanix|Workoh
20:51.19Zanix|Workok
20:51.26Zanix|Workdidnt know that
20:51.27Diskabut I'll do it again and see if i get any errors there
20:51.41Diskadon't think i did but didn't pay close attention to it
20:51.42Zanix|Workits about the new keys PleegWat
20:52.53DiskaInstanceKeys - Keycache cleaned - 0 gold stages activated - 0 item stages activated - 0 quest stages activated - 0 reputation stages activated - 0 skill stages activated
20:53.00DiskaI'm getting that for both my chars
20:53.56Diskahmm, I'm getting some php errors from about the update.lib.php, related to the ranged_dps
20:54.02Diskathat's odd, that was supposed to be fixed
20:54.09Diskalet me check my file versions :s
20:56.26Zanix|Workok
20:56.58Zanix|WorkI dont have druid, pally, or shaman data to test the fix with
20:57.15Diskaversions appear to be correct
20:57.38Diskai can send you cp data for a druid
20:58.16DiskaI'm getting this error twice: Notice line 3262: Undefined index: ranged_dps
20:58.24Diskathen: Warning line 707: Missing argument 2 for update::setError(), called in /var/vhosts/webs/blaze/roster/lib/update.lib.php on line 2353 and defined
20:58.31Diska<PROTECTED>
20:58.36Zanix|Workoh lol
20:58.49Zanix|WorkI think I know what it is
20:59.19Zanix|WorkI used the wrong (whats the name for a string element in an array?)
20:59.36Zanix|WorkI used ranged_dps and it should be Damage I think
20:59.40Diskano idea :)
20:59.41Zanix|WorkI dont have the code here
20:59.43Diskaah okay
20:59.56Zanix|Workwell, I can get it, but im working right now :(
21:00.11Diska<PROTECTED>
21:00.16Diska:p
21:01.12Zanix|Workyeah
21:01.28Zanix|Workfind the next occurance of ranged_dps
21:01.37Zanix|Workthere should be another string called damage or such
21:01.47Zanix|WorkI cant remember
21:02.30Diska$this->add_ifvalue( $attack, 'AttackDPS', 'ranged_dps' );  - Guess it should be AttackDPS then?
21:02.41Zanix|Workyeah
21:02.44Zanix|Workit should be
21:03.42Diskaaye, that fixed that problem
21:04.14Diska2 more errors to go, but I won't trouble you at work :)
21:05.56Zanix|Workusually its slow
21:06.00Zanix|Workbut today, omg
21:06.33DiskaAh, the last 2 errors are about the Guildless- addon, it errors about it being special and that i can't remove it etc
21:07.00DiskaI deleted some American guild that had suddenly turned up at my site :s
21:07.28Diskasomeone must have been trying stuff, I never did that, guess i had it unprotected at some point
21:09.03Zanix|Workgo to upload rules, make sure they are set correctly
21:09.14Zanix|Workgo to data management
21:09.18Zanix|Workhit enforece rules
21:10.50Diskathat keeps bringing up a log that tries deleting the same 15 people every time and then errors on not being able to delete the guildless- guild
21:12.28Diskathose 15 people are still present in the roster_members table
21:12.32Zanix|Workhmmm
21:13.13Zanix|Workmay be stale data from before we actually fixed/finalized guildless handling
21:13.26Diskapossibly yes
21:13.37Diskai haven't been doing much with the site lately
21:14.06Diskajust picked it up again since it seems that i'm finally taking over the hosting for our guilds website
21:14.34Diskathey are using guildportal.com right now....yuch
21:14.37Zanix|Workah
21:14.55Zanix|Workprobably need to clear the guild table of old entries, or wipe roster and start over
21:15.34Diskahmmm, i'll try and clear it manually, i'd hate to have to start over, armory isn't reliable these days
21:15.43Zanix|Workindeed
21:18.26Diskaokay, fixed it
21:19.29PleegWatHi
21:19.31PleegWatIs it working?
21:19.49Diskanope, just tried it again after fixing the other stuff, and it's still not detecting keys
21:20.34DiskaInstanceKeys - Keycache cleaned - 0 gold stages activated - 0 item stages activated - 0 quest stages activated - 0 reputation stages activated - 0 skill stages activated
21:20.35Diskam
21:25.51DiskaI deleted the character diska and then uploaded cp/gp data again, still 0 things activated
21:34.50PleegWatCan you check the number of lines in the keycache table?
21:35.07PleegWatroster_addons_keys_keycache
21:35.07Diska0
21:35.12PleegWathm
21:35.24PleegWatNo SQL errors?
21:35.32PleegWatwhat's your php/mysql version?
21:35.54Diskanope, i copy&pasted some of the select rows from the debug and ran em manually: no results returned
21:36.22Diskaphp 5.2, mysql 5.0.23
21:36.32PleegWatyou're looking for a set of 5 INSERT INTO ... SELECT statements
21:37.01PleegWatoh, and what is your roster revision?
21:37.07Diskayep, got those
21:37.18DiskaINSERT INTO `roster_addons_keys_keycache` (`member_id`, `key_name`, `stage`) SELECT '202', `stages`.`key_name`, `stages`.`stage` FROM `roster_addons_keys_stages` AS stages, `roster_reputation` AS data WHERE `stages`.`faction` = 'A' AND `data`.`member_id` = '202' AND `stages`.`type` = 'R' AND `data`.`name` = `stages`.`value` AND `stages`.`count` < FIND_IN_SET(`data`.`Standing`, 'Hated,Hostile,Unfriendly,Neutral,Friendly,Honored,Revered,Exalted')
21:37.23Diskafor instance :p
21:37.24PleegWatHow many lines in the addons_keys_keys, addons_keys_stages tables?
21:37.55PleegWatI initially forgot to check in install_enUS.php. It won't error if that isn't in, but it won't have the key defs in the db then
21:38.09Diska24 and 85
21:38.21Diskaerr, 25 and 85
21:38.36PleegWatthat'll be right
21:39.00Diskait appears okay indeed
21:39.37PleegWathm, that's weird. It's not working here either
21:39.41PleegWatI swear it worked at work
21:39.44Diska:)
21:40.01Diskawell, at least you can debug on your own machine then :p
21:48.02PleegWatAh, shit
21:48.03PleegWatI found it
21:48.23PleegWatI'm checking SUM(`data`.`item_quantity`) > `stages`.`count`
21:48.27PleegWatSee the problem?
21:49.23Diska>= ?
21:49.29PleegWatexactly
21:49.34Diska:)
21:49.38PleegWataddons/keys/update_hook
21:49.43PleegWatOr check out from svn in a bit
21:51.03Diska7 item stages, whoohoo
21:51.14Diskaand 5 on the rogue
21:51.27PleegWatgz
21:51.29PleegWatworking now here too
21:52.00Diskanice one, but it doesn't handle lockpicking yet I think?
21:52.08PleegWatnot atm
21:52.24Diskaand very nice that it's using memberlist so i can get all the alts collapsed by default :p
21:52.43PleegWatI wrote that library for reuse.
21:53.07Diskavery usefull :)
21:53.33PleegWatmemberslist can get pretty powerful. The key columns are completely described by the key defines in the DB. Add a key define, and the column will show up automatically.
21:54.07PleegWatThe keys display code consists of a memberslist template and a callback to draw a single cell.
21:54.35Diskacool, powerfull indeed, you can use that for lots of stuff
21:54.54PleegWatAbout the lockpicking: I'm not really feeling like handling it special. No TBC locks can't be picked as far as I know, plus it can handle skills natively
21:55.15Diskayeah that's true
21:55.26Diskaeven most of the old locks can be lockpicked now
21:56.05Diskabut I always thought it looked cool :p
21:56.43PleegWatI'm thinking of adding a flow value that tells if a row is the final row. So you could add an extra stage somewhere, and define it with a ! or so in the flow field, and it'll declare the key completed if that stage is active.
21:56.55PleegWatCurrently it's hardcoded for the last stage.
21:57.34PleegWatShowing a different icon for different complete methods wouldn't be possible with just that though, and that's part of the point.
21:58.22Diskayeah indeed
21:58.35Diskaoh well, no big loss there though :)
22:01.23PleegWatI really like the way the keys turned out with the cache.
22:01.39Diskayeah, it's much faster this way
22:01.47PleegWatCode is much simpler too
22:01.56PleegWatAnd much more versatile
22:02.49PleegWatThe old approach completely denied the possibility of mixed conditions. Either the whole chain was item collection, or the whole chain was quests with a key item at the end.
22:03.43Diskaand now the highest stage which is valid completes it?
22:04.07PleegWatWith the current approach, you can mix them freely. And if someone (like me) decides we need an extra stage type, you just need one extra query in the update_hook to validate the stages of that type.
22:04.11PleegWatMore or less
22:04.20PleegWatThere's support for parallel subchains
22:04.59Diskaah okay, like the trial of the naaru questline and stuff, that's neat
22:05.25DiskaI'll see if I can whip up some of the TBC things
22:05.27PleegWatThe pre-TBC data only uses them in a few cases.
22:05.41PleegWatSome of the item collection for the UBRS key is parallel
22:06.01PleegWatAnd 3 quests in the onyxia chain which looked parallel from their names turned out to be
22:07.16Zanix|Workhey PleegWat, I have an idea on the lockpicking
22:07.20Zanix|Workif you implement it
22:07.21PleegWatya?
22:08.01Zanix|Workinstead of replacing the ey like before, add something to the cell, some symbol saying that this person can pick the lock
22:08.40Zanix|Worklike have the icon, then put the lockpicking part as an overlay on the icon
22:08.55Zanix|Worklike how the item quantity shows
22:09.07Zanix|Workjust a 'display' idea
22:09.29PleegWatYeah, could do that if I want to implement locks like a special case.
22:09.36PleegWatThat wouldn't be hard. Just add a column in the keys table.
22:09.54PleegWatBut I don't really want to treat lockpicking special, because none of the TBC attunement locks are pickable.
22:10.08PleegWathm, arca might be.
22:10.08Zanix|Workyeah, I completely understand tht
22:10.15PleegWatbut I don't thinkso
22:10.22Diskaarca and shattered halls are pickable
22:11.26Zanix|Workthat might be enough to handle it
22:12.15Zanix|Workhttp://www.wowwiki.com/Lockpicking
22:12.16PleegWatyeah
22:12.51PleegWatSH, SL< arca
22:13.07Zanix|Workwow
22:13.22Diskaah right, completely forgot about SL
22:13.28Zanix|Workit even has skeleton keys and seaforium charges
22:13.45Diskai've never seen anyone use those :)
22:13.48PleegWatGuess I'll implement lockpicking as a special case then
22:15.21Zanix|Workwould it be worth adding the skeleton keys and explosives as well?
22:15.31PleegWatnah
22:15.52PleegWatI could put it in the tip
22:16.14Zanix|Workok, just no detection for it
22:16.26Zanix|Workworks out well
22:16.30Zanix|Workeveryone is happy
22:16.33PleegWatYeah, I mean just the needed skill in the tip
22:18.20Zanix|Workright
22:45.16PleegWatok it's in the DB
22:46.43PleegWatdamn.
22:46.53PleegWatlockpicking is a skill name
22:46.57PleegWatwe store those localized.
22:47.25PleegWathow did we use to do that. Ugly?
22:48.51PleegWatyup. one query per char.
22:48.58PleegWatGonna have to store the damn thing as a stage anyway.
22:49.25PleegWatso it's prefetched with the rest
23:00.59PleegWatI added lockpicking to the DB
23:01.05PleegWatI'll do display later.
23:01.08PleegWatnight
23:01.25Diskaawesome, good night :)
23:02.07PleegWatIf you feel like going at it, it's stored as stage -1 with normal syntax for the rest of it. Not tested with an actual rogue, I don't have one, but it should fill fine.
23:26.48*** join/#wowroster fewyn (i=fewyn@46.210.33.65.cfl.res.rr.com)
23:42.31fewynnote to self: upload addons to the correct directory of roster
23:43.43Zanix|Worknight PleegWat
23:48.08Zanix|Workgoing home, later

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.