| 01:15.39 | *** join/#storm jdobrien (n=john@132.199.119.70.cfl.res.rr.com) |
| 02:03.58 | *** join/#storm artista-frustrad (n=artista_@201-15-217-88.ctame704.dsl.brasiltelecom.net.br) |
| 03:37.06 | *** join/#storm jdobrien (n=john@132.199.119.70.cfl.res.rr.com) |
| 04:04.03 | *** join/#storm _thumper_ (n=quassel@125-236-193-95.adsl.xtra.co.nz) |
| 05:56.58 | *** join/#storm stub (n=stub@ppp-58-8-8-73.revip2.asianet.co.th) |
| 06:06.44 | *** join/#storm artista (n=artista_@201-15-254-59.ctame704.dsl.brasiltelecom.net.br) |
| 06:11.00 | *** join/#storm jukart (i=lovely@81.189.156.94) |
| 06:41.17 | jamesh | stub: did you have any luck running the Launchpad test suite against my aggregates Storm branch? |
| 06:41.42 | stub | Yes, and opened a bug report and subscribed you to it ;) |
| 06:41.55 | stub | https://bugs.edge.launchpad.net/launchpad-foundations/+bug/405772 |
| 06:41.56 | mup | Bug #405772: Update to Storm 0.15 <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/405772> |
| 06:42.03 | stub | I haven't looked further yet |
| 06:42.08 | jamesh | missed that. |
| 06:43.02 | stub | Only two failures over the whole Launchpad is actually pretty good I thought ;) |
| 06:43.13 | jamesh | do you know what SQL is being generated there? |
| 06:43.40 | stub | Nah - I haven't looked further yet. |
| 06:44.16 | stub | I'll grab the SQL for the first failure now.. |
| 06:44.17 | jamesh | hmm. I've got some idea though. |
| 06:45.03 | jamesh | we probably have a result set corresponding to something like "SELECT DISTINCT foo.id, foo.name FROM foo ORDER BY foo.name" |
| 06:45.36 | jamesh | and then I rewrite it to "SELECT COUNT(*) FROM (SELECT DISTINCT foo.id FROM foo ORDER BY foo.name) AS _tmp" |
| 06:46.03 | jamesh | I'm filtering out everything but the primary keys |
| 06:46.39 | jamesh | perhaps leaving the column list as is would be appropriate. |
| 06:46.48 | stub | SELECT |
| 06:46.48 | stub | <PROTECTED> |
| 06:46.48 | stub | alidPersonCache.id = Person.id WHERE (Person.visibility = 1 OR NOT (Person.teamo |
| 06:46.48 | stub | wner IS NULL) AND Person.visibility = 30) AND Person.teamowner IS NULL ORDER BY |
| 06:46.48 | stub | Person.displayname, Person.name LIMIT 100) AS "_tmp" |
| 06:47.22 | jamesh | looks about right :) |
| 06:47.34 | stub | Well... apart from the query being crap ;) |
| 06:48.09 | stub | So this one could be fixed by rewriting that code sanely perhaps, although that might leave a bug lurking in Storm. |
| 06:48.44 | jamesh | whether that particular query is bad or not is beside the point |
| 06:48.50 | jamesh | it is a bug in my branch |
| 06:51.46 | stub | You should be able to drop the ORDER BY alltogether for count. I guess you want to support generic aggregates though. |
| 06:51.59 | jamesh | not in all cases |
| 06:52.58 | jamesh | e.g. if the original query was "SELECT foo.id, foo.name, foo.maybe_null FROM foo ORDER BY foo.name LIMIT 10" |
| 06:53.07 | jamesh | and I want to do COUNT(foo.maybe_null) |
| 06:53.53 | jamesh | the order clause would affect which rows are included in the count |
| 06:55.32 | stub | Hmm... and Storm doesn't know if the column can contain null or not, unless it is the primary key. |
| 06:56.10 | stub | It might be worth special casing count when the column list contains a primary key - that will optimize the most common use case, but that is separate to this patch I guess. |
| 06:56.28 | jamesh | I'd want to generate "SELECT COUNT(_expr) FROM (SELECT foo.id, foo.name, foo.maybe_null, foo.maybe_null AS _expr FROM foo ORDER BY foo.name LIMIT 10) AS _tmp" |
| 07:21.18 | jamesh | stub: I've uploaded a new revision on my branch that should fix those two failures. |
| 07:22.26 | stub | Cool. I'll eggify that and kick off another test run. |
| 07:23.02 | jamesh | just running those two tests alone first would be useful |
| 07:28.50 | *** join/#storm goschtl (n=goschtl@p5B0BC432.dip.t-dialin.net) |
| 07:33.18 | stub | jamesh: The two failing tests now pass locally. I'll start off the full suite on EC2 to see if there are any regressions, but it looks good. |
| 07:33.44 | jamesh | awesome. |
| 07:34.11 | jamesh | I doubt the change could break any other tests |
| 07:45.01 | *** join/#storm zmijunkie (n=chatzill@92.117.182.212) |
| 08:18.40 | *** join/#storm goschtl (n=goschtl@p5B0BC432.dip.t-dialin.net) |
| 09:41.20 | *** join/#storm seiflotfy (n=seif@P5118.pallas.wh.tu-darmstadt.de) |
| 10:09.30 | *** join/#storm zmijunkie_ (n=chatzill@92.117.172.153) |
| 10:10.43 | *** join/#storm artista (n=artista_@201-24-234-38.ctame704.dsl.brasiltelecom.net.br) |
| 10:35.37 | *** join/#storm zmijunkie (n=chatzill@92.117.8.166) |
| 10:59.27 | *** join/#storm andrea-bs (n=andrea@ubuntu/member/beeseek.developer.andrea-bs) |
| 11:06.48 | *** join/#storm zmijunkie_ (n=chatzill@92.117.173.172) |
| 11:11.47 | *** join/#storm fcorrea (n=fcorrea@189.62.16.54) |
| 11:20.56 | *** join/#storm jdobrien (n=john@132.199.119.70.cfl.res.rr.com) |
| 12:57.12 | *** join/#storm niemeyer (n=niemeyer@200-138-49-140.ctame705.dsl.brasiltelecom.net.br) |
| 13:03.21 | *** join/#storm oubiwann (n=oubiwann@c-66-31-200-98.hsd1.ma.comcast.net) |
| 13:24.37 | *** join/#storm sidnei (n=sidnei@plone/dreamcatcher) |
| 13:29.53 | *** join/#storm oubiwann_ (n=oubiwann@c-66-31-200-98.hsd1.ma.comcast.net) |
| 14:00.44 | *** join/#storm stub (n=stub@ppp-58-8-8-73.revip2.asianet.co.th) |
| 14:10.54 | *** join/#storm artista (n=artista_@200-193-162-132.ctame704.dsl.brasiltelecom.net.br) |
| 14:48.12 | *** join/#storm oubiwann (n=oubiwann@c-66-31-200-98.hsd1.ma.comcast.net) |
| 15:44.45 | *** join/#storm seiflotfy (n=seif@P5118.pallas.wh.tu-darmstadt.de) |
| 16:03.54 | *** join/#storm andrea-bs (n=andrea@ubuntu/member/beeseek.developer.andrea-bs) |
| 16:44.27 | *** join/#storm mwhudson (n=mwh@canonical/launchpad/mwhudson) |
| 17:09.35 | *** join/#storm mwhudson_ (n=mwh@118-92-167-245.dsl.dyn.ihug.co.nz) |
| 17:38.16 | *** join/#storm andrea-bs (n=andrea@ubuntu/member/beeseek.developer.andrea-bs) |
| 17:39.10 | *** join/#storm drudi (n=drudi@187.47.239.104) |
| 18:05.11 | *** join/#storm artista (n=artista_@200-193-163-169.ctame704.dsl.brasiltelecom.net.br) |
| 18:53.25 | *** join/#storm jukart (n=jukart@d86-32-163-51.cust.tele2.at) |
| 19:13.18 | *** join/#storm jukart (n=jukart@d86-32-163-51.cust.tele2.at) |
| 20:00.27 | *** join/#storm mwhudson_ (n=mwh@118-93-55-67.dsl.dyn.ihug.co.nz) |
| 20:21.33 | *** join/#storm mwhudson_ (n=mwh@118-93-55-67.dsl.dyn.ihug.co.nz) |
| 21:30.55 | *** join/#storm seiflotfy1 (n=seif@P5118.pallas.wh.tu-darmstadt.de) |
| 21:38.30 | *** join/#storm keppla1 (n=keppla@i577B0110.versanet.de) |
| 21:57.31 | *** join/#storm jkakar (n=jkakar@S0106001ee57a879c.vc.shawcable.net) |
| 22:11.19 | *** join/#storm artista_frustrad (n=artista_@201-15-250-218.ctame704.dsl.brasiltelecom.net.br) |
| 22:17.40 | *** part/#storm keppla1 (n=keppla@i577B0110.versanet.de) |
| 22:26.23 | *** join/#storm keppla1 (n=keppla@i577B0110.versanet.de) |
| 23:00.20 | *** join/#storm drudi (n=drudi@189.116.23.226) |