| 00:06.53 | *** join/#storm shaunm (n=shaunm@c-98-212-133-244.hsd1.il.comcast.net) |
| 00:55.21 | *** join/#storm fcorrea (n=fcorrea@189.62.24.212) |
| 01:48.44 | *** join/#storm sidnei (n=sidnei@plone/dreamcatcher) |
| 03:17.24 | *** join/#storm thumper (n=tim@canonical/launchpad/thumper) |
| 04:09.30 | *** join/#storm _thumper_ (n=quassel@125-236-193-95.adsl.xtra.co.nz) |
| 04:58.06 | *** join/#storm jukart (n=jukart@d91-128-122-26.cust.tele2.at) |
| 07:25.26 | *** join/#storm jukart (i=lovely@81.189.156.94) |
| 07:33.54 | *** join/#storm seiflotfy1 (n=seif@41.234.25.65) |
| 08:29.42 | *** join/#storm goschtl (n=goschtl@p5B0BFD76.dip.t-dialin.net) |
| 12:22.49 | *** join/#storm niemeyer (n=niemeyer@200-103-135-47.ctame705.dsl.brasiltelecom.net.br) |
| 12:38.08 | *** join/#storm andrea-bs (n=andrea@ubuntu/member/beeseek.developer.andrea-bs) |
| 13:27.36 | *** join/#storm RainCT (n=RainCT@ubuntu/member/rainct) |
| 13:28.19 | RainCT | Hi |
| 13:28.59 | RainCT | Does the ? substitution in .execute do any safety check or is it the same as using Python's "%"? |
| 13:36.21 | therve | it means it will be substituted by the db driver |
| 13:36.50 | therve | I'm not sure what you mean though |
| 13:54.52 | RainCT | therve: as in, if I do "='?'" escape the quotes in whatever "?" represents? |
| 14:00.24 | *** join/#storm shaunm (n=shaunm@proxyserver.wolfram.com) |
| 14:12.36 | therve | RainCT: yes |
| 14:13.37 | RainCT | therve: okay, thanks |
| 14:41.34 | jamesh | therve: with your comment on https://code.edge.launchpad.net/~jamesh/storm/bug-349482/+merge/6693, why do you think it'd be clearer to pass a separate locals dict to exec? |
| 14:42.36 | jamesh | with the code being executed, only one name can be added to the namespace, so it isn't like it'll protect any special names |
| 14:43.50 | radix | doesn't exec default to using the caller's local namespace? |
| 14:44.23 | therve | jamesh: I meant cleaner, I think |
| 14:44.50 | jamesh | radix: not if you pass one to it |
| 14:44.52 | therve | oh, I wrote cleaner :) |
| 14:45.03 | radix | jamesh: right I said "default" :) |
| 14:45.45 | jamesh | radix: my code is "exec code in namespace" and therve was suggesting "exec code in namespace, local" |
| 14:46.06 | radix | yes I know |
| 14:46.15 | radix | jamesh: so your code uses the caller's local namespace |
| 14:46.31 | jamesh | radix: no. It uses the same namespace for both locals and globas |
| 14:46.33 | jamesh | globals |
| 14:46.36 | radix | oh |
| 14:46.47 | jamesh | let me check |
| 14:46.50 | radix | ok |
| 14:46.57 | radix | then that doesn't sound bad |
| 14:47.48 | jamesh | http://docs.python.org/reference/simple_stmts.html#the-exec-statement |
| 14:47.58 | jamesh | "If only the first expression after in is specified, it should be a dictionary, which will be used for both the global and the local variables." |
| 14:48.08 | radix | that sounds fine to me |
| 14:48.45 | jamesh | if it was using the caller's locals, then I'd have expected the new function to turn up there |
| 14:48.56 | therve | jamesh: the thing is that I had to check that page too to remember how it worked |
| 14:49.07 | therve | jamesh: so using a different dict makes it obvious |
| 14:49.17 | therve | jamesh: but your code is correct, I agree |
| 14:49.25 | radix | therve: yeah but james didn't, maybe you should be as smart as james ;-) |
| 14:49.28 | jamesh | therve: how about "exec code in namespace, namespace" |
| 14:49.29 | jamesh | ? |
| 14:49.40 | therve | radix: I try hard :) |
| 14:49.49 | therve | jamesh: I prefer you keep it like now then |
| 14:52.54 | jamesh | I hadn't really thought about locals vs. globals when writing that code |
| 14:53.15 | jamesh | I guess I'd be surprised if "exec code in namespace" did anything other than execute the code string in the given namespace. |
| 15:46.27 | *** join/#storm jukart (n=jukart@d91-128-122-26.cust.tele2.at) |
| 17:38.28 | *** part/#storm RainCT (n=RainCT@ubuntu/member/rainct) |
| 21:51.39 | *** join/#storm seiflotfy (n=seif@41.234.24.65) |