| 00:00.31 | *** join/#storm wallflower (n=wallflow@ip-205-246-113-216.pool.grokthis.net) |
| 03:05.11 | *** join/#storm oubiwann (n=oubiwann@70-57-176-42.omah.qwest.net) [NETSPLIT VICTIM] |
| 03:29.39 | *** join/#storm oubiwann (n=oubiwann@70-57-176-42.omah.qwest.net) |
| 05:17.26 | *** join/#storm bigdog (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) |
| 05:56.33 | *** join/#storm bigdog (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) [NETSPLIT VICTIM] |
| 05:56.33 | *** join/#storm oubiwann (n=oubiwann@70-57-176-42.omah.qwest.net) [NETSPLIT VICTIM] |
| 06:45.33 | *** join/#storm bigdog (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) [NETSPLIT VICTIM] |
| 06:45.33 | *** join/#storm oubiwann (n=oubiwann@70-57-176-42.omah.qwest.net) [NETSPLIT VICTIM] |
| 07:02.29 | *** join/#storm jukart (n=jukart@85-124-221-45.static.xdsl-line.inode.at) |
| 07:10.38 | *** join/#storm jamesh (n=james@canonical/launchpad/jamesh) |
| 07:47.19 | *** join/#storm mcella (n=mcella@ip-176-97.sn2.eutelia.it) |
| 09:01.45 | *** join/#storm lightyea1 (n=lightyea@nat/fluendo/x-a2c32ce69561c9c2) |
| 09:48.17 | *** join/#storm jukart (n=jukart@85-124-221-45.static.xdsl-line.inode.at) |
| 10:18.26 | *** join/#storm dobee (n=dobee@85-124-200-100.static.xdsl-line.inode.at) |
| 12:02.28 | *** join/#storm jamesh (n=james@canonical/launchpad/jamesh) |
| 13:05.19 | *** join/#storm niemeyer (n=niemeyer@200-103-247-228.ctame705.dsl.brasiltelecom.net.br) |
| 13:37.09 | *** join/#storm bigdog (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) |
| 14:42.52 | therve | jamesh: hi |
| 14:43.22 | jamesh | hi therve |
| 14:44.00 | therve | thanks for your insights on the group_by feature |
| 14:44.27 | therve | I've started to implement it atop of your branch, and it seems fairly trivial |
| 14:45.13 | therve | I was wondering 2 things: |
| 14:45.29 | jamesh | thanks for the comments on my branch. I'll go through them soon. |
| 14:45.35 | therve | why should group_by check the arguments in find_expr? |
| 14:45.50 | therve | and 2) what's the use case of group_by(table) ? |
| 14:48.37 | jamesh | therve: if there are tables in the find expression, we'd want to make sure that we group by all the columns in that table |
| 14:49.04 | jamesh | or none of the columns |
| 14:49.35 | therve | but that's equivalent to a group by its primary key |
| 14:49.40 | jamesh | as we select the primary key of the table, anything in between can't work |
| 14:50.23 | jamesh | right, but the columns in the SELECT statement need to either be found in GROUP BY or be aggregates |
| 14:50.42 | therve | right |
| 14:50.57 | jamesh | hmm |
| 14:51.08 | therve | so it's more checking that find_expr is in the group_by statement |
| 14:51.13 | jamesh | maybe you always want to group by tables in the find_expr if you're grouping |
| 14:52.26 | jamesh | My implementation suggestion was mostly from memory |
| 14:53.20 | therve | I think I understand what you mean, but I don't manage to transform that into an example and a test |
| 14:53.25 | jamesh | don't feel a need to do things exactly like that if you think you can do better |
| 14:54.06 | therve | okay |
| 14:54.19 | therve | I just thought you had a precise usecase in mind |
| 14:56.08 | jamesh | I've got code that could use this feature, but it is going to take me a while before I've got time to look at this |
| 14:56.23 | jamesh | so I'm happy that you're interested in it |
| 14:56.47 | therve | alright :) |
| 14:59.38 | jamesh | the use cases generally boild down to selecting one table plus one or more aggregates |
| 15:00.01 | jamesh | cases where I'd want to group by the first table |
| 15:02.29 | therve | so in fact that's pretty well summarized by the comment you put in the ticket |
| 15:02.35 | therve | store.find((Foo, Count()), Foo.id == Bar.foo).group_by(Foo) |
| 15:03.05 | therve | I just didn't read that carefully enough |
| 15:37.29 | *** join/#storm jukart (n=jukart@85-124-221-45.static.xdsl-line.inode.at) |
| 16:21.50 | *** join/#storm bigdog (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) |
| 16:52.52 | *** join/#storm mru- (n=luk@193.19.165.16.osk.enformatic.pl) |
| 16:53.00 | *** part/#storm mru- (n=luk@193.19.165.16.osk.enformatic.pl) |
| 17:10.09 | *** join/#storm bigdo3 (n=scmikes@72-197-8-8-arpa.cust.cinci.current.net) |
| 17:16.00 | *** join/#storm niemeyer (n=niemeyer@200-138-37-84.ctame705.dsl.brasiltelecom.net.br) |
| 17:39.59 | *** join/#storm dobee (n=dobee@85-124-200-100.static.xdsl-line.inode.at) |
| 17:55.36 | *** join/#storm jkakar (n=jkakar@S0106001b11b2d97a.vc.shawcable.net) |
| 18:08.41 | *** join/#storm rockstar (n=rockstar@75-171-136-68.hlrn.qwest.net) |
| 18:38.37 | *** join/#storm rockstar (n=rockstar@75-171-171-238.hlrn.qwest.net) |
| 20:07.40 | *** join/#storm dobee (n=dobee@85-124-200-100.static.xdsl-line.inode.at) |
| 20:13.05 | *** join/#storm MattCampbell (n=matt@ppp-70-130-44-224.dsl.wchtks.swbell.net) |
| 20:21.04 | *** part/#storm MattCampbell (n=matt@ppp-70-130-44-224.dsl.wchtks.swbell.net) |