| 00:39.42 | *** join/#norganna Mike-N-Go (~Mike-N-Go@64.193.93.197) |
| 01:40.44 | Gnarfoz | why does Auctioneer refuse to play nice with Links? |
| 01:41.12 | Gnarfoz | (which is an addon that allows multiple tooltips at the same time; LibExtraTip complains about being passed unknown tooltips) |
| 03:44.36 | Mike-N-Go | Gnarfoz: Some addons reduce item links.. |
| 03:45.22 | Mike-N-Go | So, if the next addon down the chain tries to look for part of the item link that got cut out, then it will likely not work. |
| 03:45.23 | Gnarfoz | meaning? it's hooking and not passing everything it itself got on to the hooked function? |
| 03:46.11 | Gnarfoz | I doubt very much it's modifying strings, if you mean the actual link string |
| 03:46.42 | Gnarfoz | hmmm |
| 03:46.46 | Mike-N-Go | Let me look it up and give an example.. |
| 03:46.59 | Mike-N-Go | Been a long time since I messed with item ids. |
| 03:48.40 | Gnarfoz | would it cut short figuring this out if I pastey'd the actual error & the addon (it's basically only one file)? |
| 03:49.18 | Mike-N-Go | This is a random dump from a GetItemInfo() |
| 03:49.20 | Mike-N-Go | "Bandit Cloak of the Owl", "|cff1eff00|Hitem:9779:0:0:0:0:0:756:1099586688:1:0|h[Bandit Cloak of the Owl]|h|r", 2, 18, 13, "Armor", "Cloth", 1, "INVTYPE_CLOAK", "Interface\\Icons\\INV_Misc_Cape_19", 334 |
| 03:49.48 | Mike-N-Go | The itemLink is what we are intrested in |
| 03:50.03 | Mike-N-Go | "|cff1eff00|Hitem:9779:0:0:0:0:0:756:1099586688:1:0%7Ch%5BBandit Cloak of the Owl]|h|r" |
| 03:50.26 | Gnarfoz | well, yes |
| 03:50.48 | Gnarfoz | but how does that result in an "unknown tooltip" error, shouldn't it say something like "broken link"? |
| 03:51.35 | Gnarfoz | or to put it another way: should I be looking for actual lost args (I don't think that's what's happening, he's using ... at all the right places (or so it seems to me, maybe I'm overlooking something)), or for string manipulation functions? |
| 03:51.58 | cirdan | damn i hate when the world servers crash |
| 03:52.01 | Mike-N-Go | If you go to http://www.wowhead.com/item=9779, that will show up as Bandit Cloak. |
| 03:52.01 | Gnarfoz | heh, if Jerry was on IRC, he'd probably figure this out himself in a minute, I'm just stumbling my way through |
| 03:52.19 | Gnarfoz | yes, because random stats are part of the item link etc |
| 03:52.48 | Mike-N-Go | The 756 stand for the 'Owl' part of the item. |
| 03:52.50 | Gnarfoz | ([Thunderfury of the Whale], yay (sadly fixed long ago) |
| 03:53.18 | Mike-N-Go | And 1099586688 is the unique identifier for the item. |
| 03:53.28 | Mike-N-Go | If memory servers me well. |
| 03:53.40 | Mike-N-Go | Some addons would cut off the latter parts of an item link. |
| 03:54.39 | Mike-N-Go | Even 'just' reducing our test item to "|cff1eff00|Hitem:9779:0:0:0:0:0:0:0:1:0|h[Bandit Cloak]|h|r" |
| 03:54.53 | Mike-N-Go | Or even "|cff1eff00|Hitem:9779|h[Bandit Cloak]|h|r" |
| 03:55.28 | Gnarfoz | but shouldn't that just result in the tooltip being wrong, instead of it causing an actual lua error? |
| 03:55.46 | Mike-N-Go | Because their addon only needs that part of the link, but if they don't do it right, it can screw with other addons that are working with items. |
| 03:55.53 | Gnarfoz | ah... 5am makes becomes noticable, of course the lua error is an assert() |
| 03:55.57 | Mike-N-Go | Gnarfoz: What is the specfi error? |
| 03:56.27 | Mike-N-Go | That error is likley in an addon for debugging to yell "Help!" |
| 03:56.30 | Gnarfoz | well, the entire point of the addon is just to allow multiple tooltips being shown at the same time, so I would expect the author to not mangle the links ;] |
| 03:57.04 | Gnarfoz | it's an assertion in LibExtraTip, let me get it real quick |
| 03:57.05 | Mike-N-Go | If memory servers me well, it is best to create a double of the variable you are working on as a local.. |
| 03:57.21 | Mike-N-Go | That way, if your addon does something funny, it does not mess up other addons. |
| 03:57.56 | Mike-N-Go | I have not programed in quite a while, but I have made a few addons that play around with item links.. so I know a deal about this topic. |
| 03:58.56 | Gnarfoz | yes, but you seem to be already focused on it being some sort of string manipulation mess-up, I'm not even sure it's that kind of problem (no offense) |
| 03:59.17 | Gnarfoz | http://pastebin.com/Z0gKAQ6F |
| 03:59.20 | Gnarfoz | is the error |
| 03:59.47 | Mike-N-Go | Gnarfoz: I did not understand exactly what the problem was, because no specfic error message was posted. |
| 03:59.50 | Gnarfoz | (Prat's just there because, well, the chatframe from which I clicked the link is) |
| 04:00.04 | Gnarfoz | and I asked initially if posting the exact error would help moving this along faster :D |
| 04:00.17 | Mike-N-Go | But one of the usual perpetrators is a depreciated itemLink. |
| 04:00.41 | Gnarfoz | http://pastebin.com/uhga81KC < this is Links.lua |
| 04:01.10 | Gnarfoz | hmm, old stuff might be the culprit, Links is probably older than Auc-Adv |
| 04:01.22 | Gnarfoz | (although still actively maintained, Jerry is still around) |
| 04:02.12 | Mike-N-Go | I don't meen a depreciated addon |
| 04:02.39 | Mike-N-Go | I mean, the itemLink itself has been depreciated or reduced to something like "|cff1eff00|Hitem:9779%7Ch%5BBandit Cloak]|h|r" in our exmaple. |
| 04:03.09 | Gnarfoz | ah, you mean truncated |
| 04:03.16 | Mike-N-Go | truncated, yah. |
| 04:03.18 | Gnarfoz | or just old format, whatever |
| 04:03.30 | Mike-N-Go | Like I said.. it has been years since I programed =D |
| 04:03.52 | Mike-N-Go | But you spend a few 100 hours on a project.. you are bound to remember at least a few hours worth of it. |
| 04:04.09 | Gnarfoz | well, that assert in LibExtraTip is to check if the tooltip being passed to it is of a type that LibExtraTip is supposed to handle |
| 04:04.21 | Mike-N-Go | 1% to 3% is the least I could rember. |
| 04:04.38 | Gnarfoz | so... I'm guessing it's being passed either without a type at all, since being passed with a wrong type would be just weird |
| 04:04.49 | Mike-N-Go | For clarification, the addons that do not play well together are Auc-Adv and LibExtraTip? |
| 04:05.03 | Gnarfoz | no |
| 04:05.13 | Mike-N-Go | What are the addons involved? |
| 04:05.38 | Gnarfoz | LibExtraTip is part of Auc-Adv; thus Links and Auc-Adv are the addons involved |
| 04:06.20 | Mike-N-Go | I see, most of my experience working with the Auctioneer addon itself is from clasic. |
| 04:06.28 | Mike-N-Go | 2.x or somesuch |
| 04:06.36 | Gnarfoz | 2.x... classic? |
| 04:06.41 | Gnarfoz | or auctioneer 2.x |
| 04:06.52 | Mike-N-Go | 2.x of auctioneer |
| 04:06.55 | Gnarfoz | (Links is at: http://www.wowace.com/addons/links/ - for reference) |
| 04:06.59 | Mike-N-Go | If memory servers me well. |
| 04:08.33 | Mike-N-Go | Have you sandboxed your UI, only enabling the addon combination that tosses the error? |
| 04:09.28 | Gnarfoz | it's pretty clear from the stack trace who is involved |
| 04:09.40 | Gnarfoz | error reports are quite verbose these days |
| 04:09.51 | Gnarfoz | (I could do it for posterity's sake, of course) |
| 04:10.23 | Gnarfoz | got a char for just that, anyway |
| 04:11.18 | Mike-N-Go | Gnarfoz: Another problem could be that the tooltip hooking is not compatible between these two addons? |
| 04:11.42 | Mike-N-Go | Gnarfoz: I have not read the entirely of the dump, yet. |
| 04:12.00 | Gnarfoz | meaning... what? of course it's not at the moment, we wouldn't have anything to talk about if it was compatible :D |
| 04:13.00 | Mike-N-Go | Nonetheless, the tracestack is not always reliable, sometimes it just shows only one of the addons in the chain that are causing the issue. |
| 04:13.26 | Gnarfoz | that's a wrong assumption these days, imho, it's provided by the game now, not addons |
| 04:13.38 | Gnarfoz | http://pastebin.com/xpVFp0xh < with just auc-adv, stubby (necessary dep for auc-adv) and Links loaded |
| 04:14.04 | Mike-N-Go | Gnarfoz: I see, this has changed since I last programed. |
| 04:14.22 | Mike-N-Go | Like I said, it has been a long time. So I am not up to date on many of the changes. |
| 04:14.24 | Gnarfoz | ahh, I think I've found both the problem and the reason why the tooltip is shown regardless of the error |
| 04:14.35 | Gnarfoz | OnTooltipSetItem = function (...) |
| 04:14.35 | Gnarfoz | local handler = ItemRefTooltip:GetScript"OnTooltipSetItem" |
| 04:14.35 | Gnarfoz | return handler and handler(...) |
| 04:14.35 | Gnarfoz | end, |
| 04:14.48 | Gnarfoz | his hook returns once without args and once with the vararg |
| 04:15.06 | Gnarfoz | the first of course calls auctioneer's hook down the line at some point, without args, resulting in the error |
| 04:15.18 | Mike-N-Go | ... is whatever args are left, if memory servers me. |
| 04:15.32 | Mike-N-Go | ... is very easy to mess up on =P |
| 04:15.35 | Gnarfoz | ... is the vararg, containing all args the function was called with |
| 04:15.53 | Gnarfoz | (that is, unless you specify more parameters in the function signature before it) |
| 04:15.58 | Mike-N-Go | I did not think it is all the args. |
| 04:16.09 | Mike-N-Go | Like if we have f(x,y,...) |
| 04:16.12 | Gnarfoz | well, nothing to mess up in this case, really, since he just does handler(...), but returning twice is the proble |
| 04:16.19 | Gnarfoz | yes, that's what I was trying to say. |
| 04:16.22 | Mike-N-Go | ... would not be x and y |
| 04:16.25 | Gnarfoz | all args except those defined before it |
| 04:16.49 | Mike-N-Go | It is a jungle out there. |
| 04:16.53 | Gnarfoz | but since he uses just ..., there's nothing to mess up, since he does exactly what he should be doing: pass /everything/ through |
| 04:17.18 | Gnarfoz | except of course I don't know why he returns twice, the first one doing it wrong and the second one doing it correctly :D |
| 04:17.48 | Gnarfoz | I'll create a ticket on Links' bug tracker and let him figure it out himself, he probably knows why it does what it does |
| 04:18.04 | Mike-N-Go | Well, what part sees the return of that call? |
| 04:18.08 | Mike-N-Go | Maybe it is messed up? |
| 04:19.24 | Gnarfoz | I don't know if I'll be able to figure that out, his coding skills are at "ninja" level from my perspective. :D |
| 04:34.56 | Gnarfoz | sadly, neither reducing it to one return, or making both returns return(...) fixes it, so I'm out of ideas :F |
| 04:35.49 | Mike-N-Go | .. |
| 04:36.21 | Mike-N-Go | If you change the return of the function, you need to change every occurage of the function to reflect the change! |
| 04:36.55 | Mike-N-Go | For when the function is called, it is looking for that specficly. |
| 04:38.25 | Mike-N-Go | being the args returned, that is. |
| 04:38.29 | Mike-N-Go | And in what order. |
| 04:41.59 | Gnarfoz | huh? |
| 04:42.53 | Gnarfoz | I can pass as many additional parameters as I like; if the function that is receiving them does not use them, they are discarded |
| 04:43.06 | Gnarfoz | (only trouble would be if the receiving function used ...) |
| 04:43.25 | Gnarfoz | anyway, the point is: the first return returns /no args/ |
| 04:43.53 | Gnarfoz | while of course it should return all of them |
| 04:44.13 | Gnarfoz | not sure why he has two returns in the first place, but I'll let him figure it out |
| 04:44.18 | Gnarfoz | http://www.wowace.com/addons/links/tickets/5-incompatibility-with-auctioneers-lib-extra-tip/ =) |
| 05:00.03 | Mike-N-Go | I'm off to reto raid AQ |
| 05:00.06 | Mike-N-Go | TTL |
| 05:31.49 | *** join/#norganna Lisimba (~Lisimba@s537510ef.adsl.wanadoo.nl) |
| 05:41.00 | *** join/#norganna MentalPower (~MPower@WoWUIDev/Norganna/Administrator/MentalPower) |
| 05:41.00 | *** mode/#norganna [+o MentalPower] by ChanServ |
| 05:48.23 | *** join/#norganna ScratchMonkey_ (~chatzilla@c-24-7-80-209.hsd1.ca.comcast.net) |
| 07:51.18 | *** join/#norganna bleeter (~bleeter@guifications/developer/bleeter) |
| 10:33.57 | Mike-N-Go | Gnarfoz: Raid done. It was long.. |
| 13:15.42 | *** join/#norganna Kandoko (~Kandoko@WoWUIDev/Norganna/Developer/Kandoko) |
| 13:15.42 | *** mode/#norganna [+o Kandoko] by ChanServ |
| 13:18.59 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 13:18.59 | *** mode/#norganna [+o brykrys] by ChanServ |
| 13:26.32 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 13:26.32 | *** mode/#norganna [+o brykrys] by ChanServ |
| 13:46.22 | cirdan | yawns |
| 14:24.33 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 14:24.33 | *** mode/#norganna [+o brykrys] by ChanServ |
| 14:56.24 | *** join/#norganna dinesh (~dinesh@WoWUIDev/Norganna/PRManager/Dinesh) |
| 14:56.24 | *** mode/#norganna [+o dinesh] by ChanServ |
| 15:26.34 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 15:26.34 | *** mode/#norganna [+o brykrys] by ChanServ |
| 16:17.50 | *** join/#norganna Zasurus (~Zasurus@78-105-174-15.zone3.bethere.co.uk) |
| 16:42.39 | *** join/#norganna Yoshimo (~Miranda@p54998DCE.dip0.t-ipconnect.de) |
| 17:55.34 | *** join/#norganna JoBbZ (~JoBbZ@75.111.45.108) |
| 17:59.50 | *** join/#norganna JoBbZ (~JoBbZ@75.111.45.108) |
| 18:30.35 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 18:30.36 | *** mode/#norganna [+o brykrys] by ChanServ |
| 19:11.14 | *** join/#norganna ScratchMonkey_ (~chatzilla@c-24-7-80-209.hsd1.ca.comcast.net) |
| 19:30.34 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 19:30.34 | *** mode/#norganna [+o brykrys] by ChanServ |
| 20:10.44 | *** part/#norganna Esamynn|work (cc32712b@WoWUIDev/WoWI/Featured/Esamynn) |
| 21:16.33 | *** join/#norganna brykrys (~chatzilla@WoWUIDev/Norganna/Dev/Brykrys) |
| 21:16.33 | *** mode/#norganna [+o brykrys] by ChanServ |
| 22:23.43 | mascondante | Hey I got an idea for gatherer... if archeology nodes are static and behave the same way as herbs it would be cool to see dots or something to help speed up homing in on artifacts |
| 22:27.43 | mascondante | Also a friend of mine is asking about snatch. Says they have an option to buy everything but when they click it only buys one thing. Any insight on that folks? |
| 22:28.45 | mascondante | I'm guessing it has something to do with a hardware event but not positive. Also they're using the curse version and not the dev version |
| 23:58.38 | *** join/#norganna Zolan (~jgk@70.102.219.22) |