| 00:38.50 | *** join/#bzflag Snake12534 (~Snake1253@c-50-156-82-76.hsd1.ca.comcast.net) |
| 00:43.46 | *** join/#bzflag apeman (~Victor@222-155-41-238.jetstream.xtra.co.nz) |
| 01:43.30 | *** join/#bzflag delusional (~delusiona@pool-98-111-215-152.pitbpa.fios.verizon.net) |
| 02:37.47 | *** join/#bzflag JeffM (~JeffM@cpe-23-240-144-5.socal.res.rr.com) |
| 03:53.49 | *** join/#bzflag delusional (~delusiona@pool-98-111-215-152.pitbpa.fios.verizon.net) |
| 04:44.24 | *** join/#bzflag meeba (~lamer@c-75-71-23-204.hsd1.co.comcast.net) |
| 05:33.03 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 05:57.23 | *** join/#bzflag apeman1 (~Victor@222-155-41-238.jetstream.xtra.co.nz) |
| 08:52.53 | *** join/#bzflag catalyst (~catalyst@allegro/user/angelchild) |
| 09:12.50 | *** join/#bzflag catay (~smertens@valyria.catay.be) |
| 11:00.44 | *** join/#bzflag _lmnop1115 (~lmnop@91-65-161-106-dynip.superkabel.de) |
| 12:14.45 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 15:06.18 | *** join/#bzflag JeffM (~JeffM@cpe-23-240-144-5.socal.res.rr.com) |
| 15:11.44 | *** join/#bzflag MonsieurApple (~MonsieurA@unaffiliated/mrapple) |
| 15:12.19 | *** join/#bzflag plastix- (~plastix@107.170.226.100) |
| 15:20.29 | *** join/#bzflag rodgort (~rodgort@192.241.198.49) |
| 15:32.36 | *** join/#bzflag catalyst (~catalyst@allegro/user/angelchild) |
| 15:51.01 | blast007 | I'm thinking a 32-bit unsigned int is a bit overkill for the dialogID, right? ;) 16-bit should be enough, as with 200 players that would still allow for over 300 dialogs per player.. and if we have 300 dialogs per player, something is wrong (IDs can get reused once a dialog is destroyed) |
| 15:56.28 | BulletCatcher | If all dialogs are specific to a player, then it might be even better to have the ID number spaces distinct per player to make it (theoretically) impossible to mix them up. |
| 15:57.50 | blast007 | the owner of the dialog is stored as part of the DialogData |
| 15:58.40 | blast007 | I'd rather not hardcode anything like that |
| 15:59.32 | blast007 | I will probably store them by playerID in a std::map so that it's easier to destroy them when a player leaves the server |
| 16:00.15 | blast007 | probably needs a creation timestamp as well so dialogs can be expired |
| 16:00.46 | BulletCatcher | That would occur naturally if dialogs are referenced within GameKeeper::Player objects. |
| 16:01.09 | blast007 | hmm |
| 16:02.15 | blast007 | I'll try that once I get to that point |
| 16:11.07 | blast007 | is it "safe" to just let an int wrap around, or should it be handled explictly? |
| 16:11.53 | *** join/#bzflag addicta (5654edfe@gateway/web/freenode/ip.86.84.237.254) |
| 16:18.46 | BulletCatcher | AFAIK, C++ has no built-in overflow detection for ints, so it should happen quietly. |
| 16:21.00 | BulletCatcher | If you want it, there is probably already a class out there somewhere that throws overflow exceptions. |
| 16:22.08 | blast007 | nah, I actually want it to wrap around |
| 16:22.30 | BulletCatcher | Then it is safe to assume that it will happen without any extra effort on your part. |
| 16:22.52 | blast007 | if (dialogID == 4294967295) { dialogID = 0; } seemed a bit dirty |
| 16:23.14 | BulletCatcher | If you wanted to do that, MAX_INT would be your friend. |
| 16:24.03 | BulletCatcher | er, INT_MAX |
| 16:25.00 | blast007 | those sounded like they varied depending on the platform though |
| 16:25.15 | BulletCatcher | So does the size of an int. :-) |
| 16:25.17 | blast007 | since I was using uint32_t, I wanted to make sure it was always right |
| 16:31.15 | Not-cdc9 | [02bzflag-import-3] 07blast007 pushed 036 commits to 03v2_6_x [+0/-0/±9] 13http://git.io/xjhTpw |
| 16:31.16 | Not-cdc9 | [02bzflag-import-3] 07blast007 03dba39b8 - Fix up the getNextDialogID to handle looping and ID reuse, and return 0 when unable to find an available ID. |
| 16:31.17 | Not-cdc9 | [02bzflag-import-3] 07blast007 03c24d5e5 - Handle closing/destroying a dialog and informing the client. |
| 16:31.18 | Not-cdc9 | [02bzflag-import-3] 07blast007 030543fb9 - Disable the example dialog (while also adding a couple other pieces to test when enabled). |
| 16:31.19 | Not-cdc9 | [02bzflag-import-3] ... and 3 more commits. |
| 16:50.29 | *** join/#bzflag plastix- (~plastix@107.170.226.100) |
| 16:54.56 | *** join/#bzflag JeffM (~JeffM@12.167.61.2) |
| 16:57.22 | *** join/#bzflag Snake12534 (~Snake1253@c-50-156-82-76.hsd1.ca.comcast.net) |
| 17:03.26 | *** join/#bzflag MonsieurApple (~MonsieurA@unaffiliated/mrapple) |
| 17:07.46 | Not-cdc9 | [02bzflag-import-3] 07blast007 pushed 031 commit to 03v2_6_x [+0/-0/±1] 13http://git.io/mvQH_w |
| 17:07.47 | Not-cdc9 | [02bzflag-import-3] 07blast007 036da0fba - Let the looping happen naturally, and just increment a second time if the dialogID is 0. |
| 17:33.52 | blast007 | hmm, in bzfsAPI.cxx, our first version of bz_fireWorldWep skips specifying the speed to fireWorldWep on line 1629 of the v2_4_x version. Looks like it should be passing -1 there to use the default speed? |
| 17:34.21 | JeffM | probably |
| 17:34.31 | JeffM | I just left the old one like it was |
| 17:45.00 | *** join/#bzflag MonsieurApple (~MonsieurA@unaffiliated/mrapple) |
| 17:49.45 | Not-cdc9 | [02bzflag-import-3] 07blast007 pushed 031 commit to 03v2_4_x [+0/-0/±1] 13http://git.io/-3YSKQ |
| 17:49.46 | Not-cdc9 | [02bzflag-import-3] 07blast007 039f5228a - Add the missing speed value so that our values are being passed to the right arguments. |
| 18:09.08 | *** part/#bzflag parrent (uid35595@gateway/web/irccloud.com/x-lkdsodxektuiirqh) |
| 18:09.12 | *** join/#bzflag parrent (uid35595@gateway/web/irccloud.com/x-lkdsodxektuiirqh) |
| 18:09.15 | *** part/#bzflag parrent (uid35595@gateway/web/irccloud.com/x-lkdsodxektuiirqh) |
| 18:12.53 | blast007 | oh look, legacy code for detecting if we're using Windows older than NT 4.0 or 95 OSR2 ;) |
| 18:17.57 | Not-cdc9 | [02bzflag-import-3] 07blast007 pushed 039 commits to 03v2_6_x [+0/-0/±26] 13http://git.io/xvLu1A |
| 18:17.58 | Not-cdc9 | [02bzflag-import-3] 07blast007 038b30db4 - Merge remote-tracking branch 'origin/v2_4_x' into v2_6_x |
| 18:22.29 | Not-cdc9 | [02bzflag-import-3] 07blast007 pushed 031 commit to 03v2_6_x [+0/-0/±2] 13http://git.io/eNnTWg |
| 18:22.30 | Not-cdc9 | [02bzflag-import-3] 07blast007 039572516 - Get rid of some legacy code for detecting Windows versions earlier than NT 4.0 or 95 OSR2, which eliminates one use of the deprecated GetVersionEx. |
| 19:22.55 | *** join/#bzflag Snake12534 (~Snake1253@c-50-156-82-76.hsd1.ca.comcast.net) |
| 20:24.29 | *** join/#bzflag Snake12534 (~Snake1253@c-50-156-82-76.hsd1.ca.comcast.net) |
| 20:24.40 | Snake12534 | apeman |
| 21:35.27 | *** join/#bzflag JeffM (~JeffM@cpe-23-240-144-5.socal.res.rr.com) |
| 21:51.51 | *** join/#bzflag [dmp] (~dennis@users.d75.net) |
| 21:51.58 | *** join/#bzflag [dmp] (~dennis@unaffiliated/dmp/x-546784) |
| 22:01.26 | *** join/#bzflag apeman (~Victor@222-155-41-238.jetstream.xtra.co.nz) |
| 22:24.09 | *** join/#bzflag JeffM (~JeffM@cpe-23-240-144-5.socal.res.rr.com) |
| 23:13.04 | *** join/#bzflag Pimpinella (~frank@gondolin.pimpi.org) |
| 23:21.24 | *** join/#bzflag catalyst (~catalyst@allegro/user/angelchild) |