IRC log for #brlcad on 20170803

00:36.53*** join/#brlcad utkcamyrjeftpzyh (~armin@dslb-188-098-168-213.188.098.pools.vodafone-ip.de)
01:00.44*** join/#brlcad http_GK1wmSU (~deep-book@119.81.230.146)
01:02.13*** part/#brlcad http_GK1wmSU (~deep-book@119.81.230.146)
01:35.59*** part/#brlcad mdtwenty[m] (mdtwentyma@gateway/shell/matrix.org/x-zzjodrxmmmvwtbhh)
03:46.40*** join/#brlcad gabbar1947 (uid205515@gateway/web/irccloud.com/x-jzxieabhewzifbdm)
05:39.58*** join/#brlcad ``Erik (~erik@pool-100-16-35-136.bltmmd.fios.verizon.net)
05:46.13*** join/#brlcad ``Erik (~erik@pool-100-16-35-136.bltmmd.fios.verizon.net)
07:15.23*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
07:25.54*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
07:59.48*** join/#brlcad ``Erik (~erik@pool-100-16-20-94.bltmmd.fios.verizon.net)
08:13.58*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
08:55.40*** join/#brlcad KimK (~Kim__@2600:8803:7a81:7400:70ff:33e:29ad:41ff)
09:00.21*** join/#brlcad merzo (~merzo@user-94-45-58-139.skif.com.ua)
09:57.38*** join/#brlcad merzo (~merzo@94.45.58.139)
10:10.08*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
10:30.24*** join/#brlcad Caterpillar (~caterpill@unaffiliated/caterpillar)
11:13.28*** join/#brlcad vasc (~vasc@bl4-144-217.dsl.telepac.pt)
13:16.53*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
13:34.26*** join/#brlcad DaRock1 (~Thunderbi@mail.unitedinsong.com.au)
13:43.01*** join/#brlcad yorik (~yorik@2804:431:f721:ff6:290:f5ff:fedc:3bb2)
14:50.07*** join/#brlcad Stragus (~alexis@modemcable131.0-202-24.mc.videotron.ca)
14:52.31*** join/#brlcad teepee (~teepee@unaffiliated/teepee)
15:24.26Notify03BRL-CAD Wiki:Mariomeissner * 10158 /wiki/User:Mariomeissner/logs:
15:50.28*** join/#brlcad mdtwenty[m] (mdtwentyma@gateway/shell/matrix.org/x-zzjodrxmmmvwtbhh)
16:32.44vaschey mdtwenty[m]
16:33.25mdtwenty[m]hi!
16:33.57vascso let's look at the pbrt code
16:37.15vascso you say it doesn't work?
16:38.39mdtwenty[m]it worked for a small example ( 0 + 1) but when I run it with a bigger example it doens't make much sense
16:39.37vaschmm
16:39.42vascwhat's with the loop?
16:39.51vascthat loop in buildtree() shouldn't be there.
16:40.22vascits like, it's a binary tree.
16:40.39vascand buildtree() or a node is like add this node and do buildtree() on the descendants.
16:40.40vascno loops.
16:40.52mdtwenty[m]oh
16:41.35mdtwenty[m]yeah the loop isn't supposed to be there.. its only one instruction inside the pbrt example! I missed that
16:42.44vasci dunno why you need rt_flat_tree() either.
16:43.14vaschmm...
16:43.40mdtwenty[m]yes I was about to ask  you that
16:44.13vascits just like...
16:44.23vascyou start at the node and build_tree left and right.
16:44.47vascthe problem is how to know where to store nodes and how to set the rchild index properly.
16:45.38vascalso
16:45.49vasc+    if (start + 1 == end) {
16:45.49vasc+        rtp[pos].has_lchild = 0;
16:45.49vasc+        rtp[pos].tr_d.tr_l.st_bit = tp[pos].st_bit;
16:45.49vasc+    }
16:45.49vasc+
16:45.56vascit's support to have a return there.
16:46.03vascthis is the case where it's a leaf.
16:46.09vascits just like...
16:46.29vascif (leaf) { leafstuff; return; }
16:47.54vasc+            rtp[pos].tr_d.tr_b.uop = tp[pos].uop;
16:47.57vascthis is before the ifs.
16:48.13vascbecause it happens forall branches (non-leafs)
16:49.20vascs/support/supposed/g.
16:49.33Notify03BRL-CAD:starseeker * 70036 brlcad/trunk/src/other/libpng/CMakeLists.txt: Not using WDIR after all
16:50.00mdtwenty[m]hmm okay I will fix these issues with the function! thank you for the help
16:50.31vascwell
16:50.35vascno problem.
16:50.46vascjust remember. write the code based on the union tree.
16:50.51vascand you don't need that flat function.
16:51.06vascits just like...
16:51.17vascbuildtree() if leaf() {} else {}
16:51.40vascin the else { buildtree(); /*left*/ buildtree(); /*right*/ }
16:52.25vasci only gave that pbrt code so you could look at how it updates the nextfreenode and things like that.
16:52.43vascdid you get to remove those fields in the partitions?
16:53.06vasclike the prev index and the next valid partition index?
16:53.28vaschm
16:53.34mdtwenty[m]no, not yet
16:53.45vascok
16:53.46mdtwenty[m]also
16:54.03mdtwenty[m]yesterday i run the command that Sean suggested
16:54.19mdtwenty[m]"mdtwenty[m]: goliath is not really a good test case for patch 473 -- run this instead on before and after: "TIMEFRAME=60 DEVIATION=1 benchmark run""
16:54.53mdtwenty[m]i run benchmarks for the version in the trunk, the version in the trunk with the patch 473 applied and with the version on the opencl branch
16:55.42mdtwenty[m]but i am not sure about what number in the benchmark results I should use to compare things
16:55.55vascwhat is the output?
16:56.33mdtwenty[m]posted a file: run-12576-benchmark_trunk.log (19KB) <https://matrix.org/_matrix/media/v1/download/matrix.org/SrGHIpeiNVUrbivZMlBvpGCG>
16:56.50mdtwenty[m]this is the output for the version in the trunk
16:57.16mdtwenty[m]i suppose I should compare with the "total testing time elapsed"?
16:57.39mdtwenty[m]or with the VGR number?
16:57.42vascok, it loads a bunch of scenes and animates them.
16:59.15vascthe VGR is some benchmark stat.
17:00.10vascyou can either compare VGRs or the RTFMs.
17:00.17vascthe total time ellapsed is also a possibility yes.
17:00.24mdtwenty[m]posted a file: run-14785-benchmark_opencl.log (19KB) <https://matrix.org/_matrix/media/v1/download/matrix.org/LOESCkSFvUMKSNDYIPAIKzTZ>
17:00.25mdtwenty[m]posted a file: run-8110-benchmark_p473.log (19KB) <https://matrix.org/_matrix/media/v1/download/matrix.org/tKDSSIgJaaoOqVEgmxrddnCl>
17:00.40mdtwenty[m]those are the other results
17:02.10vascuh...
17:03.10vascall the VGRs are the same.
17:03.42vascah no
17:04.08vascits better with the patch? oh whatever.
17:04.22vascthat doesn't make a lot of sense.
17:04.34mdtwenty[m]the version currently in the trunk has a smaller total time elapsed, but also has smaller vgr
17:04.35vascit should be exactly the same not faster.
17:05.07vascwell. i don't know what to say about these numbers since the number of rays traced isn't the same in all benchmark runs.
17:07.14vascso you probably need to compare just the performance metric VGR number.
17:07.19vascthe higher the number the better.
17:07.36vascwhatever.
17:07.54vascyou ran the tests with the test scenes and it took the same time with the patch if i remember correctly.
17:08.21mdtwenty[m]yeah thats correct
17:09.04vascit's better that you pass those run results to Sean so he can look at them. perhaps he has more insights.
17:11.09mdtwenty[m]will do that!
17:11.57mdtwenty[m]also, can you take a look on the struct tree definition that i wrote? when I run sizeof I got 8 bytes instead of 4 ..
17:12.28vascof course you do. what i wrote was pseudo-code.
17:12.33vasc:-)
17:13.00vascyou declare an uint, and then a struct.
17:13.32vascanyway, that isn't too important right now since we'll have to replace it with shifts later.
17:14.32vascso
17:14.35vascyou just use uints
17:14.59mdtwenty[m]okay! it was my first time working with bit fields so I wasn't sure if I did things correctle there
17:15.26vascand then it's like init_leaf(st_bit)
17:15.34vascand init_node(uop, rchild)
17:15.43vascand
17:15.47vascinit_leaf():
17:16.25vasc<PROTECTED>
17:16.30vascinit_node():
17:16.51vascactually
17:16.54vasc<PROTECTED>
17:16.58vascin init_leaf
17:16.59vascand
17:17.27vascoh no
17:17.30vascit's just
17:17.33vasc<PROTECTED>
17:17.35vascthe other is
17:17.54vasc<PROTECTED>
17:17.56vasci think
17:18.12vascand then to check if it's a leaf:
17:18.26vascis_leaf() : return !(val & 1);
17:18.35vascthings like that.
17:18.47vascif you want i can write it.
17:19.07vascit's not that complicated though.
17:20.18vascthing is
17:20.27vascyou need to use the UOP macros i defined
17:20.40vascwhere UOPs are renumbered 0..7 or something
17:20.59vascthe regular UOP numbers in include/ won't fit in 3 bits.
17:21.23vasc2^8 = 8
17:21.31vascso only numbers 0..7 will fit.
17:21.39vasc2^3
17:21.40vasci mean
17:21.42vasc..
17:21.45mdtwenty[m]yeah
17:21.52mdtwenty[m]sent a long message: mdtwenty[m]_2017-08-03_17:21:52.txt <https://matrix.org/_matrix/media/v1/download/matrix.org/zPUWrgyNDQBBaCTStyAyYZRo>
17:22.03vascyes those.
17:22.21vascthe one for OP_SOLID and OP_NOP are unused.
17:22.27vascthose are for leafs.
17:22.39vasci assume there are no OP_NOP and that all leafs are OP_SOLID
17:23.20vascso better assert() that there are no OP_NOP
17:23.21vascs
17:24.15mdtwenty[m]what are exaclty OP_NOPs?
17:25.29vascNOP = no-op
17:25.45vascit does... nothing
17:26.05vaschttps://en.wikipedia.org/wiki/NOP
17:26.05i5o[ NOP - Wikipedia ]
17:26.32vasci assume it's used in the code for things like...
17:26.48vascwhen it optimizes the tree one of the branches is eliminated.
17:26.56vascand that branch is replaced with NOP
17:27.01vascand later the NOPs are removed.
17:27.20vascbut i'm not sure.
17:27.31mdtwenty[m]ah yes that makes sense
17:29.04vascso OP_NOP is an empty volume basically.
17:29.27vascand OP_SOLID has the volume of the primitive.
17:30.36*** join/#brlcad gabbar1947 (uid205515@gateway/web/irccloud.com/x-fybstnoxzvwtuibd)
17:31.35vascthe code for the kdtree in pbrt is more complicated with the splitpos because it needs to partition the tree at variable intervals according to space.
17:31.42vascour binary tree doesn't need that.
17:36.50mdtwenty[m]okay! I think i am understanding it better now
18:47.56vascmdtwenty[m], send me an e-mail with the code you have once you finish for the day, i'll then give you feedback at worst by tomorrow.
18:53.04mdtwenty[m]https://pastebin.com/5Fi6u6AW
18:53.05i5o[ [C] void  buildtree(struct otree *rtp, const union tree *tp,  size_t *len, size_t *n - Pastebin.com ]
18:53.09mdtwenty[m]does it look better?
18:54.02mdtwenty[m]i haven't tested it yet, so I will test it and make some changes if necessary and will send you the email so you can review it :)
18:59.40mdtwenty[m]thanks for the help today!
19:12.43Notify03BRL-CAD Wiki:Mariomeissner * 10159 /wiki/User:Mariomeissner/logs:
19:18.01vascclose
19:18.15vascyou don't need  has_lchild anymore because that's the first bit
19:18.21vascalso
19:18.33vaschttps://github.com/mmp/pbrt-v1/blob/master/core/kdtree.h
19:18.34i5o[ pbrt-v1/kdtree.h at master · mmp/pbrt-v1 · GitHub ]
19:19.07vascthe rest needs to be tested
19:19.20vascbut it's getting there
19:19.27vascsee you tomrrow then
19:36.04Notify03BRL-CAD Wiki:Mariomeissner * 10160 /wiki/User:Mariomeissner/logs:
20:02.26*** join/#brlcad merzo (~merzo@70-24-133-95.pool.ukrtel.net)
20:32.33Notify03BRL-CAD:brlcad * 70037 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: use the warning message type
21:57.40Notify03BRL-CAD:starseeker * 70038 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: actually this is a function now...
22:00.01Notify03BRL-CAD:starseeker * 70039 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: ws
22:04.03Notify03BRL-CAD:starseeker * 70040 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: We can't use FILTER yet, but add a reminder to do so once we can require a sufficiently new CMake.
22:04.33Notify03BRL-CAD:starseeker * 70041 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: spelling
22:07.34Notify03BRL-CAD:starseeker * 70042 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: more comment tweakage
22:22.21Notify03BRL-CAD:starseeker * 70043 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: more comment tweaks
22:58.00Notify03BRL-CAD:starseeker * 70044 brlcad/trunk/misc/CMake/BRLCAD_Util.cmake: macros to functions
23:07.36Notify03BRL-CAD:starseeker * 70045 (brlcad/trunk/CMakeLists.txt brlcad/trunk/misc/CMake/BRLCAD_Summary.cmake): Turn the whole BRL-CAD summary printout into a function.
23:31.14Notify03BRL-CAD:starseeker * 70046 (brlcad/trunk/misc/CMake/BRLCAD_Targets.cmake brlcad/trunk/misc/CMake/BRLCAD_Util.cmake): Turn NORMALIZE_FILE_LIST into a function.
23:34.16Notify03BRL-CAD:starseeker * 70047 brlcad/trunk/src/CMakeLists.txt: We have an option for this, actually - use it

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.