| 00:48.13 | starseeker | can try stepping it through a debugger... |
| 00:57.51 | starseeker | brlcad: it's using the operator in CompareByAngle at 1425 |
| 00:57.58 | starseeker | gdiam.cpp:1425 |
| 00:59.30 | starseeker | http://stackoverflow.com/questions/8532224/invalid-operator-while-sorting-stdlist |
| 00:59.48 | starseeker | has me wondering if that comparison isn't satisfying some property the compiler is trying to guarantee |
| 01:02.29 | starseeker | http://stackoverflow.com/questions/5786296/overloading-comparision-operator-in-c-results-in-invalid-operator |
| 01:10.29 | starseeker | trys to puzzle out if CompareByAngle satisfies strict weak ordering, and if so why it doesn't... |
| 01:11.03 | starseeker | or could just use qsort... |
| 01:22.57 | Notify | 03BRL-CAD:starseeker * 56610 brlcad/trunk/src/other/libgdiam/gdiam.cpp: C++ comparison operators are supposed to satisfy the strict weak ordering property, and MSVC seems to think this function doesn't. This might be one reason - return false if the lengths end up being equal. |
| 01:25.11 | starseeker | hmm... no, that shouldn't change anything logically... |
| 01:40.55 | Notify | 03BRL-CAD:starseeker * 56611 brlcad/trunk/src/other/libgdiam/gdiam.cpp: Doesn't logically change behavior. |
| 01:50.20 | brlcad | starseeker: that's not the right operator |
| 01:50.27 | brlcad | it needs to define the < operator |
| 01:50.42 | starseeker | well, according to gdb that's where it's landing... |
| 01:51.15 | starseeker | it looks like it's intended as a < operator, even if they didn't call it that... |
| 01:51.46 | brlcad | in theory, the functor operator should be sufficient |
| 01:51.55 | brlcad | but msvc is apparently just using < |
| 01:51.56 | starseeker | trying to figure out how a < b && b < a might be true from that logic... that's what the error seems to be suggesting is possible |
| 01:53.18 | starseeker | or rather, (!(_Left < _Right) && (_Right < _Left)) |
| 01:55.20 | starseeker | not sure what that return (sgn > 0) might be doing to mess with things... |
| 01:56.16 | brlcad | i don't see what code you're referring to |
| 01:57.23 | starseeker | line 1444 |
| 01:58.27 | starseeker | calling a function to determine if the area is positive, negative, or zero. If the points a, b, and base are colinear, that function is going to return zero no matter what order a and b are fed in |
| 01:59.26 | starseeker | if a and b are then the same distance from base, their lengths are the same and swapping them will get the same result of the length comparison |
| 02:00.31 | starseeker | brlcad: first code block in this post is what MSVC is tripping up on: http://stackoverflow.com/a/5787053/2037687 |
| 02:01.02 | starseeker | I was trying to figure out what about that function might not satisfy that property |
| 02:01.12 | brlcad | return sgn > 0? |
| 02:01.36 | starseeker | that's OK, but it's only triggered if sgn != 0 |
| 02:01.45 | starseeker | if sgn == 0, it proceeds with the length test |
| 02:01.59 | starseeker | 1448 |
| 02:02.48 | starseeker | and if dist(a,base) == dist(b,base) that comparison is going to give the same result no matter which order a and b are fed in (if I understand correctly how the logic is flowing) |
| 02:14.50 | brlcad | that compare functor doesn't make a whole lot of sense to me |
| 02:17.57 | Notify | 03BRL-CAD:starseeker * 56612 brlcad/trunk/src/other/libgdiam/gdiam.cpp: Take another stab at ensuring (!(a < b) && (b < a)) for the gdiam comparison operator...) |
| 02:19.13 | starseeker | will try that tomorrow - if that really is a runtime check, I'll pay more attention to what actual values are causing it to trip |
| 02:25.43 | Notify | 03BRL-CAD:brlcad * 56613 brlcad/trunk/src/libicv/filter.c: style spacing, function, and comment consistency cleanup |
| 02:26.05 | brlcad | zero_level: please see r56613 and check the other files for similar cleanup |
| 02:35.15 | starseeker | yow - axis aligned arbn doesn't do well at all performance wise with bb -o |
| 02:48.56 | Notify | 03BRL-CAD:brlcad * 56614 brlcad/trunk/src/libbn/plot3.c: apply kesha's sf patch #165 that performs a code reduction in libbn's plot inteface code. 70 line reduction overall. looks good. |
| 02:51.57 | starseeker | huh - if you have an unlimited budget... http://www.rotateright.com/ |
| 03:20.00 | Notify | 03BRL-CAD:brlcad * 56615 (brlcad/trunk/src/tclscripts/mged/bindings.tcl brlcad/trunk/src/tclscripts/mged/openw.tcl): accept sf patch #193 from Emory Huff which provides a new 'c' keybinding on the graphics window that brings the command window back. right now, assumes id_0 exists and is the command window we want to restore which means we'll get an error if id_0 was destroyed. |
| 03:21.01 | Notify | 03BRL-CAD:brlcad * 56616 brlcad/trunk/src/libbn/plot3.c: stray '}' in the patch...kesha |
| 03:38.03 | *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com) |
| 05:50.21 | *** join/#brlcad caen23_ (~caen23@92.81.176.7) |
| 07:14.59 | *** join/#brlcad LaMule (~lamule@82.236.20.42) |
| 07:15.02 | LaMule | hi |
| 07:50.03 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 07:58.25 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 08:14.02 | *** join/#brlcad kesha__ (~kesha@14.139.122.114) |
| 10:04.06 | *** join/#brlcad caen23 (~caen23@92.81.176.7) |
| 10:46.33 | *** join/#brlcad mpictor_ (~mpictor_@2600:1015:b112:a83e:0:3b:516:5701) |
| 11:58.50 | brlcad | hello LaMule |
| 12:35.24 | Notify | 03BRL-CAD:brlcad * 56617 brlcad/trunk/src/libbu/tests/bu_semaphore.c: getopt returns an int, otherwise this can be an infinite loop. |
| 12:52.18 | *** join/#brlcad Ch3ck_ (~Ch3ck@195.24.220.16) |
| 12:54.48 | Notify | 03BRL-CAD:ejno * 56618 (brlcad/branches/opencl/src/librt/CMakeLists.txt brlcad/branches/opencl/src/librt/primitives/ell/ell.c brlcad/branches/opencl/src/librt/primitives/sph/sph.c): move to sph.c; raytracer changes; cmake |
| 13:11.53 | Notify | 03BRL-CAD:carlmoore * 56619 (brlcad/trunk/src/libbn/plot3.c brlcad/trunk/src/libdm/dm-qt.cpp brlcad/trunk/src/mged/dm-qt.c): remove trailing blanks/tabs |
| 13:38.41 | *** join/#brlcad kesha__ (~kesha@14.139.122.114) |
| 13:46.28 | Notify | 03BRL-CAD:mohitdaga * 56620 (brlcad/trunk/src/libicv/color_space.c brlcad/trunk/src/libicv/decimate.c): Add proper spacing in declaration of the variables. |
| 13:49.05 | Notify | 03BRL-CAD:mohitdaga * 56621 brlcad/trunk/src/libicv/decimate.c: WS |
| 14:08.48 | Notify | 03BRL-CAD:ejno * 56622 (brlcad/branches/opencl/src/librt/CMakeLists.txt brlcad/branches/opencl/src/librt/primitives/sph/sph.c): configure with cmake and compile successfully |
| 14:22.35 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 5933 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* 5 August - 11 August */ |
| 14:33.24 | Ch3ck_ | ``Erik: starseeker: waiting on the reviews so as to get done with this commit access stuff |
| 14:41.31 | ``Erik | Ch3ck_: the issue in patch 222 with lines 141-143 needing to be collapsed is trivial, but the tabs vs spaces issue is one we need to know you can get your environment set up to deal with.. awaiting the patch to prove it :) |
| 14:42.46 | ``Erik | oh, I just noticed that the last } of check_results() is in the wrong place, as well |
| 14:45.34 | Ch3ck_ | ok |
| 14:45.44 | Ch3ck_ | i have set my editor tab to 8 characters |
| 14:46.34 | Ch3ck_ | give me all the changes for this file i am to make it all right |
| 14:46.45 | Ch3ck_ | so i could do the fixes on the other patches too. |
| 14:46.59 | ``Erik | I think I already have... if you want it looked at before making a patch, you can scp it to bz and let me know where to look |
| 14:47.09 | Ch3ck_ | ok |
| 14:48.50 | ``Erik | (indent.sh seems to work ok on bz, as well) |
| 14:49.18 | ``Erik | (bz being the old name for brlcad.org) |
| 14:50.01 | Ch3ck_ | ok |
| 14:50.11 | Ch3ck_ | i've scp ied the file already |
| 14:51.03 | Notify | 03BRL-CAD:ejno * 56623 brlcad/branches/opencl/src/librt/primitives/sph/sph.c: fix error in opencl code |
| 14:51.05 | ``Erik | still has 8 spaces instead of a tab |
| 14:51.37 | Ch3ck_ | where should i put the tab? |
| 14:51.42 | Ch3ck_ | at the first level? |
| 14:51.46 | Ch3ck_ | indentation? |
| 14:52.18 | ``Erik | yes, if it's indent 3 levels (12 spaces worth), the actual file contents for that line should start with "\t " |
| 14:53.47 | Ch3ck_ | i've tried the '\t' and its equal to 4 spaces |
| 14:54.09 | ``Erik | O.o editor misconfigured? |
| 14:54.18 | Ch3ck_ | which is the same thing.. |
| 14:54.40 | Ch3ck_ | I don't understand |
| 14:54.53 | Ch3ck_ | how many spaces are for the first level? |
| 14:54.57 | Ch3ck_ | indentation 4 right? |
| 14:55.21 | ``Erik | 4 spaces for the first level, 1 tab for the second level, 1 tab followed by 4 spaces for the third, ... |
| 14:55.37 | Ch3ck_ | ok |
| 14:56.27 | ``Erik | the hex would be 20202020 then 09 then 0920202020 then 0909 then 090920202020 |
| 14:57.46 | Ch3ck_ | fixed the file |
| 14:57.51 | Ch3ck_ | should i scp it? |
| 14:57.58 | ``Erik | sure |
| 14:58.00 | Ch3ck_ | uploading patch now.. |
| 14:58.29 | *** join/#brlcad n_reed_ (~molto_cre@66-118-151-70.static.sagonet.net) |
| 14:59.30 | Ch3ck_ | should see the patch now.. |
| 15:00.07 | Ch3ck_ | and .c file on bzflag |
| 15:01.43 | ``Erik | no, still not right, check results, for example... the line with 'for' is correct, the line wtih 'if' should use just a tab at the beginning (no spaces), and the line with return -1 should have a tab, then 4 spaces, then 'return' |
| 15:02.15 | Ch3ck_ | please correct the file |
| 15:02.21 | Ch3ck_ | manually and send to me.. |
| 15:02.28 | Ch3ck_ | so i could correct the others |
| 15:02.39 | Ch3ck_ | i can't actually visualise completely all what you're saying.. |
| 15:03.57 | ``Erik | look at the file src/libbn/poly.c, the function bn_poly_add shows up to 3 levels of indentation done correctly |
| 15:04.44 | ``Erik | observe where tabs are used instead of spaces |
| 15:07.18 | Ch3ck_ | what's the difference between using tabs and using space numbers equivalent to a tab? |
| 15:07.23 | ``Erik | this gedit plugin will help: https://help.gnome.org/users/gedit/stable/gedit-plugins-draw-spaces.html.en |
| 15:07.32 | Notify | 03BRL-CAD:mohitdaga * 56624 (brlcad/trunk/src/libicv/bw.c brlcad/trunk/src/libicv/decimate.c and 5 others): Cleaning Stylistic WhiteSpaces |
| 15:08.21 | ``Erik | different file contents, and the goal is to maintain a consistent style |
| 15:09.11 | ``Erik | (personally, I like to use all tabs and people can set their tabstop wherever they want, but BRL-CAD uses the sw=4 ts=8 approach) |
| 15:11.23 | Notify | 03BRL-CAD:mohitdaga * 56625 (brlcad/trunk/src/libicv/bw.c brlcad/trunk/src/libicv/decimate.c and 2 others): Trailing WS |
| 15:12.41 | Ch3ck_ | having this patches reviewed is sucking alot of my time |
| 15:13.11 | Ch3ck_ | i would have prefered working on my project and getting it reviewed following all these conventions |
| 15:13.14 | Ch3ck_ | and the the commit access. |
| 15:13.34 | ``Erik | ... it's sucking a lot of my time, too... I'd much rather you'd gotten it right a long time ago |
| 15:29.59 | zero_level | ``Erik : I am not sure but on my machine i have been having trouble with indent.sh |
| 15:30.22 | zero_level | It leaves 2 spaces instead of 4 spaces. |
| 15:33.00 | ``Erik | I'd guess it's a system emacs config or something... *shrug* I never use indent.sh, it never works right for me... vim with :set sw=4 ts=8 is what I use |
| 15:33.10 | ``Erik | I only use emacs for lisp code :D |
| 15:33.11 | Notify | 03BRL-CAD Wiki:KeshaSShah * 5934 /wiki/User:KeshaSShah/GSoC13/Reports: |
| 15:33.28 | Notify | 03BRL-CAD:phoenixyjll * 56626 (brlcad/trunk/include/brep.h brlcad/trunk/src/libbrep/intersect.cpp): Make sub_curve() a global export function, and mark all other functions that should be only used within intersect.cpp with HIDDEN. |
| 15:42.13 | Notify | 03BRL-CAD:phoenixyjll * 56627 brlcad/trunk/src/libbrep/boolean.cpp: Use ON_Curve rather than ON_NurbsCurve for better generality. And don't always assume that the curves are all polyline curves. |
| 15:44.34 | zero_level | ``Erik : Even i do the same setting in vim. But smtimes i see blunders, while opeing out the file. |
| 15:44.53 | zero_level | ``Erik : on a lighter note :What do shrug mean?: |
| 15:44.58 | zero_level | ;0 |
| 15:45.09 | Notify | 03BRL-CAD Wiki:Phoenix * 5935 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 8 */ |
| 15:46.02 | Notify | 03BRL-CAD Wiki:Phoenix * 5936 /wiki/User:Phoenix/GSoc2013/Reports: /* Week 8 */ |
| 15:48.29 | Ch3ck_ | ``Erik: updated patch.. |
| 16:08.32 | Notify | 03BRL-CAD:phoenixyjll * 56628 brlcad/trunk/src/libbrep/boolean.cpp: Rename shadowed variable. |
| 16:22.06 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 16:26.07 | Notify | 03BRL-CAD:carlmoore * 56629 brlcad/trunk/src/conv/g-dot.c: remove H, and simplify output of usage |
| 16:28.49 | Notify | 03BRL-CAD:phoenixyjll * 56630 brlcad/trunk/src/libbrep/boolean.cpp: Should not delete c3d as it's used in GetNurbForm() followed. |
| 16:47.41 | Notify | 03BRL-CAD Wiki:Harman052 * 5937 /wiki/User:Harman052/GSoc2013/Logs: |
| 17:00.36 | *** join/#brlcad vladbogo (~vladbogo@188.25.239.5) |
| 17:37.52 | Notify | 03BRL-CAD:n_reed * 56631 brlcad/trunk/include/brep.h: use javadoc style in comments |
| 17:44.15 | Notify | 03BRL-CAD:phoenixyjll * 56632 brlcad/trunk/src/libbrep/boolean.cpp: The type of the params should be double, not int. And fix a wrong variable used (brepA => brep). |
| 17:50.12 | Notify | 03BRL-CAD:starseeker * 56633 (brlcad/trunk/src/conv/step/CMakeLists.txt brlcad/trunk/src/conv/step/ON_Brep.cpp brlcad/trunk/src/conv/step/g-step.cpp): First successful generation of STEP formatted content containing data from an ON_Brep. |
| 18:02.27 | Notify | 03BRL-CAD:phoenixyjll * 56634 brlcad/trunk/src/libbrep/boolean.cpp: Use an enum to improve readablity of m_in_out. And append the faces to out. |
| 18:03.54 | brlcad | Ch3ck_: we all would have preferred you be working on your project and not having to discuss issues of whitespace and style |
| 18:04.12 | Ch3ck_ | yeah |
| 18:04.18 | Ch3ck_ | this thing has sucked my day.. |
| 18:04.28 | brlcad | normally, you would have been failed from participation for not having understood what you need to do by now |
| 18:04.41 | brlcad | this is not hard, it shouldn't have to be explained over and over |
| 18:04.57 | Ch3ck_ | i've done everything i know |
| 18:05.07 | Ch3ck_ | and still still get this white space errors |
| 18:05.11 | Ch3ck_ | used indent.sh and ws.sh |
| 18:05.19 | Ch3ck_ | still there are still errors so |
| 18:05.24 | Ch3ck_ | i don't get it. |
| 18:05.27 | brlcad | so you don't understand |
| 18:05.37 | brlcad | what do you not understand? the problem isn't the scripts |
| 18:05.47 | brlcad | you said yesterday that your patch was about 180 lines |
| 18:05.59 | brlcad | that should take less than two minutes to manually format perfectly |
| 18:06.24 | *** join/#brlcad Izak__ (~Izak@195.24.220.16) |
| 18:06.44 | Ch3ck_ | i have |
| 18:06.46 | Ch3ck_ | already |
| 18:06.54 | Ch3ck_ | still wondering why it has not been applied yet. |
| 18:07.01 | Ch3ck_ | to continue with the others. |
| 18:07.26 | brlcad | you mean the patch you just updated yet again today? |
| 18:07.34 | Ch3ck_ | yes |
| 18:07.37 | brlcad | wow |
| 18:07.43 | Ch3ck_ | patch 222 and 223 |
| 18:08.02 | brlcad | uhm, because we don't have all day to iterate with you as you figure out how to indent a file |
| 18:08.09 | brlcad | your impatients and frustration is rude |
| 18:08.44 | brlcad | it was your reponsibility to learn this, and instruction was given in multiple forms two months ago |
| 18:10.43 | brlcad | yes, someone didn't drop everything they were doing right now to review you'r Nth patch update, you'll have to work on something else, perhaps re-read HACKING one more time still to make sure you understand the format, look at other examples throughout the code, use the gedit patch that erik mentioned, ... |
| 18:12.58 | brlcad | this is frustrating and time consuming for both, please respect other people's time |
| 18:17.58 | Ch3ck_ | yeah.. |
| 18:18.04 | Ch3ck_ | will do.. |
| 18:24.09 | brlcad | Ch3ck_: I just reviewed the latest 222 patch and there's not a single tab in there |
| 18:24.20 | brlcad | rather, there's 1 tab, one you accidentally removed in an unrelated file |
| 18:25.08 | Ch3ck_ | well since my tabs were not working |
| 18:25.19 | Ch3ck_ | i used 4 character spacing to aline |
| 18:25.23 | Ch3ck_ | them.. |
| 18:25.23 | brlcad | your editor may be messing things up for you |
| 18:25.45 | brlcad | do you at least understand what it's supposed to be? |
| 18:26.29 | brlcad | there's a difference between hitting the tab key and inserting a tab character |
| 18:27.53 | vladbogo | hi all |
| 18:29.26 | vladbogo | brlcad: I have tried using blocking Qt events but for the moment (at least until keyboard is integrated) this does not work because everything blocks waiting for a qt events which does not occur |
| 18:29.51 | Ch3ck_ | brlcad: it think its about the same thing right? |
| 18:30.10 | brlcad | it's not at all the same thing |
| 18:30.24 | brlcad | that may be why this is frustrating you because you think they are the same |
| 18:31.08 | brlcad | we care about the type encoding, that there are actual tab characters so that the format is compressed (fewer bytes, smaller download, etc) |
| 18:32.52 | brlcad | Ch3ck_: see this example: http://paste.kde.org/p2fe26c7b/ |
| 18:32.58 | brlcad | .=space |
| 18:33.03 | brlcad | [ ]=tab |
| 18:33.18 | brlcad | that is basically what is expected byte-wise |
| 18:33.49 | brlcad | basically, all sequences of 8 ........ get turned into a tab |
| 18:34.28 | vladbogo | brlcad: also I have been thinking about how to integrate events between qt and tk so that there could be easy to add/delete any key bindings. |
| 18:34.46 | Ch3ck_ | now i see clearly |
| 18:34.56 | brlcad | since your patch is predominantly correct with spaces and is just missing tabs, running the sh/ws.sh script on your code will do the tab replacements (or you can do it manually) |
| 18:34.57 | Ch3ck_ | so is this now i'm supposed to be doing the indentation? |
| 18:35.07 | Ch3ck_ | ok |
| 18:35.16 | Ch3ck_ | then i'll do it. now and submit |
| 18:35.18 | Ch3ck_ | :) |
| 18:35.58 | Notify | 03BRL-CAD:n_reed * 56635 brlcad/trunk/src/librt/primitives/brep/brep.cpp: remove debug prints |
| 18:36.03 | vladbogo | my idea is to associate to every tcl binding a qt event and every time that qt event occurs to force the corresponding tcl one. How does this sound? |
| 18:36.46 | brlcad | sounds good to me vladbogo , whatever works ;) |
| 18:37.38 | vladbogo | ok then |
| 18:42.27 | Notify | 03BRL-CAD Wiki:Vladbogolin * 0 /wiki/File:Rotate1.png: |
| 18:42.45 | Notify | 03BRL-CAD Wiki:Vladbogolin * 0 /wiki/File:Rotate2.png: |
| 18:42.56 | Ch3ck_ | brlcad: just uploaded the patch. |
| 18:43.17 | Notify | 03BRL-CAD:ejno * 56636 brlcad/branches/opencl/src/librt/primitives/sph/sph.c: complete shot function |
| 18:43.34 | Notify | 03BRL-CAD Wiki:Vladbogolin * 5940 /wiki/User:Vladbogolin/GSoC2013/Logs: /* Week 8 */ |
| 18:47.51 | Notify | 03BRL-CAD:brlcad * 56637 brlcad/trunk/HACKING: add a visual example of the indentation style |
| 18:47.59 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 5941 /wiki/User:Izak/GSOC_2013_logs: /* August 5th to August 9th */ |
| 18:57.41 | brlcad | Ch3ck_: woo hoo, that looks right |
| 18:58.15 | brlcad | I just noticed that there's an entire second page of updates on that patch... I was looking at only your fourth attempt... my bad |
| 18:58.33 | brlcad | actually your 6th |
| 18:59.03 | brlcad | instead of your .. 8th, which did still have issues, but the 9th looks right :) |
| 18:59.18 | brlcad | Ch3ck_: have you read that patch file? |
| 18:59.56 | Ch3ck_ | which one the last one? |
| 19:00.00 | brlcad | yeah |
| 19:00.11 | brlcad | or pretty much all before too I think |
| 19:00.29 | Ch3ck_ | yeah |
| 19:00.34 | Ch3ck_ | is there a problem? |
| 19:00.39 | brlcad | what files does it say were edited? |
| 19:01.10 | Ch3ck_ | well it talks of a certain bn_tri_tri_isect.c |
| 19:01.20 | Ch3ck_ | which i've done nothing to |
| 19:01.35 | Ch3ck_ | but don't understand why it was edited in the first place. |
| 19:01.52 | brlcad | you edited it at some point, somehow |
| 19:02.08 | brlcad | the patch doesn't lie :) |
| 19:02.16 | Ch3ck_ | well yeah |
| 19:02.20 | brlcad | it obviously might not have been intentional |
| 19:02.30 | Ch3ck_ | but if i opened it was just to check indentation.. |
| 19:02.41 | Ch3ck_ | but can't remember editing anything there.. |
| 19:02.42 | brlcad | but you should run "svn status" and if a file is modified that should not, you should revert it: svn revert src/libbn/... |
| 19:03.03 | Ch3ck_ | ok |
| 19:04.01 | brlcad | I suspect you maybe just hit tab on that line and gedit did the conversion to spaces |
| 19:04.20 | brlcad | you wouldn't have seen a change since it just replaced a tab with 8 spaces |
| 19:04.31 | brlcad | (unless you install that plugin erik mentioned) |
| 19:05.10 | Ch3ck_ | uploaded new patch |
| 19:05.13 | Ch3ck_ | now.. |
| 19:11.00 | Ch3ck_ | i've not installed the plugin yet.. |
| 19:12.38 | Notify | 03BRL-CAD:brlcad * 56638 brlcad/trunk/src/libbn/tests/CMakeLists.txt: woot! looks like 10th time is the charm. accept sf patch 222 from Ch3ck which adds a unit test for bn_poly_scale(). |
| 19:12.46 | brlcad | it will help if you're going to keep using gedit |
| 19:13.49 | brlcad | though I strongly recommend taking the time to learn a real development editor like emacs, slickedit, eclipse, vim, etc |
| 19:17.20 | Notify | 03BRL-CAD:brlcad * 56639 brlcad/trunk/src/libbn/tests/bn_poly_scale.c: reduce scope of input/output to static as a stop-gap. desirable to minimize/eliminate globals. also fix unreachable code condition. |
| 19:20.50 | Ch3ck_ | will rework the other patch now.. |
| 19:20.58 | Notify | 03BRL-CAD:brlcad * 56640 brlcad/trunk/src/libbn/tests/bn_poly_scale.c: spoke a little too soon, few more style errors to fix |
| 19:21.14 | brlcad | Ch3ck_: check out some fixes in r56639 and r56640 |
| 19:21.25 | Ch3ck_ | ok |
| 19:23.15 | brlcad | Ch3ck_: if the remaining patches are flawless, you'll be set |
| 19:23.28 | Ch3ck_ | ok |
| 19:23.29 | brlcad | so you know, this isn't just about being picky about style |
| 19:23.40 | Ch3ck_ | i now understand |
| 19:23.53 | Ch3ck_ | what``Erik was trying to explain since morning |
| 19:23.59 | brlcad | it's obviously frustrating because it's not something one often has to think about when learning how to write code |
| 19:24.42 | brlcad | so you're not familiar with the terminology he used or the difference between tab characters and what happens in an editor when you press the [tab] key |
| 19:25.02 | brlcad | (which can insert tabs, spaces, both, or neither depending on the software) |
| 19:25.19 | brlcad | but this isn't just being pedantic/strict about style |
| 19:25.25 | brlcad | it's about maintainability |
| 19:26.05 | brlcad | consistency is fundamentally intertwined with maintainability, if the code is inconsistent, it DIES |
| 19:26.43 | brlcad | brl-cad has survived for nearly as long as I've been alive because of a never-ending rigorous attention to maintainability |
| 19:27.16 | brlcad | which in terms of indentation and whitespace, it's attention to details that most new developers are not familiar with |
| 19:27.43 | Notify | 03BRL-CAD:r_weiss * 56641 brlcad/trunk/src/conv/fast4-g.c: Fixed a bug in the fast4-g converter where memory was corrupted when the group_head list became larger than its allocated size. Changed the code to allow the group_head list to grow dynamically. |
| 19:30.16 | *** join/#brlcad caen23_ (~caen23@92.81.162.23) |
| 19:36.53 | Ch3ck_ | yeah i understand |
| 19:36.59 | Ch3ck_ | the next patch is ready now.. |
| 19:37.01 | Ch3ck_ | uploading.. |
| 19:38.13 | brlcad | checking 224 |
| 19:39.03 | brlcad | hm, not yet updated |
| 19:40.23 | Notify | 03BRL-CAD Wiki:Level zero * 5942 /wiki/User:Level_zero/GSOC13/logs: /* Week 7 */ |
| 19:40.51 | Notify | 03BRL-CAD Wiki:Level zero * 5943 /wiki/User:Level_zero/GSOC13/logs: Logs |
| 19:42.13 | Ch3ck_ | i've uploaded. |
| 19:43.06 | Ch3ck_ | you should see it now.. |
| 19:45.44 | Izak__ | ``Erik:Any feedback on reviews of ticket 228 |
| 19:51.48 | Ch3ck_ | brlcad: have you seen the patch? |
| 20:08.58 | ``Erik | Izak__: excellent, only one small issue |
| 20:09.08 | Notify | 03BRL-CAD:erikgreenwald * 56642 brlcad/trunk/src/librt/primitives/table.c: apply patch 228 from Izak |
| 20:09.19 | Izak__ | please what is that ? |
| 20:09.36 | Izak__ | ``Erik: What was the issue? |
| 20:09.56 | Notify | 03BRL-CAD:erikgreenwald * 56643 brlcad/trunk/src/librt/primitives/hrt/hrt.c: update copyright line, this did not exist in 1985 |
| 20:12.17 | ``Erik | *point* I fixed it, it's a rare, weird and irregular issue, so not worth a bounce |
| 20:12.24 | Izak__ | ``Erik: I am acquainted with Copyrights creation and Intellectual property law. the only thing I know is that I should reference my sources and not steal anything |
| 20:14.13 | ``Erik | Izak__: you are correct, this certain aspect is a US law thing and our specific interpretation... you're not expected to know this detail... if you use someone else code, check the license and attribute (ask if you're unsure)... you did great, this detail was out of your responsibility as far as I'm concerned |
| 20:14.39 | ``Erik | :) |
| 20:14.49 | Izak__ | :) |
| 20:15.53 | Izak__ | ``Erik: As I write hrt.c, how can I always show you the status of my code so you could correct ? |
| 20:16.37 | Izak__ | Do u prefer kde.paste website or should I upload it to bzflag account |
| 20:16.45 | Izak__ | ? |
| 20:17.34 | ``Erik | Izak__: either is fine... for what it's worth, you can create a public_html directory in your home directory and files you put in there will be available via the website |
| 20:19.19 | ``Erik | for example, my username is "erik" and I've created a file called public_html/dump.html at one point, and now you can point a web browser to http://brlcad.org/~erik/dump.html and see it |
| 20:24.05 | Izak__ | ``Erik: Thanks very much. |
| 20:26.27 | ``Erik | Izak__: the only patch I see left for you is the updated rb_delete one that brlcad indicated he'd like proof of improvement for, am I missing any? was the old code proven to have the bug discussed in the paper? |
| 20:28.00 | Izak__ | The old one was not proven to have that bug |
| 20:29.02 | Izak__ | ``Erik: ;) |
| 20:29.13 | ``Erik | Izak__: hm, I'm going to have to be very careful phrasing this... is it possible to prove that the old one does not have the bug? |
| 20:30.36 | Izak__ | ``Erik:Well let me check what the TODO file says first |
| 20:34.09 | ``Erik | I'm trying to assess if the modifications to rb_delete are worth incorporating... if there is real benefit, then it may be worth you reworking 191 into a good patch... if not, then let's just close it and move on |
| 20:38.53 | Notify | 03BRL-CAD:starseeker * 56644 brlcad/trunk/src/other/libgdiam/gdiam.hpp: Clear the warnings about floating point comparisons from gdiam.hpp |
| 20:39.57 | Izak__ | ``Erik: The TODO file says to check the libbu implementation of red-black trees in bu.h which in turn says that the second edition of the rb_delete algorithm in the Cormen book (which is the basis of the current BRL-CAD rb_delete.c) has been updated to delete the node actually requested |
| 20:41.52 | Notify | 03BRL-CAD:starseeker * 56645 brlcad/trunk/src/other/libgdiam/gdiam.cpp: Try a zero clamping to see if it helps with ordering sensitivity in the results. |
| 20:41.52 | brlcad | iff ours has the bug and yours does not, it's worth integrating |
| 20:42.37 | brlcad | so it's the first part of that todo .. check the libbu implementation |
| 20:43.10 | brlcad | can't make a decision until someone does that, and that really should take just a few minutes to research the bug and write a little test |
| 20:45.22 | Izak__ | brlcad: Are the rb_nodes rays ? |
| 20:52.23 | Izak__ | ``Erik: Are the requested nodes to be deleted by rb_delete.c rays ? |
| 20:52.39 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 5944 /wiki/User:Izak/GSOC_2013_logs: /* August 5th to August 9th */ |
| 20:53.44 | *** join/#brlcad kesha_ (~kesha@14.139.122.114) |
| 20:55.33 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 5945 /wiki/User:Izak/GSOC_2013_logs: /* August 5th to August 9th */ |
| 20:56.02 | *** join/#brlcad avneet (~avneet@202.164.53.122) |
| 20:59.50 | *** join/#brlcad caen23 (~caen23@92.81.162.23) |
| 21:10.32 | Izak__ | super and resting |
| 21:16.14 | Notify | 03BRL-CAD:starseeker * 56646 brlcad/trunk/src/other/libgdiam/gdiam.cpp: Try a few robustness tweaks, but the C++ < sort still isn't happy. |
| 21:20.34 | starseeker | growl... |
| 21:24.40 | starseeker | did somebody not svn add files for the hrt primitive? |
| 21:25.09 | starseeker | build is busted |
| 21:26.44 | Notify | 03BRL-CAD:starseeker * 56647 brlcad/trunk/src/librt/primitives/table.c: Turn off the hrt definition in table.c - causing undefined reference errors? |
| 22:04.35 | Notify | 03BRL-CAD:carlmoore * 56648 brlcad/trunk/src/conv/dxf/g-dxf.c: implement h?, and also put P into the usage statement |
| 22:13.18 | *** join/#brlcad avneet (~avneet@202.164.53.122) |
| 23:38.12 | ``Erik | erm, ehhh, whu? your stuff must be busted or somethin', starseeker O.o |
| 23:46.27 | ``Erik | whupz |
| 23:46.42 | Notify | 03BRL-CAD:erikgreenwald * 56649 brlcad/trunk/src/librt/CMakeLists.txt: add hrt |
| 23:47.19 | Notify | 03BRL-CAD:erikgreenwald * 56650 brlcad/trunk/src/librt/primitives/table.c: revert 56647 |
| 23:48.40 | ``Erik | did the commit in librt/primitives instead of librt |