| 00:21.31 | zero_level | alright! nevermind :-) |
| 00:21.55 | zero_level | didnt notice "nevermind" :) |
| 00:34.27 | Notify | 03BRL-CAD:mohitdaga * 56247 brlcad/trunk/src/libicv/fileformat.c: Added png saving function supporting new icv container |
| 01:02.03 | zero_level | hi brlcad, ``Erik do we have to take care of certain things while adding a file to the repository ? |
| 01:02.52 | zero_level | I do a simple svn add <path of file to be added> |
| 01:03.17 | zero_level | while committing it showed this brlcad/trunk/src/libicv/color_space.c : svn:mime-type is not set |
| 01:05.12 | zero_level | alright got this http://brlcad.org/wiki/Mime-types :-) |
| 01:06.15 | brlcad | starseeker: -Ffile.pix should actually work, so if that crashes, that's a bug worth fixing |
| 01:06.31 | brlcad | and probably related to icv work ( zero_level ) |
| 01:07.05 | Notify | 03BRL-CAD Wiki:Level zero * 5847 /wiki/Mime-types: /* Correcting the file name which is added*/ |
| 01:09.12 | Notify | 03BRL-CAD:mohitdaga * 56248 (brlcad/trunk/include/icv.h brlcad/trunk/src/libicv/CMakeLists.txt): Added file libicv/color_space.c . This will contain all the color_space conversion api functions (currently rgb-gray and gray-rgb, later others like hsv-rgb, cmyka-rgb etc..). Added gray2rgb api function. This does a simple gray pixel copying at three places(r,g,b). This api function does an inplace color_space change. |
| 01:10.11 | zero_level | brlcad : my next task is set to find that bug. Just commiting one more api function |
| 01:10.47 | brlcad | zero_level: great |
| 01:11.05 | brlcad | notice that there are many rt* tools and they should all behave nearly identically |
| 01:11.45 | brlcad | you should sometimes test one of the other tools (like rt or rthide or rtedge) |
| 01:11.47 | zero_level | brlcad : can u just brief me about architeture of rt |
| 01:12.18 | zero_level | this seems to be a complex piece of code involving a lot of files. |
| 01:12.33 | brlcad | our docs on the website do a decent job with the intro |
| 01:12.42 | brlcad | fewer files than you'd think |
| 01:12.47 | zero_level | about the code ? or usage ? |
| 01:12.55 | brlcad | each of those rt* programs is described in basically one view*.c file |
| 01:13.21 | zero_level | ok. |
| 01:13.36 | zero_level | and does each one involve main.c do.c ? |
| 01:14.04 | brlcad | the rt apps are built on a simple front-end/back-end interface |
| 01:14.27 | brlcad | main do opt and maybe one or two others form a front end common to all of them |
| 01:14.32 | zero_level | so do.c is backend worker ? |
| 01:14.45 | brlcad | the view*.c file corresponds to the backend view |
| 01:15.06 | brlcad | you can think of it that way, sure |
| 01:15.44 | brlcad | technically still the common front-end code (if all the rt's call it, it's front-end) |
| 01:16.21 | brlcad | http://brlcad.org/w/images/3/3d/Application_Development.pdf explains in a little more technical detail |
| 01:16.52 | brlcad | it's just a little out of date in terms of header names and a few other details, but it's still relevant and useful |
| 01:17.08 | brlcad | RTUIF is what I described |
| 01:17.45 | zero_level | alright will see these. |
| 01:17.46 | brlcad | it's a lot of material, that's about an hour-long technical presentation |
| 01:18.15 | brlcad | it covers more than the rtuif, but it may still be useful for you to know |
| 01:18.28 | zero_level | one is your gut feeling regarding -Ffile.pix |
| 01:18.44 | brlcad | gut feeling is it's a bug ;) |
| 01:18.45 | zero_level | some points u could give to me. to start with |
| 01:18.57 | zero_level | sure that is ;) |
| 01:19.08 | zero_level | and it crept in today !! |
| 01:19.26 | brlcad | sure |
| 01:19.29 | brlcad | start with fbhelp |
| 01:19.53 | brlcad | run it without any options first, make sure filename is in the list of supported interface types |
| 01:20.03 | brlcad | then run it specifying that interface: fbhelp -Ffile.pix |
| 01:20.10 | brlcad | if it crashes, time to open up a debugger |
| 01:20.26 | brlcad | if it doesn't crash, the bug is probably isolated in src/rt |
| 01:20.35 | brlcad | and you'd still open up a debugger |
| 01:21.27 | brlcad | don't be afraid to use a debugger, basic usage is very simple and folks here can help you get started (along with a thousand intro tutorials around the web) |
| 01:22.30 | zero_level | and brlcad:Although that commit was large in size. Can u see the rt part and see if that is fine ? |
| 01:23.00 | zero_level | I had not discussed much abt that here . |
| 01:26.05 | Notify | 03BRL-CAD:mohitdaga * 56249 brlcad/trunk/src/libicv/fileformat.c: Improves pix_save function. Now this can save images of type ICV_COLOR_SPACE_GRAY. This uses icv_gray2rgb(..). |
| 01:37.13 | zero_level | brlcad : Is there a way I cange log message of a commit. I saw this http://stackoverflow.com/questions/304383/how-do-i-edit-a-log-message-that-i-already-committed-in-subversion . |
| 01:37.37 | zero_level | do commiters have such rights in brl-cad ? |
| 01:41.08 | Notify | 03BRL-CAD:mohitdaga * 56250 (brlcad/trunk/include/icv.h brlcad/trunk/src/libicv/color_space.c): Remove trailing ws |
| 01:54.57 | zero_level | I asked that for r56247, And made an even more henious error at 56250. |
| 02:09.02 | zero_level | wrote on the, list |
| 02:09.42 | zero_level | brlcad : Do u suggest making another commit to clarify the log message ? |
| 02:30.29 | brlcad | zero_level: you cannot change the commit message |
| 02:31.11 | brlcad | double and triple check what you are about to commit before you commit it, check it with "svn stat" and "svn diff | less" and yes, you are expected to read every line in that diff to make sure it's what you intend to submit |
| 02:33.16 | brlcad | zero_level: if it's something that really should be clarified or corrected, revert the commit (svn merge -c-56247 .), and recommit it again later/corrected |
| 02:33.39 | brlcad | but that should be used sparingly and usually only when the actual code is broken, not just a bad commit message |
| 02:34.16 | brlcad | your clarification to the mailng list, in that instance, is just fine |
| 03:46.52 | Notify | 03BRL-CAD:brlcad * 56251 brlcad/trunk/src/adrt/librender/cut.c: ws |
| 03:51.04 | *** join/#brlcad caen23 (~caen23@92.81.176.19) |
| 04:05.12 | Notify | 03BRL-CAD:brlcad * 56252 (brlcad/trunk/src/adrt/librender/camera.c brlcad/trunk/src/adrt/librender/camera.h and 25 others): ws cleanup for the rest of this directory |
| 05:17.59 | zero_level | ok brlcad. went for a little nap. |
| 05:31.49 | zero_level | Also about r56247 I wanted to add |
| 05:33.16 | zero_level | This implementation of png format is just done for 8bits channel. Later this will be edited to accomodate higher resolution of images. |
| 05:33.55 | zero_level | There is a special time alloted to Image formats in my timeline. |
| 08:14.44 | Notify | 03BRL-CAD:mohitdaga * 56253 brlcad/trunk/src/libicv/fileformat.c: Adding additional feature in bw_save. This now has ability to handle and save rgb(3 channel pix) images in bw format. This usage rgb2gray function. |
| 08:21.04 | *** join/#brlcad kesha (~kesha@49.249.1.68) |
| 09:35.01 | *** join/#brlcad kesha__ (~kesha@49.202.239.74) |
| 09:57.28 | *** join/#brlcad kesha__ (~kesha@49.202.239.74) |
| 10:21.03 | Notify | 03BRL-CAD:mohitdaga * 56254 brlcad/trunk/src/libicv/fileformat.c: Make data2uchar a hidden function. Also added comments for this function. |
| 10:24.11 | zero_level | hi ``Erik, brlcad: I use data2uchar and uchar2double functions in fileformat.c for converting from double to unsiged char and viceversa. |
| 10:25.57 | zero_level | Currently I have kept it hidden in fileformat.c . Later I plan to keep them in icv_bw.c while splitting files for different formats. |
| 10:27.31 | zero_level | and using extern double* uchar2double(..) and extern unsigned char* data2uchar(..) in files like icv_pix.c, icv_ppm.c |
| 11:03.04 | *** join/#brlcad kesha (~kesha@49.202.239.74) |
| 11:39.26 | *** join/#brlcad Ch3ck (~Ch3ck@195.24.220.16) |
| 11:40.42 | *** join/#brlcad Izak_ (~Izak@195.24.220.16) |
| 11:42.33 | ``Erik | zero_level: when we get to that point, we'll discuss it... it'd be better to define it in a private header (perhaps as a macro) than to do an extern in the file... if it's a globally useful thing, we might even move it to libbu |
| 13:25.10 | Notify | 03BRL-CAD Wiki:NyahCh3ck20 * 5848 /wiki/User:NyahCh3ck20/GSoc2013/Coding_Repor: /* 22 July - 28 July */ |
| 14:45.00 | Notify | 03BRL-CAD Wiki:Level zero * 5849 /wiki/User:Level_zero/GSOC13/logs: /* Week 6 */ |
| 15:04.07 | ``Erik | http://www.gnuplotting.org/ |
| 15:06.12 | Notify | 03BRL-CAD Wiki:195.24.220.16 * 5850 /wiki/User:Izak/GSOC_2013_logs: /* From July 22th to July 27th */ |
| 15:07.25 | Notify | 03BRL-CAD Wiki:IIIzzzaaakkk * 5851 /wiki/User:Izak/GSOC_2013_logs: /* From July 22th to July 27th */ |
| 15:26.29 | ``Erik | ios 7 is definitely going to make me rework my app :/ |
| 15:59.37 | *** join/#brlcad kesha (~kesha@49.249.1.222) |
| 16:09.29 | brlcad | kesha: didn't we just have a long discussion just yesterday about NULL vs nul and I sent you a link to read? |
| 16:15.33 | brlcad | "strncpy() NULL terminated" |
| 16:19.55 | *** join/#brlcad kesha (~kesha@49.249.18.95) |
| 16:38.21 | brlcad | kesha: didn't we just have a long discussion just yesterday about NULL vs nul and I sent you a link to read? |
| 16:49.23 | Notify | 03BRL-CAD:brlcad * 56255 brlcad/trunk/src/adrt/librender/render_util.c: since there was no mention as to why they were commented out in r29559 (erik), re-enable calculations in the render_util_spall_vec() function. do try to prevent a division by zero. |
| 17:00.30 | Notify | 03BRL-CAD:brlcad * 56256 brlcad/trunk/src/adrt/librender/render_util.c: revert 56255, didn't compile-test properly, some work is needed |
| 17:05.24 | Notify | 03BRL-CAD:brlcad * 56257 (brlcad/trunk/src/adrt/librender/cut.c brlcad/trunk/src/adrt/slave/slave.c): eliminate dead code, #if 0'd |
| 17:12.45 | Notify | 03BRL-CAD:brlcad * 56258 brlcad/trunk/src/libbu/tests/bu_progname.c: whatever the last set progname is should be the one returned by getprogname, so the tests make sense (and pass here) |
| 17:30.45 | zero_level | ``Erik : I am not sure about the aptness of macro. Because this part of code requires memory allocation. It is not straight forward due to gamma correction. |
| 17:43.38 | kesha | brlcad: ya, that commit was made earlier, before our discussion. I will change it. |
| 17:45.49 | *** join/#brlcad Ch3ck (~Ch3ck@195.24.220.16) |
| 17:53.18 | Notify | 03BRL-CAD:mohitdaga * 56259 (brlcad/trunk/src/libged/screengrab.c brlcad/trunk/src/rt/view.c and 2 others): Adding a TODO section for writeline function. Currently In writeline function unsigned char data is added. Part of rt and libged has to modified to write double data. Although writeline is implemented in such a way that it can accomodate both double and unsigned char data. But adding double data from rt will |
| 17:53.20 | Notify | help in better resolution of output images. |
| 17:53.46 | Notify | 03BRL-CAD:brlcad * 56260 (brlcad/trunk/src/libbu/heap.c brlcad/trunk/src/libbu/tests/CMakeLists.txt): move the heap main() test harness into a preliminary unit test. doesn't do any validation other than running 50M allocations with some random freeing. |
| 17:54.21 | brlcad | kesha: AH .. okay, that's reassuring |
| 17:54.22 | Notify | 03BRL-CAD:brlcad * 56261 brlcad/trunk/src/libgcv/CMakeLists.txt: don't put test programs into the bin directory, mark them LOCAL (perhaps NO_INSTALL should imply that) |
| 17:54.30 | brlcad | I thought you JUST made that commit, not updated it |
| 17:55.25 | zero_level | Hi brlcad, ``Erik check r56259. Although another such function writepixel uses double data from ap->a_color in view.c, viewedge.c viewexray.c |
| 17:55.57 | zero_level | correction viewexray.c/viewxray.c |
| 17:59.09 | Notify | 03BRL-CAD:brlcad * 56262 brlcad/trunk/include/ged.h: provide tracker's declaration |
| 18:08.41 | Notify | 03BRL-CAD:brlcad * 56263 brlcad/trunk/src/libbn/plane.c: convert and (very) temporarily enable bn_isect_ray_tri() |
| 18:11.13 | Notify | 03BRL-CAD:brlcad * 56264 brlcad/trunk/src/libbn/plane.c: and now eliminate bn_isect_ray_tri() since comments from jra in r17228 indicate that it doesn't work right, apparently replaced with bn_does_ray_isect_tri() |
| 18:15.07 | Notify | 03BRL-CAD Wiki:Harman052 * 5852 /wiki/User:Harman052/GSoc2013/Logs: |
| 18:29.53 | *** join/#brlcad vladbogo (~vladbogo@188.25.238.209) |
| 18:30.50 | Notify | 03BRL-CAD:mohitdaga * 56265 brlcad/trunk/src/libicv/fileformat.c: Added ppm_save function. Alike pix,bw this function also uses data2uchar function. |
| 18:47.29 | *** join/#brlcad caen23 (~caen23@92.81.173.2) |
| 19:02.28 | Notify | 03BRL-CAD:vladbogo * 56266 brlcad/trunk/src/libdm/dm-qt.cpp: Resize the Qt window when the Tk one changes size. |
| 19:05.30 | Notify | 03BRL-CAD:mohitdaga * 56267 brlcad/trunk/src/libicv/fileformat.c: Change data type of size and perform related sanctity measures in read/write function. |
| 19:08.12 | Notify | 03BRL-CAD:mohitdaga * 56268 brlcad/trunk/src/libicv/fileformat.c: Correct log message and remove debug message. |
| 19:10.23 | zero_level | brlcad, Erik : at r56268. All the functions of previous implementation are brought in with the new structure definition. |
| 19:10.30 | zero_level | Plus from here. |
| 19:11.27 | zero_level | +Bw_save can handle rgb images, similarly ppm_save and pix_save can handle gray images. |
| 19:13.46 | zero_level | +Gamma Correction is added to prevent bad color aliasing. |
| 19:14.18 | zero_level | Also I am looking at the bug which have crept in. |
| 20:34.25 | Notify | 03BRL-CAD:mohitdaga * 56269 brlcad/trunk/src/libicv/fileformat.c: trailing ws |
| 21:41.11 | Notify | 03BRL-CAD:mohitdaga * 56270 (brlcad/trunk/src/libged/screengrab.c brlcad/trunk/src/rt/do.c): Corrected bug in rtedge. As per the new ICV api, icv_image_save doesnt free image. Thus icv_image_save and icv_image_free have to be called atomically if the image has to be freeed. |
| 21:46.39 | Notify | 03BRL-CAD:tbrowder2 * 56271 brlcad/trunk/TODO: fix typo |
| 21:59.37 | Notify | 03BRL-CAD:tbrowder2 * 56272 brlcad/trunk/TODO: ws |
| 22:01.26 | Notify | 03BRL-CAD:tbrowder2 * 56273 (brlcad/trunk/misc/perl/CMakeLists.txt brlcad/trunk/misc/perl/rt.i): commenting out trials that don't work |
| 22:24.09 | zero_level | hi brlcad, ``Erik, Even after r56270, still some bugs are left related to image saving in rtedge. |
| 22:24.19 | zero_level | I am looking on to them |