| 05:12.46 | *** join/#brlcad elf` (~elf11_@p5.eregie.pub.ro) |
| 05:14.11 | brlcad | is having trouble syncing with jarray52 |
| 05:14.37 | brlcad | anyone else caring to respond: the "tra" command does this, preceeded by either sed or oed to select the object for editing |
| 06:07.13 | *** join/#brlcad elf` (~elf11_@p5.eregie.pub.ro) |
| 06:33.12 | *** join/#brlcad elf11_ (~elf11_@p5.eregie.pub.ro) |
| 11:45.50 | notify | 03BRL-CAD:starseeker * 53716 brlcad/trunk/src/librt/test_botpatches.cpp: Add TODO note. |
| 11:45.55 | notify | 03BRL-CAD:carlmoore * 53717 brlcad/trunk/src/libbn/tabdata.c: fix spellings |
| 11:45.59 | notify | 03BRL-CAD:carlmoore * 53718 brlcad/trunk/src/libbn/msr.c: fix spellings (notice several occurrences of 'gauss') |
| 11:46.03 | notify | 03BRL-CAD:carlmoore * 53719 (brlcad/trunk/src/libbn/symbol.c brlcad/trunk/src/libbn/vectfont.c): fix spelling |
| 11:46.06 | notify | 03BRL-CAD:carlmoore * 53720 brlcad/trunk/src/libbn/wavelet.c: fix spelling |
| 11:46.10 | notify | 03BRL-CAD:carlmoore * 53721 brlcad/trunk/src/libbn/tri_tri.c: fix spelling, and I had to find Franklin Antonio in a web search |
| 11:46.14 | notify | 03BRL-CAD:carlmoore * 53722 brlcad/trunk/src/libbn/noise.c: fix spelling |
| 11:46.18 | notify | 03BRL-CAD:carlmoore * 53723 brlcad/trunk/src/libbn/mat.c: fix spelling and add 2 missing periods |
| 11:46.23 | notify | 03BRL-CAD:carlmoore * 53724 (brlcad/trunk/src/libbn/bntester.c brlcad/trunk/src/libbn/rand.c): fix spellings (2 files being submitted here) |
| 11:46.27 | notify | 03BRL-CAD:carlmoore * 53725 (brlcad/trunk/src/libbu/uce-dirent.h brlcad/trunk/src/libdm/dm-plot.c): fix spellings |
| 11:46.31 | notify | 03BRL-CAD:brlcad * 53726 brlcad/trunk/src/proc-db/brepintersect.cpp: assert.h is a system header, wrap in <> |
| 11:46.35 | notify | 03BRL-CAD:bob1961 * 53727 (brlcad/trunk/src/mged/chgview.c brlcad/trunk/src/mged/sedit.h): Reset the keypoint if using the mouse to drag/translate a primitive. This fixes the teleportation problem seen when translating a primitive after having set the keypoint. |
| 11:46.39 | notify | 03BRL-CAD:carlmoore * 53728 (brlcad/trunk/src/libbn/multipoly.c brlcad/trunk/src/libged/facetize.c and 2 others): fix spellings, including that of multipoly |
| 11:46.44 | notify | 03BRL-CAD:carlmoore * 53729 (brlcad/trunk/src/libged/human.c brlcad/trunk/src/libicv/rot.c): fix spellings ('anthro', right?) |
| 11:46.48 | notify | 03BRL-CAD:brlcad * 53730 brlcad/trunk/src/liboptical/sh_prj.c: init to char 0 instead of value 0 since that's what it checks |
| 11:46.52 | notify | 03BRL-CAD:carlmoore * 53731 (brlcad/trunk/src/liboptical/sh_light.c brlcad/trunk/src/liboptical/sh_prj.c): fix spellings |
| 11:46.56 | notify | 03BRL-CAD:carlmoore * 53732 (brlcad/trunk/src/libpc/pc_main.c brlcad/trunk/src/librt/prep.c): fix spellings |
| 11:46.59 | notify | 03BRL-CAD:bob1961 * 53733 brlcad/trunk/src/librt/primitives/bot/bot.c: Minor mod. |
| 11:47.03 | notify | 03BRL-CAD:n_reed * 53734 brlcad/trunk/src/librt/primitives/pipe/pipe.c: turn one function that does two things into two functions that do one thing |
| 11:47.08 | notify | 03BRL-CAD:carlmoore * 53735 brlcad/trunk/src/librt/primitives/bot/tie_kdtree.c: fix spellings and punctuation |
| 11:53.06 | *** join/#brlcad Notify (~brlbot@66-118-151-70.static.sagonet.net) |
| 12:45.10 | *** join/#brlcad Notify (~notify@66-118-151-70.static.sagonet.net) |
| 12:50.38 | *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com) |
| 12:55.10 | Notify | 03BRL-CAD:carlmoore * 53737 (brlcad/trunk/src/librt/primitives/bspline/bspline.cpp brlcad/trunk/src/librt/primitives/bspline/bspline_mirror.c): fix spellings of 'allocate' |
| 12:55.13 | Notify | 03BRL-CAD:carlmoore * 53738 (brlcad/trunk/src/librt/primitives/extrude/extrude.c brlcad/trunk/src/librt/primitives/half/half.c brlcad/trunk/src/librt/primitives/nmg/nmg_fuse.c): fix spellings |
| 12:55.16 | Notify | 03BRL-CAD:carlmoore * 53739 (brlcad/trunk/src/librt/primitives/nmg/nmg.c brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c): fix spellings |
| 12:55.19 | Notify | 03BRL-CAD:carlmoore * 53740 brlcad/trunk/src/librt/primitives/hyp/hyp_brep.cpp: fix spelling and add a period |
| 12:55.22 | Notify | 03BRL-CAD:carlmoore * 53741 brlcad/trunk/src/librt/primitives/nmg/nmg_pr.c: use capital E |
| 12:55.25 | Notify | 03BRL-CAD:brlcad * 53742 (brlcad/trunk/src/conv/g-vrml.c brlcad/trunk/src/conv/g-x3d.c and 24 others): found the cause of solids regression failure. more structparse tables existed in need of using %g for doubles. |
| 12:55.28 | Notify | 03BRL-CAD:starseeker * 53743 brlcad/trunk/CMakeLists.txt: Add note to investigate whether if(TARGET ) test will replace pulling and checking for target properites manually... could simplify the logic for this quite a bit. |
| 12:55.31 | Notify | 03BRL-CAD:starseeker * 53744 brlcad/trunk/misc/CMake/ThirdParty.cmake: downcase add_subdirectory. |
| 13:03.03 | *** join/#brlcad d_rossberg (~rossberg@BZ.BZFLAG.BZ) |
| 15:59.49 | brlcad | ``Erik: replayed friday commits? |
| 16:03.37 | ``Erik | the shouter thread wedged itself on friday, shouldn't have been any that replayed... |
| 16:11.47 | brlcad | ah, okay |
| 16:14.53 | Notify | 03BRL-CAD:starseeker * 53743 brlcad/trunk/CMakeLists.txt: Add note to investigate whether if(TARGET ) test will replace pulling and checking for target properites manually... could simplify the logic for this quite a bit. |
| 16:15.04 | Notify | 03BRL-CAD:starseeker * 53744 brlcad/trunk/misc/CMake/ThirdParty.cmake: downcase add_subdirectory. |
| 16:16.52 | Notify | 03BRL-CAD:erikgreenwald * 53745 brlcad/trunk/src/libbn/ulp.c: double/float min funcs are in bn, not bu |
| 16:16.55 | Notify | 03BRL-CAD:erikgreenwald * 53746 brlcad/trunk/src/libbn/ulp.c: isfinite() is a c99 macro, so use the old isinf() |
| 16:45.06 | Notify | 03BRL-CAD:brlcad * 53747 brlcad/trunk/src/librt/bool.c: remove a hard-coded 0.001 constant that has been in here since 1989 (mike, r3900). the intent seems to be to discard partitions that are behind the ray start point implying the constant was attempting to capture near-zero or negative partitions. this should be something below SMALL_FASTF but the 'large' value implies it may be accommodating compound math model-space values so go wi |
| 17:13.52 | brlcad | ``Erik: how about truncating on a word boundary? and something to indicate it was truncated... |
| 17:21.54 | *** join/#brlcad elf` (~elf11_@p5.eregie.pub.ro) |
| 18:17.49 | *** join/#brlcad Notify (~notify@66-118-151-70.static.sagonet.net) |
| 18:42.56 | *** join/#brlcad cristina (~quassel@188.24.12.112) |
| 18:46.40 | ``Erik | !notify todo 12:13 <@brlcad> ``Erik: how about truncating on a word boundary? and something to indicate it was truncated... |
| 18:46.40 | Notify | OK |
| 19:00.03 | Notify | 03BRL-CAD:carlmoore * 53748 (brlcad/trunk/src/librt/primitives/tgc/tgc.c brlcad/trunk/src/libwdb/wdb.c and 2 others): fix spellings |
| 19:00.06 | Notify | 03BRL-CAD:r_weiss * 53749 (brlcad/trunk/include/raytrace.h brlcad/trunk/src/conv/euclid/euclid-g.c and 4 others): Renamed function "nmg_model_break_e_on_v" to "nmg_break_e_on_v" and changed the function to process any NMG object, not just an model structure. Changed all references to this function. Updated files "raytrace.h", "bot_fuse.c", "euclid-g.c", "jack-g.c", "nmg_fuse.c" and "nmg_bool.c". |
| 19:00.09 | Notify | 03BRL-CAD:r_weiss * 53750 brlcad/trunk/src/librt/primitives/nmg/nmg_bool.c: Fixed a bug in function "nmg_bool" in file "nmg_bool.c". Changed when classlist is allocated to after all changes to the model are complete. The reason is these changes increase the number of objects in the model and the allocated size of classlist needs to be large enough for all the objects. Also changed when function "nmg_classify_shared_edges_verts" is called |
| 19:00.12 | Notify | 03BRL-CAD:brlcad * 53751 brlcad/trunk/src/librt/bool.c: fix up the comment, was called rt_fdiff(). expand a note that sensitivity testing is needed but using distance tolerance is probably warranted here. |
| 19:09.16 | Notify | 03BRL-CAD:erikgreenwald * 53752 (brlcad/trunk/doc/deprecation.txt brlcad/trunk/include/raytrace.h brlcad/trunk/src/librt/primitives/nmg/nmg_fuse.c): Re-add nmg_model_break_e_on_v as wrapper for nmg_break_e_on_v and mark deprecated. |
| 19:15.04 | brlcad | wasn't that a minimally-impacting change? |
| 19:15.19 | brlcad | there's a good argument that all of NMG is unpublished |
| 19:17.08 | ``Erik | the symbol was exported *shrug* who knows if anyone is using it? if you want to call it an exception to the deprecation procedure, that's cool |
| 19:18.01 | brlcad | even if it isn't considered published, isn't that effectively just renaming the function? |
| 19:18.04 | ``Erik | yeah |
| 19:18.42 | brlcad | changes that fall under regex can just happen (they go to the end of deprecation.txt) |
| 19:18.53 | brlcad | *simple regex :) |
| 19:19.16 | ``Erik | simple to who? :> |
| 19:22.11 | brlcad | limited to s/// substitutions |
| 19:23.08 | brlcad | and that aren't likely to have false positives |
| 19:55.25 | *** join/#brlcad andrei (~andrei@188.25.27.46) |
| 20:06.50 | brlcad | waves to andrei |
| 20:08.40 | andrei | Hi |
| 20:09.08 | andrei | Sorry for the "dissapearing", I ve been caught up in preparing myself for programming challenges and the challenges themselves |
| 20:09.37 | andrei | I m trying to finish all my homeworks today/tonight and focus on GCI after |
| 20:10.46 | andrei | by the way, I ve been thinking. Are all of the ksuze's patches reviewed already? |
| 20:11.08 | andrei | I could have a look at them, see if there are any issues with them |
| 20:11.18 | andrei | and create some tasks from them |
| 20:13.11 | andrei | I need to polish and commit my unit tests aswell. Got a todo list somewhere around |
| 20:27.05 | brlcad | andrei: they are not all reviewed, several still pending |
| 20:33.44 | andrei | does what I said above sound good? |
| 20:37.07 | andrei | or, do you have any other suggestions? |
| 21:44.10 | *** join/#brlcad elf` (~elf11_@p5.eregie.pub.ro) |
| 22:47.59 | brlcad | andrei: of course that sounds good |
| 22:48.14 | brlcad | all of it |
| 22:51.21 | andrei | just one question: suppose that a patch seems correct, do I commit it or just leave a comment that I ve checked it |
| 22:55.14 | brlcad | andrei: you should verify that it's correct, but yes you can commit it |
| 22:55.45 | brlcad | "don't break anything" ;) |
| 22:56.20 | brlcad | the patch doesn't break anything, applying it might -- so best to test the function/application/whatever quickly just to make sure a change wasn't introdcued |
| 22:56.32 | brlcad | several should be obvious, but some aren't |
| 22:57.17 | brlcad | given the rate at which previous patches had problems, they do warrant caution |
| 22:57.26 | andrei | since time is of essence, I ll just take care of the easiest ones first. |
| 22:57.37 | andrei | you can't make any tasks after GCI starts, can you ? |
| 23:33.25 | *** join/#brlcad bhlegm (6cb41b13@gateway/web/freenode/ip.108.180.27.19) |