IRC log for #brlcad on 20120113

00:34.28*** join/#brlcad starseeker (~starseeke@BZ.BZFLAG.BZ)
00:36.31*** join/#brlcad starseeker (~starseeke@BZ.BZFLAG.BZ)
01:00.34*** join/#brlcad CIA-130 (~CIA@cia.atheme.org)
01:17.43CIA-130BRL-CAD: 03starseeker * r48607 10/brlcad/trunk/src/mged/polyif.c: Initialize the point count variable - CID 156
01:20.31CIA-130BRL-CAD: 03starseeker * r48608 10/brlcad/trunk/src/mged/edsol.c: Initialize vectors - CID 1629
01:35.14CIA-130BRL-CAD: 03starseeker * r48609 10/brlcad/trunk/src/mged/edarb.c: instead of just continuing, initialize any tarb.pt entries that aren't set by the primary permutation entries. CID 1628
01:36.48CIA-130BRL-CAD: 03starseeker * r48610 10/brlcad/trunk/src/libged/ypr.c: initialize pt CID 1620
01:38.27CIA-130BRL-CAD: 03r_weiss * r48611 10/brlcad/trunk/src/libged/ (move_arb_edge.c wdb_obj.c): Updated functions 'wdb_move_arb_edge_cmd' and 'ged_move_arb_edge'. Coverity CID 411, 412 and 418.
01:51.29CIA-130BRL-CAD: 03starseeker * r48612 10/brlcad/trunk/src/mged/edarb.c: use VSETALL.
01:53.03CIA-130BRL-CAD: 03starseeker * r48613 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: initialize top_pl - CID 1618
01:57.06CIA-130BRL-CAD: 03starseeker * r48614 10/brlcad/trunk/src/rt/rtshot.c: initialize cur - CID 1615
01:59.21CIA-130BRL-CAD: 03starseeker * r48615 10/brlcad/trunk/src/fbserv/fbserv.c: initialize namelen - CID 1614
02:08.50CIA-130BRL-CAD: 03starseeker * r48616 10/brlcad/trunk/src/vfont/getfont.c:
02:08.50CIA-130BRL-CAD: Initialize width and height, but this is actually a complex structure...
02:08.50CIA-130BRL-CAD: curious, why not have getfont return a pointer that can be checked for NULL,
02:08.50CIA-130BRL-CAD: instead of the entire struct? Need second option on what to do about
02:08.50CIA-130BRL-CAD: initializing this 'properly'... CID 1613
02:11.00CIA-130BRL-CAD: 03starseeker * r48617 10/brlcad/trunk/src/conv/stl/stl-g.c: initialize tmp_face - CID 1612
02:12.13CIA-130BRL-CAD: 03starseeker * r48618 10/brlcad/trunk/src/conv/proe-g.c: Initialize tmp_face - CID 1611
02:14.12CIA-130BRL-CAD: 03starseeker * r48619 10/brlcad/trunk/src/conv/iges/recsize.c: Initialize length array - CID 1609
02:17.11CIA-130BRL-CAD: 03starseeker * r48620 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: initialize pt1 and pt2 - CID 1608
02:18.12CIA-130BRL-CAD: 03starseeker * r48621 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: initialize pt1 and pt2 - CID 1604
02:22.24CIA-130BRL-CAD: 03starseeker * r48622 10/brlcad/trunk/src/burst/ui.c: Don't use cmdfile uninitialized. CID 1602
02:24.39CIA-130BRL-CAD: 03starseeker * r48623 10/brlcad/trunk/src/burst/ui.c: Don't use cmdfile uninitialized. CID 1601
02:26.44CIA-130BRL-CAD: 03starseeker * r48624 10/brlcad/trunk/src/anim/anim_lookat.c: Initialize vect_t variables - CID 1600
02:29.15CIA-130BRL-CAD: 03starseeker * r48625 10/brlcad/trunk/src/anim/anim_keyread.c: initialize variables = CID 1599
02:30.36CIA-130BRL-CAD: 03starseeker * r48626 10/brlcad/trunk/src/anim/anim_cascade.c: initialize vect_t variables - CID 1598
02:50.40starseekerthinks the first step for review should be to default set the impact of some categories of bugs...
02:51.02starseekeris looking over his categorizations and realizes he didn't do it right...
02:51.05starseekeroops
02:57.17CIA-130BRL-CAD: 03starseeker * r48627 10/brlcad/trunk/src/conv/shp/shapelib/shpopen.c: Free malloced memory if we're erroring out - CID 464
03:03.01CIA-130BRL-CAD: 03starseeker * r48628 10/brlcad/trunk/src/liboptical/photonmap.c: Yow. Whole lotta places we can lose FH - add fclose calls. CID 2065
03:50.52*** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com)
03:55.32*** join/#brlcad brlcad (~sean@BZ.BZFLAG.BZ)
03:55.43brlcadrun 8 being uploaded now
03:59.26starseekeris done committing for the night anyhow :-)
03:59.53starseekerwill be interesting to see what the final count is
05:14.42*** join/#brlcad DarkCalff (DC@173.231.40.98)
08:05.44*** join/#brlcad merzo (~merzo@193.254.217.44)
09:35.53*** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol)
11:05.41*** join/#brlcad KimK (~Kim__@209.248.147.2.nw.nuvox.net)
11:52.17*** join/#brlcad milamber (~devlin@d118-75-244-176.try.wideopenwest.com)
13:29.13starseekerpokes CIA-130
14:21.50*** join/#brlcad juanman (~quassel@unaffiliated/juanman)
16:06.32*** join/#brlcad Stattrav (~Stattrav@61.12.114.82)
16:06.32*** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav)
16:29.49*** join/#brlcad Stattrav (~Stattrav@61.12.114.82)
16:29.49*** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav)
17:44.27CIA-130BRL-CAD: 03indianlarry * r48629 10/brlcad/trunk/src/ (21 files in 5 dirs): Fix to remaining tainted strings. Relates to Run 8 CIDs 1517,1545-7,1553,1560,1570-85
17:48.23CIA-130BRL-CAD: 03starseeker * r48630 10/brlcad/trunk/src/util/pixclump.c: Close fp before it goes out of scope - CID 512
17:48.28CIA-130BRL-CAD: 03starseeker * r48631 10/brlcad/trunk/src/util/pix3filter.c: Free working_name on error cases. CID 511
17:49.02CIA-130BRL-CAD: 03starseeker * r48632 10/brlcad/trunk/src/util/pix-alias.c: We malloced it - free it. CID 510
17:49.40CIA-130BRL-CAD: 03brlcad * r48633 10/brlcad/trunk/src/rt/do.c: quell unused warning
17:51.26CIA-130BRL-CAD: 03starseeker * r48634 10/brlcad/trunk/src/tab/tabinterp.c: make sure goto out also closes the fp. CID 509
17:53.52CIA-130BRL-CAD: 03starseeker * r48635 10/brlcad/trunk/src/rt/read-rtlog.c: Make sure we fclose the file before returning with an error condition - CID 508
17:54.02CIA-130BRL-CAD: 03starseeker * r48636 10/brlcad/trunk/src/remrt/remrt.c: remember to fclose - CID 507
17:55.38CIA-130BRL-CAD: 03starseeker * r48637 10/brlcad/trunk/src/remrt/remrt.c: remember to fclose - CID 506
17:57.33CIA-130BRL-CAD: 03starseeker * r48638 10/brlcad/trunk/src/mged/tedit.c: remember to fclose when erroring out - CID 504
17:57.52CIA-130BRL-CAD: 03starseeker * r48639 10/brlcad/trunk/src/mged/history.c: remember to fclose when erroring out - CID 503
17:57.55CIA-130BRL-CAD: 03starseeker * r48640 10/brlcad/trunk/src/mged/clone.c: remember to fclose when erroring out - CID 502
18:00.01CIA-130BRL-CAD: 03starseeker * r48641 10/brlcad/trunk/src/libicv/rot.c: remember to fclose - CID 499
18:02.14CIA-130BRL-CAD: 03starseeker * r48642 10/brlcad/trunk/src/libged/tree.c: remember to fclose when erroring out - CID 498
18:09.43CIA-130BRL-CAD: 03starseeker * r48643 10/brlcad/trunk/src/libged/saveview.c: remember to fclose when erroring out - CID 497
18:10.25CIA-130BRL-CAD: 03starseeker * r48644 10/brlcad/trunk/src/libged/loadview.c: remember to fclose when erroring out - CID 494
18:10.46CIA-130BRL-CAD: 03starseeker * r48645 10/brlcad/trunk/src/libged/edmater.c: Close, then handle errors - CID 493
18:11.07CIA-130BRL-CAD: 03starseeker * r48646 10/brlcad/trunk/src/libged/edcodes.c: Close, then handle errors - CID 492
18:11.08CIA-130BRL-CAD: 03bob1961 * r48647 10/brlcad/trunk/src/libged/vdraw.c: run 8, CID 1737, DEADCODE.
18:11.27CIA-130BRL-CAD: 03starseeker * r48648 10/brlcad/trunk/src/libged/rcodes.c: Close fp - CID 491
18:11.28CIA-130BRL-CAD: 03starseeker * r48649 10/brlcad/trunk/src/libged/dg_obj.c: remember to fclose when erroring out - CID 490
18:11.29CIA-130BRL-CAD: 03n_reed * r48650 10/brlcad/trunk/src/util/azel.c: remove fall-through from break, CID 366
18:11.31CIA-130BRL-CAD: 03starseeker * r48652 10/brlcad/trunk/src/libged/dg_obj.c: Don't try to fopen an output file if fdout is already non-NULL (presumably this happens if multiple -o options are passed...) - CID 490
18:11.42CIA-130BRL-CAD: 03n_reed * r48651 10/brlcad/trunk/src/util/dbcp.c: missing break. CID 367
18:11.43CIA-130BRL-CAD: 03bob1961 * r48653 10/brlcad/trunk/src/libged/vdraw.c: run 8, CID 1751, OVERRUN STATIC.
18:11.44CIA-130BRL-CAD: 03brlcad * r48654 10/brlcad/trunk/ (NEWS src/fb/gif2fb.c): looks like there's an off-by-one error in gif2fb, reported by coverity OVERRUN_STATIC check (cid 2059), that should result in a segfault if we attempted to convert a tall non-interlaced image.
18:11.45CIA-130BRL-CAD: 03starseeker * r48655 10/brlcad/trunk/src/librt/opennurbs_ext.cpp: Free parent when erroring out - CID 488
18:11.46CIA-130BRL-CAD: 03bob1961 * r48656 10/brlcad/trunk/src/libged/get_solid_kp.c: run 8, CID 1736, DEADCODE.
18:11.48CIA-130BRL-CAD: 03starseeker * r48657 10/brlcad/trunk/src/libged/bot_dump.c: remember to fclose when erroring out - CID 487
18:11.49CIA-130BRL-CAD: 03n_reed * r48658 10/brlcad/trunk/src/conv/fast4-g.c: unchecked return from ftell CID 373
18:12.20CIA-130BRL-CAD: 03bob1961 * r48659 10/brlcad/trunk/src/libged/comb_std.c: run 8, CID 1735, DEADCODE.
18:12.21CIA-130BRL-CAD: 03starseeker * r48660 10/brlcad/trunk/src/libfb/tcl.c: Free before return - CID 486
18:12.54CIA-130BRL-CAD: 03indianlarry * r48662 10/brlcad/trunk/src/conv/step/MeasureValue.cpp: Added initializers accidently skipped in initial fix. Relates to Run 8 CIDs 1987 1989
18:12.54CIA-130BRL-CAD: 03bob1961 * r48661 10/brlcad/trunk/src/libged/analyze.c: run 8, CID 1734, DEADCODE.
18:13.03CIA-130BRL-CAD: 03starseeker * r48663 10/brlcad/trunk/src/libfb/if_X.c: free what has been successfully calloced on error - CID 483
18:13.03CIA-130BRL-CAD: 03n_reed * r48664 10/brlcad/trunk/src/conv/stl/g-stl.c: using fd after open fails. CID 374
18:13.07CIA-130BRL-CAD: 03bob1961 * r48665 10/brlcad/trunk/src/libged/analyze.c: run 8, CID 1733, DEADCODE.
18:13.36CIA-130BRL-CAD: 03r_weiss * r48666 10/brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c: Updated file nmg_mk.c functions nmg_kvu nmg_kfu nmg_klu nmg_ks nmg_kr nmg_km nmg_jv nmg_keu. Removed coverity 'use after free' errors. CIDs 1823-1832.
18:13.42CIA-130BRL-CAD: 03erikgreenwald * r48667 10/brlcad/trunk/src/librt/primitives/nmg/nmg_fcut.c: log what should be an unreachable point and add a break at the end of the case. Cov358
18:13.44CIA-130BRL-CAD: 03indianlarry * r48668 10/brlcad/trunk/src/libpc/pcVariable.h: Didn't interpret coverity issue last time submitted. Actually needed to add check for list::end() before using after the the loop to std::list:erase() elements. Relates to Run 8 CID 333.
18:13.58CIA-130BRL-CAD: 03erikgreenwald * r48669 10/brlcad/trunk/src/conv/shp/shapelib/shpopen.c: remove double-frees. Cov2070
18:14.19CIA-130BRL-CAD: 03brlcad * r48670 10/brlcad/trunk/src/libbu/parse.c:
18:14.19CIA-130BRL-CAD: looks like there are a few more SIGN_EXTENSION defects being reported by
18:14.19CIA-130BRL-CAD: coverity. same problem, where we were loosing range on buffer values greater
18:14.19CIA-130BRL-CAD: than 0x7FFFFFFF (which probably would have led to instability on crazy-large
18:14.19CIA-130BRL-CAD: structures (approaching 32-bit limit). unlikely an issue, but real bug
18:14.19CIA-130BRL-CAD: nonetheless.
18:14.20CIA-130BRL-CAD: 03erikgreenwald * r48671 10/brlcad/trunk/src/rttherm/ssampview.c: comment out useless assign until tcl arg is fixed. Cov1713
18:14.29CIA-130BRL-CAD: 03erikgreenwald * r48672 10/brlcad/trunk/src/rttherm/ssampview.c: comment out useless assign until tcl arg is fixed. Cov1714
18:14.29CIA-130BRL-CAD: 03n_reed * r48673 10/brlcad/trunk/src/fb/gif2fb.c: unchecked error return. CID 375
18:14.29CIA-130BRL-CAD: 03bob1961 * r48674 10/brlcad/trunk/src/libged/edit.c: run 8, CID 1727, CONSTANT EXPRESSION RESULT.
18:14.40CIA-130BRL-CAD: 03brlcad * r48675 10/brlcad/trunk/src/rttherm/ssampview.c: remove dead code
18:14.41CIA-130BRL-CAD: 03bob1961 * r48676 10/brlcad/trunk/src/libged/edit.c: run 8, CID 1727, CONSTANT EXPRESSION RESULT, part 2
18:14.42CIA-130BRL-CAD: 03r_weiss * r48677 10/brlcad/trunk/src/librt/primitives/ars/ars.c: Updated file ars.c function rt_ars_import4. Fixed a coverity 'sizeof mismatch' error. CID 1269.
18:14.53CIA-130BRL-CAD: 03brlcad * r48679 10/brlcad/trunk/src/conv/iges/makegroup.c: UNUSED_VALUE detected by coverity. returned matrix isn't used. (cid 1690)
18:14.53CIA-130BRL-CAD: 03brlcad * r48678 10/brlcad/trunk/src/conv/iges/trimsurf.c: unused edgeuse, reported by Coverity in UNUSED_VALUE check (cid 1689)
18:14.54CIA-130BRL-CAD: 03brlcad * r48680 10/brlcad/trunk/src/conv/nastran-g.c: the first ptr is obviously not reused (strtok() is stateful), so quell the UNUSED_VALUE coverity report by not staching the value. (cid 1691)
18:14.55CIA-130BRL-CAD: 03n_reed * r48681 10/brlcad/trunk/src/fbed/fbed.c: unchecked EOF return. CID 376
18:14.56CIA-130BRL-CAD: 03brlcad * r48682 10/brlcad/trunk/src/conv/nmg/asc-nmg.c: faceuse is never used, fixes UNUSED_VALUE coverity issue (cid 1692)
18:15.05CIA-130BRL-CAD: 03r_weiss * r48683 10/brlcad/trunk/src/rt/viewarea.c: Updated file viewarea.c function increment_assembly_counter. Fixed a coverity 'reverse inull' error. CID 570.
18:16.02CIA-130BRL-CAD: 03n_reed * r48684 10/brlcad/trunk/src/fbed/fbed.c: avoid using negative index. CID 377
18:16.07CIA-130BRL-CAD: 03bob1961 * r48685 10/brlcad/trunk/src/libged/analyze.c: run 8, CID 191, DEADCODE.
18:16.08CIA-130BRL-CAD: 03starseeker * r48686 10/brlcad/trunk/src/libfb/fb_generic.c: Free memory - CID 481
18:16.15CIA-130BRL-CAD: 03starseeker * r48687 10/brlcad/trunk/src/lgt/texture.c: close iconfp on error - CID 477
18:16.15CIA-130BRL-CAD: 03starseeker * r48688 10/brlcad/trunk/src/gtools/remapid.c: close the file pointer - CID 471
18:16.16CIA-130BRL-CAD: 03starseeker * r48689 10/brlcad/trunk/src/fbed/fbed.c: close file pointer - CID 469
18:16.17CIA-130BRL-CAD: 03bob1961 * r48691 10/brlcad/trunk/src/libged/get_obj_bounds.c: run 8, CID 192, DEADCODE.
18:16.26CIA-130BRL-CAD: 03starseeker * r48690 10/brlcad/trunk/src/fbed/fbed.c: close file pointer - CID 468
18:16.36CIA-130BRL-CAD: 03n_reed * r48693 10/brlcad/trunk/src/gtools/remapid.c: unhandled EOF returns. CID 378, 379
18:16.36CIA-130BRL-CAD: 03brlcad * r48692 10/brlcad/trunk/src/conv/tankill/tankill-g.c: attempt to quell UNUSED_VALUE detected by coverity (cid 1693)
18:16.37CIA-130BRL-CAD: 03starseeker * r48694 10/brlcad/trunk/src/fb/spm-fb.c: Free scanline - CID 467
18:16.42CIA-130BRL-CAD: 03bob1961 * r48695 10/brlcad/trunk/src/librt/binunif/binunif.c: run 8, CID 193, DEADCODE.
18:16.47CIA-130BRL-CAD: 03starseeker * r48703 10/brlcad/trunk/src/fb/fbgammamod.c: Several memory issues in fbgammamod - CID 465-466
18:16.47CIA-130BRL-CAD: 03indianlarry * r48701 10/brlcad/trunk/src/librt/ (opennurbs_ext.cpp opennurbs_ext.h): remaining constructor initialization issues turned up by coverity. Run 8 CIDs: 1648-51,1662
18:16.48CIA-130BRL-CAD: 03erikgreenwald * r48705 10/brlcad/trunk/src/mged/animedit.c: minor casting fixes
18:16.56CIA-130BRL-CAD: 03erikgreenwald * r48700 10/brlcad/trunk/src/mged/animedit.c: type size fix (struct directory*, not struct directory**). Cov1271
18:16.56CIA-130BRL-CAD: 03n_reed * r48702 10/brlcad/trunk/src/lgt/octree.c: unchecked return from ftell. CID 380
18:16.56CIA-130BRL-CAD: 03erikgreenwald * r48697 10/brlcad/trunk/src/conv/off/g-off.c: type size fix (int, not int*). Cov1264
18:17.03CIA-130BRL-CAD: 03brlcad * r48696 10/brlcad/trunk/src/fb/cmap-fb.c: the last one isn't used. UNUSED_VALUE reported from coverity (cid 1694)
18:17.13CIA-130BRL-CAD: 03bob1961 * r48699 10/brlcad/trunk/src/libged/eac.c: run 8, CID 197, DEADCODE.
18:17.21CIA-130BRL-CAD: 03erikgreenwald * r48704 10/brlcad/trunk/src/mged/animedit.c: type size fix (struct directory*, not struct directory**). Cov1270
18:17.21CIA-130BRL-CAD: 03brlcad * r48698 10/brlcad/trunk/src/librt/primitives/nmg/nmg_brep.cpp: no need to make a model, not used (cid 1706).
18:17.40CIA-130BRL-CAD: 03erikgreenwald * r48708 10/brlcad/trunk/src/conv/cy-g.c: fastf_t** -> fastf_t* in sizeof. Cov1263
18:18.59CIA-130BRL-CAD: 03erikgreenwald * r48707 10/brlcad/trunk/src/proc-db/contours.c: pull npts check outside of for loop. Add upper limit test.
18:19.15CIA-130BRL-CAD: 03brlcad * r48706 10/brlcad/trunk/src/burst/ui.c: if reading input fails, then cmdfp will be unset and passed to fclose(). fixed. detected by coverity UNINIT check
18:19.21CIA-130BRL-CAD: 03brlcad * r48709 10/brlcad/trunk/src/conv/iges/trimsurf.c: the vertex use ends up being used too, remove it. looks like copy-paste from another function.
18:19.48CIA-130BRL-CAD: 03erikgreenwald * r48714 10/brlcad/trunk/src/vdeck/vdeck.c: cast sizeof() to size_t? Cov1272
18:19.49CIA-130BRL-CAD: 03bob1961 * r48713 10/brlcad/trunk/src/libged/plot.c: run 8, CID 200, DEADCODE.
18:19.53CIA-130BRL-CAD: 03brlcad * r48717 10/brlcad/trunk/src/mged/bodyio.c: ws/indent. previous commit (r48712) message to bodyio.c should have also said that it fixed a time-of-call, time-of-use race condition detected by coverity TOCTOU check. (cid 1590)
18:19.59CIA-130BRL-CAD: 03brlcad * r48712 10/brlcad/trunk/src/mged/bodyio.c: it's a function, not a macro
18:19.59CIA-130BRL-CAD: 03erikgreenwald * r48710 10/brlcad/trunk/src/gtools/beset/population.c: char** -> char* in sizeof. Cov1265
18:20.22CIA-130BRL-CAD: 03starseeker * r48715 10/brlcad/trunk/src/conv/euclid/euclid-g.c: Bounds check reg_id (somewhat more liberal than the function itself on allowable region id values - something to look into later.) CID 1766
18:20.22CIA-130BRL-CAD: 03erikgreenwald * r48711 10/brlcad/trunk/src/gtools/beset/population.c: char* -> char in sizeof. Cov1266
18:20.22CIA-130BRL-CAD: 03bob1961 * r48716 10/brlcad/trunk/src/libged/wdb_comb_std.c: run 8, CID 203, DEADCODE.
18:20.25CIA-130BRL-CAD: 03bob1961 * r48720 10/brlcad/trunk/src/libged/wdb_comb_std.c: run 8, CID 204, DEADCODE.
18:20.26CIA-130BRL-CAD: 03brlcad * r48719 10/brlcad/trunk/src/libpkg/pkg.c:
18:20.27CIA-130BRL-CAD: address a race condition time-of-call, time-of-use issue detected by coverity
18:20.29CIA-130BRL-CAD: TOCTOU check (cid 1589) whereby the file we stat might not be the file we open.
18:20.30CIA-130BRL-CAD: swap the order so we still get our stat data but reusing the file that was
18:20.31CIA-130BRL-CAD: opened.
18:20.32CIA-130BRL-CAD: 03erikgreenwald * r48718 10/brlcad/trunk/src/conv/nmg/asc-nmg.c: verify vertex number. Cov1468 and 324
18:21.27CIA-130BRL-CAD: 03brlcad * r48721 10/brlcad/trunk/src/other/tnt/tnt_array1d.h: fix a leak detected by coverity (cid 157) via CTOR_DTOR_LEAK check. all of the constructors initialize data_, but the destructor wasn't releasing it
18:21.32CIA-130BRL-CAD: 03r_weiss * r48722 10/brlcad/trunk/src/lgt/do_options.c: Updated file do_options.c function f_Batch. Fixed coverity error 'resource leak'. CID 472.
18:21.35CIA-130BRL-CAD: 03n_reed * r48723 10/brlcad/trunk/src/remrt/remrt.c: handle invalid fd rather than passing it down. CID 386
18:21.38CIA-130BRL-CAD: 03erikgreenwald * r48724 10/brlcad/trunk/src/proc-db/tube.c: test number of samples for extrapolation to avoid buffer underrun. Cov329
18:22.12CIA-130BRL-CAD: 03n_reed * r48726 10/brlcad/trunk/src/util/dunncomm.c: closing an fd known to be invalid. CID 388
18:22.31CIA-130BRL-CAD: 03brlcad * r48725 10/brlcad/trunk/src/lgt/do_options.c: memory fail. not only not using bu_malloc() but not stashing the pointer so we can't free it. switch it to default line buffering for simplicity, untested. detected by coverity RESOURCE_LEAK check (cid 476)
18:22.49CIA-130BRL-CAD: 03brlcad * r48727 10/brlcad/trunk/src/lgt/lgt.c: ws, indent, style
18:22.55CIA-130BRL-CAD: 03erikgreenwald * r48728 10/brlcad/trunk/src/util/sun-pix.c: test image size in double space for possible overflow. Cov332
18:23.16CIA-130BRL-CAD: 03brlcad * r48729 10/brlcad/trunk/src/lgt/do_options.c: free the file pointer we just opened. RESOURCE_LEAK coverity check (cid 475)
18:23.17CIA-130BRL-CAD: 03n_reed * r48731 10/brlcad/trunk/src/lgt/prnt.c: said NULL, meant '\0'. CID 389
18:23.18CIA-130BRL-CAD: 03starseeker * r48730 10/brlcad/trunk/src/util/ttcp.c: Do some input validation for ttcp - CID 1513
18:23.23CIA-130BRL-CAD: 03brlcad * r48732 10/brlcad/trunk/src/lgt/do_options.c: another unclosed file pointer. coverity RESOURCE_LEAK check (cid 474)
18:23.23CIA-130BRL-CAD: 03r_weiss * r48733 10/brlcad/trunk/src/libged/wdb_obj.c: Updated file wdb_obj.c function wdb_put_cmd. Fixed a coverity error 'overrun static'. CID 419.
18:23.23CIA-130BRL-CAD: 03brlcad * r48734 10/brlcad/trunk/src/libged/inside.c:
18:23.33CIA-130BRL-CAD: idb_type just might be negative if an object is initialized with
18:23.33CIA-130BRL-CAD: RT_DB_INTERNAL_INIT() and never filled in with internal details. prevents a
18:23.33CIA-130BRL-CAD: potential (albeit unlikely) crash, detected by NEGATIVE_RETURNS coverity check
18:23.43CIA-130BRL-CAD: (cid 383)
18:23.43CIA-130BRL-CAD: 03erikgreenwald * r48735 10/brlcad/trunk/src/util/pl-pl.c: collapse logic, removing a variable. Explicitely cast to short on return. Cov331
18:23.43CIA-130BRL-CAD: 03n_reed * r48736 10/brlcad/trunk/src/conv/dxf/dxf-g.c: Static string can't have NULL address. Do empty check instead. CID 390
18:24.09CIA-130BRL-CAD: 03r_weiss * r48737 10/brlcad/trunk/src/libged/put.c: Updated file put.c function ged_put. Fixed coverity error 'overrun static'. CID 414.
18:24.11CIA-130BRL-CAD: 03n_reed * r48738 10/brlcad/trunk/src/conv/iges/convsurf.c: Static string can't have NULL address. Do empty check instead. CID 391
18:24.39CIA-130BRL-CAD: 03n_reed * r48739 10/brlcad/trunk/src/conv/iges/trimsurf.c: Static string can't have NULL address. Do empty check instead. CID 392
18:24.49CIA-130BRL-CAD: 03erikgreenwald * r48740 10/brlcad/trunk/src/rt/rtshot.c: test number of rings for a legit value. Cov1488
18:25.13CIA-130BRL-CAD: 03bob1961 * r48741 10/brlcad/trunk/src/mged/utility1.c: Fixed a bug. Shouldn't be adding 1 to argc in call to ged_edcodes.
18:27.20CIA-130BRL-CAD: 03bob1961 * r48743 10/brlcad/trunk/src/libged/edcodes.c: run 8, CID 198, DEADCODE.
18:27.21CIA-130BRL-CAD: 03n_reed * r48742 10/brlcad/trunk/src/anim/anim_cascade.c: misordered arguments. CID 400
18:27.21CIA-130BRL-CAD: 03brlcad * r48744 10/brlcad/trunk/src/fb/pl-fb.c: at a glance, looks like the two MISSING_BREAK detections from coverity (cid 342,343) are intentional fall-through cases so document them as such to quell the warning.
18:27.22CIA-130BRL-CAD: 03erikgreenwald * r48745 10/brlcad/trunk/src/bwish/input.c: verify read character is not 0. Cov1461
18:27.25CIA-130BRL-CAD: 03n_reed * r48746 10/brlcad/trunk/src/anim/ (anim_keyread.c anim_lookat.c anim_orient.c): swapped arguments to anim_mat2ypr. CID 401, 402, 403
18:27.26CIA-130BRL-CAD: 03brlcad * r48747 10/brlcad/trunk/src/libged/make_name.c: looks like the fallthrough to the Usage statement was intentional, but make it explicit anyways. coverity reported a MISSING_BREAK due to the ambiguity.
18:27.37CIA-130BRL-CAD: 03erikgreenwald * r48748 10/brlcad/trunk/src/vdeck/vdeck.c: copy directory entry length
18:27.37CIA-130BRL-CAD: 03r_weiss * r48749 10/brlcad/trunk/src/librt/primitives/arb8/arb8.c: Updated file 'arb8.c' and 'struct arb_specific'. This change was to correct a coverity error 'overrun static' in function 'rt_arb_vshot'. CID 424.
18:27.46CIA-130BRL-CAD: 03bob1961 * r48750 10/brlcad/trunk/src/libged/editit.c: Modified _ged_editit() to do some kind of last ditch check for an editor if editstring is NULL. This gets edcodes etc. working with archer. Not tested on windows.
18:28.01CIA-130BRL-CAD: 03brlcad * r48751 10/brlcad/trunk/src/librt/primitives/nmg/nmg_fcut.c: if it's an unknown wedge class type, then the code falls through and probably does bad things, but it at least logs a message now. relates to coverity MISSING_BREAK cid 357 from erik and cid 358 too.
18:28.10CIA-130BRL-CAD: 03starseeker * r48752 10/brlcad/trunk/src/conv/patch/patch-g.c: check num ranges - CID 1470
18:28.11CIA-130BRL-CAD: 03erikgreenwald * r48753 10/brlcad/trunk/src/vdeck/vdeck.c: explicitely track remaining buffer and use that for dirname copy bound. Cov1272
18:30.21CIA-130BRL-CAD: 03starseeker * r48754 10/brlcad/trunk/src/conv/asc/asc2pix.c: Check both lower bound as well - CID 1462
18:30.48CIA-130BRL-CAD: 03erikgreenwald * r48755 10/brlcad/trunk/src/fb/gif2fb.c: hoist width/height expansion and verify values. Cov1475
18:30.48CIA-130BRL-CAD: 03n_reed * r48756 10/brlcad/trunk/src/irprep/ir-X.c: comparing index against wrong constant. CID 406
18:30.49CIA-130BRL-CAD: 03brlcad * r48757 10/brlcad/trunk/src/librt/primitives/nmg/nmg_fcut.c:
18:30.49CIA-130BRL-CAD: looks like the section of code immediately preceeding handles the
18:30.50CIA-130BRL-CAD: WEDGE2_IDENTICAL case, and was intentionally added back in r7584 by mike to test
18:30.50CIA-130BRL-CAD: for TOUCHing wedges first. so can remove the prior stale case detected by
18:30.51CIA-130BRL-CAD: coverity DEADCODE check (cid 210).
18:30.53CIA-130BRL-CAD: 03indianlarry * r48758 10/brlcad/trunk/src/librt/comb/comb.c: Check for overrunning static array buffer Run 8 CID 422,423
18:31.04CIA-130BRL-CAD: 03erikgreenwald * r48759 10/brlcad/trunk/src/util/bwcrop.c: verify xval before using as loop bound. Cov1496
18:31.04CIA-130BRL-CAD: 03brlcad * r48760 10/brlcad/trunk/src/mged/clone.c: prevent a bonefide infinite loop bug introduced when bu_getopt() was pulled out of an option parsing loop. coverity detected via INFINITE_LOOP check (cid 319).
18:31.05CIA-130BRL-CAD: 03tbrowder2 * r48761 10/brlcad/trunk/TODO: add reference to more items to do for STEP code
18:31.34CIA-130BRL-CAD: 03erikgreenwald * r48762 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov560
18:31.34CIA-130BRL-CAD: 03brlcad * r48763 10/brlcad/trunk/src/mged/update.c: mark the 'done' variable as volatile since it's updated via Tk, possibly asynchronously. should quell coverity INFINITE_LOOP report (cid 320).
18:31.34CIA-130BRL-CAD: 03erikgreenwald * r48764 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov554
18:31.34CIA-130BRL-CAD: 03erikgreenwald * r48765 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov555
18:31.37CIA-130BRL-CAD: 03n_reed * r48766 10/brlcad/trunk/src/libged/move_arb_face.c: insufficient index checking. CID 413
18:31.38CIA-130BRL-CAD: 03brlcad * r48767 10/brlcad/trunk/src/conv/intaval/regtab.h: the Region forward decl is unnecessary. the class is declared in here and nothing uses it between this decl and the class decl.
18:31.51CIA-130BRL-CAD: 03erikgreenwald * r48768 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov567
18:31.51CIA-130BRL-CAD: 03erikgreenwald * r48769 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov566
18:31.52CIA-130BRL-CAD: 03erikgreenwald * r48770 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov565
18:31.57CIA-130BRL-CAD: 03erikgreenwald * r48771 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov556
18:31.57CIA-130BRL-CAD: 03r_weiss * r48772 10/brlcad/trunk/src/libged/get_solid_kp.c: Updated file ged_solid_kp.c function _ged_get_solid_keypoint. Fixed a coverity 'overrun static' error. CID 1750.
18:32.09CIA-130BRL-CAD: 03erikgreenwald * r48773 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov557
18:33.13CIA-130BRL-CAD: 03erikgreenwald * r48774 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov558
18:34.59CIA-130BRL-CAD: 03erikgreenwald * r48775 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov559
18:35.49CIA-130BRL-CAD: 03erikgreenwald * r48776 10/brlcad/trunk/src/mged/fbserv.c: test buf for null. Cov561
18:36.00CIA-130BRL-CAD: 03starseeker * r48777 10/brlcad/trunk/src/conv/asc/pix2asc.c: Try to check the pix characters... little surprised this is giving a TAINTED_SCALAR warning... CID 1463
18:36.35CIA-130BRL-CAD: 03n_reed * r48778 10/brlcad/trunk/src/ (anim/anim_orient.c libged/ypr.c): more swapped args to anim_mat2ypr. CID 417
18:42.45CIA-130BRL-CAD: 03erikgreenwald * r48779 10/brlcad/trunk/src/mged/fbserv.c: test buf before accessing.
18:45.43CIA-130BRL-CAD: 03r_weiss * r48780 10/brlcad/trunk/src/librt/comb/db_comb.c: Updated file db-comb.c function db_wrap_v4_external. Fixed coverity error 'overrun static'. CID 2068.
18:50.38CIA-130BRL-CAD: 03n_reed * r48781 10/brlcad/trunk/src/librt/primitives/hf/hf.c: unchecked index. CID 425
18:53.43CIA-130BRL-CAD: 03erikgreenwald * r48782 10/brlcad/trunk/src/libfb/fbserv_obj.c: test buf before accessing.
19:05.09CIA-130BRL-CAD: 03indianlarry * r48783 10/brlcad/trunk/src/libged/wdb_vdraw.c: Added static bounds check for bn_vlist arrays cmd[BN_VLIST_CHUNK] and pt[BN_VLIST_CHUNK]. Coverity run 8 CIDs 420 and 421
19:05.26CIA-130BRL-CAD: 03n_reed * r48784 10/brlcad/trunk/src/mged/edsol.c: bad constant index (typo). CID 426
19:09.07CIA-130BRL-CAD: 03erikgreenwald * r48785 10/brlcad/trunk/src/conv/iges/getcurve.c: test splroot for NULL early. Cov515
19:12.47CIA-130BRL-CAD: 03erikgreenwald * r48786 10/brlcad/trunk/src/librt/primitives/hf/hf.c: test stp before dereferencing it. Cov551
19:13.27CIA-130BRL-CAD: 03brlcad * r48787 10/brlcad/trunk/include/wdb.h: add a WMEMBER_INIT_ZERO static initializer and a WMEMBER_INIT() macro for initializing wmember structs.
19:13.56CIA-130BRL-CAD: 03starseeker * r48788 10/brlcad/trunk/src/conv/dem-g.c: Use realpath to validate av[1] - CID 1464
19:14.08CIA-130BRL-CAD: 03brlcad * r48789 10/brlcad/trunk/src/conv/intaval/regtab.h:
19:14.08CIA-130BRL-CAD: initialize all of the wmember entities in the constructor. this addresses an
19:14.08CIA-130BRL-CAD: UNINIT_CTOR check being reported by coverity due to three uninitialized fields
19:14.09CIA-130BRL-CAD: (addHead.wm_name, excludeHead.wm_name, head.wm_name). doesn't seem to be
19:14.09CIA-130BRL-CAD: critical, but for general safety. (cid 1647)
19:15.08*** join/#brlcad Technicus (~Technicus@DSLPool-net208-2.wctc.net)
19:19.30CIA-130BRL-CAD: 03erikgreenwald * r48790 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: test i_fus before dereferencing. Cov517
19:19.36CIA-130BRL-CAD: 03starseeker * r48791 10/brlcad/trunk/src/conv/intaval/read_dra.cpp: Check form.npts - CID 1465
19:22.36CIA-130BRL-CAD: 03indianlarry * r48792 10/brlcad/trunk/src/mged/track.c: wrong variable being initialized, fixes coverity run 8 CID 427
19:23.34CIA-130BRL-CAD: 03erikgreenwald * r48793 10/brlcad/trunk/src/conv/shp/shapelib/shpopen.c: test mallocs before dereferencing. Cov518
19:23.35CIA-130BRL-CAD: 03brlcad * r48794 10/brlcad/trunk/src/libpc/pcConstraint.cpp: initialize all class members, UNINIT_CTOR (cid 1652)
19:26.21CIA-130BRL-CAD: 03erikgreenwald * r48795 10/brlcad/trunk/src/libged/put_comb.c: test comb after BU_GET. Cov549
19:35.10CIA-130BRL-CAD: 03brlcad * r48796 10/brlcad/trunk/src/libpc/pcNetwork.cpp: init v and e (cid 1656)
19:39.40CIA-130BRL-CAD: 03brlcad * r48797 10/brlcad/trunk/src/libpc/pcParameter.cpp: UNINIT_CTOR, cid 1657. initialize all class fields in constructors.
19:39.50CIA-130BRL-CAD: 03r_weiss * r48798 10/brlcad/trunk/src/libfb/fbserv_obj.c:
19:39.50CIA-130BRL-CAD: Update file fbserv_obj.c functions fbs_rfbzoom fbs_rfbwriterect fbs_rfbwrite
19:39.50CIA-130BRL-CAD: fbs_rfbwindow fbs_rfbview fbs_rfbsetcursor fbs_rfbscursor fbs_rfbreadrect
19:39.50CIA-130BRL-CAD: fbs_rfbreadrect fbs_rfbread fbs_rfbread fbs_rfbhelp fbs_rfbcursor fbs_rfbclear
19:39.50CIA-130BRL-CAD: fbs_rfbbwwriterect fbs_rfbbwreadrect fbs_rfbbwreadrectw. Did code cleanup and
19:39.51CIA-130BRL-CAD: worked on coverity error 'reverse inull' for these functions. Coverity CIDs
19:39.51CIA-130BRL-CAD: 535-548.
19:44.08CIA-130BRL-CAD: 03brlcad * r48799 10/brlcad/trunk/src/libpc/pcParser.cpp: UNINIT_CTOR, cid 1658. initialize all class fields in constructors.
19:47.53CIA-130BRL-CAD: 03brlcad * r48800 10/brlcad/trunk/src/libpc/pcVariable.cpp: UNINIT_CTOR, cid 1659. initialize all class fields in constructors.
19:50.12CIA-130BRL-CAD: 03bob1961 * r48801 10/brlcad/trunk/src/lgt/reflect.c: run 8, CID 181-185, DEADCODE. It is impossible for failure to be set to PT_BEHIND or PT_EYE in the Get_Partition macro. If it gets into this section it will always be set to PT_GRID.
19:51.20CIA-130BRL-CAD: 03indianlarry * r48802 10/brlcad/trunk/src/sig/smod.c: increase static size of clip_l[] and clip_h[] to match mapbuf[] since initialized together. Fixes coverity Run 8 CID 429
19:51.47CIA-130BRL-CAD: 03r_weiss * r48803 10/brlcad/trunk/src/librt/comb/comb.c: Updated comb.c. fixed overrun static errors.
19:52.03CIA-130BRL-CAD: 03erikgreenwald * r48804 10/brlcad/trunk/src/mged/chgview.c: verify output of path_parse is not null. Cov552
19:54.02CIA-130BRL-CAD: 03brlcad * r48805 10/brlcad/trunk/src/librt/primitives/brep/brep.cpp: initialize all of the class fields. fixes report from coverity UNINIT_CTOR check. (cid 1663)
19:54.03CIA-130BRL-CAD: 03erikgreenwald * r48806 10/brlcad/trunk/src/mged/mged.c: verify dm entry is not null before shutting it down. Cov553
19:54.55CIA-130BRL-CAD: 03n_reed * r48807 10/brlcad/trunk/src/sig/dconv.c: potentially indexing one past last. CID 428
19:55.54CIA-130BRL-CAD: 03erikgreenwald * r48808 10/brlcad/trunk/src/mged/vrlink.c: verify buf is not null. Cov568
19:57.44CIA-130BRL-CAD: 03erikgreenwald * r48809 10/brlcad/trunk/src/util/buffer.c: verify bu_temp_file returned a valid handle before using it. Cov571
19:58.08CIA-130BRL-CAD: 03brlcad * r48810 10/brlcad/trunk/src/proc-db/brepintersect.cpp: initialize all of the class fields. fixes report from coverity UNINIT_CTOR check. (cid 1665)
19:58.54CIA-130BRL-CAD: 03bob1961 * r48811 10/brlcad/trunk/src/conv/proe-g.c: run 8, CID 177, DEADCODE.
20:02.38CIA-130BRL-CAD: 03erikgreenwald * r48812 10/brlcad/trunk/src/util/pixcolors.c: verify unsigned char is [0,255]. Cov1509
20:04.24CIA-130BRL-CAD: 03bob1961 * r48813 10/brlcad/trunk/src/conv/stl/stl-g.c: run 8, CID 178-179, DEADCODE.
20:09.48CIA-130BRL-CAD: 03erikgreenwald * r48814 10/brlcad/trunk/src/mged/mged.c: verify non-0 length buffers first element is not zero. Cov1485
20:28.11CIA-130BRL-CAD: 03tbrowder2 * r48815 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: quell uninitialized variable warning
20:29.16CIA-130BRL-CAD: 03tbrowder2 * r48816 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: quell uninitialized variable warning
20:48.41CIA-130BRL-CAD: 03tbrowder2 * r48817 10/brlcad/trunk/src/libgcv/test_bottess.c: unwrap macros so we can see what is happening
20:52.22CIA-130BRL-CAD: 03indianlarry * r48818 10/brlcad/trunk/src/sig/syn.c: casted to force expected(?) branching and index wrap. addresses coverity run 8 CID 330
20:54.51CIA-130BRL-CAD: 03bob1961 * r48819 10/brlcad/trunk/src/irprep/secpass.c: run 8, CID 180, DEADCODE.
20:56.08CIA-130BRL-CAD: 03n_reed * r48820 10/brlcad/trunk/src/util/sun-pix.c: unchecked index variable. CID 1512
21:05.33CIA-130BRL-CAD: 03tbrowder2 * r48821 10/brlcad/trunk/src/libgcv/test_bottess.c: quell uninitialized variable warning
21:07.35CIA-130BRL-CAD: 03tbrowder2 * r48822 10/brlcad/trunk/src/libged/editit.c: quell uninitialized variable warning
21:08.25CIA-130BRL-CAD: 03bob1961 * r48823 10/brlcad/trunk/src/libwdb/wdb.c: run 8, CID 213, DEADCODE.
21:11.44CIA-130BRL-CAD: 03n_reed * r48824 10/brlcad/trunk/src/util/pixbustup.c: unchecked cl argument. CID 1508
21:15.55CIA-130BRL-CAD: 03r_weiss * r48825 10/brlcad/trunk/src/librt/comb/comb.c: Updated file comb.c function rt_comb_v5_serialize. Fixed a coverity error 'negative returns'. CID 384.
21:17.30CIA-130BRL-CAD: 03tbrowder2 * r48826 10/brlcad/trunk/src/librt/comb/db_comb.c: fix array overrun error; same problem as in commit at revision 48780: Fixed coverity error 'overrun static'. CID 2068
21:25.47CIA-130BRL-CAD: 03tbrowder2 * r48827 10/brlcad/trunk/src/util/pixcolors.c: ws, style
21:28.30CIA-130BRL-CAD: 03tbrowder2 * r48828 10/brlcad/trunk/src/util/pixcolors.c: eliminated 'always false' statement (due to array type)
21:33.33CIA-130BRL-CAD: 03bob1961 * r48829 10/brlcad/trunk/src/mged/edsol.c: run 8, CID 216, DEADCODE.
21:35.20CIA-130BRL-CAD: 03n_reed * r48831 10/brlcad/trunk/src/util/pixhist3d.c: unchecked indexes. CID 1511
21:35.40CIA-130BRL-CAD: 03starseeker * r48830 10/brlcad/trunk/regress/ (9 files in 3 dirs): Add a regression test for dem-g - working out general techniques for geometry conversion regression. This appears to work, but at the moment it's a stand-alone dem-regress build target.
21:44.34CIA-130BRL-CAD: 03brlcad * r48832 10/brlcad/trunk/src/proc-db/surfaceintersect.cpp: initialize all of the class fields. fixes report from coverity UNINIT_CTOR check. (cid 1666)
21:50.58CIA-130BRL-CAD: 03brlcad * r48833 10/brlcad/trunk/src/other/step/src/clstepcore/ExpDict.h: initialize all of the class fields. fixes report from coverity UNINIT_CTOR check. (cid 2014)
22:01.00CIA-130BRL-CAD: 03brlcad * r48834 10/brlcad/trunk/src/other/step/src/clstepcore/complexSupport.h: initialize all of the class fields. fixes report from coverity UNINIT_CTOR check. (cid 2034)
22:13.53CIA-130BRL-CAD: 03brlcad * r48835 10/brlcad/trunk/NEWS: nick's 48742 fix to anim_cascade fixed a clear-cut crasher. params to anim_mat2ypr() were flipped.
22:27.08*** join/#brlcad cadman (~Adium@mwg-e04.infosec.fedex.com)
23:42.22*** join/#brlcad cadman1 (~Adium@mwg-e06.infosec.fedex.com)
23:51.49CIA-130BRL-CAD: 03starseeker * r48836 10/brlcad/trunk/misc/CMake/ (ThirdParty.cmake ThirdParty_TCL.cmake): String normalization FAIL for third party build logic. Let's try that again...

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.