| 03:20.56 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 03:26.26 | brlcad | looks like run4 is going to be complete |
| 03:29.11 | *** join/#brlcad archivist (~archivist@host81-149-189-98.in-addr.btopenworld.com) |
| 04:12.44 | brlcad | <PROTECTED> |
| 04:12.49 | brlcad | <PROTECTED> |
| 04:52.16 | *** join/#brlcad hackrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 05:10.55 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 05:26.24 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 05:36.01 | *** join/#brlcad hackrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 06:35.53 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 06:47.39 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 07:10.35 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 07:38.08 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 07:49.53 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 08:09.49 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 09:49.21 | *** join/#brlcad merzo (~merzo@193.254.217.44) |
| 09:52.49 | *** join/#brlcad merzo (~merzo@193.254.217.44) |
| 11:57.33 | brlcad | yawn! |
| 12:53.55 | *** join/#brlcad merzo (~merzo@193.254.217.44) |
| 13:34.05 | ``Erik | :/cl |
| 13:43.12 | CIA-57 | BRL-CAD: 03starseeker * r48266 10/brlcad/trunk/src/librt/db_tree.c: Check return value on bn_mat_ck - being in a debug conditional does not excuse us. CID 119 |
| 13:50.30 | CIA-57 | BRL-CAD: 03starseeker * r48267 10/brlcad/trunk/src/conv/dxf/bot-bldxf.c: Check return value of db_walk_tree - CID 120 |
| 14:01.32 | CIA-57 | BRL-CAD: 03n_reed * r48268 10/brlcad/trunk/src/fbserv/server.c: check pointers before dereferencing, CID 521 |
| 14:04.44 | CIA-57 | BRL-CAD: 03starseeker * r48269 10/brlcad/trunk/src/conv/intaval/write_brl.cpp: Check return of rt_db_put_internal - CID 123 |
| 14:11.46 | CIA-57 | BRL-CAD: 03starseeker * r48270 10/brlcad/trunk/src/conv/jack/jack-g.c: Check return of nmg_kill_zero_length_edgeuses - CID 124 |
| 14:13.27 | *** join/#brlcad merzo (~merzo@193.254.217.44) |
| 14:17.04 | CIA-57 | BRL-CAD: 03indianlarry * r48271 10/brlcad/trunk/src/ (8 files in 6 dirs): |
| 14:17.05 | CIA-57 | BRL-CAD: Cleanup of cases where assignment made in 'if' conditional but variable never |
| 14:17.05 | CIA-57 | BRL-CAD: used. Felt more readable leaving variable assignment so simply moved assignment |
| 14:17.05 | CIA-57 | BRL-CAD: outside of 'if'. Relates to CID 1681, 1695, 1705, 1705, 1715, 1716, 1717, 1820, |
| 14:17.05 | CIA-57 | BRL-CAD: 1822 |
| 14:20.14 | CIA-57 | BRL-CAD: 03starseeker * r48272 10/brlcad/trunk/src/conv/jack/jack-g.c: More checking for empty_model cases using return of nmg_kill_zero_length_edgeuses - CID 125 |
| 14:29.20 | CIA-57 | BRL-CAD: 03starseeker * r48273 10/brlcad/trunk/src/fb/pl-fb.c: Check return of BuildStr in pl-fb, print warning. CID 127 |
| 14:35.48 | CIA-57 | BRL-CAD: 03starseeker * r48274 10/brlcad/trunk/src/gtools/beset/population.c: Add check for rt_db_put_internal return in beset - CID 128 |
| 14:42.12 | CIA-57 | BRL-CAD: 03starseeker * r48275 10/brlcad/trunk/src/lgt/do_options.c: Add check on return of ready_Output_Device - CID 129 |
| 14:42.15 | CIA-57 | BRL-CAD: 03erikgreenwald * r48276 10/brlcad/trunk/src/conv/g-egg.c: check file and object name existance. Cov1524 |
| 14:47.12 | CIA-57 | BRL-CAD: 03starseeker * r48277 10/brlcad/trunk/src/libged/sphgroup.c: Check return of rt_db_get_internal - CID 134 |
| 14:48.27 | CIA-57 | BRL-CAD: 03erikgreenwald * r48278 10/brlcad/trunk/src/librt/primitives/metaball/metaball_tri.c: fix null check out model struct. Cov1847 |
| 14:51.01 | CIA-57 | BRL-CAD: 03erikgreenwald * r48279 10/brlcad/trunk/src/conv/g-egg.c: dup bu_exit to quell missing break warning. Cov336 |
| 14:57.49 | CIA-57 | BRL-CAD: 03starseeker * r48280 10/brlcad/trunk/src/libged/ (wdb_obj.c xpush.c): Check returns of db_dirdelete. CID 135 (wdb_obj.c case highlights the need for cleanup in libged to remove duplicate code...) |
| 15:06.46 | CIA-57 | BRL-CAD: 03starseeker * r48281 10/brlcad/trunk/src/liboptical/photonmap.c: Check return values on bu_struct_parse in photonmap.c - CID 136 |
| 15:07.31 | CIA-57 | BRL-CAD: 03erikgreenwald * r48282 10/brlcad/trunk/src/libgcv/test_bottess.c: simplify passing of intersect line segment ends, hopefully clearing up cov1749. |
| 15:10.41 | CIA-57 | BRL-CAD: 03erikgreenwald * r48283 10/brlcad/trunk/src/libgcv/test_bottess.c: extend urf array one entry (hopefully all compilers do static partial evaluation). Cov1861 |
| 15:13.55 | CIA-57 | BRL-CAD: 03n_reed * r48284 10/brlcad/trunk/src/conv/jack/jack-g.c: notify user if empty model isn't written, CID 124 |
| 15:24.48 | CIA-57 | BRL-CAD: 03starseeker * r48285 10/brlcad/trunk/src/liboptical/sh_light.c: Check the return value of rt_bound_tree - CID 138 |
| 15:26.42 | CIA-57 | BRL-CAD: 03erikgreenwald * r48286 10/brlcad/trunk/src/libgcv/bottess.c: ack, +1, not +11 ! Cov1748 |
| 15:28.10 | *** join/#brlcad Stattrav (~Stattrav@61.12.114.82) |
| 15:28.10 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) |
| 15:31.16 | CIA-57 | BRL-CAD: 03starseeker * r48287 10/brlcad/trunk/src/mged/dm-X.c: Check return value of bu_struct_parse - CID 145 |
| 15:41.34 | CIA-57 | BRL-CAD: 03starseeker * r48288 10/brlcad/trunk/src/mged/dm-X.c: Be a little better about freeing memory when returning TCL_ERROR |
| 15:42.04 | CIA-57 | BRL-CAD: 03erikgreenwald * r48289 10/brlcad/trunk/src/libgcv/bottess.c: remove untriggerable error checking. Cov1732 |
| 15:43.06 | CIA-57 | BRL-CAD: 03starseeker * r48290 10/brlcad/trunk/src/mged/dm-ogl.c: Check bu_struct_parse return for Ogl_dm. CID 146 |
| 15:48.01 | CIA-57 | BRL-CAD: 03starseeker * r48291 10/brlcad/trunk/src/mged/vparse.c: Check return of bu_struct_parse - CID 148 |
| 15:50.15 | CIA-57 | BRL-CAD: 03erikgreenwald * r48292 10/brlcad/trunk/src/libgcv/bottess.c: test return value of db_walk_tree and log on failure. Cov1724 |
| 15:54.57 | CIA-57 | BRL-CAD: 03brlcad * r48293 10/brlcad/trunk/ (39 files in 19 dirs): |
| 15:54.57 | CIA-57 | BRL-CAD: adding a new parameter to bu_file_exists() so we can capture a file descriptor |
| 15:54.57 | CIA-57 | BRL-CAD: at the same time as stat'ing whether a file exists to prevent time-of-check vs |
| 15:54.57 | CIA-57 | BRL-CAD: time-of-use vulnerabilities. right now, ignorantly assuming read-only access is |
| 15:54.57 | CIA-57 | BRL-CAD: sufficient and that an fd is better than an fp (without reason). |
| 15:57.32 | CIA-57 | BRL-CAD: 03starseeker * r48294 10/brlcad/trunk/src/rt/reshoot.c: Issue warnings for bu_struct_parse in src/rt/reshoot.c - CID 152 |
| 16:07.21 | CIA-57 | BRL-CAD: 03brlcad * r48295 10/brlcad/trunk/src/libbu/ptbl.c: usually taking size of pointer variables is suspecious, but here we actually mean it. still, use the type instead of the pointer. cov cid 105 |
| 16:26.56 | CIA-57 | BRL-CAD: 03brlcad * r48296 10/brlcad/trunk/src/lgt/reflect.c: fix defect detected by coverity (cid 513). was taking the address of a local and then using it out-of-scope. |
| 16:27.56 | CIA-57 | BRL-CAD: 03erikgreenwald * r48297 10/brlcad/trunk/src/libbn/tabdata.c: close file pointer on bad line read to prevent fd leak. Cov1877 |
| 16:28.02 | CIA-57 | BRL-CAD: 03starseeker * r48298 10/brlcad/trunk/src/libgcv/bottess.c: might as well identify the parent function. |
| 16:31.36 | CIA-57 | BRL-CAD: 03r_weiss * r48299 10/brlcad/trunk/src/libged/draw.c: Updated function 'draw_nmg_region_start' in file 'draw.c'. Changed a test for an idenity matrix from a null pointer test to testing the contents of the matrix. |
| 16:32.20 | CIA-57 | BRL-CAD: 03erikgreenwald * r48300 10/brlcad/trunk/src/libbn/tabdata.c: no need to close a file descriptor that didn't open. Cov381 |
| 16:39.10 | CIA-57 | BRL-CAD: 03r_weiss * r48301 10/brlcad/trunk/src/libged/dg_obj.c: Updated file 'dg_obj.c' function 'dgo_nmg_region_start'. Changed a test for an idenity matrix from a null pointer test to testing the contents of the matrix. |
| 16:39.22 | CIA-57 | BRL-CAD: 03starseeker * r48302 10/brlcad/trunk/src/conv/step/step-g.cpp: missing NULL param |
| 16:52.41 | CIA-57 | BRL-CAD: 03r_weiss * r48303 10/brlcad/trunk/src/mged/dodraw.c: Updated file 'dodraw.c' function 'mged_nmg_region_start'. Changed test for an identity matrix from a null pointer test to testing the contents of the matrix. |
| 16:56.13 | CIA-57 | BRL-CAD: 03brlcad * r48304 10/brlcad/trunk/src/proc-db/menger.c: missing NULL |
| 17:00.56 | CIA-57 | BRL-CAD: 03starseeker * r48305 10/brlcad/trunk/src/libdm/labels.c: Check rt_db_get_internal - CID 1723 |
| 17:01.23 | CIA-57 | BRL-CAD: 03erikgreenwald * r48306 10/brlcad/trunk/src/libbn/tcl.c: comment out unreachable noise code pending further review. Cov186 |
| 17:02.00 | CIA-57 | BRL-CAD: 03brlcad * r48307 10/brlcad/trunk/src/proc-db/menger.c: ah, it put the NULL, but wrong place |
| 17:04.41 | CIA-57 | BRL-CAD: 03erikgreenwald * r48308 10/brlcad/trunk/src/libbn/tcl.c: disable noise_type def |
| 17:11.40 | CIA-57 | BRL-CAD: 03indianlarry * r48309 10/brlcad/trunk/src/ (conv/step/OpenNurbsInterfaces.cpp proc-db/csgbrep.cpp): Added NULL checks prior to usage to resolve REVERSE_NULL checks for CID 1879, 1880, 1881, 1882 |
| 17:12.06 | CIA-57 | BRL-CAD: 03n_reed * r48310 10/brlcad/trunk/src/fb/pl-fb.c: return void from BuildStr rather than always returning true, CID 127 |
| 17:12.46 | CIA-57 | BRL-CAD: 03starseeker * r48311 10/brlcad/trunk/src/libged/search.c: Check return of db_string_to_path - don't do anything unless we get a sane result from the path conversion. CID 1725 |
| 17:31.57 | CIA-57 | BRL-CAD: 03n_reed * r48312 10/brlcad/trunk/src/ (conv/obj-g.c libgcv/wfobj/tri_face.c): propagate faceuse creation failure and skip faces that don't yield a faceuse |
| 17:34.14 | CIA-57 | BRL-CAD: 03starseeker * r48313 10/brlcad/trunk/src/conv/step/STEPWrapper.cpp: Check return of brep validity test - CID 1836 |
| 17:38.16 | CIA-57 | BRL-CAD: 03starseeker * r48314 10/brlcad/trunk/src/mged/setup.c: Check Bu_Init return - CID 1726 |
| 17:38.50 | CIA-57 | BRL-CAD: 03erikgreenwald * r48315 10/brlcad/trunk/src/librt/primitives/ars/ars.c: set min/max to quell coverity (even though the next line sets them via a func). Cov1930 |
| 17:44.28 | CIA-57 | BRL-CAD: 03erikgreenwald * r48316 10/brlcad/trunk/src/librt/vlist.c: fill in cargs in case rt_uplot_get_*args does not fill. Cov1928 |
| 17:47.34 | CIA-57 | BRL-CAD: 03brlcad * r48317 10/brlcad/trunk/src/lgt/reflect.c: ws, style, indent overhaul to conform with package conventions |
| 17:55.51 | CIA-57 | BRL-CAD: 03starseeker * r48318 10/brlcad/trunk/src/librt/search.c: Make sure we've got something initializing all the fields of OPTION - CID 1619 |
| 18:00.17 | starseeker | hmm - http://www.ibm.com/developerworks/library/s-buffer-defend.html |
| 18:10.52 | CIA-57 | BRL-CAD: 03starseeker * r48319 10/brlcad/trunk/src/libged/red.c: Check the value of dp to see if it is RT_DIR_NULL (also add some missing frees for a vls that has been inited when calling return in several places.) CID 398 |
| 18:14.45 | CIA-57 | BRL-CAD: 03starseeker * r48320 10/brlcad/trunk/src/libged/red.c: close fp before returning - CID 496 |
| 18:20.47 | CIA-57 | BRL-CAD: 03starseeker * r48321 10/brlcad/trunk/src/libged/ged.c: Check if filename is NULL - CID 1551 |
| 18:23.37 | CIA-57 | BRL-CAD: 03starseeker * r48322 10/brlcad/trunk/src/libged/gqa.c: fclose before returning error - CID 470 |
| 18:58.32 | CIA-57 | BRL-CAD: 03erikgreenwald * r48323 10/brlcad/trunk/src/liboptical/sh_plastic.c: test for pp==NULL early to avoid forward null issue. Cov1744 |
| 19:08.33 | CIA-57 | BRL-CAD: 03brlcad * r48324 10/brlcad/trunk/src/libbu/temp.c: secure the temp file with only user read-write permissions so we don't let snooping eyes see what we're doing or get access if umask is nefarious. fixed in response to coverity scan (cov cid 1255) SECURE_TEMP check. |
| 19:14.39 | CIA-57 | BRL-CAD: 03erikgreenwald * r48325 10/brlcad/trunk/src/libged/fracture.c: eliminate unused assign. Cov1703 |
| 19:19.35 | CIA-57 | BRL-CAD: 03erikgreenwald * r48326 10/brlcad/trunk/src/libged/comb.c: test value of dp to quell unused value warning from Cov1702 |
| 19:21.11 | CIA-57 | BRL-CAD: 03brlcad * r48327 10/brlcad/trunk/src/other/step/src/clstepcore/complexSupport.h: strcpy() is unsafe to use given the 'n' argument is a parameter to the function. use strncpy() instead so we can always null-terminate the result. issue detected in brl-cad coverity scan (cov cid 1925) |
| 19:34.44 | CIA-57 | BRL-CAD: 03erikgreenwald * r48328 10/brlcad/trunk/src/liboptical/sh_scloud.c: set incident light to 0,0,0 (Cov1623) |
| 19:34.50 | CIA-57 | BRL-CAD: 03n_reed * r48329 10/brlcad/trunk/src/ (5 files in 3 dirs): default code was being appended to rule code to prevent fall-through; now requiring a cl flag to avoid generating unreachable code |
| 19:38.36 | *** join/#brlcad merzo (~merzo@183-199-133-95.pool.ukrtel.net) |
| 19:42.20 | CIA-57 | BRL-CAD: 03brlcad * r48330 10/brlcad/trunk/src/fb/gif2fb.c: |
| 19:42.21 | CIA-57 | BRL-CAD: if the gif header is short and we're in a verbose debug mode, the magic number |
| 19:42.21 | CIA-57 | BRL-CAD: gets printed. the character array isn't null-terminated, though, so copy it to |
| 19:42.21 | CIA-57 | BRL-CAD: a string buffer for clarity (even in spite of using %.6s). should quell cov cid |
| 19:42.21 | CIA-57 | BRL-CAD: 1457. |
| 19:43.26 | CIA-57 | BRL-CAD: 03erikgreenwald * r48331 10/brlcad/trunk/src/liboptical/sh_toyota.c: close file handle on exit. Cov500 |
| 19:49.47 | CIA-57 | BRL-CAD: 03erikgreenwald * r48332 10/brlcad/trunk/src/liboptical/photonmap.c: Push and Pop do not seem to be used, so eliminate them. Also happens to fix Cov431. |
| 19:52.56 | CIA-57 | BRL-CAD: 03erikgreenwald * r48333 10/brlcad/trunk/src/liboptical/photonmap.c: verify irradiance cache info on read. Cov1483 |
| 19:53.49 | CIA-57 | BRL-CAD: 03brlcad * r48334 10/brlcad/trunk/src/fbed/fbed.c: leave room for a terminating nul char in the length calculations, and always terminate at the end of our fread memory instead of just at the end of the buffer. this fixes a coverity STRING_NULL defect (cov cid 1458). |
| 19:55.25 | CIA-57 | BRL-CAD: 03erikgreenwald * r48335 10/brlcad/trunk/src/liboptical/sh_stack.c: test sp for null before dereferencing. Cov1759 |
| 19:56.08 | CIA-57 | BRL-CAD: 03brlcad * r48336 10/brlcad/trunk/src/fbed/fbed.c: remove argsused comment |
| 19:56.23 | CIA-57 | BRL-CAD: 03erikgreenwald * r48337 10/brlcad/trunk/src/liboptical/sh_stack.c: test sp for null before dereferencing. Cov1760 |
| 19:56.57 | CIA-57 | BRL-CAD: 03erikgreenwald * r48338 10/brlcad/trunk/src/liboptical/sh_stack.c: test sp for null before dereferencing. Cov1761 |
| 19:57.49 | CIA-57 | BRL-CAD: 03erikgreenwald * r48339 10/brlcad/trunk/src/liboptical/sh_stack.c: add return value |
| 20:04.15 | CIA-57 | BRL-CAD: 03brlcad * r48340 10/brlcad/trunk/src/libged/human.c: pass the dude around as a pointer instead of a copy. might have intended a copy so still need to regression test this one, but should address coverity PASS_BY_VALUE check (cov cid 430). |
| 20:08.10 | CIA-57 | BRL-CAD: 03brlcad * r48341 10/brlcad/trunk/src/librt/primitives/ (half/half.c hf/hf.c): bah, add deprecation statements to hf.c .. not half.c |
| 20:10.12 | CIA-57 | BRL-CAD: 03erikgreenwald * r48342 10/brlcad/trunk/src/conv/obj-g.c: test to make sure vert allocation succeeded. Cov1757 |
| 20:12.34 | CIA-57 | BRL-CAD: 03erikgreenwald * r48343 10/brlcad/trunk/src/conv/obj-g.c: verify nmg model is generated. Cov1756 |
| 20:29.48 | CIA-57 | BRL-CAD: 03erikgreenwald * r48344 10/brlcad/trunk/src/proc-db/vegetation.c: test segList before deref. Cov569 |
| 20:37.36 | CIA-57 | BRL-CAD: 03erikgreenwald * r48345 10/brlcad/trunk/src/proc-db/molecule.c: test atom value before using as index in array. Cov1487 |
| 20:40.15 | CIA-57 | BRL-CAD: 03erikgreenwald * r48346 10/brlcad/trunk/src/proc-db/contours.c: test npts to verify a valid positive number for looping. Cov1486 |
| 20:51.24 | CIA-57 | BRL-CAD: 03starseeker * r48347 10/brlcad/trunk/src/librt/primitives/bot/tie_kdtree.c: split is passed in as a pointer, and all other code seems to be working with the value pointed to, not the pointer held by split itself - assume the goal here was not to squash the pointer value. CID 235. |
| 20:52.47 | CIA-57 | BRL-CAD: 03erikgreenwald * r48348 10/brlcad/trunk/src/proc-db/menger.c: fix bit test logic to actually test. Cov1728 |
| 20:55.14 | CIA-57 | BRL-CAD: 03erikgreenwald * r48349 10/brlcad/trunk/src/proc-db/menger.c: fix bit test logic to actually test. Cov1729 |
| 21:06.18 | CIA-57 | BRL-CAD: 03starseeker * r48350 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: Don't try to print keep_eu if it's NULL - just print a log message that it is NULL. Debugging case only. CID 237 |
| 21:07.27 | CIA-57 | BRL-CAD: 03brlcad * r48351 10/brlcad/trunk/src/libbu/file.c: |
| 21:07.27 | CIA-57 | BRL-CAD: fix a TOCTOU time-of-check, time-of-use race condition reported by coverity now |
| 21:07.27 | CIA-57 | BRL-CAD: that we can capture a fild descriptor from bu_file_exists(). with that, now all |
| 21:07.27 | CIA-57 | BRL-CAD: of the stat calls will act on the same file. might still call remove() on a |
| 21:07.27 | CIA-57 | BRL-CAD: different path, but there's no way to unlink a file descriptor. (cov cid 1800) |
| 21:11.23 | CIA-57 | BRL-CAD: 03n_reed * r48352 10/brlcad/trunk/src/conv/comgeom/cvt.c: more checking of user-supplied filenames before using them, CID 1771 |
| 21:17.52 | CIA-57 | BRL-CAD: 03brlcad * r48353 10/brlcad/trunk/src/libbu/progname.c: default prefix on crash logs files with (BRL-CAD) instead of (unknown) so it's clear where they came from even when we don't know the application's name. |
| 21:19.35 | CIA-57 | BRL-CAD: 03starseeker * r48354 10/brlcad/trunk/src/burst/prnt.c: Protect p assignment from the case where p is NULL. CID 238 |
| 21:20.39 | CIA-57 | BRL-CAD: 03starseeker * r48355 10/brlcad/trunk/src/burst/prnt.c: Whoops - NULL -> NUL |
| 21:27.57 | CIA-57 | BRL-CAD: 03brlcad * r48356 10/brlcad/trunk/TODO: g-nff crashes |
| 21:28.01 | CIA-57 | BRL-CAD: 03starseeker * r48357 10/brlcad/trunk/src/libfb/fb_util.c: Coverity wants us to do something about the NULL case if we're testing for it - the fb_ functions always seem to return 0 - just do that if ifp is NULL, rather than calling other functions. CID 239, 240 |
| 21:32.13 | CIA-57 | BRL-CAD: 03brlcad * r48358 10/brlcad/trunk/TODO: g-dot seems to be having trouble too |
| 21:33.33 | CIA-57 | BRL-CAD: 03starseeker * r48359 10/brlcad/trunk/src/librt/shoot.c: No fp, no function calling - Bad Things likely if we do. CID 241 |
| 21:35.00 | CIA-57 | BRL-CAD: 03indianlarry * r48360 10/brlcad/trunk/src/conv/step/ (28 files): |
| 21:35.01 | CIA-57 | BRL-CAD: Added initialization for all class fields in constructor to take care of |
| 21:35.01 | CIA-57 | BRL-CAD: UNINIT_CTOR for CIDS: |
| 21:35.01 | CIA-57 | BRL-CAD: 1935,1939,1938,1941,1940,1944,1943,1946,1945,1949,1948,1951,1950,1953,1952,1957,1947,1959,1958,1960,1954,1962,1961,1964,1963,1965,1942,1967,1966,1969,1968,1971,1970,1972,1936,1974,1973,1976,1975,1980,1979,1982,1981,1983 |
| 23:07.33 | CIA-57 | BRL-CAD: 03starseeker * r48361 10/brlcad/trunk/src/libged/bot_dump.c: |
| 23:07.33 | CIA-57 | BRL-CAD: Check if we have a binary file type and don't have STL as the type - in that |
| 23:07.33 | CIA-57 | BRL-CAD: case, we won't have a valid fp and continuing on to the switch statement is a |
| 23:07.33 | CIA-57 | BRL-CAD: Bad Idea - instead, inform the user we have a binary+non-STL situation and |
| 23:07.33 | CIA-57 | BRL-CAD: return. CID 243 |
| 23:24.28 | CIA-57 | BRL-CAD: 03starseeker * r48362 10/brlcad/trunk/src/librt/primitives/nmg/nmg_rt_isect.c: Check for the null myhit case - CID 245 |
| 23:28.32 | CIA-57 | BRL-CAD: 03starseeker * r48363 10/brlcad/trunk/src/librt/primitives/nmg/nmg_plot.c: Don't do something that needs to check fp if fp has been NULLed out. CID 247 |
| 23:32.09 | CIA-57 | BRL-CAD: 03starseeker * r48364 10/brlcad/trunk/src/librt/primitives/nmg/nmg_inter.c: Make sure we have this before we try bu_logging it. CID 248 |
| 23:35.31 | CIA-57 | BRL-CAD: 03starseeker * r48365 10/brlcad/trunk/src/conv/g-vrml.c: If we have no path, we're done here - return. CID 250 |
| 23:38.24 | CIA-57 | BRL-CAD: 03starseeker * r48366 10/brlcad/trunk/src/conv/iges/revolve.c: Check for the NULL case first - CID 251 |
| 23:42.32 | CIA-57 | BRL-CAD: 03starseeker * r48367 10/brlcad/trunk/src/conv/iges/showtree.c: Make sure we've got ptr->parent - may want to revisit and see if we really need to verify it earlier... CID 252 |
| 23:57.29 | CIA-57 | BRL-CAD: 03starseeker * r48368 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: (log message trimmed) |
| 23:57.29 | CIA-57 | BRL-CAD: This one's a bit more interesting. Coverity doesn't think the tol->dist |
| 23:57.29 | CIA-57 | BRL-CAD: comparison with the -1 settings of dist1 and dist2 is enough to guanantee a |
| 23:57.29 | CIA-57 | BRL-CAD: continue in the bad case, and if that's so then next_fus->vp being check for |
| 23:57.29 | CIA-57 | BRL-CAD: NULL earlier and then being used may imply a problem. I doubt we're getting |
| 23:57.29 | CIA-57 | BRL-CAD: negative tolerances, but since the tol type is double it's not forbidden. |
| 23:57.30 | CIA-57 | BRL-CAD: Rather than depend on the -1 comparison, set a control variable that will |