| 01:29.08 | *** join/#brlcad R0b0t1 (n=Enigma@unaffiliated/r0b0t1) |
| 01:29.55 | *** join/#brlcad talcite_ (n=matthew@bas2-toronto21-1279331972.dsl.bell.ca) |
| 03:36.38 | *** join/#brlcad talcite__ (n=matthew@bas2-toronto21-1242351444.dsl.bell.ca) |
| 05:19.48 | *** join/#brlcad talcite_ (n=matthew@bas2-toronto21-1242310260.dsl.bell.ca) |
| 06:33.32 | *** join/#brlcad talcite__ (n=matthew@bas2-toronto21-1279332088.dsl.bell.ca) |
| 07:44.34 | *** join/#brlcad talcite_ (n=matthew@bas2-toronto21-1279331635.dsl.bell.ca) |
| 07:49.14 | CIA-38 | BRL-CAD: 03brlcad * r37096 10/brlcad/trunk/src/librt/primitives/pipe/ (pipe.c pipe_brep.cpp): big cleanup of formatting (vmath macros missing semicolon), mass quellage on unused params and shodowing. |
| 08:01.08 | CIA-38 | BRL-CAD: 03brlcad * r37097 10/brlcad/trunk/src/librt/primitives/pnts/pnts.c: printf family promotes to double, so no %lf (for c90). use %f instead. other minor quelling. |
| 08:12.07 | *** join/#brlcad talcite (n=matthew@bas2-toronto21-1279331635.dsl.bell.ca) |
| 08:24.40 | *** join/#brlcad talcite (n=matthew@bas2-toronto21-1279331635.dsl.bell.ca) |
| 13:38.53 | CIA-38 | BRL-CAD: 03brlcad * r37098 10/brlcad/trunk/src/librt/primitives/ (poly/poly.c rec/rec.c): quell verbose warnings. remove register keyword, quell and check parameters. |
| 14:11.08 | CIA-38 | BRL-CAD: 03brlcad * r37099 10/brlcad/trunk/src/librt/primitives/ (5 files in 3 dirs): more warnings being quelled. unused params/vars and extra checks. |
| 14:23.16 | CIA-38 | BRL-CAD: 03brlcad * r37100 10/brlcad/trunk/src/librt/primitives/ (15 files in 14 dirs): invert the verbose logic test so we can reduce depth/complexity. just return early. remove some more register keywording while we're at it. |
| 14:36.19 | CIA-38 | BRL-CAD: 03brlcad * r37101 10/brlcad/trunk/src/librt/primitives/ (4 files in 3 dirs): more warnings |
| 16:29.23 | *** join/#brlcad Nohla (n=jesica@168.226.178.253) |
| 16:49.40 | *** join/#brlcad jesica__ (n=jesica@168.226.178.122) |
| 17:02.40 | *** join/#brlcad Nohla (n=jesica@168.226.178.217) |
| 17:37.13 | CIA-38 | BRL-CAD: 03brlcad * r37102 10/brlcad/trunk/src/librt/primitives/ (submodel/submodel.c superell/superell.c): quelling unused params, added checks, removed register keyword. |
| 17:39.56 | CIA-38 | BRL-CAD: 03brlcad * r37103 10/brlcad/trunk/src/librt/primitives/table.c: eliminate the crudgery of the old _nul_ placeholder callbacks and expand out the function table. replace the _nul_ with NULL. one step closer to callback wrappers. |
| 17:43.47 | *** join/#brlcad Nohla (n=jesica@168.226.179.109) |
| 17:48.51 | CIA-38 | BRL-CAD: 03brlcad * r37104 10/brlcad/trunk/ (include/raytrace.h src/libged/put.c src/libged/wdb_obj.c): remove references to rt_nul_make |
| 18:12.07 | CIA-38 | BRL-CAD: 03brlcad * r37105 10/brlcad/trunk/src/librt/primitives/tgc/ (tgc.c tgc_brep.cpp): good gravy tgc.. eliminate a slew of exact == 0.0 floating point comparisons. |
| 18:16.28 | ``Erik | O.o |
| 18:17.49 | ``Erik | in my old age, I'm gaining more and more appreciation for stp |
| 18:23.58 | brlcad | yeah kids, stay off grandpa's lawn |
| 18:24.20 | CIA-38 | BRL-CAD: 03brlcad * r37106 10/brlcad/trunk/src/librt/primitives/ (tor/tor.c vol/vol.c): !woo hoo! the last of the primitives, now all free of verbose warnings. added usual unused parameter checks and dequelled a couple exact floating point comparisons |
| 18:24.22 | ``Erik | :D |
| 18:24.34 | ``Erik | seirously? all squashed? O.O |
| 18:33.56 | brlcad | that be all of them |
| 18:34.05 | brlcad | there are still about a dozen files in librt though |
| 18:34.21 | brlcad | alphabetical, those after 'p' (primitives dir) |
| 18:34.37 | brlcad | librt is almost fully clean |
| 18:36.20 | CIA-38 | BRL-CAD: 03brlcad * r37107 10/brlcad/trunk/src/librt/roots.c: |
| 18:36.20 | CIA-38 | BRL-CAD: odd exact floating point comparison here that dates back to 1986. the intent |
| 18:36.20 | CIA-38 | BRL-CAD: looks like a simple comparison of b-diff == b being that the diff is simply so |
| 18:36.20 | CIA-38 | BRL-CAD: near zero that it's below computation tolerance to represent, which is |
| 18:36.21 | CIA-38 | BRL-CAD: SMALL_FASTF. additionally the magic 1.0e-5 that was added for SGI is tightened |
| 18:36.23 | CIA-38 | BRL-CAD: up to SQRT_SMALL_FASTF. obviously needs testing. |
| 18:54.00 | CIA-38 | BRL-CAD: 03brlcad * r37108 10/brlcad/trunk/src/librt/shoot.c: |
| 18:54.00 | CIA-38 | BRL-CAD: modify the spatial position traversal to do what the comment says, progressing |
| 18:54.00 | CIA-38 | BRL-CAD: the smallest amount possible. we progress by SQRT_SMALL_FASTF (1e-39/1e-18) |
| 18:54.00 | CIA-38 | BRL-CAD: instead of the hardware tol SMALL_FASTF (1e-77/1e-37) so as to be 'slightly' |
| 18:54.00 | CIA-38 | BRL-CAD: closer to what we were stepping (1e-14). obviously needs testing.. |
| 18:56.56 | brlcad | exciting! |
| 18:57.01 | brlcad | giggity giggity |
| 18:57.43 | ``Erik | now make nmg not suck |
| 18:57.44 | ``Erik | :D |
| 18:57.45 | ``Erik | *duck* |
| 18:58.03 | brlcad | i actually grew a new appreciation for nmg whilest cleaning it's warnings |
| 18:58.17 | brlcad | that's on the refactor block after functab |
| 18:58.26 | ``Erik | it's got some crazy smart person stuff in there, but the details and implementation are.. uh... not so hot |
| 18:58.27 | brlcad | pull back to libnmg |
| 18:58.56 | brlcad | can count the remaining librt files to quell on two hands! |
| 18:59.03 | ``Erik | is pissing off his cats and neighbors by singing along to alice in chains songs :D |
| 18:59.12 | ``Erik | with only 30 fingers per hand? |
| 18:59.37 | brlcad | one tequila two tequila |
| 18:59.41 | ``Erik | the '91 moore session was.. wow. |
| 19:00.26 | ``Erik | http://www.youtube.com/watch?v=l9jX1KAKp78&feature=related |
| 19:00.51 | ``Erik | when I lived there, one of the big radio stations (99.9, kisw) kept playing the show... like... all of the show |
| 19:01.24 | ``Erik | boom, here's 90 minutes of AiC doin' their thang, no commercials or anything |
| 19:03.48 | brlcad | gasp! .. drumroll |
| 19:04.00 | ``Erik | all done? |
| 19:04.36 | ``Erik | w00t to de 00t |
| 19:04.57 | ``Erik | now I'll go compile it somewhere that the errors are massive and all over |
| 19:05.05 | ``Erik | fbsd tends to be bitchier than osX or leenewx |
| 19:05.45 | CIA-38 | BRL-CAD: 03brlcad * r37109 10/brlcad/trunk/ (4 files in 2 dirs): almost there, almost there... |
| 19:07.59 | poolio | ooo, new year cleaning? |
| 19:08.45 | ``Erik | yo ben, how's it going? gradjimucated yet? |
| 19:08.57 | poolio | heh, still got a year and a half but it's going well |
| 19:10.19 | poolio | how are things with you? have a good new year? |
| 19:10.48 | ``Erik | been a hell of a year for me. :/ |
| 19:11.26 | ``Erik | almost quit, moved halfway across the country, and got married, btu *shrug* it didn't happen, now I'm back in the saddle :) |
| 19:12.15 | poolio | ah well, there's always this year :) |
| 19:12.38 | ``Erik | made for some odd conversations... "yeh, uh, I've decided I'm NOT seeling my house, apologies for wasting your time" "uh, yeh, you know when I said I was quitting? um, I'd still like to work here, if that's ok" |
| 19:12.59 | ``Erik | now I'm trying to convince http://cdn.okcimg.com/php/load_okc_image.php/images/16/150x150/558x800/0x0/438x438/0/14337150525155587730.jpeg to punch me in the head :D |
| 19:14.10 | poolio | oy, that's no fun |
| 19:14.16 | ``Erik | are you going to apply to next years gsoc? |
| 19:15.24 | poolio | probably not... I've been doing a lot of machine learning + neuroscience research and will probably be continuing with that |
| 19:15.43 | ``Erik | machine learning and neuroscience? lots of NN type stuff? |
| 19:16.00 | poolio | but I was just looking into using BRL-CAD for some fancy visualizations |
| 19:16.03 | ``Erik | I think that a ga generated nn would be ... awesome... I just haven't seen anyone try it |
| 19:16.51 | poolio | not really any NNs actually, I've mainly been working on dynamic bayesian networks (HMMs, kalman filters, etc...) for neural prosthetics |
| 19:17.03 | ``Erik | cool |
| 19:17.17 | poolio | many people have tried GA + NN but I don't remember any names offhand |
| 19:17.19 | ``Erik | graphviz isn't a player for viz? |
| 19:17.49 | ``Erik | hm, ten years ago, in my AI course, it seemed like a damn obvious step that no one did |
| 19:18.15 | ``Erik | use a ga to generate an optimized nn.... |
| 19:18.35 | ``Erik | mebbe folk have tried it and it's just not good, I dunno, I didn't actually try it :) |
| 19:19.02 | ``Erik | if it was obvious to me, I'm sure many folk smarter than I have tried it and we don't see it cuz there's a fault |
| 19:19.48 | poolio | well, many people have used it with some amount of success, but NNs have been out of style for the past few years |
| 19:20.05 | ``Erik | oh, I'm out of date :) |
| 19:20.17 | ``Erik | what's the new hotness for processing fuzzy data? |
| 19:20.18 | poolio | they're making a come back under the name "deep belief networks" |
| 19:20.52 | poolio | It depends what you want to do with the data, but for classification support vector machines (SVMs) are hip |
| 19:21.40 | ``Erik | *google* *wiki* |
| 19:22.28 | CIA-38 | BRL-CAD: 03brlcad * r37110 10/brlcad/trunk/src/librt/ (brep_test.cpp nurb_example.c primitives/xxx/xxx.c wdb.c): |
| 19:22.28 | CIA-38 | BRL-CAD: awesome. with this commit, librt's C code is now free of all verbose |
| 19:22.28 | CIA-38 | BRL-CAD: compilation warnings (on 32-bit osx). quellage includes unused params/vars, |
| 19:22.28 | CIA-38 | BRL-CAD: shadows, and added tests. removed the ray parameter from rt_tcl_pr_hit(). |
| 19:22.39 | ``Erik | wow, thanks... when I was in school, palm was radical and new, they made nn's do something worth doing... but linux was a whelp, nt was hot new sexiness, solaris 7 was keen, ... |
| 19:22.51 | poolio | brlcad: woot! |
| 19:23.26 | poolio | ``Erik: yeah, machine learning is a constantly evolving field |
| 19:23.29 | ``Erik | now I'm gonna read up and decide that it's just new names on old ideas, but now I'll have the new names... and can refer to the 50's crud |
| 19:23.50 | brlcad | howdy poolio! merry new year, happy christmas |
| 19:24.15 | poolio | it almost always is the same idea renamed...or an idea renamed from another field |
| 19:24.17 | ``Erik | <-- codes in lisp for fun these days... :) |
| 19:24.29 | poolio | ahoy brlcad! happy holidays to you too |
| 19:24.43 | brlcad | ``Erik: yeah, verbose on a 64-bit is probably going to expose a slew of type conversion warnings, and I've got a linux box set to c99 which is a bitch to quell |
| 19:25.06 | brlcad | but that's at least 75% complete now, and almost enough to turn the flag on the dir :) |
| 19:25.06 | poolio | ``fun'' eh? |
| 19:25.07 | ``Erik | my fbsd boxen are 32b, but they still expose asstons more of issues than starseekers leenewxen |
| 19:25.23 | ``Erik | how very LaTeX in your phrasing |
| 19:25.36 | brlcad | poolio: hah, ... it was ... for the first 100 hours |
| 19:25.37 | poolio | ah whoops...school requires so much typesetting :) |
| 19:25.51 | ``Erik | yes, fun, couple vdeo games I'm working on... :) |
| 19:26.01 | poolio | video games in LISP? |
| 19:26.01 | ``Erik | one is ucw based, web thingie |
| 19:26.09 | brlcad | the second and third, not so much .. then the last 8 hours it got exciting again ;) |
| 19:26.19 | ``Erik | the other effort is lisp at the core, using ogre and ode |
| 19:26.44 | ``Erik | um, there've been several lisp based video games... they just don't brag that they're lisp... :) |
| 19:27.03 | ``Erik | abuse, crash bandicoot, ... |
| 19:27.14 | poolio | brlcad: heh, I don't think I ever made it past 10 hours |
| 19:28.00 | ``Erik | sean: fbsd will break on the compile in new and interesting (but legit) ways |
| 19:28.14 | ``Erik | mebbe not brlcad.org, but crit will |
| 19:28.17 | ``Erik | :) |
| 19:28.25 | brlcad | poolio: so future devs don't have to endure nearly as much pain as *cough* some have ;) |
| 19:28.44 | ``Erik | hop on crit and try :D |
| 19:28.53 | brlcad | still a LOT more to go, but having the core strict clean will help with long-term maintenance |
| 19:29.14 | brlcad | ``Erik: you mean with strict on? |
| 19:29.18 | ``Erik | yeah |
| 19:29.22 | brlcad | i'm sure bsd will |
| 19:29.36 | brlcad | linux is up next, it's pretty damn noisy |
| 19:29.40 | brlcad | 64-bit |
| 19:29.57 | ``Erik | one of the reasons I fell in love with bsd was that it was so aggressive about correctness, where linux was very loose and easy |
| 19:30.20 | poolio | brlcad: heh, you should just leave it as a rite of passage |
| 19:30.34 | ``Erik | when I started caring about hpux and solaris, taking my lumps up front in bsd was very ... least painful |
| 19:30.40 | ``Erik | oh, and aix |
| 19:30.47 | brlcad | ah, wonderful.. "No space left on device" .. world class, I tell ya |
| 19:31.00 | brlcad | poolio: there are still plenty of other rites of passage ;) |
| 19:31.09 | brlcad | just as painful |
| 19:31.25 | ``Erik | hah, "look at nmg" :D |
| 19:31.58 | poolio | or my personal favorite, "complete the paperwork" |
| 19:32.10 | poolio | although I suppose a lot of devs can skip that step :) |
| 19:32.15 | brlcad | bsd at least will do bu/bn and a few others strict now.. solaris build doesn't even get that far |
| 19:32.17 | ``Erik | paperwhat? |
| 19:32.26 | ``Erik | solaris using sunw or gcc? |
| 19:33.10 | ``Erik | do we have an irix box anymore? I have an o2 bookend if we need |
| 19:34.17 | brlcad | gcc |
| 19:34.34 | brlcad | no irix |
| 19:35.37 | ``Erik | we lost the irix server, ... but I will not surrender that o2 :) |
| 19:36.15 | ``Erik | best bookend ever |
| 19:36.28 | ``Erik | and only what, 6k in its prime? |
| 19:37.18 | brlcad | yeah, 5-8k |
| 19:37.32 | brlcad | < $100 on ebay now |
| 19:38.37 | ``Erik | twinky has an o200, or had one in his closet |
| 19:39.36 | ``Erik | sits around feeling old :) |
| 19:39.59 | brlcad | well, look on the bright side |
| 19:40.03 | brlcad | you're not nearly as old as you look |
| 19:40.23 | ``Erik | hey, I get carded all the time |
| 19:41.16 | poolio | aha, even I don't get carded anymore :) |
| 19:42.24 | ``Erik | yeah, see, I'm 33 and I get carded all the time |
| 19:42.52 | ``Erik | pisses me off... when I'm out with a girl, they're always "wow, that' awesome, I'm so jealous" ... no it's annoying |
| 19:56.21 | CIA-38 | BRL-CAD: 03brlcad * r37111 10/brlcad/trunk/src/librt/nurb_example.c: wow, only warning to come up on 64-bit linux (rhel5) with c99 set. less work than bu and bn. |
| 19:57.21 | CIA-38 | BRL-CAD: 03brlcad * r37112 10/brlcad/trunk/src/librt/Makefile.am: linux and macosx are now warning-free. that's more than the other libs got before strict was enabled, so let others in on the quelling fun. |
| 19:58.23 | brlcad | ``Erik: it's probably more the serial murderer look, they want a name in case they see your face again in the news |
| 20:02.10 | CIA-38 | BRL-CAD: 03brlcad * r37113 10/brlcad/trunk/src/libbu/bitv.c: reduce. -3 +2. net gain. |
| 20:40.23 | *** join/#brlcad R0b0t1 (n=Enigma@unaffiliated/r0b0t1) |
| 20:51.05 | *** join/#brlcad louipc (n=louipc@75-119-247-24.dsl.teksavvy.com) |
| 20:59.50 | *** join/#brlcad _sushi_ (n=_sushi_@84-72-9-218.dclient.hispeed.ch) |
| 20:59.58 | _sushi_ | happy new year all! |
| 21:03.33 | brlcad | happy new year _sushi_ |
| 21:23.16 | starseeker | updates and gives Gentoo a go at librt strict... |
| 21:23.32 | starseeker | (must take brake from working on closet...) |
| 21:24.14 | starseeker | brlcad: did ``Erik frag somebody again? :-P |
| 21:25.45 | starseeker | those BSD vs. world brawls can get intense... |
| 21:43.32 | starseeker | um |
| 21:43.43 | starseeker | ../../../brlcad/src/librt/db5_io.c: In function ârt_db_cvt_to_external5â: |
| 21:43.43 | starseeker | ../../../brlcad/src/librt/db5_io.c:1251: error: the address of âbodyâ will always evaluate as âtrueâ |
| 21:43.46 | starseeker | ../../../brlcad/src/librt/db5_io.c:1256: error: the address of âattributesâ will always evaluate as âtrueâ |
| 21:43.49 | starseeker | ../../../brlcad/src/librt/db5_io.c: In function ârt_db_put_internal5â: |
| 21:43.52 | starseeker | ../../../brlcad/src/librt/db5_io.c:1426: error: the address of âextâ will always evaluate as âtrueâ |
| 21:44.09 | starseeker | is it complaining because it thinks the checks are useless? |
| 21:47.23 | _sushi_ | starseeker: the compiler must think these things will never be NULL |
| 21:47.40 | _sushi_ | Maybe something like int a; int *b=&a; if (b)... ? |
| 21:47.47 | starseeker | maybe... |
| 21:48.16 | starseeker | wonders if body, attributes and ext are supposed to be pointers to structs with the BU_* routines handling memory... |
| 21:48.19 | starseeker | tries that... |
| 22:03.51 | starseeker | hmm... it doesn't like hits in ars.c, but I'm not quite sure how to approach that one... |
| 22:05.14 | starseeker | I suppose it should be a malloc of the amount of memory needed for RT_ARS_MAXHITS rather than struct hit hits[RT_ARS_MAXHITS] ... |
| 22:05.57 | starseeker | looks at clock and realizes he has to get back to the closet... |
| 22:05.59 | starseeker | arrgh |
| 22:06.41 | starseeker | brlcad: I'll go ahead and commit what I've got so far - if it's wrong go ahead and revert and I'll take another swipe at it later |
| 22:08.19 | CIA-38 | BRL-CAD: 03starseeker * r37114 10/brlcad/trunk/src/librt/ (6 files in 2 dirs): Quellage in librt on Gentoo linux - this isn't all of it but commit what I've done so far to see if I'm doing something The Wrong Way... - haven't tested yet because I haven't gotten a complete librt build yet. |
| 22:09.34 | brlcad | that'll segfault |
| 22:10.14 | brlcad | they're not pointers otherwise you'd have to malloc/free them .. if it's just a pointer, you can't call INIT() yet |
| 22:11.35 | starseeker | ah |
| 22:12.49 | brlcad | have to unroll the macro to see what it's actually complaining about |
| 22:12.55 | starseeker | k |
| 22:13.11 | brlcad | there are a slew of similar BU_CK* macros that preceed it, so something about BU_CK_EXTERNAL |
| 22:13.44 | brlcad | BU_CK_EXTERNAL -> BU_CKMAG -> if statement and a call to bu_badmagic() |
| 22:14.13 | CIA-38 | BRL-CAD: 03starseeker * r37115 10/brlcad/trunk/src/librt/ (6 files in 2 dirs): Undo librt changes - need to delve into macro land. |
| 22:14.57 | brlcad | ah, I see |
| 22:15.03 | brlcad | it's exactly what it says |
| 22:15.22 | brlcad | it's an object on the stack, so the address is guaranteed to be non-null |
| 22:15.37 | starseeker | ah - so the check is unnecessary? |
| 22:15.39 | brlcad | so the if test that happens inside BU_CKMAG() will always be true |
| 22:15.47 | brlcad | a portion of the if-test |
| 22:16.20 | brlcad | the test is A or B or C .. and the warning is merely that A is always false |
| 22:17.08 | brlcad | way to quell that is to get a pointer to that address |
| 22:17.16 | starseeker | point of interest - since they aren't pointers, how come some of them have free calls? |
| 22:17.40 | brlcad | bu_free_external() is not freeing the struct |
| 22:17.44 | _sushi_ | brlcad: have you already had time to read my query? |
| 22:17.46 | brlcad | it's freeing things the struct holds |
| 22:17.50 | brlcad | _sushi_: not yet |
| 22:17.54 | _sushi_ | brlcad: sorry |
| 22:18.01 | starseeker | ah |
| 22:18.29 | starseeker | would have favored bu_free_struct_contents or some such for that... ah well |
| 22:19.14 | starseeker | thought &ext was the address of struct bu_external ext |
| 22:22.00 | starseeker | has to run - back later |
| 22:22.27 | brlcad | starseeker: try this.. |
| 22:26.42 | CIA-38 | BRL-CAD: 03brlcad * r37116 10/brlcad/trunk/include/magic.h: |
| 22:26.42 | CIA-38 | BRL-CAD: get the pointer value as a long integer before doing the comparisons. this will |
| 22:26.42 | CIA-38 | BRL-CAD: allow calls to BU_CKMAG for address of structs on the stack to not produce a |
| 22:26.42 | CIA-38 | BRL-CAD: compilation warning about the address always evaluating to true. going |
| 22:26.43 | CIA-38 | BRL-CAD: indirectly through the value does make the magic check potentially a little more |
| 22:26.45 | CIA-38 | BRL-CAD: expensive for non-optimized non-production builds. |
| 22:28.09 | brlcad | if it works, should study it for understanding ;) |
| 22:53.27 | starseeker | so the compiler was complaining about the if test because it knew the answer of that test for that case would always be false, since the pointer would evalute as true |
| 22:54.23 | starseeker | doesn't quite see why that matters, since there were other cases in the OR statement... an evaluation of the OR condition as TRUE would have shorted the test, but not false |
| 22:54.58 | starseeker | ah, well |
| 22:56.58 | starseeker | yeah, same deal with BU_VLS_IS_INITIALIZED |
| 23:05.25 | CIA-38 | BRL-CAD: 03starseeker * r37117 10/brlcad/trunk/include/ (brlcad_version.h bu.h): Also do pointer to long integer in BU_VLS_IS_INITIALIZED test |
| 23:05.48 | starseeker | and that completes the librt build here |
| 23:07.15 | starseeker | only warning I see is deprecated conversion from string constant to char* in dsp_brep.cpp |
| 23:07.31 | starseeker | wonder why it didn't gag on that |
| 23:08.24 | *** join/#brlcad akafubu (n=akafubu@unaffiliated/akafubu) |
| 23:08.32 | starseeker | hmm - must investigate bu_cv_cookie after supper |
| 23:17.27 | CIA-38 | BRL-CAD: 03starseeker * r37118 10/brlcad/trunk/src/librt/primitives/dsp/dsp_brep.cpp: cast to (char *) explicitly to avoid the string constant to char * warning - might want to check if bu_cv_cookie should be expecting const char * or not... |
| 23:18.32 | starseeker | I suppose if bu_cv_cookie doesn't alter the input string it could take a const value... |
| 23:21.03 | brlcad | erm, parens right on that? |
| 23:21.10 | brlcad | looks like you inverted the whole if test |
| 23:21.45 | brlcad | also shouldn't cast away constness |
| 23:22.18 | brlcad | the fix is what you suggested, should be const |
| 23:24.07 | brlcad | ah, logic looks okay on the bu.h change .. just funky in the email |
| 23:42.35 | *** join/#brlcad _sushi_ (n=_sushi_@84-72-9-218.dclient.hispeed.ch) [NETSPLIT VICTIM] |
| 23:42.37 | *** join/#brlcad CIA-38 (n=CIA@208.69.182.149) [NETSPLIT VICTIM] |
