| 02:26.52 | *** join/#asterisk-dev andrewyager (~andrewyag@8-104-141-114.static-dsl.realworld.net.au) |
| 02:56.31 | *** join/#asterisk-dev andrewyager (~andrewyag@114.141.97.1) |
| 07:54.43 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 07:54.43 | *** mode/#asterisk-dev [+o ChanServ] by services. |
| 09:28.21 | *** join/#asterisk-dev X-Rob (X-Rob@gateway/web/irccloud.com/x-ijdkccjwqjfwbwlk) |
| 09:34.16 | *** join/#asterisk-dev X-Rob (X-Rob@gateway/web/irccloud.com/x-hzudwcfhowiqyxsw) |
| 11:19.41 | *** join/#asterisk-dev andrewyager (~andrewyag@114.141.97.1) |
| 12:22.01 | *** join/#asterisk-dev sduthil (~sduthil@198-48-220-170.cpe.pppoe.ca) |
| 13:03.49 | *** join/#asterisk-dev gtjoseph (~gtjoseph@asterisk/developer/gtjoseph) |
| 13:03.49 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 13:41.44 | *** join/#asterisk-dev InterLinked (~ambassado@cpe-24-209-155-151.wi.res.rr.com) |
| 13:42.01 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@asterisk/developer/gtjoseph) |
| 13:42.01 | *** mode/#asterisk-dev [+o gtjoseph_] by ChanServ |
| 13:44.52 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@asterisk/developer/gtjoseph) |
| 13:44.52 | *** mode/#asterisk-dev [+o gtjoseph_] by ChanServ |
| 13:51.06 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@asterisk/developer/gtjoseph) |
| 13:51.06 | *** mode/#asterisk-dev [+o gtjoseph_] by ChanServ |
| 14:07.32 | *** join/#asterisk-dev gtjoseph (~gtjoseph@asterisk/developer/gtjoseph) |
| 14:07.32 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 14:15.17 | *** join/#asterisk-dev HannaM (~quassel@p54849510.dip0.t-ipconnect.de) |
| 14:26.09 | *** join/#asterisk-dev gtjoseph (~gtjoseph@asterisk/developer/gtjoseph) |
| 14:26.09 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 14:28.38 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-kowgjshmqrnkutjx) |
| 14:28.38 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:33.38 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-ydckizssuieqdzbp) |
| 14:33.38 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 17:11.15 | InterLinked | For audiohooks, is there any reason destroy_callback could not be called during runtime? It seems like that's intended for cleanup after a channel disappears, and I couldn't find any examples of this, but is there a reason it couldn't be explicitly called from a write function, to end the audiohook? |
| 17:11.52 | file | you change the state to end it |
| 17:12.19 | file | otherwise I'm not sure what you are referring to |
| 17:14.28 | InterLinked | How would you change the state then? It seems like destroy_callback() would end it but I don't see any functions explicitly calling it |
| 17:14.55 | file | audiohooks don't have a destroy_callback |
| 17:15.25 | InterLinked | What would this be for then? https://github.com/asterisk/asterisk/blob/b4347c486150653ec7ce1d129e8f9017c69344da/funcs/func_volume.c#L86 |
| 17:15.46 | file | that's a datastore |
| 17:15.55 | file | a completely separate API, used to attach arbitrary data to a channel |
| 17:16.44 | InterLinked | Ah, I see. So, is there no way to get rid of an audiohook manually on a channel? |
| 17:16.55 | file | that destroy callback does it internally |
| 17:17.06 | file | it locks the audiohook, detaches it from the channel it is attached to, and then destroys it |
| 17:17.23 | file | that's how you do such a thing. |
| 17:18.31 | InterLinked | Okay, so a function could accept an option to end the audiohook if it was already be set, and just call destroy_callback with the existing datastore, and that would get rid of it? |
| 17:19.27 | file | destroy_callback also frees the datastore contents, if the datastore is not removed from the channel and that API followed then you potentially encounter a scenario where you access freed memory |
| 17:19.31 | file | so the answer is - it depends on how things are done |
| 17:20.03 | file | the datastore API provides an API call to remove a datastore |
| 17:21.21 | file | so you'd want to remove the datastore from the channel, and then call ast_datastore_free which would result in the destroy_callback being called |
| 17:23.40 | InterLinked | Okay, I see, it looks like remove_hold_intercept demonstrates that, thanks! |
| 17:42.50 | *** join/#asterisk-dev elguero (~miguel323@c-73-238-205-3.hsd1.nh.comcast.net) |
| 17:42.50 | *** mode/#asterisk-dev [+o elguero] by ChanServ |
| 17:47.42 | *** join/#asterisk-dev elguero (~miguel323@c-73-238-205-3.hsd1.nh.comcast.net) |
| 17:47.42 | *** mode/#asterisk-dev [+o elguero] by ChanServ |
| 17:48.59 | *** join/#asterisk-dev elguero (~miguel323@c-73-238-205-3.hsd1.nh.comcast.net) |
| 17:48.59 | *** mode/#asterisk-dev [+o elguero] by ChanServ |
| 18:28.49 | *** join/#asterisk-dev HannaM (~quassel@p54849510.dip0.t-ipconnect.de) |
| 18:30.54 | *** join/#asterisk-dev elguero (~elguero@c-73-238-205-3.hsd1.nh.comcast.net) |
| 18:30.55 | *** mode/#asterisk-dev [+o elguero] by ChanServ |
| 19:54.00 | *** join/#asterisk-dev opticron (~opticron@136.53.69.43) |
| 19:54.00 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 20:23.41 | *** join/#asterisk-dev seanbright (~sean@asterisk/community-developer/seanbright) |
| 20:23.41 | *** mode/#asterisk-dev [+o seanbright] by ChanServ |
| 20:52.59 | *** join/#asterisk-dev n0tiz (~n0tiz@82-69-15-38.dsl.in-addr.zen.co.uk) |
| 21:20.22 | *** join/#asterisk-dev andrewya_ (~andrewyag@114.141.97.1) |
| 22:27.22 | *** join/#asterisk-dev elguero (~elguero@c-73-238-205-3.hsd1.nh.comcast.net) |
| 22:27.22 | *** mode/#asterisk-dev [+o elguero] by ChanServ |