| 06:20.28 | *** join/#asterisk-dev JAunis (~jean@lputeaux-658-1-51-39.w92-154.abo.wanadoo.fr) |
| 13:27.02 | seanbright | file: great. why are you telling me? |
| 13:27.09 | seanbright | i mean... i like knowing thing |
| 13:27.11 | seanbright | s |
| 13:27.15 | file | you mentioned previously doing something about it |
| 13:27.19 | seanbright | oh. |
| 13:27.25 | seanbright | i say a lot of things, josh. |
| 13:27.49 | seanbright | i'm what you call... a "talker" |
| 13:28.50 | seanbright | i do agree with someone from one of the mailing lists in that i am not sure why we still rely on an ancient mp3 library |
| 13:29.04 | seanbright | is that a patches welcome kinda thing? |
| 13:29.41 | file | yes, it's for an addon module |
| 13:29.56 | file | disabled by default, extended support |
| 13:30.12 | seanbright | roger that |
| 13:56.00 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-iivioernmecirreb) |
| 13:56.00 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:12.40 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-vgjuzotanfamiyqj) |
| 14:12.40 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:02.04 | *** part/#asterisk-dev JAunis (~jean@lputeaux-658-1-51-39.w92-154.abo.wanadoo.fr) |
| 18:14.19 | elguero | Hey all. I saw the same post about format_mp3 on the mailing list yesterday and it prompted me to take a look how difficult it would be to update it to use libmpg123. I was able to switch to using that library (which is provided by the distro, CentOS 7) and it appears to be working. I am looking at any possible improvements before submitting for review. After reading README-addons.txt, my question is, does it still need to be in |
| 18:32.02 | seanbright | elguero: the end if your message was cut off |
| 18:32.15 | seanbright | "does it still need to be in..." what? |
| 18:59.26 | elguero | in addons? |
| 18:59.58 | elguero | If we switch to that library and since patents, I think, have expired for mp3 |
| 19:00.02 | file | I'd have to double check with legal |
| 19:01.06 | elguero | Okay. I had a feeling you would need to. Thanks. Should I hold off on any reviews requests for now? |
| 19:01.35 | file | you can put a review request up, worst case it gets abandoned |
| 19:01.49 | elguero | Alright, sounds good. |
| 19:02.37 | elguero | Thanks |
| 21:21.26 | seanbright | any change should only go into master imho, unless it can be done in a backwards compatible way |