| 04:21.30 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 07:08.15 | *** join/#asterisk-dev dakudos (~dakudos@c-73-229-175-50.hsd1.co.comcast.net) |
| 10:26.22 | *** join/#asterisk-dev HannaM (~quassel@p54849510.dip0.t-ipconnect.de) |
| 12:27.39 | gtjoseph | seanbright: do you just want to reuse authenticate_qualify since it's currently a no-op? |
| 12:36.34 | *** join/#asterisk-dev sduthil (~sduthil@198-48-220-170.cpe.pppoe.ca) |
| 13:27.57 | seanbright | gtjoseph: i don't know what that is |
| 13:28.03 | seanbright | but i can look at it |
| 13:29.50 | gtjoseph | there's an option on aor named "authenticate_qualify" that became a no-op a while back. it was meant to indicate that we should send an authorization header if we got a www-authenticate from the OPTIONS target. |
| 13:30.56 | gtjoseph | It was decided that we should always respond with an authorization header if we got a www-authenticate so the option became unused. |
| 13:31.10 | seanbright | i think this is the opposite of what i am doing, right? |
| 13:31.24 | seanbright | my patch should be addressing when we received an OPTIONS request |
| 13:32.35 | gtjoseph | yes and my opinion is that the option _should_ have controlled the creation of the www-authenticate header. |
| 13:32.48 | gtjoseph | it always confused me. |
| 13:33.38 | seanbright | i'm sorry, i don't understand |
| 13:33.41 | seanbright | but that's ok |
| 13:34.00 | seanbright | i can switch my patch to use authenticate_qualify |
| 13:34.04 | seanbright | and then we're good |
| 13:34.51 | seanbright | file: "Each place also needs to be extended to state..." what is a 'place' in this context? |
| 13:35.04 | file | where the functionality is documented |
| 13:35.11 | seanbright | got it. alright. |
| 13:35.14 | gtjoseph | I always thought "authenticate_qualify" meant just what your patch does and never understood why it was controlling the cliet side istead of the server side. |
| 13:35.27 | seanbright | i see |
| 13:37.53 | file | the option is on AOR though |
| 13:37.57 | file | not endpoint |
| 13:38.44 | seanbright | is there a way to get the AOR from a request before authentication? |
| 13:39.15 | file | no, because there may not even be one |
| 13:40.10 | file | the most you could do is reuse the name |
| 13:55.00 | seanbright | gotcha. if there is a cleaner/safer approach i would prefer to go that direction than to shoe-horn something in for the sake of closing an open issue. |
| 13:55.33 | seanbright | so if anyone has thoughts on that i am happy to change things |
| 13:56.54 | file | I think the option as you have it is fine |
| 13:56.56 | gtjoseph | I think the capability is needed. |
| 13:56.59 | gtjoseph | yeah |
| 13:58.01 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 13:58.10 | seanbright | got it. i will document the security implications. |
| 14:14.12 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-brxfhiuifigakcie) |
| 14:14.12 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:17.44 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-mspacwlkmqdknzjc) |
| 14:17.44 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 17:06.59 | *** join/#asterisk-dev Nglpx1 (6d351148@109.53.17.72) |
| 17:40.04 | *** join/#asterisk-dev Nglpx1 (6d351148@109.53.17.72) |
| 17:48.36 | *** join/#asterisk-dev Nglpx1 (6d351148@109.53.17.72) |
| 18:23.41 | *** join/#asterisk-dev Nglpx1 (6d3503e2@109.53.3.226) |
| 18:30.29 | *** join/#asterisk-dev Nglpx1 (6d3503e2@109.53.3.226) |
| 19:44.25 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@37.157.48.2) |
| 20:52.44 | *** join/#asterisk-dev Nglpx1 (05abd30e@5.171.211.14) |
| 21:25.45 | *** join/#asterisk-dev Nglpx1 (6d350b30@109.53.11.48) |
| 22:07.58 | *** join/#asterisk-dev Nglpx1 (6d350b30@109.53.11.48) |
| 22:40.28 | *** join/#asterisk-dev Nglpx1 (6d350b30@109.53.11.48) |
| 23:23.01 | *** join/#asterisk-dev nglpx1 (05abc946@5.171.201.70) |
| 23:53.38 | *** join/#asterisk-dev nglpx1 (05abc946@5.171.201.70) |