| 01:04.52 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 03:04.30 | pchero | Hi gtjoseph, Could you please take a look this again? https://gerrit.asterisk.org/c/asterisk/+/15224 I'm not sure you are waiting for something from me. I thought my last reply was enough for you question, but please let me know if you need more detail. :) |
| 03:42.44 | *** join/#asterisk-dev electronic_eel (~quassel@213.240.182.132) |
| 09:46.25 | *** join/#asterisk-dev wdoekes (~walter@wjd.osso.nl) |
| 09:46.25 | *** mode/#asterisk-dev [+o wdoekes] by ChanServ |
| 13:19.30 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 13:32.33 | gtjoseph | pchero: oops, sorry about that. I just lost track of it. You're good to cherry-pick. |
| 13:45.38 | pchero | gtjoseph: Thanks, I will do that. :) |
| 14:40.13 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 14:40.13 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 14:41.50 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-ufskrrauvfpdmbfq) |
| 14:41.50 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:46.13 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 14:46.13 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 16:55.08 | jkroon | I have a need to for --with-lua simply pass a version number (eg, 5.1) instead of a path. happy to cook the patch. I'm also in two minds as to whether this should not be a separate LUA_IMPL variable (like CFLAGS) perhaps, or a separate --luaimplementation=5.1 argument to ./configure. |
| 16:55.13 | jkroon | what would be the preferred solution? |
| 16:55.52 | gtjoseph | hmmm |
| 16:56.07 | jkroon | yea, multiple versions of lua installed into /usr ... go figure. |
| 16:56.34 | gtjoseph | rather than confusing things by passing in the version to an existing option that expects a path, you could create a new option --with-lua5.1 |
| 16:57.03 | jkroon | how do I prevent more than one being specified? duplicate code for future versions ... ? |
| 16:57.06 | gtjoseph | what distro and version are you using? |
| 16:57.12 | jkroon | Gentoo, latest. |
| 16:57.32 | jkroon | someone decided lua must become SLOT'ed (multiple versions installed) |
| 16:57.51 | gtjoseph | we _should_ be detecing the correct version. why do you need 5.1 explicitly? |
| 16:58.13 | jkroon | because the package manager needs to be able to reliably know which versions are linked (or will be linked) at build time. |
| 16:59.00 | jkroon | so if a user has 5.{1,2,3,4} installed, he should be able to provide the build system with the preferred version of lua he wants for asterisk specifically. |
| 17:00.24 | gtjoseph | gotcha. gimme a sec |
| 17:00.49 | jkroon | what if I simply change the for ver in 5.{3,2,1}; do ... to for ver in ${LUA_IMPL:-5.{3,2,1}}; do ... ? |
| 17:01.15 | jkroon | that way you can inject the desired list into ./configure |
| 17:01.40 | gtjoseph | yeah that's what I was thinking. maybe LUA_VERSION |
| 17:01.46 | jkroon | happy with that. |
| 17:02.56 | jkroon | gtjoseph, not being overly familiar with autotools here, let's say you find a braindead situation where both the lua5.1 -I variant and the stripped version is present, in the current setup, which one will take precedence? |
| 17:02.57 | gtjoseph | just double check that the ${LUA_VERSION:-5.{3,2,1}} reference style isn't bash-specific. i forget whether it is nor ot. |
| 17:04.21 | jkroon | yes it is now that you mention it, I'll type it out. |
| 17:04.51 | jkroon | safer either way. |
| 17:05.02 | gtjoseph | yeah. looking at the precedence now. |
| 17:06.09 | gtjoseph | so it looks like you can specify LUA_INCLUDE and LUA_DIR environment variables. |
| 17:06.27 | jkroon | LUA_DIR doesn't help, that's /usr for all installed versions. |
| 17:06.37 | jkroon | LUA_INCLUDE helps, but that still doesn't get the version to *link* |
| 17:07.37 | jkroon | need a safety on the "no version" from what I can see, if test "x${PBX_LUA}" != "x1"; then ... fi |
| 17:09.40 | jkroon | uhrm, if I run ./bootstrap.sh on master it adds a bunch of stuff related to runstatedir into ./configure that wasn't there previously. |
| 17:10.30 | gtjoseph | I hate this whole process :) |
| 17:10.38 | gtjoseph | That should be fine. |
| 17:10.54 | jkroon | yea, imho ./configure itself shouldn't be part of the repo. |
| 17:11.13 | gtjoseph | don't get me started. :) |
| 17:11.28 | jkroon | I'll use git add -p :) |
| 17:12.25 | gtjoseph | I think you're going to have to test what happens if there's both a versioned and unversioned install. |
| 17:12.46 | jkroon | hmm, I'll fake it with a few symlinks |
| 17:13.00 | gtjoseph | the versioned checks will run first and I _think_ the unversioned check will skip if the versioned check worked. |
| 17:13.49 | jkroon | i'll confirm in 5 |
| 17:15.14 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 17:19.41 | jkroon | looks like you're right |
| 17:19.53 | gtjoseph | whew :) |
| 17:22.19 | jkroon | i'm still making double sure. |
| 17:22.40 | jkroon | where is the def for AST_EXT_LIB_CHECK btw, because that'll be able to confirm with 100% certainty |
| 17:23.18 | gtjoseph | it's in the autoconf directory |
| 17:23.23 | jkroon | thanks |
| 17:26.20 | jkroon | 110 if test "x${PBX_$1}" != "x1" -a "${USE_$1}" != "no"; then |
| 17:26.28 | jkroon | so it already has the safety built in. |
| 17:26.50 | gtjoseph | makes sense |
| 17:28.40 | jkroon | do we want to test the "without version suffix" at all if LUA_VERSION was provided? |
| 17:28.57 | gtjoseph | hmmm |
| 17:29.42 | gtjoseph | if you specify a version in an unversioned environment and the version happens to be the default, it'll get missed |
| 17:30.06 | gtjoseph | I.E. If you specify 5.1 and it happens to be the default, it'll get missed |
| 17:30.07 | jkroon | but if I specify a version, I probably mean I really want that version? |
| 17:30.19 | gtjoseph | true |
| 17:30.33 | gtjoseph | i'm ok with skipping the default check |
| 17:30.42 | jkroon | consider it done. |
| 17:31.10 | gtjoseph | do you have the ability to make sure this all works for centos, fedora, ubuntu, debian, etc? |
| 17:31.32 | jkroon | for centos by way of jenkins :) |
| 17:31.46 | gtjoseph | heh |
| 17:32.05 | jkroon | i do have a ubuntu chroot here somewhere ... |
| 17:32.22 | gtjoseph | we can test it on other platforms but probably not until next week. |
| 17:32.32 | gtjoseph | can I suggest docker? :) |
| 17:32.55 | jkroon | you may :). but I'll probably not listen. |
| 17:34.28 | gtjoseph | that seems to be a common response. |
| 17:34.38 | gtjoseph | no worries. we'll figure it out, |
| 17:35.09 | jkroon | yea, chroot works well enough, I'll test ubuntu quickly since that's just a chroot ./bootstrap.sh; ./configure --with-lua |
| 17:35.22 | gtjoseph | cool |
| 17:35.36 | jkroon | Some influential environment variables: <-- LUA_VERSION is probably worthwhile to list here? |
| 17:36.13 | gtjoseph | yep |
| 17:52.04 | jkroon | works on ubuntu as well. https://gerrit.asterisk.org/c/asterisk/+/15234 - I don't see how there can be any variation in functionality unless LUA_VERSION is set. |
| 17:52.18 | gtjoseph | sounds good. |
| 18:09.39 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@cgn-barr-67-222-245-52.carolinaconnect.net) |
| 18:09.39 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 21:04.17 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-172-88-21-24.socal.res.rr.com) |
| 21:06.36 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 21:06.36 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 21:15.07 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 21:15.07 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |