| 00:51.48 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 00:51.48 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 02:38.28 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 14:10.52 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 14:29.15 | seanbright | hope he made backups... |
| 14:42.37 | seanbright | gtjoseph: do you need emotional support in this trying time? |
| 14:42.48 | gtjoseph | I think I'm OK. :) |
| 14:43.02 | seanbright | alrighty, let me know if you need me to tag in |
| 14:43.18 | gtjoseph | I'm done with the upgrade but am running git gc on the repo for good measure. |
| 14:45.27 | seanbright | i am know internally for running firmware updates for the pleasure of it |
| 14:45.31 | seanbright | known* |
| 14:45.53 | seanbright | i often do those firmware updates... for good measure |
| 14:45.56 | seanbright | heh |
| 14:46.27 | seanbright | (it's only blown up in my face 1 time but i will never live it down) |
| 14:46.48 | gtjoseph | been there |
| 14:47.22 | seanbright | on snap... i think it's back |
| 14:48.45 | gtjoseph | yep, should be. |
| 14:50.08 | gtjoseph | updating jenkins as well so it's down |
| 15:02.30 | gtjoseph | And jenkins is back up. |
| 15:17.50 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 15:33.05 | seanbright | will a gate build run with a -2 code review? |
| 15:33.49 | file | I think so. |
| 15:34.06 | seanbright | k |
| 15:36.28 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-mqphkfxirewhmcnu) |
| 15:36.28 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:36.35 | seanbright | well then something is broken |
| 15:36.36 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/14889 |
| 15:36.47 | seanbright | sorry to be high maintenance |
| 15:38.06 | file | yes, it seems as though Jenkins isn't triggering |
| 15:38.14 | file | even on a recheck on another review |
| 15:38.36 | file | gtjoseph: kaboom |
| 15:39.30 | file | seanbright: in the mean time - https://www.youtube.com/watch?v=aGSKrC7dGcY |
| 15:39.55 | gtjoseph | yeah ok. looking. |
| 15:40.19 | seanbright | nah, i'll just go back to doom-scrolling on twitter |
| 15:40.54 | file | why not Instagram? |
| 15:40.56 | file | dog pictures! |
| 15:43.49 | seanbright | i am not on "the gram" |
| 15:43.59 | seanbright | or insta |
| 15:44.04 | seanbright | whatever the people are calling it |
| 15:44.15 | seanbright | i avoid FB properties as much as possible |
| 15:44.26 | file | you can run, but you can not hide |
| 15:44.27 | seanbright | which is a shame because i would love an oculus device |
| 15:47.29 | seanbright | gtjoseph: i want gate tests, dagnabbit |
| 15:47.49 | gtjoseph | i know i was testing from jenkins and it does the unit tests |
| 15:47.58 | seanbright | ah |
| 15:48.00 | file | seanbright: now now - don't https://www.youtube.com/watch?v=ADlGkXAz1D0 |
| 15:48.04 | seanbright | i forgive you |
| 15:49.13 | seanbright | you have a YT link for everything |
| 15:49.36 | file | mostly! |
| 16:14.51 | seanbright | res_pjsip/pjsip_resolver.c: 'TCP+IPv4' is not an available SIP transport, disabling resolver support for it |
| 16:14.55 | seanbright | weird |
| 16:15.15 | seanbright | or does that just mean there is no [transport] with protocol=tcp? |
| 16:17.15 | seanbright | what is a "flow" transport? |
| 16:18.06 | seanbright | fucking google voice, amirite |
| 16:20.16 | file | there's no [transport] with protocol=tcp |
| 16:21.02 | seanbright | got it, thanks. |
| 16:24.11 | *** join/#asterisk-dev pchero (~pchero@211.178.226.108) |
| 16:24.11 | *** mode/#asterisk-dev [+o pchero] by ChanServ |
| 16:56.38 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@37.157.48.2) |
| 17:06.26 | gtjoseph | Interesting. It seems the normal triggers are working (new patchset, patchset updated) but not the ones triggered by comments. |
| 17:07.45 | seanbright | maybe new gerrit comments are formatted differently? |
| 17:08.02 | gtjoseph | yeah maybe. |
| 17:08.05 | seanbright | like whatever gets sent to jenkins? |
| 17:08.14 | gtjoseph | or the trigger syntax changed. |
| 17:08.46 | gtjoseph | or maybe there' |
| 17:08.58 | gtjoseph | s a bug in the new gerrit trigger plugin |
| 17:09.38 | seanbright | https://issues.jenkins.io/browse/JENKINS-64372 |
| 17:09.48 | seanbright | so there we go |
| 17:10.40 | seanbright | gtjoseph: ^^ |
| 17:11.12 | gtjoseph | figures |
| 17:11.25 | file | this upgrade has been rough |
| 17:11.50 | file | "this upgrade" I more mean of Jenkins |
| 17:14.14 | gtjoseph | I just changed that issue from a New Feature to a Bug. |
| 17:15.48 | gtjoseph | Oh, I have the source for that plugin. I can probably just fix it. |
| 17:20.24 | seanbright | i'm a java expert - let me know if you have quetsions |
| 17:20.49 | gtjoseph | if you're such an expert, you can fix it :) |
| 17:21.15 | seanbright | sure, setting up a test environment would be trivial |
| 18:13.42 | seanbright | once a channel is hung up, is there a way to make ast_channel_snapshot_get_latest() work? |
| 18:15.28 | file | probably not, no |
| 18:15.33 | seanbright | k |
| 18:16.40 | file | holding a channel reference should allow it to work, as the channel snapshot is removed when the channel is destroyed |
| 18:20.29 | seanbright | so i am looking at this more closely: https://gerrit.asterisk.org/c/asterisk/+/14889 |
| 18:20.57 | seanbright | and it's failing the tests because the channel being spied on is gone by the time the chanspystop event is fired |
| 18:21.19 | seanbright | and therefore the snapshot is gone as well |
| 18:21.53 | seanbright | considering changing that code to subscribe to the channel topic and keep the last snapshot around? not sure if that is better than keeping a channel ref or not |
| 18:23.24 | file | meh |
| 18:23.30 | file | either way is meh |
| 18:23.42 | file | channel ref is probably betting |
| 18:23.48 | file | better rather |
| 18:38.37 | seanbright | seems to work |
| 20:32.52 | csavinovich | Hi @gtjoseph, greetings. I have a question: I've been using the external media demo you wrote in node, but I can only get it to work when using a confbridge. But when I try to send the external media of only a single channel (one side) on a one-on-one phone call it doesn't work for me. Before I keep trying any more I will better ask you: It only works on a confbridge, right? |
| 20:44.25 | gtjoseph | csavinovich: It should work on any bridge but it does have to be a bridge the way it's set up now. |
| 20:49.52 | gtjoseph | actually I need to rephrase |
| 20:50.55 | gtjoseph | if you create a channel via ari you can only put that channel in a bridge that's also created via ari. |
| 20:52.47 | gtjoseph | so what the demo does is create the external media channel, create a local channel, dial the local channel into an existing confbridge, the create another bridge to bridge the local and external media channels |
| 20:54.21 | gtjoseph | the only real restriction is the one that requires that the external media channel be placed into a bridge also in stasis |
| 20:58.41 | seanbright | gtjoseph: when you get a sec can you remove your -2s from 14889 and it's cherry picks? |
| 20:59.48 | gtjoseph | can't get to gerrit right now. can you remove them? |
| 21:00.18 | seanbright | i don't have the necessary juice |
| 21:00.27 | seanbright | don't worry about it |
| 21:00.42 | gtjoseph | need about an hour |
| 21:00.57 | seanbright | in no way urgent. thanks. |
| 21:50.12 | gtjoseph | seanbright: -2's removed |
| 22:02.09 | seanbright | gtjoseph: thanks guy |