| 01:30.12 | Kobaz | #0 0x00005628b431d40f in ast_timer_set_rate (handle=0x0, rate=50) at timing.c:168 |
| 01:30.21 | Kobaz | so, no timer handle is bad? |
| 01:31.28 | Kobaz | yeah that's bad |
| 01:31.39 | Kobaz | <PROTECTED> |
| 01:31.46 | Kobaz | asterisk 16.14.1 |
| 01:35.44 | Kobaz | https://issues.asterisk.org/jira/browse/ASTERISK-29002?jql=text%20~%20ast_timer_set_rate |
| 01:36.44 | Kobaz | aaaah looks like the issue is no timer is loaded |
| 01:37.38 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 01:59.12 | Kobaz | i fixed it: https://issues.asterisk.org/jira/secure/attachment/59671/tag-16.14.1-no-timer.patch |
| 06:17.49 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6c39e4e3d4e964.ipv6.abo.wanadoo.fr) |
| 06:25.08 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6c39e4e3d4e964.ipv6.abo.wanadoo.fr) |
| 07:50.52 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@37.157.48.2) |
| 08:11.34 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:a9e4:ef0d:ef39:8609) |
| 08:16.25 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:16.28 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@068-114-057-249.res.spectrum.com) |
| 08:16.28 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 08:37.38 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01:e0a:d:1111:a9e4:ef0d:ef39:8609) |
| 08:40.26 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 11:39.37 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.109) |
| 11:39.38 | *** mode/#asterisk-dev [+o jkroon] by ChanServ |
| 12:59.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lfbn-nan-1-1995-213.w90-105.abo.wanadoo.fr) |
| 13:19.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6c39e4e3d4e964.ipv6.abo.wanadoo.fr) |
| 13:43.09 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-ljhtqzcqanpxaqje) |
| 13:43.09 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:08.56 | seanbright | gtjoseph: the thread1 dump of the most recent crash on ASTERISK-29134 makes it look like a pjsip crash/memory corruption and not a mixmonitor issue |
| 14:09.18 | gtjoseph | yeah that's why i asked for both coredumps. |
| 14:09.19 | seanbright | but i am not an expert |
| 14:09.38 | gtjoseph | no your correct. |
| 14:09.43 | file | do you play one on TV? |
| 14:11.48 | seanbright | no, but i did stay at a holiday inn express last night |
| 14:12.24 | file | I wonder what the latest promotions are for hotels |
| 14:12.44 | tsearle | holiday inn - total gardening solutions? |
| 14:24.43 | seanbright | holiday inn express lawn care |
| 14:24.46 | seanbright | but you were close |
| 14:25.19 | tsearle | nice! |
| 14:45.18 | seanbright | jeez. are there really not libc functions to do this timezone handling that makes main/stdtime/* necessary |
| 16:51.18 | Kobaz | haha |
| 16:51.36 | Kobaz | seanbright: thoughts on my patch? i saw you commented on one of those issues |
| 16:51.40 | Kobaz | https://issues.asterisk.org/jira/browse/ASTERISK-29002?jql=text%20~%20ast_timer_set_rate |
| 17:19.42 | seanbright | i don't have any thoughts, no |
| 18:06.05 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-nan-1-1995-213.w90-105.abo.wanadoo.fr) |
| 18:45.06 | *** join/#asterisk-dev elguero (~miguel323@c-73-238-205-3.hsd1.nh.comcast.net) |
| 18:45.06 | *** mode/#asterisk-dev [+o elguero] by ChanServ |
| 19:04.02 | seanbright | Kobaz: that is a crazy amount of context in that diff - how did you generate it? |
| 19:04.38 | Kobaz | git diff |
| 19:04.42 | seanbright | hmm |
| 19:04.51 | Kobaz | oh. my default context is like, a lot of lines |
| 19:05.05 | Kobaz | I think it's 200 |
| 19:05.15 | Kobaz | we need a lot of context for our stuff |
| 19:05.44 | seanbright | ok |
| 19:05.48 | Kobaz | It looks like, quite a number of things wont work right without a timer, but... Asterisk shouldn't crash without a timer loaded |
| 19:06.16 | seanbright | submit it to gerrit, then someone will review it |
| 19:06.27 | Kobaz | I don't typically operate without a timer, but dtmf immediately crashed channel.c without a timer |
| 19:06.28 | Kobaz | yeah sure |
| 19:07.15 | seanbright | my feeling is that if something requires timing and there are no timing modules loaded, it should fail early and 'hard' |
| 19:07.29 | seanbright | but that is just my opinion |
| 19:13.24 | seanbright | checking for the existence of the timer everywhere seems pretty blunt |
| 19:13.30 | seanbright | but this is above my paygrade |
| 19:41.22 | Kobaz | true |
| 19:41.29 | Kobaz | if you are loading confbridge and music on hold |
| 19:41.35 | Kobaz | and you have no timer... asterisk should refuse to start |
| 19:41.48 | Kobaz | like the other critical items, so the second/third/etc server can take over |