| 02:33.10 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 07:12.26 | *** join/#asterisk-dev CELYA_ (~Thunderbi@185.14.178.189) |
| 10:05.21 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 10:24.37 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 12:26.27 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 13:45.51 | *** join/#asterisk-dev AsteriskRoss (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 13:55.47 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 14:01.33 | gtjoseph | DanJenkins[m]: pull request updated. |
| 14:02.04 | DanJenkins[m] | thanks! |
| 14:02.04 | DanJenkins[m] | I shall take a look momentarily |
| 14:17.37 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-cgcqtxpkdjjczauc) |
| 14:17.37 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:37.05 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-kzcyqnazyuhkcmtj) |
| 14:37.05 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:55.25 | *** join/#asterisk-dev tmoore (~tmoore@2600:1702:4110:3d10:5c53:529c:53d0:df4b) |
| 16:14.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 18:16.27 | DanJenkins[m] | [gtjoseph](https://matrix.to/#/@freenode_gtjoseph:matrix.org) I replied with one small addition if you don't mind? |
| 18:16.41 | gtjoseph | looks |
| 18:16.44 | DanJenkins[m] | If not I can add it |
| 18:19.04 | gtjoseph | it's a reasonable request. I can fix it shortly. I'm not understanding your second comment though. What's the concern? |
| 18:21.19 | DanJenkins[m] | I kinda just "feels" like it shouldnt be a permanent thing. Hence why it's not a request for a change because I don't even know how I feel about it - it's a valid addition.... Just kinda feels like there should be a setting for enabling that kinda functionality.... I guess there is because you're passing a user in which isn't in the base state |
| 18:22.58 | gtjoseph | if make the other change then user will only be in the temporary queryParams object and not propogate to the rest of the app. |
| 18:23.55 | DanJenkins[m] | Ah yes............ |
| 18:24.47 | DanJenkins[m] | What do you think? We could add user to the base state.... That's fine... So then it would stay if you'd set it via the URL.... |
| 18:25.07 | DanJenkins[m] | But it's not an option in the config screen |
| 18:25.17 | DanJenkins[m] | So you'd never be able to unset it if you wanted to..... |
| 18:26.12 | DanJenkins[m] | Oh but you're only using it to create a sip Uri right? Which then gets put into the base state |
| 18:26.18 | DanJenkins[m] | So should be good |
| 18:26.25 | gtjoseph | I don't think we need it for any reason other than to set the default. We _could_ make sipUri be more flexible in format... just user user@hostname user@hostname:port |
| 18:26.34 | DanJenkins[m] | Don't you just love state |
| 18:26.39 | gtjoseph | :) |
| 18:28.25 | file | I state categorically I do not |
| 18:28.51 | gtjoseph | well, I do love state machines. |
| 18:28.55 | DanJenkins[m] | ð |
| 18:29.15 | gtjoseph | well, ones that are implemented correctly that is. |
| 18:30.08 | *** join/#asterisk-dev opticron (~opticron@136.53.69.43) |
| 18:30.08 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 18:31.08 | gtjoseph | DanJenkins[m]: how do you want to go... Use the "user" query param in a temp object, or make sipUri accept partial entries and default what isn't specified? |
| 18:32.49 | gtjoseph | actually i just finished doing it with the "user" query param. :) |
| 18:33.08 | DanJenkins[m] | Sure, ok |
| 18:33.53 | gtjoseph | seriously, you lick, I'm fine whith any way you want to go. |
| 18:34.05 | gtjoseph | s/lick/pick/ |
| 18:34.43 | DanJenkins[m] | I'd say make sipUri accept partials sounds fine |
| 18:35.00 | gtjoseph | Cool! |
| 18:35.30 | DanJenkins[m] | I don't want to overthink it too much - it's only a demo app but at the same time should kinda show best practices (I really need to split out that videoroom component a lot.more ) |
| 18:35.41 | gtjoseph | heh |
| 18:39.59 | gtjoseph | ugh, need to keep user actually because if someone specifies "myasterisk" as the uri is that a username or hostname? |
| 18:41.33 | DanJenkins[m] | Hmmmmm.... I'd say that's not a Uri and I should add in validation ;) in that case it's a username right? |
| 18:42.22 | gtjoseph | well, well, what if you don't need a username and accept anonymous calls? |
| 18:42.45 | gtjoseph | now we're really overthinking it. :) |
| 18:43.27 | DanJenkins[m] | There's no way to accept calls in Dana |
| 18:43.42 | gtjoseph | sorry, asterisk accepting anonymous calls |
| 18:43.44 | DanJenkins[m] | ;) |
| 18:43.47 | DanJenkins[m] | Ahh |
| 18:44.49 | gtjoseph | so I think that sipUri must at least contain hostname with an optional user before it and an optional port after it. |
| 18:45.16 | gtjoseph | if you leave out user, we'll default it to the "user" parameter is specified. |
| 18:45.25 | gtjoseph | if specified. |
| 18:45.59 | DanJenkins[m] | Sounds wise |
| 18:46.13 | gtjoseph | this way if sipUri is specified, it HAS to parse as a valid Uri |
| 18:47.22 | DanJenkins[m] | ð |
| 18:47.27 | gtjoseph | what's the right way to throw an error in AppProvider if the uri doesn't parse? |
| 18:47.59 | DanJenkins[m] | Oh good question..... Because it does it b fore everything else |
| 18:47.59 | gtjoseph | "this.setState({ snackOpen: true, errorMessage: err.message });" ? |
| 18:48.24 | gtjoseph | although it's not a Component I guess. |
| 18:48.39 | DanJenkins[m] | I think the snack is only part of another component |
| 18:48.44 | DanJenkins[m] | For now I would throw an error |
| 18:48.53 | gtjoseph | gotcha |
| 19:03.24 | *** join/#asterisk-dev sduthil (~sduthil@198-91-196-19.cpe.distributel.net) |
| 19:09.12 | *** join/#asterisk-dev sduthil (~sduthil@198-91-196-19.cpe.distributel.net) |
| 21:19.36 | *** join/#asterisk-dev infobot (ibot@96-86-209-99-static.hfc.comcastbusiness.net) |
| 21:19.36 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |