IRC log for #asterisk-dev on 20200902

04:26.27*** join/#asterisk-dev infobot (ibot@96-86-209-99-static.hfc.comcastbusiness.net)
04:26.27*** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev
07:12.49*** join/#asterisk-dev jkroon (~jkroon@165.16.204.108)
07:16.03*** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a)
07:23.54*** join/#asterisk-dev jkroon (~jkroon@165.16.204.108)
07:34.09*** join/#asterisk-dev jkroon (~jkroon@165.16.204.108)
08:18.18*** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b0e8:c287:967d:4fcd)
08:23.07*** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr)
08:48.40*** part/#asterisk-dev dsobrinho (~The_jacka@187.75.127.80)
10:29.45fileseanbright: I bounced an issue to you, if you don't want to deal with it just say so
10:51.27*** join/#asterisk-dev n0tiz (~n0tiz@82-69-15-38.dsl.in-addr.zen.co.uk)
10:55.17*** join/#asterisk-dev sduthil (~sduthil@bras-base-mtrlpq4806w-grc-18-50-100-133-152.dsl.bell.ca)
11:19.53*** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb06804ac612a9643eec6daad604.ipv6.abo.wanadoo.fr)
11:37.47*** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb06804ac612a9643eec6daad604.ipv6.abo.wanadoo.fr)
11:47.19seanbrightoh god
11:50.34filemy thoughts exactly
11:51.08tsearlestill talking about voicemail?
11:53.40seanbrightno, realtime and music on hold
11:53.42seanbrightand AsteriskRoss
11:53.46seanbrightit's a deadly combination
11:54.42tsearlehrm... not the moh_passthru flag though right?
11:54.49fileno.
11:55.14tsearlethat was last years fun I think, (or was that early this year)
11:55.58tsearlehard to keep track, most what I do ref asterisk today is for DT regulatory compliance
11:56.17tsearle181/History Info is the latest
12:03.26tsearleand a confession ref that, we do the implementaiton for the invite in AGI, so we really needed just forwarding redirection info in 181
12:03.42tsearledid more than voxbone needed in the patch so it could be pushed upstream, heh
12:04.01*** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01cb06804ac612a9643eec6daad604.ipv6.abo.wanadoo.fr)
13:31.01AsteriskRossI've attached my config files, I'm now compiling with the patch and will get the debug.
13:31.47seanbrightAsteriskRoss: just tested with latest 16 and your configs and it works fine.
13:31.55seanbrightwhat does "playing correctly" mean?
13:33.42seanbrightgood talk
13:34.53AsteriskRossThe issue is that when going into a queue, no MoH plays at all. No messages are shown in the CLI
13:35.26AsteriskRossI'm just getting a test box built to get the debug info for you
13:35.30seanbrightok
13:35.58seanbrightare you using symbolic links or anything funky in your moh directory setup?
13:36.06seanbrightare the files local to the box?
13:36.12seanbrightor on a network share of some kind?
13:36.26AsteriskRossThey are all stored locally
13:36.38seanbrightk
13:36.45AsteriskRossin the asterisk moh directory, but under a sub directory
13:36.51seanbrightright
14:07.40*** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-uwqkmmpbfjoeeccq)
14:07.40*** mode/#asterisk-dev [+o kharwell] by ChanServ
14:13.45AsteriskRossI can't replicate the issue on the test server, though everything is the same and uses the same database. I'll continue to investigate
14:13.50seanbrightk
14:32.58*** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-fnpnfthzcyfnwyov)
14:32.58*** mode/#asterisk-dev [+o bford] by ChanServ
14:40.30AsteriskRossOk, I hold my hands up. If an asterisk server sends an already answered call to a server running a queue and the queue server does not explicitly 'Answer' the call, no audio flows until one of the agents answers the call. This dial plan changes only rolled out when I updated the queue server. I have no idea why I could first replicate the issue on the test server and then could not once I removed the patch. I am very sorry
14:40.30AsteriskRossfor wasting peoples time.
14:56.25seanbrightnot a waste of time, thank you for following up.
15:24.52*** join/#asterisk-dev jkroon (~jkroon@165.16.203.98)
15:45.15*** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb06804ac61288e60d0023a71d41.ipv6.abo.wanadoo.fr)
16:21.11Dovid<PROTECTED>
16:50.49kharwellthanks for the patch. While it technically should work it could use some improvement. I'd suggest pushing it up to gerrit for review as it's much easier to comment/review  patch there https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage
16:51.14*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
16:52.56kharwellOne thing I'd do is instead of searching for a string I'd check the response code from curl itself: https://curl.haxx.se/libcurl/c/CURLINFO_RESPONSE_CODE.html
16:55.31kharwellAlso formatting wise (for Asterisk submissions/patches) the opening braces should be on the same line as the iif/else clause
17:01.43*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
17:03.59*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
17:06.17*** join/#asterisk-dev CELYA_2 (~Thunderbi@185.200.145.19)
17:10.47*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
17:12.50*** join/#asterisk-dev jkroon (~jkroon@165.16.203.106)
17:15.20*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
17:19.51*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
17:26.04*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
17:27.27Dovidkharwell: TY
17:40.24*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
17:41.03kharwellDovid: no problem
17:46.50*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
17:51.12*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
17:55.40*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
17:57.48Dovidkharwell: How's this ? https://issues.asterisk.org/jira/secure/attachment/59416/28825-2.patch
18:00.22*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
18:05.45kharwelllooks better! However variable declarations must be at the start of the code scope (in this case top of function), so your 'long http_code' will have to be moved
18:06.04seanbrightuse: ./configure --enable-dev-mode
18:06.10seanbrightthat will enable additional compiler warnings
18:06.14seanbrightwhich would catch that
18:06.16kharwellwhen creating a patch configure asterisk with the -enable-dev-mode option and it'll catch that type of warning/error on compile
18:06.24seanbrightwhat kharwell said
18:06.35kharwellha was just about to say what seanbright said
18:07.41kharwellalso I'd either put the log warning statement after the if check, or make it a log debug statement as it probably doesn't need to log on every return code
18:08.15kharwellif it does it need to be the make it a log notice
18:11.26DovidHows this? https://pastebin.com/K1p3PScD
18:12.10Doviddont think I learnt c over night. I have a dev in the backround doing the work ;)
18:15.57*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
18:17.55kharwellmove "ast_log(LOG_WARNING, "Curl CURLINFO_RESPONSE_CODE (%ld).\n",http_code);" to be within the if (http_code == 404) or change it to a LOG_NOTICE. Also I'd delete ret=0 and just set it at the top where it is declared.
18:18.10kharwelllastly I'd move the added blank line at 29
18:18.52kharwellit's minor stuff but the smaller the patch the better
18:22.52*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
18:25.07*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
18:29.23*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
18:35.32*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
18:41.56*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
18:48.41*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
18:53.42*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
18:58.20*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
18:59.45Dovidkharwell: http://voice1.telecurve.net/patch3 ?
19:02.50*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
19:07.41*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
19:12.00*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
19:18.43*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
19:20.00*** join/#asterisk-dev bbbenphone (57465c38@87.70.92.56)
19:23.31*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
19:25.53*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
19:27.52bbbenphonecan you have queue rules change the ring type also ?
19:29.05bbbenphoneand or stop the original ringing and start again with the new set of the members ?
19:39.07*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
19:44.58*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
19:47.14*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
19:51.30*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
19:56.07*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
19:58.30*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:03.08*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
20:05.32*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:10.01*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
20:12.21*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:16.49*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
20:21.11*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:25.40kharwellDovid: looks fine to me
20:28.03*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
20:32.05*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
20:34.22*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:39.58*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
20:44.25*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:46.42*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
20:51.12*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
20:59.45*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
21:04.16*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
21:09.00*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
21:13.52*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
21:22.06*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
21:29.06*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
21:33.41*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
21:38.12*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
21:40.32*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
21:45.06*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
21:49.24*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
21:53.43*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
21:57.58*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
22:08.39*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
22:13.15*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
22:15.35*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
22:20.11*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
22:24.44*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)
22:27.04*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
22:31.36*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
22:36.16*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
22:38.35*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
22:42.53*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
22:51.40*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
23:00.06*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
23:06.38*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
23:11.07*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534229.pck.nerim.net)
23:12.21*** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n)
23:12.21*** mode/#asterisk-dev [+o cresl1n] by ChanServ
23:19.41*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
23:26.15*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
23:30.58*** join/#asterisk-dev CELYA_ (~Thunderbi@185.200.145.19)
23:33.09*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
23:37.50*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534257.pck.nerim.net)
23:42.42*** join/#asterisk-dev CELYA_1 (~Thunderbi@a5964-0383534229.pck.nerim.net)
23:51.32*** join/#asterisk-dev CELYA_1 (~Thunderbi@185.200.145.19)
23:56.07*** join/#asterisk-dev CELYA_ (~Thunderbi@a5964-0383534257.pck.nerim.net)

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.