| 03:09.15 | *** join/#asterisk-dev infobot (ibot@96-86-209-99-static.hfc.comcastbusiness.net) |
| 03:09.15 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 13:54.11 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-uspysocmcviqlirc) |
| 13:54.11 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:46.04 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-zqednqagqlnxivcl) |
| 14:46.04 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:00.13 | *** join/#asterisk-dev rmudgett (~rmudgett@170.249.191.178) |
| 15:00.13 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 17:09.30 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 17:38.11 | kharwell | so I'm clear pjsip_media_offer should override, essentially replace, what's configured for an outgoing offer? |
| 17:38.45 | kharwell | so if an endpoint is configured with ulaw, and pjsip_media_offer sets g722 then the outgoing invite will contain g722? |
| 17:39.33 | file | yes, I believe that's the way it's documented/should work |
| 17:41.02 | kharwell | that's what I thought too. I must be doing something wrong or it's more broken than I thought |
| 17:42.18 | kharwell | the initial invite can be replace right? It's not necessarily the re-invite only right? |
| 17:42.54 | file | define "can be replace" |
| 17:43.46 | gtjoseph | and which channel are you calling it on? |
| 17:45.05 | kharwell | I originate a local channel into Echo, and the dialplan. Dialplan calls pjsip/alice, but in a pre-dial handler I seemingly set the pjsip_media_offer for alice but it doesn't seem to be doing anything |
| 17:45.28 | kharwell | Alice's endpoint config has allow=!all,g722 |
| 17:45.52 | kharwell | In dialplan using pjsip_media_offer I set allow=!all,ulaw |
| 17:45.57 | kharwell | But the sdp has g722 |
| 17:46.01 | kharwell | in the invite |
| 17:46.20 | gtjoseph | i wonder if it has something to do with a local channel being the caller. |
| 17:46.36 | kharwell | Using pjsip_media_offer I thought it would "replace" the g722 with ulaw in the offer's sdp? |
| 17:46.40 | gtjoseph | i wouldn't _think_ so but... |
| 17:47.01 | gtjoseph | maybe that's what's busted. :) |
| 17:47.04 | kharwell | hrm maybe |
| 17:47.48 | kharwell | issue reporter said it is busted in 16, but not 13. but what I tried above doesn't work in 13 or 16 |
| 17:48.15 | kharwell | ah well I'll keep digging. Wanted to make sure I wasn't too far in the weeds. thanks |
| 17:48.19 | gtjoseph | well, 16 is tream based so it miight be different |
| 17:48.26 | kharwell | yeah |
| 17:48.27 | gtjoseph | than 13 |
| 17:48.44 | kharwell | so reporter's issue might be more core related |
| 17:49.06 | kharwell | I was hoping to get a basic example test working first, but can't heh |
| 17:49.35 | gtjoseph | in 16+ all that function does it set the pending stream topology |
| 17:49.52 | gtjoseph | so whever we have after that is still going to override it. |
| 17:50.46 | gtjoseph | in my stuff i'll be also setting a flag on the topolody that says "final" use ME and don't do any firther manipulation. |
| 17:51.59 | kharwell | it all makes me wonder how much this function is actually used |
| 17:52.45 | gtjoseph | i forget what the default operation was for ouotgoing. i think it was "favor endpoint" |
| 17:53.09 | gtjoseph | if you set both ulaw and g722 do both get sent or still just g722? |
| 17:59.39 | file | kharwell: not much probably? |
| 17:59.43 | kharwell | I haven't tried that yet. I'll give it a shot. maybe it has to be a subset of what's configured and not a full replacement |
| 18:14.52 | kharwell | adding ulaw to the endpoint config worked |
| 18:15.26 | file | nifty |
| 18:15.43 | gtjoseph | but what does that tell you. |
| 18:15.49 | gtjoseph | you didn't alter anything. |
| 18:16.40 | kharwell | so I guess that means pjsip_media_offer does not replace codecs, but allows one to use a subset or reduce what is offered |
| 18:16.50 | kharwell | hrm I wonder ... |
| 18:17.00 | file | did we change that fixing something else perhaps? |
| 18:17.03 | gtjoseph | so what got sent when you added ulaw, just ulaw or did g722 stiull get sent? |
| 18:17.18 | kharwell | just ulaw |
| 18:17.22 | gtjoseph | ah ok. |
| 18:17.37 | gtjoseph | is that 13 or 16? |
| 18:17.54 | kharwell | 13 so far |
| 18:18.40 | kharwell | oh this worked too. config is allow=!all,g722,ulaw, and pjsip_media_offer is allow=!all,ulaw,alaw |
| 18:18.49 | kharwell | both ulaw and alaw are in the outgoing sdp |
| 18:18.57 | gtjoseph | eh? |
| 18:19.08 | kharwell | so it must have to have at least one in the list of config codecs for it to work? |
| 18:19.21 | file | interesting... |
| 18:19.21 | kharwell | file: yeah this sounds like something we were dealing with on the video side recently |
| 18:19.42 | gtjoseph | this is also why current codec negotiation sucks. :) |
| 18:20.07 | kharwell | heh |
| 18:20.13 | file | gtjoseph: well why don't you do some... oh, nevermind |
| 18:20.15 | file | :D |
| 18:20.20 | rmudgett | who needs video anyway? :P |
| 18:20.22 | gtjoseph | :P |
| 18:20.28 | file | rmudgett: us. every day. |
| 18:21.32 | kharwell | the wiki for the function doesn't really say. So what's the expected behavior? complete replacement allowed? Meaning whatever is specified in the pjsip_media_offer is what's sent whether or not any codecs are on the endpoint config? or something like what's is happening now? At least one codec has to be listed in the config? |
| 18:21.55 | kharwell | I was expecting the former behavior |
| 18:22.12 | file | kharwell: it kinda says in a different place |
| 18:22.24 | file | kinda? |
| 18:22.25 | file | https://wiki.asterisk.org/wiki/display/AST/Asterisk+17+Function_PJSIP_SEND_SESSION_REFRESH |
| 18:23.16 | kharwell | aah yeah the warning. Hadn't seen that doc yet |
| 18:24.01 | file | I knew that was somewhereeeee |
| 18:24.09 | kharwell | then yeah pjsip_media_offer seems broken in 13+ in that sense. Still not sure about the possible reported issue. could be related...hopefully |