| 03:16.33 | *** join/#asterisk-dev infobot (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 03:16.33 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:22.36 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 07:43.34 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 08:10.07 | *** join/#asterisk-dev Corydon76_ (~quassel@96.69.98.139) |
| 08:10.08 | *** mode/#asterisk-dev [+o Corydon76_] by ChanServ |
| 12:54.53 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-qlrffszdqgvezuqf) |
| 12:54.53 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 13:01.35 | *** join/#asterisk-dev sduthil (~sduthil@23-233-111-218.cpe.pppoe.ca) |
| 13:52.12 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-nan-1-2297-47.w92-139.abo.wanadoo.fr) |
| 14:18.07 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-duxxfbvzlhyvbpsq) |
| 14:18.07 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 21:23.29 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@rrcs-66-57-14-122.midsouth.biz.rr.com) |
| 21:23.30 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 21:50.21 | seanbright | kharwell: hi. can you explain how the `transport | IPV6` thing is different than the `transport + IPV6` thing in that AAAA patch? |
| 21:50.39 | seanbright | (bearing in mind that i do know the difference between addition and bitwise OR) |
| 21:51.04 | seanbright | i don't see how changing + to | would make a difference |
| 21:51.14 | kharwell | I don't think it really makes a difference here from what I can tell |
| 21:51.25 | kharwell | seems to calculate to the same value |
| 21:52.52 | kharwell | I thought about mentioning it, but in the end didn't. I'd be fine though taking the no unneeded changes route if you'd rather |
| 21:54.51 | seanbright | so which lines of the patch are actually doing something? |
| 21:54.56 | seanbright | heh |
| 21:55.43 | seanbright | ok, i see them now |
| 21:56.17 | kharwell | just really two spots that I can see |
| 21:57.30 | file | PJSIP uses both | and + in different places, not consistent |
| 21:58.06 | seanbright | in the enum definition it's + |
| 21:58.17 | seanbright | and they are bit flags, so | seems inapproprite |
| 21:58.21 | seanbright | inappropriate |
| 21:58.30 | seanbright | sorry - they are NOT bit flags |
| 21:59.28 | seanbright | i know it is super minor, but by allowing the change we are lending credence to the idea that something was wrong there in the first place |
| 21:59.55 | file | nods |
| 22:03.05 | seanbright | in effect, it's saying |
| 22:03.15 | seanbright | "add 128 unless we already added 128" |
| 22:03.23 | seanbright | which i suppose makes sense |
| 22:07.33 | kharwell | could always ask for that to be changed in a separate patch too I suppose since it's kinda a separate change to the actual bug |
| 22:10.43 | seanbright | it's probably fine |
| 22:10.47 | seanbright | it's a safer add |
| 22:10.51 | seanbright | i can live with that |
| 22:11.08 | seanbright | the leading whitespace on a few lines is wrong though, which i am fixing |
| 22:14.29 | seanbright | i shall now stop bike shedding - my apologies |
| 22:15.20 | file | paint it blue! |
| 22:15.31 | kharwell | nope green! |
| 22:46.14 | opticron | as always, you fail to grasp the scope of the bike shed. it obviously needs an alpha channel |