| 02:03.22 | *** join/#asterisk-dev spatel (~spatel@pool-96-237-230-175.bstnma.fios.verizon.net) |
| 02:31.32 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@rrcs-66-57-14-122.midsouth.biz.rr.com) |
| 02:31.32 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 07:36.53 | *** join/#asterisk-dev pchero_work (~pchero@ip-213-127-79-161.ip.prioritytelecom.net) |
| 08:11.09 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.106) |
| 08:30.11 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 10:44.00 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:90c5:9167:7d39:819d) |
| 10:48.14 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-nan-1-178-51.w90-49.abo.wanadoo.fr) |
| 11:10.53 | *** join/#asterisk-dev electronic_eel (~quassel@hsi-kbw-46-223-65-185.hsi.kabel-badenwuerttemberg.de) |
| 11:14.23 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:90c5:9167:7d39:819d) |
| 11:39.59 | *** join/#asterisk-dev sduthil (~sduthil@107-179-252-17.cpe.teksavvy.com) |
| 13:52.44 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-gqswvvzcidgpobvb) |
| 13:52.44 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 13:55.59 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-glpiysbbnkaeghzi) |
| 13:55.59 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:22.56 | Kobaz | what's the use case for ast_func_read vs ast_func_read2 |
| 14:23.59 | file | one has the ability to grow the output buffer, the other doesn't |
| 14:24.11 | Kobaz | k nice |
| 14:24.14 | Kobaz | reviewing some old code |
| 14:29.04 | Kobaz | here goes... |
| 14:29.40 | Kobaz | nothing quite like porting up 6 year old code into master |
| 14:33.36 | DanJenkins[m] | hey all, before i go making an issue..... the example config says you can set commands to run after startup (https://github.com/asterisk/asterisk/blob/master/configs/samples/cli.conf.sample#L10 ) but this results in a warning ( https://github.com/CyCoreSystems/asterisk-config/issues/7 ) at startup... so this begs the question.... is there a better way to put it in the config file, or is the warning always going to |
| 14:33.36 | DanJenkins[m] | be there and should it be fixed so it doesnt complain |
| 14:34.25 | Kobaz | yes, startup commands should not cause a warning |
| 14:34.58 | file | there is a better way to put it in the config file |
| 14:35.04 | file | well, better is relative |
| 14:35.08 | file | you put " = yes" beside it |
| 14:35.21 | DanJenkins[m] | LOL |
| 14:35.28 | DanJenkins[m] | thanks @file |
| 14:35.35 | DanJenkins[m] | that works for me |
| 14:35.51 | DanJenkins[m] | no point changing the parser if theres no real need |
| 14:37.07 | DanJenkins[m] | i guess i should do a PR for changing the sample config |
| 14:37.16 | DanJenkins[m] | if such a nonsense change would be accepted ? |
| 14:37.29 | file | we review anything that goes up. |
| 14:38.59 | DanJenkins[m] | merci beaucoup file as always |
| 14:39.16 | Kobaz | awww it didn't build |
| 14:40.40 | Kobaz | haha what |
| 14:40.43 | Kobaz | func_groupcount.c:1085:18: error: 'buf' undeclared (first use in this function); did you mean 'butt'? |
| 14:40.50 | Kobaz | Why is this a suggestion |
| 14:41.19 | DanJenkins[m] | I was going to make a rather inappropriate joke and decided agianst it |
| 14:41.20 | DanJenkins[m] | :D |
| 14:42.49 | gtjoseph | jkroon: apparently the DAHDI owner changed so i'm following up on your DAHDI issues with the new owner. |
| 14:46.13 | Kobaz | oh man, no whammys no whammys |
| 14:48.23 | jkroon | gtjoseph, ack. looks like the one fix for ppc (32-bit) might be incomplete. waiting for confirmation, so no rush. just want to make sure the patches will get into 3.1.1 or 3.2.0 as the case may be. |
| 14:48.27 | Kobaz | woah, it built |
| 14:52.17 | Kobaz | it starts up and doesn't crash and everything.. this is exciting |
| 14:52.36 | Kobaz | what's a good example for basic dialplan unit tests? |
| 15:03.07 | coreyfarrell | Kobaz: not sure it's a "good" example but tests/test_file.c does unit tests against the `FILE` function of func_env.c. |
| 15:11.24 | Kobaz | Ah.. hmm |
| 15:11.32 | Kobaz | I was more referring to the python-userspace testing |
| 15:11.38 | Kobaz | but i'll take a look at test file |
| 15:12.04 | Kobaz | basically, make some calls, set some variables, test some results |
| 15:38.43 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:90c5:9167:7d39:819d) |
| 15:52.50 | coreyfarrell | Kobaz: oh you mean the testsuite.. I think of that as integration testing rather than unit testing. tests/funcs/func_channel looks reasonable |
| 15:53.11 | Kobaz | k cool, getting back into all this |
| 15:53.18 | Kobaz | yeah so unit testing is the low level then |
| 15:54.28 | file | yes |
| 15:54.34 | file | generally tests underlying APIs and such |
| 16:17.46 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 17:39.03 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:90c5:9167:7d39:819d) |
| 17:47.05 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-nan-1-178-51.w90-49.abo.wanadoo.fr) |
| 19:23.00 | sduthil | Hi, in funcs/func_channel.c on master, there is this code, corresponding to the dialplan function: CHANNEL(channame) |
| 19:23.01 | sduthil | else if (!strcasecmp(data, "channame") && ast_channel_data(chan)) |
| 19:23.01 | sduthil | locked_copy_string(chan, buf, ast_channel_name(chan), len); |
| 19:23.24 | sduthil | does somebody know why ast_channel_data(chan) is required for getting the channame? |
| 19:33.15 | seanbright | it's not |
| 19:33.20 | seanbright | copypasta i assume |
| 19:34.07 | seanbright | exten, context, userfield, and channame |
| 19:34.14 | seanbright | none of those need ast_channel_data to be non-NULL |
| 19:36.03 | seanbright | ugh, that code sucks |
| 19:37.11 | seanbright | looks like you can just use 'name' and it won't do that check |
| 19:45.13 | sduthil | that's what I thought, thank you |
| 20:00.02 | sduthil | I created an issue, I'll see if I can submit a patch: https://issues.asterisk.org/jira/browse/ASTERISK-28796 |
| 20:00.46 | seanbright | i think your console log is copypasta too |
| 20:00.57 | seanbright | unless the error always says "exten |
| 20:01.22 | sduthil | erm, fixed :) |
| 20:06.37 | seanbright | it's not really clear to me why appname or appdata do the additional check either |
| 20:07.14 | file | I think those checks... predate me |
| 20:08.11 | seanbright | came in with CEL |
| 20:08.20 | seanbright | 2009 |
| 20:09.06 | seanbright | i guess the real question is: can those things actually be NULL these days? |
| 20:09.18 | seanbright | if they are stringfields, then they cannot |
| 20:11.30 | file | quite |
| 20:11.35 | seanbright | they are not stringfields in 13 at least |
| 20:11.59 | seanbright | nor in master |
| 20:12.10 | seanbright | so... *shrug* |