| 04:18.42 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 07:11.17 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 08:53.07 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 09:02.28 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 09:02.53 | *** join/#asterisk-dev mvanbaak1 (~mvanbaak@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 09:02.54 | *** mode/#asterisk-dev [+o mvanbaak1] by ChanServ |
| 09:03.16 | *** join/#asterisk-dev zerohalo_ (sid288136@gateway/web/irccloud.com/x-kknedjhzlqwhbrni) |
| 09:05.03 | *** join/#asterisk-dev dadrc (~quassel@unaffiliated/drc) |
| 09:18.01 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@68-114-57-249.dhcp.davl.vt.charter.com) |
| 09:18.01 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 09:20.52 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-fmqeapvrwtysyiqa) |
| 09:20.52 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 11:34.35 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 12:21.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 13:03.09 | *** join/#asterisk-dev pc-m (~pcm@cable-66-129-132-216.b2b2c.ca) |
| 13:51.12 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 14:10.09 | coreyfarrell | file: sorry last night I didn't think to check 13.x for other format strings which should not be used in that version. worth noting the scan I used to find those other files would miss code where the format string is on a different line from the ast_json_pack. |
| 14:14.34 | file | I think you got all of them |
| 14:15.38 | file | I did a more general search and didn't find others besides what you did |
| 14:19.19 | coreyfarrell | it's tough since `git grep -e 's?'` finds 1 million false positives. the actual check I used was `git grep -e '[soO][*?]'|grep -e json` |
| 14:24.15 | file | I did grep -r -i --include \*.h --include \*.c "s?" * | more |
| 14:24.27 | file | and then manually looked, which was reasonable enough |
| 14:25.14 | seanbright | does s\? not work? |
| 14:27.01 | file | on mine? should |
| 14:27.17 | seanbright | i was trying to understand why s? was returning false positives |
| 14:27.26 | seanbright | other than the ? not be escaped |
| 14:27.30 | file | "this?" |
| 14:28.04 | seanbright | can't be many of those |
| 14:28.06 | seanbright | whatever |
| 14:28.07 | seanbright | good times |
| 14:29.57 | file | yeah, only 30, plus some other words |
| 14:30.09 | file | which is why I manually looked - wasn't worth trying to narrow down that much |
| 14:30.40 | *** join/#asterisk-dev _Vile (~abcdefg12@freeswitch/developer/vile) |
| 14:30.54 | seanbright | it is taco tuesday |
| 14:31.03 | coreyfarrell | matches a lot more when you check for "s*" as well.. |
| 14:31.25 | seanbright | is it always right of a colon? |
| 14:31.47 | seanbright | why am i obsessed with this |
| 14:31.52 | seanbright | i'll move on |
| 14:52.46 | file | I did some cleanup on Gerrit of old reviews |
| 15:08.08 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-zaooqlkavmdpwdlb) |
| 15:08.08 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:22.09 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-btoxbjhlrmdgghsk) |
| 15:22.09 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:29.51 | *** join/#asterisk-dev AsteriskRoss_ (~AsteriskR@r01.nt-r1.nor.gb.voicehost.co.uk) |
| 15:43.48 | seanbright | let's just abandon them all and start over |
| 15:45.33 | file | computer says no |
| 17:00.21 | seanbright | so on https://gerrit.asterisk.org/c/asterisk/+/13480 |
| 17:00.46 | seanbright | i made requested changes on the commit message itself, which were not addressed in the subsequent patch set |
| 17:00.59 | seanbright | i want to just make the commit message changes myself |
| 17:01.03 | seanbright | talk me out of it |
| 17:02.41 | file | whistles |
| 17:03.54 | seanbright | i have decided to teach a man to fish |
| 18:01.42 | *** join/#asterisk-dev sduthil (~sduthil@modemcable094.94-70-69.static.videotron.ca) |
| 18:49.49 | *** join/#asterisk-dev pchero (~pchero@ip-213-127-35-5.ip.prioritytelecom.net) |
| 18:52.06 | *** join/#asterisk-dev pchero_work (~pchero@2a02:a210:2241:6480:515:3939:937e:149) |
| 20:22.45 | *** join/#asterisk-dev sduthil (~sduthil@modemcable094.94-70-69.static.videotron.ca) |
| 20:35.29 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |