| 00:16.10 | *** join/#asterisk-dev infobot (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 00:16.10 | *** topic/#asterisk-dev is Take the March 2019 Asterisk User Survey! https://goo.gl/forms/xL1VUHRsf95saly13 -- Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:17.02 | *** join/#asterisk-dev andrewyager (~andrewyag@2406:a800:d108:1:dce1:41d3:15a6:2169) |
| 04:52.22 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.109) |
| 05:14.03 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.109) |
| 06:04.51 | *** join/#asterisk-dev wraythe (~wraythe@41.175.148.17) |
| 07:01.17 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 07:18.35 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 08:32.33 | *** join/#asterisk-dev legid (5b592aec@HSI-KBW-091-089-042-236.hsi2.kabelbw.de) |
| 09:42.59 | *** join/#asterisk-dev andrewyager (~andrewyag@2406:a800:d108:1:c985:9de2:9190:2a4a) |
| 10:45.52 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |
| 11:52.58 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 12:16.45 | *** join/#asterisk-dev opticron (~opticron@75.76.209.103) |
| 12:16.47 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 13:05.13 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |
| 13:33.30 | *** join/#asterisk-dev andrewyager (~andrewyag@2406:a800:d108:1:c985:9de2:9190:2a4a) |
| 13:37.02 | seanbright | a typo is going to cost me another week waiting for a patch to be merged |
| 13:37.09 | seanbright | this workflow suuccccck sometimes |
| 13:37.13 | seanbright | sucks* |
| 13:37.29 | gtjoseph | :) |
| 13:37.36 | gtjoseph | we'll get it through today |
| 13:42.10 | seanbright | i messed it up in a comment too. i guess i don't know english. |
| 14:12.54 | *** join/#asterisk-dev kharwell (uid358942@gateway/web/irccloud.com/x-yqxuwxvxgqjbvgik) |
| 14:12.54 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:13.43 | *** join/#asterisk-dev andrewyager (~andrewyag@2406:a800:d108:1:c985:9de2:9190:2a4a) |
| 14:13.58 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-wpqodkljklnyalzb) |
| 14:13.58 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:24.47 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |
| 15:28.31 | *** join/#asterisk-dev spatel (~spatel@pool-98-118-124-216.bstnma.fios.verizon.net) |
| 15:54.15 | off-nominal | so i am flailing on https://gerrit.asterisk.org/c/asterisk/+/12744 |
| 15:54.37 | off-nominal | i would like some guidance |
| 15:55.27 | off-nominal | for the most part, this is the pattern: |
| 15:55.37 | off-nominal | 1) parse a = delimited string for a variable name and value |
| 15:55.43 | off-nominal | 2) allocate an ast_variable |
| 15:56.07 | off-nominal | 3) try to find it in the existing list, and replace if found |
| 15:56.19 | off-nominal | 4) if not found, prepend or append |
| 15:56.37 | off-nominal | i don't want to litter the config API more than i have to |
| 15:57.00 | file | reduce, reuse, recycle |
| 15:57.49 | off-nominal | i also don't think that ast_variable is the ideal data structure for this, but that is a whole other thing |
| 15:59.49 | file | what's your conundrum? |
| 16:00.21 | off-nominal | https://gerrit.asterisk.org/c/asterisk/+/12744/5/channels/chan_dahdi.c |
| 16:01.00 | off-nominal | so, i could create a new function ast_variable_parse_and_replace_or_prepend(...) that does all of that work |
| 16:01.38 | off-nominal | or i could use existing API to do most of the work at the current call sites, but that is just duplicating code everywhere |
| 16:02.06 | file | I think creating a new one is fine? |
| 16:02.12 | off-nominal | ok |
| 16:12.06 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 18:47.08 | *** join/#asterisk-dev wraythe (~wraythe@fw.keithro.se) |
| 19:05.43 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 19:44.51 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lfbn-1-9707-146.w86-236.abo.wanadoo.fr) |
| 20:09.15 | gtjoseph | seanbright: you misspelled SILENCE |
| 20:09.59 | gtjoseph | oh he's not here. well, that was wasted. |
| 20:10.06 | file | he's off-nominal |
| 20:11.20 | gtjoseph | oh, hah |
| 20:11.35 | gtjoseph | i forgot that was his alter-alias |
| 20:14.38 | *** join/#asterisk-dev offbeatwitch (~offbeatwi@platypus.offbeatwit.ch) |
| 20:16.18 | off-nominal | oh jesus, where? |
| 20:42.38 | kharwell | gtjoseph pointing out spelling mistakes. what is the world coming to :-D |
| 20:44.05 | gtjoseph | :) |
| 20:44.28 | gtjoseph | for the first time in a long time, i've pointed out more that i've created. |
| 20:45.02 | kharwell | somewhere there is a proud rmudgett about |
| 20:45.25 | rmudgett | :D |
| 20:49.23 | seanbright | where did i typo 'silence?' |
| 20:49.52 | gtjoseph | nowhere. was just yankin your chain :) |
| 20:49.59 | seanbright | you son of a... |
| 21:43.32 | *** join/#asterisk-dev andrewyager (~andrewyag@2406:a800:d108:1:c985:9de2:9190:2a4a) |