| 02:34.01 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:08.45 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:31.19 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 05:09.18 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 05:29.31 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.106) |
| 05:59.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 06:14.11 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 06:28.42 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 06:58.12 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.52) |
| 07:02.02 | *** join/#asterisk-dev tombriden (~tom@0540f238.skybroadband.com) |
| 07:03.04 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.52) |
| 07:06.17 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-hxqbqzqbuxfmgcfm) |
| 07:07.03 | *** join/#asterisk-dev X-Rob (X-Rob@gateway/web/irccloud.com/x-arjjaodbfcfxckxb) |
| 07:16.13 | tombriden | hey, i think the difference between 13.18-cert4 and master answer my question but just want to confirm, in rtp_engine.c, should ast_rtp_codecs_payloads_copy also cleanup vector elements that are in dest but not in source? |
| 07:17.17 | tombriden | i ask because i have an issue where an incoming invite has codecs of 0 and 101, asterisk responds OK with the same codecs. Then a re-invite changes the codecs to 0 and 1, asterisk again responds OK with the same codecs |
| 07:17.57 | tombriden | but then a final re-invite sets the codecs back to 0 and 101 but the asterisk OK still has codecs 0 and 1 where i'd expect to see 0 and 101 again |
| 07:30.35 | tombriden | doing an ao2_t_cleanup(AST_VECTOR_GET(&dest->payloads, i) if AST_VECTOR_GET(&src->payloads, i) is null does seem to fix the issue but want to ensure that's not going to break something elsewhere |
| 07:32.23 | *** part/#asterisk-dev snuff-work (~snuff-wor@202-161-112-134.tpgi.com.au) |
| 07:55.37 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 08:09.49 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 08:20.44 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 08:26.22 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 08:31.50 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:51.47 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 10:23.38 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 11:32.02 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 11:41.07 | *** join/#asterisk-dev tombriden (~tom@0540f238.skybroadband.com) |
| 11:48.17 | *** join/#asterisk-dev tombriden (~tom@0540f238.skybroadband.com) |
| 12:06.38 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 12:30.27 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 12:40.30 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 12:45.55 | gtjoseph | seanbright: you've been busy :) |
| 13:11.50 | seanbright | gtjoseph: just trying to pick off low hanging fruit |
| 13:12.05 | gtjoseph | keep on picking! |
| 13:12.44 | seanbright | weird |
| 13:12.54 | seanbright | that's what i get for editing in the browser i guess |
| 13:15.18 | seanbright | i'm actually pretty happy with how https://gerrit.asterisk.org/c/asterisk/+/11264 turned out |
| 13:15.41 | seanbright | my initial attempt was switching to strtol and a lot of other nonsense |
| 13:15.55 | gtjoseph | yep. good solution |
| 13:16.48 | seanbright | it's not the greatest parsing function i have ever seen |
| 13:16.56 | seanbright | but... whatever |
| 13:17.20 | gtjoseph | if only regex parsing were cheaper in C |
| 13:18.04 | seanbright | that'd be a tough regex because you'd kind of need to parse from right to left |
| 13:22.48 | seanbright | eh, i guess you could do something like: ((<context-like>,)?<exten-like>,)?<priority> |
| 13:23.15 | gtjoseph | yep |
| 13:35.39 | seanbright | oh murf |
| 13:46.13 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 13:47.42 | gtjoseph | seanbright: the gerrit diff viewer really doesn't like your ael Macro/Gosub changes. I was scratching my head for a bit. |
| 13:48.12 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 13:55.36 | seanbright | hm |
| 13:55.54 | seanbright | what doesn't it like? |
| 13:56.12 | gtjoseph | the old gerrit interface shifts the diff highlights |
| 13:56.28 | seanbright | oh weird |
| 13:56.34 | gtjoseph | there must be something in pval.c that's throwing it off becasue the other ael patch does the same thing |
| 13:56.34 | seanbright | yeah, use polygerrit |
| 13:56.35 | seanbright | heh |
| 13:56.48 | gtjoseph | yeah i was holding our |
| 13:56.51 | gtjoseph | yeah i was holding out |
| 13:56.59 | seanbright | that file is a disaster |
| 13:57.10 | gtjoseph | so is pval.c |
| 13:57.11 | file | how dare you say that about me! |
| 13:57.13 | gtjoseph | :) |
| 13:57.20 | file | is perfectly pleasant and perfect |
| 14:07.12 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 14:17.09 | *** join/#asterisk-dev tombriden_ (~tom@0540f238.skybroadband.com) |
| 14:25.22 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-nvzixdbftcltfmgl) |
| 14:25.22 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:42.53 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 14:49.41 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 15:04.00 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-mtbtcjzvbdmqsnou) |
| 15:04.00 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:07.29 | gtjoseph | just fyi... we made a bunch of I/O related changes in our VM cluster to see if we can improve the gate passes and auto-merging |
| 15:07.46 | gtjoseph | i've temporarily turned off auto-merge to facilitate testing |
| 15:08.27 | gtjoseph | in the mean time, seanbright i may be using some of your reviews for testing |
| 15:08.38 | gtjoseph | so don't worry if you see me regating things |
| 15:24.11 | seanbright | i'm not scared |
| 15:24.23 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 15:24.23 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 15:44.19 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 15:45.13 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.106) |
| 16:20.44 | seanbright | can we deprecate 'extenpatternmatchnew' in master? |
| 16:20.54 | seanbright | it's a disaster |
| 16:22.19 | file | would not be against |
| 16:23.02 | seanbright | or maybe i will rewrite it to suck less |
| 16:23.11 | seanbright | why? no idea |
| 16:24.26 | file | seanbright: do not want |
| 16:24.52 | seanbright | heh |
| 16:27.17 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 17:00.06 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 17:03.35 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 17:36.25 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 18:01.13 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 18:16.41 | coreyfarrell | seanbright: I'm in favor of deprecating it. anything that eventually simplifies the dialplan context structures is a good thing. |
| 18:26.51 | seanbright | well now i kind of have an itch to rewrite it |
| 18:26.57 | seanbright | so... there's that |
| 18:30.30 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 18:32.18 | seanbright | step 1: use graphviz to make pretty pictures |
| 18:32.19 | seanbright | https://seanbright.com/dialplan.svg |
| 18:32.28 | seanbright | step 3: profit |
| 18:36.36 | file | needs more ponies |
| 19:04.49 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 19:27.39 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lfbn-1-5196-243.w90-105.abo.wanadoo.fr) |
| 19:39.15 | *** join/#asterisk-dev tombriden (~tom@0540f238.skybroadband.com) |
| 19:51.35 | *** join/#asterisk-dev tombriden_ (~tom@0540f238.skybroadband.com) |
| 20:01.16 | *** join/#asterisk-dev tombriden (~tom@0540f238.skybroadband.com) |
| 20:03.14 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-49-8-191.dialup.adsl.anteldata.net.uy) |
| 20:45.17 | seanbright | now with more ternary-search-tree-iness: https://seanbright.com/dialplan.svg |
| 20:45.38 | seanbright | i think i'll just spend my time on the images and won't bother with the actual code |
| 21:05.59 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 23:41.22 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
