| 00:40.11 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 00:59.54 | sahmed | @coryfarrell Could you please have a look into this? is this something need to care about? https://pastebin.com/Ebs9tNrN |
| 01:01.58 | sahmed | in my system few days ago I had a crash with "corrupted double-linked list", Thats why I am digging this and little worried about this crash. |
| 02:09.44 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@arennes-652-1-148-146.w92-139.abo.wanadoo.fr) |
| 02:52.33 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:01.40 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:25.54 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:45.11 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 05:46.12 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 05:56.50 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 06:41.16 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 07:06.44 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 07:27.11 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 08:05.06 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.42) |
| 08:52.23 | pchero_work | Hi, the security patch note of https://downloads.asterisk.org/pub/security/AST-2019-001.pdf , the patch file linked to the old patch. |
| 08:52.55 | pchero_work | The link of the patch file pointing to the http://downloads.asterisk.org/pub/security/AST-2018-009-15 . |
| 08:57.29 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 11:00.27 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 11:39.44 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-usbscztphhdjmuto) |
| 11:39.44 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 11:56.09 | *** join/#asterisk-dev pchero_work (~pchero@51.247.195.35.bc.googleusercontent.com) |
| 12:08.57 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 12:08.57 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 12:17.47 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 12:17.47 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:10.08 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 13:10.08 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:57.03 | coreyfarrell | the last valgrind leak sahmed posted looks like https://issues.asterisk.org/jira/browse/ASTERISK-27121 - is this something that can be fixed again or is that still on hold? |
| 14:01.47 | file | it may occur, we have an internal issue to just revisit the voicemail stuff in general and decide - because it seems as though we're still suffering from the changes already done |
| 14:32.28 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 14:34.19 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 14:47.36 | seanbright | the menuselect_gtk.c review now has russell's official blessing |
| 14:47.48 | seanbright | which was a close one - i smelled lawsuit |
| 14:53.51 | coreyfarrell | sahmed: I think the leak you posted might be https://issues.asterisk.org/jira/browse/ASTERISK-27121. this is a tough issue, we had a fix but it caused regressions. it'll be revisited by Digium/Sangoma when the time is right. |
| 14:54.59 | coreyfarrell | sahmed: if you are experiencing a "corrupted double-linked list" that is not a leak. you are most likely looking for a write after free. |
| 15:08.02 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-mxzietrhytxguaqa) |
| 15:08.02 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:09.58 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:09.58 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:23.33 | cresl1n | Did we revert the gerrit upgrade? |
| 15:23.49 | cresl1n | I don't think I've got polygerrit on my code review interface |
| 15:24.00 | file | cresl1n: it has not been reverted |
| 15:24.01 | cresl1n | or rather "it looks the same" |
| 15:24.04 | cresl1n | :-) |
| 15:24.08 | cresl1n | waves to file |
| 15:24.14 | file | go to the bottom and click the link for the new one? |
| 15:24.19 | file | warbles |
| 15:24.36 | cresl1n | seems like a trap |
| 15:28.08 | file | cresl1n: you can always switch back... |
| 15:28.08 | file | for now. |
| 15:28.27 | cresl1n | too late |
| 15:28.30 | cresl1n | I'm in polygerrit |
| 15:35.57 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 15:35.57 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 15:39.58 | seanbright | the only thing i don't like is that to get back to the list of open reviews requires two clicks |
| 15:40.55 | file | hit "g" and "o" at the same time on your keyboard |
| 15:41.43 | cresl1n | What's the difference between update and update2 in the odbc driver? |
| 15:41.57 | cresl1n | <---- somehow never had to work on the database code |
| 15:42.00 | file | something? |
| 15:43.14 | file | https://www.irccloud.com/pastebin/zJZO0PEA/ |
| 15:43.18 | file | :D |
| 15:43.29 | cresl1n | nice |
| 15:43.33 | cresl1n | thanks file |
| 15:44.17 | seanbright | file: fancy |
| 15:44.19 | cresl1n | Maybe I should update the docs on that function |
| 15:44.39 | seanbright | i think update has a single column to update and a single column to query on |
| 15:44.51 | seanbright | update2 takes multiple to update and multiple to query on |
| 15:44.55 | seanbright | i _think_ |
| 15:45.02 | cresl1n | that jives with the commit message |
| 15:45.04 | seanbright | BUT realtime is garbage |
| 15:45.07 | seanbright | so |
| 15:45.19 | file | I think garbage is a bit extreme |
| 15:45.28 | file | I'd phrase it... "not how we would do it these days" |
| 15:45.38 | seanbright | potato potato |
| 15:45.53 | seanbright | it's the chansip of configuration |
| 15:46.19 | seanbright | NULL? empty string? storing an int as a string? a string as an int? |
| 15:46.24 | seanbright | that is realtime in a nutshell |
| 15:46.27 | file | it helps to pay my bills though, so I can't knock it too much |
| 15:47.46 | seanbright | i can afford to be less PC about it |
| 15:47.56 | seanbright | but if it offends, i will stop saying garbage |
| 15:48.04 | file | you can say as you want :D |
| 15:57.31 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 15:57.31 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 16:00.09 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 16:21.47 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 16:27.09 | *** join/#asterisk-dev sahmed (~sahmed@63.65.120.22) |
| 16:33.00 | seanbright | https://github.com/asterisk/asterisk/blob/master/main/rtp_engine.c#L2295-L2297 |
| 16:33.11 | seanbright | that is dead code, but i don't know what the appropriate fix is |
| 16:33.29 | sahmed | <coreyfarrell> Thanks for the reply, Actually I was suspecting if any leak lead to this "corrupted double-linked list" error. According to gdb this linked list is owned by Malloc. I have no deep knowledge on this, just learning. |
| 16:33.37 | seanbright | (it's dead because we never set tinstance_src or tinstance_dst to anything that is non-NULL) |
| 16:34.45 | sahmed | <coreyfarrell> write after free can lead to this error(corrupted double-linked list) ? |
| 16:37.18 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 17:00.51 | bford | would anyone be opposed to making the way CHANGES and UPGRADE.txt do their formatting more uniform? for example, making the entries in UPGRADE.txt have the same "----" separator notation as CHANGES, and use asterisks instead of dashes for bullet points, etc.? the reason i ask is because i'm working on automating the process via our release process |
| 17:04.37 | seanbright | fine with me |
| 17:04.48 | file | +! |
| 17:04.50 | file | or +1 |
| 17:05.40 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 17:05.40 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 17:27.01 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 17:34.28 | rmudgett | What's wrong with +! ? |
| 17:36.17 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 17:40.13 | coreyfarrell | sahmed: corrupted double-linked list means that something wrote to memory which it wasn't supposed to touch (something other than glibc wrote to memory which malloc uses internally). use after free is the most likely cause of this. maybe double free could do it as well but I think that might have it's own error. |
| 17:46.37 | sahmed | <coreyfarrell> Okay, looking for anything like you explained, Will share, if anything found suspicious. Thanks |
| 17:48.47 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-yoikkfdzajovdjoe) |
| 17:48.47 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 18:42.46 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-181-237-90.dhcp.oxfr.ma.charter.com) |
| 18:42.46 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 18:45.55 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 18:46.05 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 18:51.17 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 18:51.17 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:04.30 | *** join/#asterisk-dev jkroon (~jkroon@105.12.5.6) |
| 19:27.59 | *** join/#asterisk-dev jkroon_ (~jkroon@105.12.5.6) |
| 19:38.53 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 19:49.56 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 19:56.32 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 20:05.43 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 20:24.12 | *** join/#asterisk-dev jkroon (~jkroon@105.12.5.6) |
| 20:27.30 | *** join/#asterisk-dev pchero (~pchero@dhcp-077-249-058-090.chello.nl) |
| 21:34.30 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-clfjjxosgcjacxie) |
| 21:34.30 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 22:08.47 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 22:19.36 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 22:37.21 | seanbright | cresl1n: asterisk.dev is available. might be time to whip out the company CC. |
| 22:45.40 | *** join/#asterisk-dev GameGamer43_ (sid5533@gateway/web/irccloud.com/x-ngkdftfrjqkxtrtq) |
| 22:45.40 | *** mode/#asterisk-dev [+o GameGamer43_] by ChanServ |
| 22:45.50 | *** join/#asterisk-dev tm1000_ (sid6728@gateway/web/irccloud.com/x-eqxceknhxqahjowt) |
| 22:45.50 | *** mode/#asterisk-dev [+o tm1000_] by ChanServ |
| 22:47.14 | cresl1n | heh |
| 23:08.50 | *** join/#asterisk-dev tzafrir (~tzafrir@lemon.tzafrir.org.il) |
| 23:08.50 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:25.38 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-yoikkfdzajovdjoe) |
| 23:50.58 | tzafrir | Hi, the dahdi-tools and dahdi-linux bug tracker are not fun. Could someone please go over the and close some recent bugs closed by the recent fixes? |