| 00:23.38 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-nxcauntzdwwjdhdh) |
| 00:48.37 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 02:49.16 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 03:00.06 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 04:51.13 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 05:02.12 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 06:48.27 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 07:13.55 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 09:21.25 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 09:21.25 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 09:23.12 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 09:24.18 | *** join/#asterisk-dev stevedav_ (~stevedavi@197.155.252.3) |
| 09:41.34 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.114) |
| 10:36.54 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 12:03.59 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 12:06.14 | file | seanbright: I have a query for you when you appear |
| 12:48.55 | seanbright | file: to avoid a getsockaddr() call per packet (if i recall correctly) |
| 12:49.04 | file | that's what I thought |
| 12:49.27 | file | it unfortunately breaks this - so may have to revert and rethink |
| 12:49.32 | seanbright | sure |
| 12:49.57 | seanbright | it's been in for a while |
| 12:50.13 | file | yeah, not many people run with such a config it seems |
| 12:50.29 | file | probably just bind to 0.0.0.0 and move on |
| 12:51.38 | file | beat me to it |
| 12:55.42 | seanbright | i'm fine reverting. i'm not currently in a position to be able to test additional changes beyond that. |
| 12:55.54 | file | aye |
| 12:57.12 | seanbright | can a revert have a #close in it? i assume yes |
| 12:57.33 | file | yup |
| 12:58.21 | seanbright | alrighty. done. sorry about that. |
| 12:58.36 | file | no prob |
| 12:58.55 | seanbright | runs away again |
| 13:00.29 | file | warbles |
| 14:35.46 | seanbright | re: ASTERISK-23812 |
| 14:36.17 | seanbright | i remember coreyfarrell fixing a bug a few months ago that involved making a header field name static instead of part of a pool that resolved a similar issue |
| 14:36.56 | file | seanbright: I remembered that too but wasn't able to quickly find it - also wrong issue ID |
| 14:36.59 | seanbright | https://gerrit.asterisk.org/c/asterisk/+/10652 |
| 14:37.13 | seanbright | yes, 28312, sorry |
| 14:37.58 | file | added a comment to it linking to that |
| 14:40.58 | coreyfarrell | usually when I get randomly mentioned it's because I broke something :) |
| 14:41.04 | seanbright | not this time |
| 14:41.15 | seanbright | the code does look similar to that same issue though |
| 14:41.46 | file | agreed |
| 14:42.31 | coreyfarrell | makes sense to me based on the bug report, a 302 redirect would cause the sip dialog to be replaced so the old one gets freed. |
| 14:58.32 | file | I think it's the 180 and then 200 that ultimately did it |
| 14:59.14 | file | seanbright: I'm not sure what to do on https://issues.asterisk.org/jira/browse/ASTERISK-28295 - thoughts? |
| 15:09.58 | seanbright | file: yeah... |
| 15:10.03 | seanbright | well |
| 15:10.16 | seanbright | it's grammatically valid |
| 15:11.07 | seanbright | there is no easy answer |
| 15:11.20 | file | yeah |
| 15:11.26 | seanbright | i assume pjsip unescapes it blindly? |
| 15:11.33 | file | probably |
| 15:11.34 | seanbright | or decodes it, i should say |
| 15:11.42 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-uwvmbapkaslnyasb) |
| 15:11.42 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:12.11 | file | we can dance! |
| 15:12.29 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:12.29 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:13.05 | file | it's the JIRA Issue triage danceeeee |
| 15:19.43 | seanbright | i'm surprised there are not RFCs that address this type of thing |
| 15:20.11 | seanbright | my guess is that you probably shouldn't decode them because you don't know what encoding (charset-wise) they are |
| 15:23.20 | seanbright | or the other options - STOP PUTTING STUPID SHIT IN YOUR REQUEST URIs |
| 15:46.32 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-cvrfkidmvzdsvekn) |
| 15:46.32 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:59.55 | seanbright | weird... Diversion isn't IANA registered |
| 16:00.19 | seanbright | ah, historic. |
| 16:01.12 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 16:09.34 | seanbright | if that review looks familiar... it's because it is |
| 16:16.40 | *** join/#asterisk-dev snuff-work (~snuff-wor@202-161-112-134.tpgi.com.au) |
| 16:16.40 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 16:38.14 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 17:05.23 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@2600-6c65-767f-e1b2-5a17-7656-2f73-2194.dhcp6.chtrptr.net) |
| 17:05.23 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 17:07.05 | seanbright | ruh-roh |
| 17:07.34 | seanbright | worldwide community director's last day |
| 17:07.38 | seanbright | that doesn't bode well |
| 17:07.52 | seanbright | updates his local git mirror |
| 17:08.08 | file | just means more work for me probably! #BoostEgo |
| 17:21.40 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.42) |
| 18:05.26 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 18:48.40 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 18:58.04 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 19:47.44 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 20:57.00 | seanbright | ASTERISK-25389 |
| 20:57.08 | seanbright | "On a memory constrained system (where malloc may fail), encountered a crash where pjsip_msg_find_hdr() returns a contact_hdr with null uri." |
| 20:57.21 | seanbright | "... where malloc may fail ..." |
| 20:57.34 | seanbright | "... malloc may fail ..." |
| 20:57.40 | seanbright | "MALLOC MAY FAIL" |
| 20:57.41 | seanbright | heh |
| 21:01.02 | kharwell | hrm seems like we fixed that |
| 21:03.01 | kharwell | well not the malloc may fail part, but if that function returns null |
| 21:04.41 | seanbright | well either way |
| 21:04.53 | seanbright | if malloc() fails you are in a world of hurt |
| 21:05.33 | kharwell | yes and if I recall I don't think you are even guaranteed it will return NULL |
| 21:05.40 | kharwell | if it fails |
| 21:06.48 | seanbright | right, you just get murdered |
| 21:07.35 | kharwell | just another malloc murder |
| 21:30.35 | seanbright | is everything pre-git gone gone? |
| 21:30.43 | seanbright | like the history of menuselect? |
| 21:31.23 | file | origsvn still exists? |
| 21:31.31 | seanbright | ah |
| 21:32.25 | seanbright | old ssl |
| 21:34.10 | seanbright | wait, maybe not |
| 21:34.58 | seanbright | does anyone know if russell was a digium employee on 2007-03-15? |
| 21:35.12 | file | uhhhh |
| 21:35.28 | file | shrugs |
| 21:36.26 | seanbright | seems he was |
| 21:40.55 | seanbright | asterisk.org needs an update |
| 21:41.03 | seanbright | Asterisk 15: Under the Hood |
| 22:25.51 | *** join/#asterisk-dev sahmed (~sahmed@cpe-70-114-236-63.austin.res.rr.com) |
| 22:28.06 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 22:30.05 | sahmed | Hello, I have run the asterisk testsuite with valgrind and found some definite lost, is there anything to consider? |
| 22:31.19 | sahmed | we have found such 6 definite lost in the different test cases, |
| 22:31.52 | coreyfarrell | sahmed: you want to pastebin the output? |
| 22:32.06 | sahmed | sure |
| 22:36.11 | sahmed | corefarrell: https://pastebin.com/rBRapSjm |
| 22:38.36 | sahmed | @corefarrell this is just the definite lost error, there have some other possible lost also. |
| 22:39.44 | *** join/#asterisk-dev stevedavies (~stevedavi@197.155.252.3) |
| 22:41.39 | coreyfarrell | sahmed: what you posted is associated with thread local storage, could be that the system exited without closing a couple of pjproject threads (not a huge surprise). I'm guessing you also have some 'possibly lost' with pthread_create in the backtrace. |
| 22:50.04 | sahmed | <coreyfarrell> All 'definitely lost' are similar to posted one, so, no need to worry about it. |
| 22:54.21 | coreyfarrell | sahmed: you might be able to get valgrind to report clean by adding `memcheck-delay-stop` to the test-config.yaml for the test in question, this would let asterisk 'cooldown' after the test completes / before shutting down asterisk. sometimes there will be active timers when the test finishes so you could delay long enough to let those timers expire and the associated threads can exit. |
| 22:55.38 | coreyfarrell | so far `memcheck-delay-stop` has only been used on tests where it allowed REF_DEBUG to report clean results (all ao2 objects freed). usually the option is combined with pjsip config setting timer_t1 / timer_b to minimum. |
| 22:57.07 | sahmed | Thanks @Coreyfarrell thats a good option, I will try with this one |
| 23:08.31 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-uwvmbapkaslnyasb) |