| 01:40.29 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 01:40.29 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 06:13.39 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 06:20.56 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.58) |
| 06:47.07 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:47.07 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:09.12 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:12.26 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 08:32.22 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:23.07 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01:e0a:d:1111:c539:1e6:3c08:c8f4) |
| 09:25.46 | *** join/#asterisk-dev ahmed89 (~ahmed89@82.178.171.52) |
| 09:37.48 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 11:12.18 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 12:49.19 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 13:00.09 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:c539:1e6:3c08:c8f4) |
| 13:16.14 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 14:21.55 | *** join/#asterisk-dev sduthil (~sduthil@modemcable094.94-70-69.static.videotron.ca) |
| 14:38.35 | *** join/#asterisk-dev jkroon (~jkroon@213.150.207.83) |
| 14:39.59 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:39.59 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:20.57 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qzfwcnrjcrwnwsjp) |
| 15:20.57 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:21.02 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-refxokthfputbutt) |
| 15:21.02 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:26.38 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-jfiyypxcggpulryw) |
| 15:26.38 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:29.18 | seanbright | happy monday you sons of guns |
| 15:30.39 | jsmith | seanbright: Same back at you... |
| 15:34.46 | cresl1n | waves to seanbright |
| 15:35.53 | *** join/#asterisk-dev AsteriskRoss (259d3426@gateway/web/freenode/ip.37.157.52.38) |
| 15:41.10 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 15:49.20 | seanbright | what's good? asterisk still awesome? |
| 15:50.52 | file | seanbright: oui! |
| 15:51.42 | seanbright | fantastic |
| 15:57.47 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-raftyschymqvhkys) |
| 15:57.47 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:33.23 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.35) |
| 18:26.01 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 19:18.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 19:33.20 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 19:50.54 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 22:00.38 | seanbright | heh |
| 22:00.55 | seanbright | i like the civil discourse on gerrit |
| 22:00.59 | seanbright | "this is useful" |
| 22:01.03 | seanbright | "why is this useful?" |
| 22:01.14 | seanbright | "IT'S USEFUL!" Code Review +2 |
| 22:10.41 | cresl1n | Sorry about that seanbright |
| 22:10.45 | cresl1n | that was one that I was pushing for |
| 22:10.55 | seanbright | no apologies necessary |
| 22:11.09 | cresl1n | we've had a number of different customer issues where it's helped us figure out the memory situation with more clarity |
| 22:11.52 | cresl1n | discerning between temporary process heap spikes from long term memory leaks |
| 22:12.20 | cresl1n | ugh |
| 22:12.23 | cresl1n | english |
| 22:12.36 | cresl1n | that's what I get for typing in IRC while talking to someone at the same time |
| 22:12.57 | file | you should know better |
| 22:13.43 | seanbright | if gerrit had tags we could have a not-up-for-discussion one |
| 22:14.04 | seanbright | or maybe we just prepend or append NUFD to the topic? i dunno |
| 22:14.20 | kharwell | well still be good to know why in the commit message. for like historical purposes and stuff |
| 22:16.21 | file | um |
| 22:16.23 | seanbright | i actually do have review comments |
| 22:16.36 | seanbright | i'll just submit a secondary review since this one is already green-lit |
| 22:17.25 | cresl1n | *so* sorry about the rush on it |
| 22:17.36 | cresl1n | we were trying to get releases cut sooner rather than later since it's been so long |
| 22:17.43 | seanbright | i'm being a _little_ passive aggressive |
| 22:17.46 | seanbright | but just a little |
| 22:18.04 | cresl1n | We can wait on releases if you have some feedback you'd like to put against them |
| 22:18.19 | seanbright | nope. go with god. |
| 22:18.22 | cresl1n | or rather, feedback that didn't make the +2 deadline |
| 22:18.23 | cresl1n | ok |
| 22:18.56 | cresl1n | if you have good feedback though, that's important |
| 22:19.03 | kharwell | we can cut an RC2 for the updated commit message :-D |
| 22:19.06 | seanbright | i have no feedback |
| 22:19.11 | seanbright | the function shouldn't be indented |
| 22:19.15 | seanbright | that's my feedback |
| 22:19.34 | cresl1n | Osnap |
| 22:19.36 | seanbright | ANnnnnnnd... |
| 22:19.37 | cresl1n | that's good feedback |
| 22:19.37 | cresl1n | :-) |
| 22:19.40 | seanbright | i don't see how it's useful |
| 22:19.41 | seanbright | BUT |
| 22:19.57 | seanbright | it's your project |
| 22:20.01 | seanbright | i just armchair code |
| 22:20.16 | seanbright | or monday morning coderbacking |
| 22:20.21 | seanbright | whatever the appropriate term is |
| 22:23.00 | gtjoseph | seanbright: the issue comes up most often with 32 bit instances. we've seen customers where asterisk is getting killed because a process can't allocate more than around 3g of memory on a 32 bit system. |
| 22:23.30 | gtjoseph | so the question is whether it's because there's a leak or because the heap is so fragmented that there isn't enough contiguous memory available. |
| 22:24.04 | gtjoseph | the malloc_trim compacts the heap and returns the unused back to th ekernel. |
| 22:24.05 | seanbright | roger that |
| 22:24.21 | seanbright | that would be potentially useful in the commit message |
| 22:24.23 | gtjoseph | that tells us leak vs fragmentation |
| 22:24.40 | kharwell | merged failed so commit and what not can be updated if need be |
| 22:25.49 | gtjoseph | yeah it would have. it was a patch that rmudgett had in his library for a while. |
| 22:26.12 | gtjoseph | at this point, let's just get it in so we can do the releases. |
| 22:26.27 | seanbright | one sec |
| 22:27.26 | gtjoseph | seanbright: dammit, i was already merging when i saw your "one sec". sorry. |
| 22:27.35 | gtjoseph | is there an issue? |
| 22:27.42 | seanbright | "IT'S USEFUL!" |
| 22:27.44 | seanbright | nope |
| 22:27.49 | seanbright | i was just updated the patch |
| 22:27.52 | seanbright | nbd |
| 22:28.05 | seanbright | updating* |
| 22:28.41 | gtjoseph | for the commit message or something functional? |
| 22:28.46 | seanbright | it's fine |
| 22:28.48 | seanbright | let's move on |
| 22:28.53 | seanbright | release release release |
| 22:30.37 | seanbright | also, if anyone wants a panasonic KX-UT670 for an absolute steal, some asshole on ebay is selling one super cheap |
| 22:30.48 | seanbright | https://www.ebay.com/itm/Panasonic-Executive-SIP-Phone-W-7-in-Color-Touch-Screen-VoIP/173662952873 |
| 22:31.12 | cresl1n | Would it make me an executive? |
| 22:31.12 | gtjoseph | does it have a better description than "It's useful"? |
| 22:31.25 | cresl1n | If not, I say pass. |
| 22:31.41 | cresl1n | :-P |
| 22:32.06 | seanbright | what about a gigaset C530ip? with the EU power adapters instead of US ones |
| 22:32.13 | seanbright | so useful |
| 22:33.01 | seanbright | so hot right now |
| 22:33.19 | file | seanbright: kharwell will be doing the rcs and will be here for a bit, so if you'd like to tweak anything before then we can wait and then review immediately and get it sorted from a code perspective, alas we can not alter history |
| 22:33.42 | cresl1n | +1 |
| 22:36.29 | seanbright | ok |
| 22:45.15 | file | seanbright: double the the, double the fun |
| 22:45.33 | seanbright | :P |
| 22:46.39 | file | minor comment. |
| 22:47.40 | seanbright | minor fix. |
| 22:48.38 | file | kharwell: give 'er a looksee and merge in once the builds finish eh |
| 22:49.10 | seanbright | thank you for enabling me, file. |
| 22:49.18 | file | bill is in the mail |
| 22:49.23 | file | :D |
| 22:49.32 | kharwell | file: I shall |
| 23:00.31 | file | seanbright: merci |
| 23:00.34 | file | kharwell: also merci |
| 23:00.59 | kharwell | no problemo |
| 23:20.37 | rmudgett | no potato |