| 00:11.15 | file | coreyfarrell: I'm on a slight mission to remove silly stringfield usage when I see it >_> |
| 00:15.19 | coreyfarrell | file: I support. I'd say include situations where we have static strings combined with non-static strings in stringfields. the static strings will prevent the first (and maybe second) buffer allocation from ever releasing. |
| 00:15.33 | file | yeah |
| 00:16.12 | coreyfarrell | in that case it would be better to have 'char buf[0];' for the static strings |
| 00:36.52 | coreyfarrell | file: -1 on the backtrace reviews is for the merge conflict? |
| 00:37.17 | file | yeah, I forgot that didn't overrule the +2 indication on the list |
| 00:38.00 | file | there. |
| 02:09.44 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 02:09.44 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:16.17 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 07:03.52 | *** join/#asterisk-dev tsearle (~tsearle@188.44.81.78) |
| 07:03.52 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:18.47 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 07:21.49 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 09:12.42 | *** join/#asterisk-dev moy (sid47040@gateway/web/irccloud.com/x-rxiqvlvqsxnkwlks) |
| 09:42.05 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 10:31.28 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:45.19 | *** join/#asterisk-dev pchero_work (~pchero@87.213.247.82) |
| 11:56.42 | coreyfarrell | file: I'm guessing that breaking the ABI of 'struct ast_sip_session_supplement' in 13/16 would be a big deal? |
| 11:56.53 | file | yeah... |
| 11:57.49 | coreyfarrell | I wish we had an explicit mechanism for the rare ABI breakage within releases. sometimes it's unavoidable (security fixes), other times it's highly desirable (like this patch). |
| 12:01.53 | coreyfarrell | the only thing I can think of is to create 'struct session_supplement_private { struct ast_sip_session_supplement supp; struct ast_module *mod; };' and allocate/link that to the registry. |
| 12:03.12 | file | yeah |
| 12:06.31 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.61) |
| 12:09.44 | coreyfarrell | do those reviews for 15 that you just closed not apply to 13? |
| 12:12.26 | file | they don't |
| 14:15.16 | *** join/#asterisk-dev sduthil (~sduthil@modemcable094.94-70-69.static.videotron.ca) |
| 14:20.25 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:20.25 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:25.11 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-pnaddgazpcmqfkjz) |
| 14:25.11 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:33.24 | pchero_work | Ah⦠Sorry about stupid merge request. :'( |
| 14:33.38 | gtjoseph | no worries! |
| 14:33.58 | pchero_work | gtjoseph: Thanks. :) Btw, where can I find a __builtin_alloca() ? |
| 14:34.14 | pchero_work | Just wondering how does it working. |
| 14:35.03 | gtjoseph | <PROTECTED> |
| 14:35.32 | gtjoseph | (or really when whatever scope it was called in ends) |
| 14:35.41 | gtjoseph | see alloca() |
| 14:37.22 | pchero_work | Ah, I can see it. Thanks! I learned something. :) |
| 15:00.34 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-afjnjaemmoomthaf) |
| 15:00.34 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:04.01 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 15:36.46 | file | gtjoseph: good thing these actions are atomic |
| 15:37.39 | gtjoseph | which actions? |
| 15:37.58 | file | oh nevermind, I clashed with myself HA |
| 15:38.06 | file | I thought we were merging stuff at the same time |
| 15:38.16 | gtjoseph | heh |
| 15:38.27 | gtjoseph | i was just about to take a pass at them |
| 15:38.38 | gtjoseph | but saw you were doing them |
| 15:39.13 | file | yeah, connected_no_send in most cases |
| 15:39.21 | gtjoseph | yep |
| 15:39.45 | gtjoseph | if you look at the test analyzer there's a thing at the bottom which lists the top 10 failing tests |
| 15:48.06 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 15:57.02 | coreyfarrell | test analyzer doesn't work for me, just sits with the loading indicator. |
| 15:57.26 | gtjoseph | hmmm. it's set to only scan the last 5 jobs by default |
| 15:57.32 | gtjoseph | so it should be quick |
| 15:57.37 | gtjoseph | which job? |
| 15:58.06 | coreyfarrell | gtjoseph: https://jenkins2.asterisk.org/job/asterisk-gatetests/job/master/test_results_analyzer/ |
| 15:58.49 | gtjoseph | took about 5 seconds for me |
| 15:59.26 | gtjoseph | maybe start the developer console and see if there are any JS errors? |
| 15:59.36 | coreyfarrell | ah I just noticed that I wasn't signed in, I clicked login and now it's working |
| 15:59.46 | gtjoseph | :) |
| 15:59.52 | coreyfarrell | which is surprising, I thought you had to be signed in to see anything in jenkins |
| 16:04.13 | gtjoseph | it's weird. if your session expired you still get access to most things which is different than not having a session at all. |
| 18:33.04 | *** join/#asterisk-dev elcontrastador (~textual@70-90-215-98-BusName-ca.sacra.hfc.comcastbusiness.net) |
| 20:14.00 | X-Rob | file: I'm in #debian-voip on oftc, and they're really grumpy about libasteriskpj vs libpjproject. I'm trying to say that using non-bundled pjproject is a bad idea. Am I wrong? Even in the 16 branch you have patched a 'breaking change'. |
| 20:14.13 | X-Rob | What would you prefer? |
| 20:14.20 | file | we support and recommended bundled |
| 20:14.24 | file | er recommend |
| 20:14.45 | file | it is built for server usage for Asterisk, and receives fixes that directly impact our users ahead of a PJSIP release |
| 20:15.04 | file | Asterisk can be built non-bundled, but if it's a PJSIP problem we generally won't support it |
| 20:15.41 | gtjoseph | bundled is also what we test with. |
| 20:16.10 | X-Rob | Yeah, that's what I said. |
| 20:16.50 | *** join/#asterisk-dev sh_smith (~sh_smith@cpe-76-174-26-91.socal.res.rr.com) |
| 20:17.10 | X-Rob | Thanks guys. I will continue arguing that line. Their problem is, the debian build guidelines require repeatable builds, which means 'no downloading of stuff from the internet'. So I had to put the 2.7.2.tar.gz into the actual debian package, which made it huge, and I think that could be one of the dramas. |
| 20:17.55 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 20:18.46 | gtjoseph | can you specify an exact version of pjproject in your package dependencies? |
| 20:19.16 | gtjoseph | except for the updates we've added, that'd be close. |
| 20:19.28 | file | gtjoseph: well - except for the build config |
| 20:19.49 | gtjoseph | correct, and also things like propogating MALLOC_DEBUG |
| 20:21.19 | X-Rob | I believe they have seen the light |
| 20:21.28 | gtjoseph | cool |
| 20:22.06 | file | packages are cool and all, but I value the end software for the users and how it performs >_> |
| 20:23.20 | coreyfarrell | gtjoseph: I'd hope a distro package would not enable MALLOC_DEBUG :/ |
| 20:23.31 | gtjoseph | yep, me too. |
| 20:28.22 | X-Rob | Ah. IT's a licencing issue, with pjproject. |
| 20:28.29 | X-Rob | https://tracker.debian.org/media/packages/p/pjproject/copyright-2.7.2dfsg-4 |
| 20:30.58 | X-Rob | OK, next question. How far away is the pj2.8 commit that's in the 16 branch? https://github.com/asterisk/asterisk/commit/60258b4ec1d13f8ee135d163b00a0c8d99eccb09#diff-aaa08002437a3c86db3ac9616388e317 |
| 20:31.18 | gtjoseph | how ffar away from what? |
| 20:31.26 | X-Rob | from making into a .tar.gz that debian wants 8-( |
| 20:31.40 | gtjoseph | that's up to Teluu. we have no control over that |
| 20:32.24 | X-Rob | You don't know when that commit, in the asterisk repo, is going to be put into an asterisk tarball? |
| 20:32.35 | gtjoseph | oh an asterisk tarball |
| 20:32.43 | file | you were not specific in your query |
| 20:32.46 | X-Rob | I was not. |
| 20:32.58 | file | next releases probably in 2 weeks? |
| 20:33.01 | gtjoseph | then yeah... within two weeks i'd guess |
| 20:33.10 | X-Rob | Ooooh. Ok. Thanks. |
| 20:33.31 | gtjoseph | 13.24 and 16.1 |
| 20:33.42 | coreyfarrell | testing is looking much better than it was a couple days ago :) |
| 20:33.51 | gtjoseph | no kidding |
| 20:35.32 | gtjoseph | are we taking bets on the first gate to pass and auto-merge? |
| 20:35.44 | file | I'm not |
| 20:38.10 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.34) |
| 20:46.53 | X-Rob | Update: I have proposed that someone magic's a DFSG compatible pjproject-2.8.tar.gz into existence (which is just physically removing the code that is --disabled in pj's ./configure). If someone can bless that, I could then use THAT to build the 16.1 dpkg. Then everyone's happy, until asterisk upgrades pjproject next time 8) |
| 21:21.39 | seanbright | that'd be a fun project |
| 21:21.49 | seanbright | when do i kick myself in the nuts? before, during, or after? |
| 22:26.54 | X-Rob | Why not both? |
| 22:27.10 | X-Rob | </debian> |
| 22:59.31 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-vdaopmccioptbvnx) |
| 22:59.31 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |