| 01:24.44 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 01:24.44 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 01:52.35 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 03:23.40 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 07:15.36 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:b749:768d:ed77:7c9a) |
| 07:57.56 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 08:09.05 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.61) |
| 08:35.30 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:20.53 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.27.29) |
| 11:16.44 | *** join/#asterisk-dev CELYA_ (~Thunderbi@lstlambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 12:35.45 | coreyfarrell | csavinovich: https://gerrit.asterisk.org/#/q/topic:pjproject-devmode should resolve the pjsua codec error. |
| 12:55.19 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 12:55.24 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-zndjmuuowonwomfy) |
| 12:55.24 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 13:10.03 | csavinovich | Thank you @cfarrell for the work but I must apologize cause I might not have propose it better yesterday. What we want is actually to enable 711 when in dev-mode, and since it is never disabled in non-dev mode therefore eliminating the following "if" entirely will have the effect of keeping it enabled for both dev and non-dev modes, which is what we want. |
| 13:10.03 | csavinovich | Eliminate this: |
| 13:10.03 | csavinovich | ifeq ($(findstring TEST_FRAMEWORK,$(MENUSELECT_CFLAGS)),) |
| 13:10.03 | csavinovich | <PROTECTED> |
| 13:10.03 | csavinovich | endif |
| 13:10.04 | csavinovich | After all, we'll never have the ability to have a phone conversation if there are no codecs :) |
| 13:11.29 | csavinovich | @coreyfarrell |
| 13:23.51 | coreyfarrell | csavinovich: with my patch we don't install pjsua (binary or python) unless dev-mode is enabled. so the normal compile mode excludes those codecs so because they would make libasteriskpj.so.2 larger for no benefit. |
| 13:25.17 | coreyfarrell | looks like my first patch had a slight error where pjsua was still built during ./configure without dev-mode but then the final build worked correctly. I'm fixing that now. |
| 13:43.07 | gtjoseph | coreyfarrell: if you have a minute, could you look at the final versions of the backtrace patches? |
| 13:46.10 | csavinovich | @coreyfarrell: Got it. Thank you Corey. |
| 13:47.18 | coreyfarrell | gtjoseph: looks like you're missing the ------ below 'Core' in CHANGES on 13 only. good otherwise. |
| 13:47.26 | gtjoseph | Oh god. |
| 13:48.00 | gtjoseph | that's weird. how did I delete that. |
| 13:48.43 | gtjoseph | fixed |
| 14:09.45 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 14:35.42 | *** join/#asterisk-dev pchero_work (~pchero@60.30.148.146.bc.googleusercontent.com) |
| 14:45.09 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:45.09 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:54.17 | coreyfarrell | gtjoseph: if I understand correctly 'set timeout 600' will cause expect to timeout after 10 minutes of no output from the asterisk console? also should the expect script run 'core stop now' if timeout occurs? |
| 14:54.41 | gtjoseph | correct on the timeout |
| 14:55.08 | gtjoseph | if there's no output for 10 minutes i'm not sure issuing core stop now will help. |
| 14:55.52 | gtjoseph | when the container goes away so will the process... if you're running in a container |
| 14:56.32 | gtjoseph | i could add a kill at the end just in case but we don't have that now. |
| 14:57.12 | gtjoseph | what do you think? |
| 14:57.57 | coreyfarrell | don't worry about it.. if we need a kill it can be added later |
| 14:58.44 | gtjoseph | i don't have a problem tossing a "killall -KILL $DESTDIR/usr/sbin/asterisk" in there now. |
| 15:00.45 | coreyfarrell | if you're going to do that maybe SIGABRT would be better? that way if the unit tests lock up we'll get a backtrace that might show us where/why |
| 15:01.04 | gtjoseph | good idea |
| 15:04.07 | gtjoseph | done |
| 15:29.19 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-opfzdilllmgwviyh) |
| 15:29.19 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:35.14 | *** join/#asterisk-dev pchero_work (~pchero@60.30.148.146.bc.googleusercontent.com) |
| 15:57.25 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-gzalcibrhpshzcbu) |
| 15:57.25 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:29.15 | *** join/#asterisk-dev dandann00dle (~dandann00@c-76-114-64-149.hsd1.tn.comcast.net) |
| 17:05.18 | *** join/#asterisk-dev tuxd00d (~tuxd00d@unaffiliated/tuxd00d) |
| 18:37.37 | coreyfarrell | csavinovich: I'm not trying to be difficult on that review but the old conditional was correct. the problem is that something is preventing pjproject from being rebuilt after upon changes to menuselect. I haven't been able to figure out what stops the rebuild from happening. |
| 18:38.40 | coreyfarrell | really the issue of not rebuilding after changes to MENUSELECT_CFLAGS is not fixed (I was not able to reproduce that issue so I don't know how to deal with it). my guess is that issue will still cause problems where setting DONT_OPTIMIZE doesn't cause a rebuild of the bundled pjproject. |
| 18:42.21 | coreyfarrell | if someone shows me a way to reliably reproduce the failure to rebuild pjproject when needed then I'm sure I could find a fix to that as well. |
| 18:42.50 | *** join/#asterisk-dev snuff-work (~snuff-wor@202-161-112-134.tpgi.com.au) |
| 18:42.50 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 18:44.26 | gtjoseph | coreyfarrell: i'm not sure why it's failing either unless certain versions of make aren't honoring the "include ../../menuselect.makeopts" |
| 18:52.37 | csavinovich | @coreyfarrell, no problem at all, you've been right the whole time. I was just trying to leave an accurate comment. |
| 18:52.37 | csavinovich | As per the reproducing it, yesterday I reproduced it every time I did a "make dist-clean" |
| 18:53.45 | coreyfarrell | gtjoseph: the weird thing is kharwell's trace appears to show that pjproject is being rebuilt, but not reconfigured. https://pastebin.com/ATMbd8wq |
| 18:53.46 | csavinovich | ...and manually did "make menuselect.makeopts" |
| 18:54.00 | gtjoseph | hmmm |
| 18:54.40 | coreyfarrell | csavinovich: on what platform? gtjoseph might be right that this has something to do with the version of make. I'm using Fedora 28 and I believe gtjoseph also uses Fedora, might be why we're not having this issue? |
| 18:55.11 | kharwell | yep unchecked BUILD_NATIVE and the it would reconfigure pjproject and rebuild |
| 18:55.19 | csavinovich | I am using good old CentOS Linux release 7.4.1708 |
| 18:55.52 | kharwell | I tried it from a clean directory too and if I initially unchecked BUILD_NATIVE it reconfigured too vs going back and unchecking it after building the first time |
| 18:56.00 | gtjoseph | kharwell: but DONT_OPTIMIZE wouldn't trigger it? |
| 18:56.40 | csavinovich | @kharwell: after @coreyfarrell's review change I didn't have the need to touch BUILD_NATIVE |
| 18:58.01 | csavinovich | kharrell uses ubuntu |
| 18:58.54 | coreyfarrell | csavinovich: well my patch that uses --enable-dev-mode removes the need to reconfigure pjproject after using menuselect. I suspect you'll still have an issue with DONT_OPTIMIZE not forcing a rebuild. |
| 19:01.08 | csavinovich | I can test that |
| 19:05.15 | kharwell | gtjoseph: nope DONT_OPTIMIZE appeared to not trigger it. |
| 19:05.33 | gtjoseph | i don't understand that at all |
| 19:06.24 | kharwell | I had DONT_OPTIMIZE, BETTER_BACKTRACES, MALLOC_DEBUG, DO_CRASH, TEST_FRAMEWORK all checked along with BUILD_NATIVE. After unchecking BUILD_NATIVE it triggered the reconfigure |
| 19:06.27 | kharwell | ya it's a weird one |
| 19:13.09 | csavinovich | guys, I get PJSUA build now on all instances, regardless of the DONT_OPTIMIZE flag |
| 19:25.08 | csavinovich | ....and regardless of the BUILD_NATIVE flag |
| 21:14.23 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d000c5fcae2d3e7ce80.ipv6.abo.wanadoo.fr) |
| 21:33.31 | *** join/#asterisk-dev dandann00dle (~dandann00@c-76-114-64-149.hsd1.tn.comcast.net) |
| 22:19.25 | *** join/#asterisk-dev dandann00dle (~dandann00@c-76-114-64-149.hsd1.tn.comcast.net) |
| 23:21.25 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-opfzdilllmgwviyh) |
| 23:38.24 | *** join/#asterisk-dev dandann00dle (~dandann00@c-76-114-64-149.hsd1.tn.comcast.net) |
| 23:42.59 | *** join/#asterisk-dev dcollins0 (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |