| 00:00.50 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:9967:99fc:50e4:95a3) |
| 00:30.25 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 00:30.26 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:40.43 | FrankyCyborg | I assume the people developing the pjsip software are completely different from those who develop asterisk? or is some pjsip developer in this channel by any chance? |
| 05:51.17 | *** join/#asterisk-dev opticron_ (~opticron@75.76.209.103) |
| 05:51.17 | *** mode/#asterisk-dev [+o opticron_] by ChanServ |
| 06:11.50 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:11.50 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:20.40 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 10:37.48 | coreyfarrell | FrankyCyborg: no actual pjproject developers here (that I know of). some here do write patches pjproject. BTW if you are patching a bunch of errors for OSX I would suggest against submitting one gigantic patch. |
| 10:41.02 | coreyfarrell | FrankyCyborg: huge patches are more difficult to review and it's better to get some feedback on small pieces before you do a lot of work |
| 10:59.49 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.126) |
| 11:03.44 | *** join/#asterisk-dev pchero_work (~pchero@87.213.240.121) |
| 13:46.47 | *** join/#asterisk-dev dandann00dle (~dandann00@2601:840:8401:d7ee:cd87:f9f3:b237:db82) |
| 14:20.26 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-wboebqzmjkicnkvn) |
| 14:20.26 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:30.12 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:30.12 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:37.55 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-bmebuntygigciwep) |
| 14:37.55 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:40.29 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-yhxjmmjviosaqrat) |
| 15:40.29 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:32.10 | bford | coreyfarrell: for the sip blind transfer tests, pjsua was trying to send the INVITE via TCP instead of UDP |
| 16:35.38 | coreyfarrell | bford: cool, I'm giving it a test locally. probably should modify the commit messages to close ASTERISK-28085 |
| 16:36.03 | bford | oh, der |
| 16:36.08 | bford | ill update it |
| 16:40.45 | coreyfarrell | bford: thanks! |
| 16:41.08 | bford | np! |
| 18:01.14 | gtjoseph | seanbright: were you involved in Robert Cripps' packetization patch https://gerrit.asterisk.org/#/c/asterisk/+/10495/ other than uploading it? Any other insight on the issue? |
| 18:01.44 | seanbright | he uploaded, i just fixed some coding guideline issues to short-circuit those types of comments. |
| 18:01.53 | gtjoseph | gotcha, thanks. |
| 18:18.02 | FrankyCyborg | coreyfarrell: I would always submit small patches, which handle only one thing, because otherwise it gets messy, as you said. aside from that, I still haven't found the reason, why pjsip_uri_get_uri() receives a NULL pointer. |
| 18:21.05 | FrankyCyborg | But I can tell for sure, that the pjproject needs proper stack variable initialization at various places. In pjsip_auth_srv_verify() ( pjsip/sip_auth_server.c ) for example, it's necessary to do bzero( &cred_info, sizeof(pjsip_cred_info) ) ; after variable declaration, as otherwise debugging the cred_info variable later on would result in invalid pointer values (pointing on my machine to the heap) and of course leading to |
| 18:21.05 | FrankyCyborg | a segm. fault. (at least it would be good practice and these few cpu cycles shouldn't matter) |
| 18:30.52 | coreyfarrell | FrankyCyborg: I've never submitted any patches to pjproject.. check out https://www.pjsip.org/ especially go to the 'TRAC' link. they have a CLA so if you intend to submit patches to pjproject might as well get that out of the way now. |
| 18:31.34 | FrankyCyborg | yup, I have the webpage with their mailing list already open ;-) |
| 18:32.02 | seanbright | fwiw, i've submitted patches to their ML and have never signed a CLA |
| 18:32.06 | seanbright | not that you shouldn't |
| 18:32.09 | seanbright | just sayin' |
| 18:32.13 | FrankyCyborg | i'm still not ruling out, that my configuration is a mess or missing something |
| 19:19.09 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 19:22.51 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 20:11.27 | *** join/#asterisk-dev pchero_work (~pchero@dhcp-077-249-058-090.chello.nl) |
| 20:38.56 | seanbright | coreyfarrell: re: 10460 |
| 20:39.31 | seanbright | do the files that are not specifically chan_sip.c require a MODULEINFO section at all? |
| 20:43.38 | coreyfarrell | seanbright: I don't know. AFAIK no technical requirement. cresl1n ? |
| 20:44.39 | seanbright | maybe it's necessary to pick up the documentation blocks |
| 20:44.43 | seanbright | just seems weird |
| 20:46.00 | coreyfarrell | no documentation blocks are found by matching '/*** DOCUMENTATION'. |
| 20:51.10 | coreyfarrell | seanbright: if you insist and others agree we can remove them but I'd rather not bother. |
| 20:51.26 | seanbright | i'm not insisting |
| 20:51.27 | seanbright | i was asking |
| 20:51.52 | seanbright | i apologize for the inconvenience this interaction may have caused |
| 20:51.57 | seanbright | carry on |
| 20:52.24 | coreyfarrell | no worries. and no need to apologize. |
| 20:52.37 | rmudgett | unless you want to :D |
| 22:43.43 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-wboebqzmjkicnkvn) |
| 22:57.18 | *** join/#asterisk-dev dandann00dle (~dandann00@c-76-114-64-149.hsd1.tn.comcast.net) |
| 23:30.35 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-250-191.dhcp.nwtn.ct.charter.com) |
| 23:30.35 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |