| 00:26.02 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 00:26.02 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 01:02.25 | *** join/#asterisk-dev Juggie (~Juggie@unaffiliated/juggie) |
| 01:26.10 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@LFbn-1-5359-81.w90-105.abo.wanadoo.fr) |
| 03:07.36 | *** join/#asterisk-dev seanbright (~sean@asterisk/community-developer/seanbright) |
| 03:07.36 | *** mode/#asterisk-dev [+o seanbright] by ChanServ |
| 06:03.07 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:03.07 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:07.57 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:60cf:a214:c4a6:d5cd) |
| 07:31.06 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:25.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:60cf:a214:c4a6:d5cd) |
| 09:50.47 | *** join/#asterisk-dev tsearle (~tsearle@ptr-a3h0hm4gw886i4y5bap.18120a2.ip6.access.telenet.be) |
| 09:50.47 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 09:58.26 | *** join/#asterisk-dev tsearle (~tsearle@ptr-a3h0hm2un19u8vfoust.18120a2.ip6.access.telenet.be) |
| 09:58.26 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 10:01.39 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:60cf:a214:c4a6:d5cd) |
| 10:13.50 | *** join/#asterisk-dev infobot (ibot@208.53.50.136) |
| 10:13.50 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 10:29.35 | *** join/#asterisk-dev tsearle (~tsearle@ptr-a3h0hm2un19u8vfoust.18120a2.ip6.access.telenet.be) |
| 10:29.35 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 12:47.58 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 12:47.58 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:39.12 | cresl1n | waves |
| 13:39.21 | file | wobbles |
| 14:20.45 | file | cresl1n: I see you accepted the fate of the moh review |
| 14:20.53 | cresl1n | for better or worse |
| 14:20.58 | cresl1n | we'll see how this plays out |
| 14:21.04 | cresl1n | get it? |
| 14:21.05 | cresl1n | :-P |
| 14:21.14 | file | yes, I very much got it, and promptly ignored it |
| 14:21.31 | cresl1n | Ah. |
| 14:21.33 | cresl1n | Wasted |
| 14:21.56 | cresl1n | I'll have to turn my dad humor elsewhere |
| 14:22.31 | file | to your... kids? :D |
| 14:23.28 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-acwtdyvpxifmghvz) |
| 14:23.28 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:43.41 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-hhilltbhwrrxmbju) |
| 14:43.41 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:44.53 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-wvtzhjxvrlwjnbir) |
| 14:44.53 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:38.05 | file | gtjoseph: other stuff is failing - ut roh, it's rebelling! |
| 15:38.29 | gtjoseph | hmmm |
| 15:47.10 | rmudgett | Rise of the machines!!! |
| 16:07.25 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-hbsnusoenekdfigy) |
| 16:11.44 | jameswf | Anyone ariving in Orlando Monday(10/8) ~4pm |
| 16:11.56 | file | um |
| 16:12.07 | file | no. |
| 16:12.16 | file | I wish. |
| 16:12.18 | jameswf | I got the digium list but it only has days not times |
| 16:12.50 | file | lemme see if you have an old one |
| 16:13.42 | file | oh, um, they changed it |
| 16:13.43 | jameswf | I am in at 3:30ish, qwell about 4:20 |
| 16:13.46 | file | it used to include that info |
| 16:14.04 | gtjoseph | not till 7:40 for me |
| 16:14.44 | jameswf | from the west coast it was redeye, 4pm (leaving at 5am) or getting there about 11:30pm |
| 16:15.07 | jameswf | with delta at least |
| 16:15.35 | file | yeah best I could do was leaving here at 6AM and arriving at noon, unless I wanted to arrive at 11:30 too |
| 16:17.49 | jameswf | I need to actually find one of the cool people with a rental so I don't get stuck doing 30 extra minutes akwardly in an uber while the driver learns to navigate orlando |
| 16:18.11 | jameswf | (last 2 times) |
| 16:21.58 | file | jameswf: at least it's not hitchhiking? |
| 16:23.49 | jameswf | That sounds exciting |
| 17:17.26 | seanbright | will those of us not attending in person be able to remotely participate in astridevcon in any fashion? |
| 17:18.15 | file | hoping to make that happen! |
| 17:18.21 | seanbright | you should set up an SFU |
| 17:18.34 | seanbright | i think freeswich does that |
| 17:18.39 | seanbright | har dee har har |
| 17:18.58 | file | did they make an SFU? I know they did MCU :P |
| 17:19.02 | seanbright | yeah i dunno |
| 17:19.06 | seanbright | just trolling. badly. |
| 17:19.38 | file | you? trolling? can't be |
| 17:20.05 | seanbright | say whaaaaaaaaaaaat |
| 17:23.55 | seanbright | does anyone have thoughts on this: u |
| 17:23.58 | seanbright | LOL |
| 17:24.05 | seanbright | THIS => https://issues.asterisk.org/jira/browse/ASTERISK-27406 |
| 17:24.11 | seanbright | silly clipboard. |
| 17:24.37 | seanbright | i've confirmed the behavior. can't really think of an elegant and backwards compatible fix. |
| 17:24.54 | rmudgett | u is the 21st letter |
| 17:25.00 | seanbright | rmudgett: -2 |
| 17:25.23 | seanbright | rmudgett: did you know that or had to look it up? |
| 17:25.26 | file | seanbright: um, don't allow it to start on an odd? |
| 17:25.39 | rmudgett | just giving my 2cents |
| 17:25.42 | rmudgett | :) |
| 17:25.55 | seanbright | (i would have had to look it up... just sayin) |
| 17:26.55 | file | For UDP and similar protocols, |
| 17:26.55 | file | <PROTECTED> |
| 17:26.55 | file | <PROTECTED> |
| 17:26.58 | file | gotta love SHOULD |
| 17:27.44 | seanbright | so the code currently allows: |
| 17:27.53 | seanbright | rtpstart=5001 rtpend=5002 |
| 17:28.54 | seanbright | so we could add validation that fails on odd rtpstarts |
| 17:29.08 | file | aye |
| 17:29.31 | seanbright | and that would be an acceptable behavior change for 13? |
| 17:29.46 | rmudgett | What about the ending. The sample file sets 10000-20000. The 20000 port doesn't then have the next port for RTCP. |
| 17:29.55 | seanbright | right |
| 17:30.25 | seanbright | i would think the correct behavior there would be to limit the upper port to 19998 |
| 17:30.34 | seanbright | so 20000 would never get selected |
| 17:31.11 | seanbright | anyway, happy to patch it, but lots of edge cases to consider |
| 17:31.17 | seanbright | and BC issues too |
| 17:31.59 | rmudgett | That's what makes trivial issues more interesting. :D |
| 17:32.15 | off-nominal | AGREED |
| 17:32.46 | rmudgett | pushed Sean into off-nominal territory |
| 17:34.10 | off-nominal | i think at the absolute minimum, rtpstart needs to be even and rtpend needs to be at least (rtpstart + 2) |
| 17:34.45 | off-nominal | and then the random port selection will be [rtpstart,rtpend) |
| 17:35.40 | off-nominal | i also think it would be interesting to find a way to track used ports, so that we aren't using ast_bind() to figure out if it is in use, but that is a different patch |
| 17:36.47 | off-nominal | uint8_t used[8192] as a bitfield? |
| 17:36.50 | off-nominal | good times. |
| 17:37.08 | file | vector? |
| 17:37.27 | off-nominal | typeof? |
| 17:37.52 | file | tacos? |
| 17:38.00 | off-nominal | what are you storing in the vector? |
| 17:38.13 | off-nominal | the element type? |
| 17:38.35 | file | vector of ints? I dunno |
| 17:38.52 | file | :P hadn't given it any thought |
| 17:39.01 | off-nominal | 2MB |
| 17:39.03 | off-nominal | not bad |
| 17:39.18 | off-nominal | well, 1MB because you'd only need to stop evens |
| 17:39.39 | off-nominal | actually, what happens if the even port is available but the odd port isn't? does rtcp just fail? |
| 17:39.53 | file | I don't think the code would allow that |
| 17:40.01 | file | that is, it wouldn't get into a state where that could happen |
| 17:40.09 | file | unless something external was binding it |
| 17:40.15 | off-nominal | that's what i mean |
| 17:40.17 | file | then RTCP would fail |
| 17:40.18 | off-nominal | something else |
| 17:40.26 | file | it may fail completely |
| 17:40.46 | file | I dare say that's in... off-nominal territory |
| 17:41.00 | off-nominal | dun dun dunnnnnn |
| 17:50.56 | coreyfarrell | in the case of 10001-20000 I think it should just be treated as 10002-19999 (19999 being the highest possible RTCP). |
| 17:54.25 | coreyfarrell | ^^ I don't think this would be worth throwing an error, a warning at most. |
| 17:56.38 | off-nominal | well, it's fine for the defaults |
| 17:56.45 | off-nominal | it gets hairy for non-defaults |
| 17:56.51 | off-nominal | 10001-10002 |
| 17:57.40 | off-nominal | so you round up, 10002 is the only option and then the rtcp port falls outside the range |
| 17:57.49 | off-nominal | and probably outside of firewall rules |
| 17:58.06 | off-nominal | it's pathological worst case |
| 17:58.07 | coreyfarrell | yeah that's an error because it does not contain any valid pairs. |
| 17:58.31 | off-nominal | off-nominal, as it were |
| 18:01.50 | coreyfarrell | in the case of 10001-10002 I think res_rtp_asterisk should decline to load. or in the case of reload it should abort reload (keep all previous settings). |
| 18:03.54 | gtjoseph | If folks could take a quick look at reviews 10041 - 10047 i'd appreciate it. security reviews won't gate until this patch is merged. |
| 18:11.57 | off-nominal | RED BLOB |
| 18:12.21 | off-nominal | i'd +1 it but i have no idea if it is right :-) |
| 18:12.36 | rmudgett | It can't be with a red blob |
| 18:13.02 | rmudgett | They have a tendency to make people see red. |
| 18:13.02 | off-nominal | well, it was there before |
| 18:24.15 | gtjoseph | then there it will stay until I touch that code. |
| 18:26.43 | off-nominal | +1 |
| 18:27.06 | off-nominal | let me try this command line nonsense |
| 18:29.39 | off-nominal | oh snap |
| 18:30.34 | off-nominal | i think i just merged every open review |
| 18:30.35 | off-nominal | too much power |
| 18:30.53 | gtjoseph | :) |
| 18:32.40 | file | off-nominal: https://www.youtube.com/watch?v=VauzhTAuoFw |
| 18:34.15 | off-nominal | wonderful |
| 18:45.55 | file | I'd say the time I spent knocking out that bash script for the topic has already paid off |
| 18:46.05 | gtjoseph | no kiddingf |
| 18:51.42 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0050ddbe958c6f0edd.ipv6.abo.wanadoo.fr) |
| 18:54.22 | off-nominal | rtcpinterval = 0; /* Just so we're clear... it's zero */ |
| 18:54.23 | off-nominal | lulz |
| 19:09.28 | jameswf | script all the things.... but in golang just because |
| 19:10.03 | file | mmm golang |
| 20:00.22 | *** join/#asterisk-dev elguero (~miguel323@74-95-21-41-Connecticut.hfc.comcastbusiness.net) |
| 20:39.52 | off-nominal | file: i updated the disable connection reuse patch - care if i update the review? |
| 20:40.02 | file | nope, go for it |
| 20:40.11 | off-nominal | k |
| 20:40.12 | file | did you check the oauth one? |
| 20:40.18 | off-nominal | it's identical |
| 20:40.21 | file | cool |
| 20:40.28 | file | merci |
| 20:41.12 | off-nominal | well... whitespace is different |
| 20:41.17 | off-nominal | i'll fix that one too |
| 22:58.28 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-acwtdyvpxifmghvz) |