| 00:19.07 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:19.07 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:34.10 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:16ba:8d00:b147:1eac:8028:ad29) |
| 00:49.22 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:16ba:8d00:b147:1eac:8028:ad29) |
| 01:04.50 | *** join/#asterisk-dev leedm777 (~textual@50-81-28-132.client.mchsi.com) |
| 01:04.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:15.41 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:c897:db33:5cfe:7ac3) |
| 02:15.41 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:20.38 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:c897:db33:5cfe:7ac3) |
| 02:20.38 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:37.43 | *** join/#asterisk-dev scgm11__ (~scgm11@2800:a4:1789:d700:6555:1a9d:d46a:ccf0) |
| 02:47.36 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:89e8:c4df:6299:629b) |
| 02:47.37 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 08:32.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.37.182) |
| 08:43.48 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.37.182) |
| 08:51.37 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.37.182) |
| 09:58.27 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 09:58.27 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 10:44.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:418:85c5:3172:dac9) |
| 10:57.26 | *** join/#asterisk-dev maurice2k (~maurice2k@213.95.133.22) |
| 10:58.13 | maurice2k | hi there, anyone here with knowledge on func_talkdetect.c? |
| 11:09.33 | maurice2k | logic in func_talkdetect is completely wrong regarding talking detection |
| 11:10.32 | maurice2k | it is mixing millisecond thresholds with avg. amplitude thresholds |
| 11:14.12 | maurice2k | looks like nobody ever used it? func_talkdetect is responsible for ARI events ChannelTalkingStarted / ChannelTalkingFinished |
| 11:26.25 | coreyfarrell | maurice2k: I have never used it. it's still early so maybe later people will be here who have used it. you could also try #asterisk, often more people in that channel so maybe someone could help confirm if you are dealing with a bug. |
| 11:28.06 | maurice2k | coreyfarrell: thx |
| 12:28.39 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 13:14.29 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-50-9-49.dialup.adsl.anteldata.net.uy) |
| 13:58.20 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-agnjnhutktkvmzcz) |
| 13:58.20 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:08.45 | *** join/#asterisk-dev csavinovich (~KingDavid@ip98-169-120-168.dc.dc.cox.net) |
| 14:14.54 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-srhptpzdbmhooayc) |
| 14:14.54 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:37.16 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-qddlggtusaoggbvj) |
| 14:37.16 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:41.22 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:41.22 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 14:41.25 | cresl1n | fseeks and ftells seanbright |
| 14:43.27 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-skdmiwglwqqalqum) |
| 14:43.28 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:44.08 | seanbright | i know. that patch is sexy. |
| 14:44.21 | seanbright | so general opus question |
| 14:44.47 | seanbright | as we all know format_ogg_opus is going to convert opus to slin48, so it's basically pointless to have .opus files |
| 14:45.27 | seanbright | i'm wondering if there is some way to read opus samples out of a file and send it without first transcoding it |
| 14:45.54 | gtjoseph | kharwell might know ^^ |
| 14:46.08 | cresl1n | kharwell did a lot of the opus work |
| 14:46.41 | file | the answer is - if you properly read the container, yes? |
| 14:46.54 | *** join/#asterisk-dev Oooohboy (~Oooohboy@cpe-67-11-10-120.satx.res.rr.com) |
| 14:46.58 | file | unless you are meaning just stuffing it in containerless in some way |
| 14:48.11 | seanbright | what i mean is... if i have foo.g729 file and my endpoint is using g729, asterisk can just blindly pull samples from foo.g729 and send them to my endpoint |
| 14:48.19 | seanbright | i want the same thing, but with opus |
| 14:48.32 | file | opus is a bit more difficult because they can be different sizes |
| 14:48.43 | file | other things, g729, ulaw, g722, are fixed |
| 14:49.05 | file | so it's comparatively easy to just pull data out |
| 14:49.48 | kharwell | what file is saying basically. Also we currently use a library to handle that, and I can't remember if that is the only way it could do it |
| 14:50.34 | seanbright | but the packet (frame, whatever) has to provide some indication of its size, no? |
| 14:50.40 | kharwell | guessing not since we'd for sure want to skip the transcoding step there if possible |
| 14:50.57 | seanbright | i guess i'm looking for a way to 'read 20ms of opus data from this file (and don't convert it to pcm)' |
| 14:51.47 | kharwell | right now we don't have a way to do that unfortunately |
| 14:51.54 | file | 20ms of opus data can be 'n' bytes, so you may be able to use the parsing library to know where one starts and ends, or add a header yourself maybe... |
| 14:52.08 | file | it's probably not impossible, it's just not as easy as the others |
| 14:52.31 | seanbright | got it |
| 14:52.44 | seanbright | i shall futz |
| 14:54.05 | seanbright | i think ogg is the wrong format |
| 14:54.14 | seanbright | maybe i will try webm |
| 14:54.29 | file | ogg is a container |
| 14:54.41 | seanbright | right |
| 14:54.43 | seanbright | as is webm |
| 14:54.48 | seanbright | right? |
| 14:55.14 | kharwell | seanbright: this is the third party library that is used. perhaps looking at that source might show something? https://github.com/xiph/opusfile |
| 14:56.25 | seanbright | kharwell: yeah. already readying through the API. |
| 14:56.43 | file | ready player one! |
| 15:34.05 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-kgccpcbckebsdvor) |
| 15:34.05 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 15:43.35 | *** join/#asterisk-dev Oooohboy (~Oooohboy@2605:6000:1711:c1ff:300b:bb21:8bb2:2647) |
| 15:58.39 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-joezedaxjwejtlpe) |
| 15:58.39 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:06.21 | *** join/#asterisk-dev Qwell (~north@asterisk/developer/Qwell) |
| 16:06.21 | *** mode/#asterisk-dev [+o Qwell] by ChanServ |
| 16:17.31 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 16:17.39 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 16:17.39 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 16:34.29 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-qjmcduhxzhvdrscc) |
| 16:34.30 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:37.19 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-upeffkcchszqgpxv) |
| 16:37.19 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:15.31 | seanbright | seems it's possible... but non-trivial |
| 17:15.39 | seanbright | which are the best kinds of problems |
| 17:15.54 | file | :D |
| 17:16.05 | seanbright | (see source of opus-tools/src/opusinfo.c for gory details) |
| 18:13.12 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-138-50.dialup.adsl.anteldata.net.uy) |
| 18:24.21 | *** join/#asterisk-dev LkBurn (~quassel@pool-108-34-210-109.prvdri.fios.verizon.net) |
| 19:02.17 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LFbn-1-11898-144.w90-93.abo.wanadoo.fr) |
| 19:02.39 | seanbright | tomorrow release day? |
| 19:02.55 | gtjoseph | in progress now |
| 19:03.11 | gtjoseph | 13.21.0-rc1 and 15.4.0-rc1 |
| 19:03.17 | seanbright | sweet |
| 19:04.58 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-qxxedoblewhrisas) |
| 19:04.58 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:27.06 | *** join/#asterisk-dev dakudos (~dakudos@c-73-203-6-107.hsd1.co.comcast.net) |
| 19:33.05 | jkroon | cresl1n, thanks for the info regardings CDRs - will definitely get rid of them at some point (especially after a handful of in-house discussions we had), but for now it allows us to move forward at least. |
| 19:35.59 | cresl1n | No worries :-) |
| 19:36.10 | cresl1n | glad it helped |
| 19:37.29 | file | rmudgett: you don't get a response on my review until tomorrow! :D |
| 19:37.55 | file | flips a table and goes to watch TV |
| 19:40.50 | jkroon | cresl1n, well, that's one platform down, one to go. and it's nice being able to run chan_sip and chan_pjsip concurrently. |
| 19:41.52 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-138-50.dialup.adsl.anteldata.net.uy) |
| 20:19.17 | *** mode/#asterisk-dev [+o csavinovich] by gtjoseph |
| 20:22.19 | *** mode/#asterisk-dev [+o csavinovich] by ChanServ |
| 21:16.47 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-vnudqsrkmjqenrxl) |
| 21:16.47 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 21:19.07 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:6de4:b36f:4d99:bce6) |
| 21:19.08 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:33.58 | kharwell | coreyfarrell: in utils_socket.py are you saying both isinstance checks need to be done or just one or the other? |
| 21:35.42 | coreyfarrell | kharwell: I'm not sure if it's needed in Ports.reserve, probably wouldn't hurt to do it though. |
| 21:36.29 | kharwell | ya I'll probably add there too. I mean though are both int and list checks required? Seems redundant? |
| 21:37.59 | coreyfarrell | both are needed.. it's because a range() isn't a list in python3. so the second check is really doing: if isinstance(ports, range): ports = list(ports) |
| 21:38.17 | coreyfarrell | but python2 fails if you use isinstance(ports, range), thus the check for not list. |
| 21:39.27 | kharwell | aah okay and happens there specifically cause a range is passed in. Interesting,didn't know that about range. Thought it evaluated to a list. Is that python3 only or happens in 2 as well? |
| 21:40.05 | coreyfarrell | it's python3.. I think range() is a class of it's own vs in python2 it seems like a helper function that returns a list(). |
| 21:42.19 | coreyfarrell | alternative would be for all callers to pass list(range(....)) for the argument, that is compatible with py2 and py3.. but I think the code will be cleaner if we handle the range -> list cast inside the function. |
| 21:43.11 | kharwell | I agree. I won't put the burden on the caller |
| 21:44.22 | coreyfarrell | utils_socket.py is self contained / doesn't use any other parts of lib/python so I think you should be able to run: python3 lib/python/asterisk/self_test/test_utils_socket.py |
| 21:45.10 | coreyfarrell | if you make the changes I've proposed it should pass if run by python2 or python3. |
| 21:46.21 | kharwell | I'll try it out. I need to be better about running pep8 as well. Forget most of the time to do that these days |
| 21:48.02 | coreyfarrell | pep8 is tough to remember since it produces so many errors already, some of them will be resolved by the python3 compatibility patch I'm working on. |
| 21:49.23 | coreyfarrell | gtjoseph: is it possible to get python3 installed to all the build agents? my python3 compatibility patch will enable use of both python2 and python3 to run unittests (if they're detected). |
| 21:50.37 | coreyfarrell | gtjoseph: not an immediate priority, my python3 patch is quite large and blocked by topic:self_test anyways. should I open a ticket for this? |
| 21:53.56 | file | he's running errands right now |
| 21:54.03 | file | JIRA issues are a good thing(tm) |
| 21:56.41 | kharwell | my pep8 must be old as I'm not seeing the lambda expression warning |
| 21:57.16 | coreyfarrell | kharwell: I only have python3-pep8 installed, maybe that's why it warns.. |
| 21:57.30 | kharwell | could be |
| 21:58.10 | kharwell | lambdas are life |
| 21:59.15 | kharwell | coreyfarrell: one last thing (hopefully). How does sys.path.append('lib/python') include the utils_socket.py path? If I just use that my test can't find the import |
| 22:00.48 | coreyfarrell | you need to 'import asterisk.utils_socket' |
| 22:01.40 | kharwell | aah yep left the asterisk. off my bad |
| 22:01.55 | coreyfarrell | kharwell: it works relative to pwd, assumes that the tests are run from the testsuite repo's root folder (which is how we always run it) |
| 22:17.09 | gtjoseph | coreyfarrell: i'll do python3 this weekend. |
| 22:19.16 | coreyfarrell | gtjoseph: cool thanks.. I just assigned ASTERISK-27817 to you :) |
| 22:19.24 | gtjoseph | :) |
| 22:19.28 | gtjoseph | no prob |
| 22:51.35 | coreyfarrell | kharwell: at line 208 of utils_socket.py, I've never seen that - the else: statement to 'for attempt in range(attempts):' |
| 22:52.42 | coreyfarrell | is that hitting the else: block only if you use all attempts and don't break? |
| 22:52.47 | kharwell | ah yeah basically triggers only if the loop runs to completion |
| 22:52.48 | kharwell | yeah |
| 22:55.43 | coreyfarrell | neat, thanks |
| 22:58.06 | kharwell | np. "else" is an odd word to use there, but I'm guessing they didn't want to introduce another reserved word |
| 23:03.56 | coreyfarrell | kharwell: btw about range http://python-future.org/compatible_idioms.html#range |
| 23:05.23 | coreyfarrell | my python3 compatibility patches would not have happened without that page :) |
| 23:05.47 | kharwell | ya looks like quite a handy reference page |
| 23:07.36 | coreyfarrell | that plus the utility pyflakes-3 |
| 23:56.26 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-vnudqsrkmjqenrxl) |