| 00:03.31 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 00:03.31 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 02:05.00 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:d181:6af2:41ca:3aa7) |
| 02:05.00 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:41.51 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 04:41.51 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 07:36.07 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:36.07 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:06.08 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:37.19 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:45.10 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:13.29 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@unaffiliated/gtj) |
| 10:13.29 | *** mode/#asterisk-dev [+o gtjoseph_] by ChanServ |
| 10:14.45 | *** join/#asterisk-dev _skrusty (~skrusty@88.150.145.104) |
| 10:14.45 | *** mode/#asterisk-dev [+o _skrusty] by ChanServ |
| 10:14.46 | *** join/#asterisk-dev zopsi_ (~zopsi@dir.ac) |
| 10:22.12 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 10:23.06 | *** join/#asterisk-dev fblackburn (~fblackbur@modemcable094.94-70-69.static.videotron.ca) |
| 11:18.17 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 12:15.45 | *** join/#asterisk-dev opticron (~opticron@75.76.59.35) |
| 12:15.45 | *** mode/#asterisk-dev [+o opticron] by ChanServ |
| 12:53.15 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 12:53.15 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 12:55.28 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-kvllxqkwpcqdfklg) |
| 12:55.28 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:13.26 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 13:27.35 | *** join/#asterisk-dev DivideBy0x0 (~DivideBy0@unaffiliated/divideby0x0) |
| 13:27.35 | *** mode/#asterisk-dev [+o DivideBy0x0] by ChanServ |
| 14:21.01 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-irsudarbasokfeli) |
| 14:21.01 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:21.51 | cresl1n | Hey coreyfarrell, ping? |
| 14:21.59 | coreyfarrell | cresl1n: pong |
| 14:22.08 | cresl1n | Was looking through old code reviews |
| 14:22.09 | cresl1n | https://gerrit.asterisk.org/#/c/8061/ |
| 14:22.45 | cresl1n | Seems like there's not a lot of harm switching typeof to __typeof__ since it's more compatible, no? |
| 14:23.10 | cresl1n | am I missing something in your thoughts? |
| 14:23.37 | coreyfarrell | if others want that to happen I guess I'm OK. it's used in nearly 100 spots in the headers though and I think __typeof__ makes the code less readable. |
| 14:23.56 | cresl1n | It seems a little visually less pleasant |
| 14:24.13 | cresl1n | but from a compiler compatibility perspective, seems like there isn't a downside |
| 14:24.41 | cresl1n | no? |
| 14:24.43 | cresl1n | yes? |
| 14:25.19 | jkroon | #define it perhaps ... ? |
| 14:25.28 | cresl1n | Ha! |
| 14:25.34 | coreyfarrell | if others want to put that change through I guess I can remove my -1. |
| 14:25.47 | cresl1n | Well, just trying to think of downsides |
| 14:25.53 | cresl1n | And I can't think of many |
| 14:25.59 | cresl1n | Anybody else have any thoughts on it? |
| 14:26.14 | file | Not really |
| 14:27.32 | cresl1n | pokes gtjoseph_ |
| 14:27.39 | gtjoseph_ | eh, what? |
| 14:27.46 | coreyfarrell | so are we going to change these 4 spots or all 94? this problem is caused by net-snmp in freebsd pushing CFLAGS=-std=c99 onto us. |
| 14:27.57 | jkroon | https://stackoverflow.com/questions/14877415/difference-between-typeof-typeof-and-typeof-objective-c - All three mean the same thing, but none are standard C so a conforming compiler may choose to make any mean something different |
| 14:28.29 | cresl1n | How about let's start with 4, and see how it goes? :-) |
| 14:28.41 | cresl1n | I know that's a bit inconsistent |
| 14:28.56 | jkroon | this also makes sense: Standard C requires compilers to prefix language extensions with a double-underscore ... and then "typeof() is exactly the same, but throws the underscores out the window with the understanding that every modern compiler supports it." |
| 14:29.16 | coreyfarrell | my votes are removed |
| 14:29.21 | cresl1n | but it's a decent compromise between changing the world and making freebsd happy-ish |
| 14:29.26 | jkroon | is there a way to test if the feature/keyword is available or not? |
| 14:29.44 | cresl1n | probably in configure |
| 14:29.49 | jkroon | ./configure and then #define whatever is used in the code to match the compiler. |
| 14:30.08 | jkroon | (or not define it if the given choice for wide use is in fact implemented) |
| 14:30.11 | cresl1n | But if coreyfarrell is right, that wouldn't catch this particular build time inconsistency |
| 14:30.18 | cresl1n | well, I guess we know about it now |
| 14:30.21 | cresl1n | so we could catch it |
| 14:30.23 | coreyfarrell | the check would have to be in the library check. |
| 14:30.56 | coreyfarrell | so we'd add something like 'int tmp = 0; typeof(tmp) tmp2 = 0; if (tmp == tmp2) {}' to the library check code. |
| 14:31.02 | cresl1n | you sure you're ok with it coreyfarrell? |
| 14:31.12 | cresl1n | Don't want to push you too hard on something you feel strongly about |
| 14:31.26 | coreyfarrell | and that would cause net-snmp to be rejected on freebsd due to the bad -std=c99 in CFLAGS. |
| 14:31.36 | cresl1n | ah |
| 14:33.28 | coreyfarrell | I don't feel as strongly about this one as I do about the ignoring SSL error's thing. I'm fine with seanbright idea of allowing SSL validation to be disabled by a configure option but 100% against ignoring SSL errors by default. |
| 14:34.05 | coreyfarrell | granted I'm still not going to +1 the __typeof__.. that's up to others. I'll just get out of the way. |
| 14:34.16 | cresl1n | Heh |
| 14:34.30 | cresl1n | What if we swapped them all to __typeof__? |
| 14:34.42 | cresl1n | or would that cause a definite -2 on your part? |
| 14:34.43 | cresl1n | :-P |
| 14:36.12 | coreyfarrell | give me a second to look at something else. |
| 14:37.59 | coreyfarrell | cresl1n: we already have SED commands in AST_EXT_TOOL_CHECK that manipulate -I directives in the detected CFLAGS. What if we used that to strip -std=c99? |
| 14:38.35 | cresl1n | I'd be ok with counterproposing that to Alexander |
| 14:38.55 | cresl1n | But it does seem like the underscores are the most compatible way of doing it |
| 14:39.26 | cresl1n | I've held your position on similar issues though, so I don't want to push too hard for my thoughts on it |
| 14:41.55 | coreyfarrell | my thing about compatibility is that we've required GNU C extensions since the beginning of time. typeof is a GNU C extension and it's also supported by clang. |
| 14:42.17 | cresl1n | Gotcha |
| 14:42.27 | cresl1n | Well, let's try your counterproposal then :-) |
| 14:45.44 | file | Counterpropose all the things |
| 14:46.17 | cresl1n | coreyfarrell: I'll let you post it |
| 14:46.22 | cresl1n | if that's ok |
| 14:47.33 | coreyfarrell | cresl1n: yup, I'll be posting it with 'git review', just running ./configure before and after so I can inspect the results on linux. |
| 14:47.38 | cresl1n | thanks |
| 14:48.19 | cresl1n | tzafrir: bump? |
| 14:48.22 | cresl1n | you there? |
| 14:49.00 | tzafrir | cresl1n, yes |
| 14:49.33 | cresl1n | Were you planning on moving https://gerrit.asterisk.org/#/c/7928/ forwared? |
| 14:49.35 | cresl1n | *forward |
| 14:50.38 | tzafrir | I'll try to look at it again... |
| 14:52.35 | cresl1n | thanks :-) |
| 14:52.51 | cresl1n | If you don't have time, it's ok, but I think we'll abandon it for now until you want to look at it some more |
| 14:53.01 | cresl1n | (if you decide you can't work on it) |
| 14:53.45 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-pehdjfpunjyszovt) |
| 14:53.45 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:07.52 | coreyfarrell | cresl1n: looks like my patch will remove an errant trailing space from the _INCLUDE vars produced by AST_PKGCONFIG. not sure where the space came from or why my change removes it but I've verified it doesn't strip spaces found in the middle of CFLAGS. |
| 15:11.21 | coreyfarrell | the asterisk-code-review mailing list does some weird things to the subject line. converted the '=c9' in -std=c99 to an invalid unicode char. |
| 15:29.53 | tzafrir | cresl1n, I see that I already have something that should work (not sure if it is tested). |
| 15:30.31 | tzafrir | It's broken to several commits, and I'm not sure how to get them reviewed, as it makes little sense to squash them into one |
| 15:30.47 | tzafrir | See http://git.tzafrir.org.il/cgit/asterisk.git/log/?h=cdr_mysql_empty |
| 15:31.19 | tzafrir | First two commits just move code around. Third commit should be useful independently. |
| 15:31.44 | tzafrir | I'm less sure about the fourth, which will become the topic of the review |
| 15:48.26 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-nztfvtmlzwpuwkth) |
| 15:48.26 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:57.02 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-moqunllnxwlhaazf) |
| 15:57.02 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 15:57.37 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-dfghddmdmhmkbavj) |
| 15:57.37 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:10.47 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-qiundxjbvpoqqlpb) |
| 16:10.47 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:11.21 | cresl1n | coreyfarrell: gotcha |
| 16:11.25 | cresl1n | thanks for thinking about it |
| 16:11.37 | cresl1n | tzafrir: ok - maybe link them both to the same topic/asterisk issue? |
| 16:12.42 | tzafrir | How do I do that? |
| 16:13.31 | tzafrir | They are also in a branch: must be oredered |
| 16:15.21 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-bycccqvkaukojqzm) |
| 16:15.21 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:27.57 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-eravgpckhprxlexb) |
| 16:27.57 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:57.37 | *** join/#asterisk-dev malcolmd (malcolmd@pdpc/sponsor/digium/malcolmd) |
| 16:57.37 | *** mode/#asterisk-dev [+o malcolmd] by ChanServ |
| 19:21.57 | *** join/#asterisk-dev scgm11_ (~scgm11@r186-52-114-20.dialup.adsl.anteldata.net.uy) |
| 20:40.11 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 21:12.51 | *** join/#asterisk-dev leedm777 (~textual@2607:fb90:1b85:3909:add6:ed4d:f9b6:5f6f) |
| 21:12.51 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:42.17 | *** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:16fe:2700:1846:8bb2:24e0:9a17) |
| 22:03.37 | *** join/#asterisk-dev leedm777 (~textual@2607:fb90:1b93:126f:15b4:aa69:eda6:29a9) |
| 22:03.38 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:31.21 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-irsudarbasokfeli) |