IRC log for #asterisk-dev on 20180323

00:44.24*** join/#asterisk-dev jkroon_ (~jkroon@165.16.204.170)
00:52.54*** join/#asterisk-dev Oooohboy (~Oooohboy@cpe-67-11-10-120.satx.res.rr.com)
07:33.44*** join/#asterisk-dev tsearle (~tsearle@37.19.10.33)
07:33.44*** mode/#asterisk-dev [+o tsearle] by ChanServ
09:13.24*** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net)
10:25.09*** join/#asterisk-dev razzex (~razzex@77.48.251.5)
11:34.57coreyfarrellfor anyone not watching the fedora devel list looks like they intend to drop python2 by Fedora 30. https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/2XDT6S62SEN4KGWQCOUYKXLBYVTKJ5VI/
12:10.37stefan27Jokes on them, I'm on Fedora 20 still
12:19.03*** join/#asterisk-dev CELYA_ (~Thunderbi@ppp-seco11pareq2-46-193-142-233.wb.wifirst.net)
13:43.36coreyfarrellstefan27: personally I wouldn't connect something that old to a network (it's been years since f20 has gotten security fixes)
13:56.48razzexHi guys, im here with my module again, could anyone give me a hand? Code here: https://pastebin.com/TiuSFKLf . 2 scenarios: module is running but doesnt print out anything, or it is running but whenever a packet arrives, Asterisk crashes with SIGSEGV error. I was told to look at priority. So I found out that whenever the priority is <64, SIGSEGV crash occurs, because packet isnt parsed
13:56.49razzexwhen the function is called. When its 64, Asterisk works normally but module doesnt do anything.
13:58.22*** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n)
13:58.22*** mode/#asterisk-dev [+o cresl1n] by ChanServ
13:59.48seanbrightrazzex: gdb
14:00.22seanbrightrazzex: what precisely is your module going to do? what is the problem you are trying to solve?
14:01.16razzexsean: i already did gdb, it crashes on line 47, because it is trying to access something that isnt there yet i guess, because the packet isnt parsed at that moment
14:01.27razzexbut that happens only when the priority of module is lower than 64
14:01.52seanbrightrazzex: what precisely is your module going to do? what is the problem you are trying to solve?
14:01.55razzexI just want to print out values from sip messages into console, like Content-length
14:02.03seanbrightfor what reason?
14:02.10seanbrightis this a learning experience?
14:02.12razzexyes
14:02.17seanbrighti see
14:03.05seanbrightdo you know gdb at all?
14:03.06razzexBut whenever the prio is 64, it appears as if the function isnt called, because not event simple ast_log message is printed :/
14:04.06razzexwell i started asterisk with -g parameter, then I got the .core coredump file, generated those 4 txt files and saw the problem
14:04.21razzexp *rdata->msg_info.from gave "Cannot access memory at address 0x0"
14:04.25seanbrightright, but i mean have you ever run a program in gdb and stepped through it line by line?
14:04.37razzex"p *rdata->msg_info" gave ""Structure has no component named operator*.""
14:04.59razzexno
14:05.26seanbrightbased on what you've described, i would recommend that you make a copy of res/res_pjsip_logger.c
14:05.39seanbrighttake out the stuff you don't care about
14:05.51seanbrightand try with that
14:06.41razzexthats sort of what i did
14:06.49fileres_pjsip_logger doesn't touch the parsed message, so it can exist at a lower level safely
14:07.21seanbrightok, then maybe res/res_pjsip_one_touch_record_info.c
14:07.33seanbrightit is simple
14:07.59filethat's a session supplement so it is only applicable to sessons
14:08.06seanbrightok
14:08.11seanbrightwell, fuck me for trying to help, right?
14:08.13seanbrightheh
14:08.58filePJSIP provides macros which search the message for a few different headers, parses it if not found, and returns it
14:09.04filehttp://www.pjsip.org/pjsip/docs/html/group__PJSIP__MSG__MSG.htm
14:09.09filePJSIP_MSG_FROM_HDR for example
14:09.44filecould probably be used for others, if you really can't find the right priority
14:10.17razzexwell i cant, because whenever its lower than 64, it crashes, and when its 64 it doesnt do anything, and from what I understand, 64 is maximum
14:10.27filewhat have you tried?
14:10.31filewhat priority have you tried?
14:10.48razzexdecremented by one until 50
14:11.09filetry .priority = PJSIP_MOD_PRIORITY_TSX_LAYER - 2
14:11.26razzexok, sec
14:11.34filethat's before the endpoint identifier, which uses the From header at the very least
14:11.42*** join/#asterisk-dev kharwell (kharwell@nat/digium/x-spythktrhvtsqufc)
14:11.42*** mode/#asterisk-dev [+o kharwell] by ChanServ
14:12.15filethere's also additional checks that should be done to ensure it is a SIP URI, or else it'll crash
14:12.59filehttps://github.com/asterisk/asterisk/blob/master/res/res_pjsip_endpoint_identifier_user.c#L32 is what the endpoint identifier does
14:14.44razzex.priority = PJSIP_MOD_PRIORITY_TSX_LAYER - 2   is the same as 64, it doesnt crash but doesnt print out either
14:15.23razzexat least line 40 should be printed, but its not, so the function probably isnt called
14:16.41filewhat traffic is it?
14:17.04razzexim just trying to call from one sip phone to the other
14:17.17razzexthe call goes through normally
14:17.29filetry PJSIP_MOD_PRIORITY_TSX_LAYER Then
14:17.43fileotherwise you have to figure out what is stopping the packet before it gets to your module
14:17.48razzexoh wait, turns out the module didnt automatically load, and now when i called, it crashed
14:19.16razzexhow can something so simple be so complicated :(
14:19.29seanbrightwelcome to programming
14:20.06fileyou're programming at a PJSIP low level, it's not easy down there
14:20.58fileprovided updated gdb information, including print *rdata->msg_info and print rdata->msg_info
14:21.16razzexwith .priority = PJSIP_MOD_PRIORITY_TSX_LAYER - 2 ?
14:22.19fileyes
14:22.22razzexkk
14:23.35filealso, https://github.com/asterisk/asterisk/blob/master/res/res_pjsip/pjsip_distributor.c#L651
14:23.45filethat prints the From header into a buffer, and it's used in the core part
14:24.06fileso using that instead of doing your own thing would be better, as that code does work
14:24.48razzexits the same,  p *rdata->msg_info gives "Structure has no component named operator*.", and p rdata->msg_info is empty ($1 = {msg_buf = 0x0, len = 0,...)
14:25.09fileI need the full details
14:25.18fileprint *rdata
14:25.18fileas well
14:25.50razzexhttps://pastebin.com/i78vxKP3
14:25.50fileyou also need to add:
14:25.56filehttps://www.irccloud.com/pastebin/X4LJmF8D/
14:25.58fileat the top
14:26.09razzexok
14:27.48fileyour information is very suspect
14:28.06fileif your system has PJSIP installed outside of Asterisk and it's a different version, then it would screw up your module without the MODULEINFO I provided
14:28.44filewhat's the output of "ldd /usr/lib/asterisk/modules/res_modul.so" ?
14:29.55razzex<PROTECTED>
14:29.55razzex<PROTECTED>
14:29.55razzex<PROTECTED>
14:29.55razzex<PROTECTED>
14:30.06seanbrightHRMMMMMMMMMMMMMM
14:30.36seanbrighti have nothing to add
14:30.37razzexwhats that suppose to mean :D ?
14:30.54filehow about... "file /usr/include/pjsip.h"
14:32.35razzexits not there
14:33.02razzexwait its there
14:33.28razzexfile /usr/include/pjsip.h
14:33.36filethat's not good
14:33.49razzexgives: /usr/include/pjsip.h: C source, ASCII text
14:33.54fileyou need to add the MODULEINFO like I said, do a make clean (maybe even make distclean), and rebuild
14:34.31razzexokay, will do!
14:34.36seanbrightdistclean or GTFO
14:35.06fileyour module was built against the headers that Asterisk didn't use, and we have different build options
14:35.10filewe increase the maximum packet size
14:35.21fileso for modules built properly - it's fine, they see stuff
14:35.33filefor your module the packet size is LOW, so it would see... well... nothing - zeroes
14:35.52razzexok, i added the MODULEINFO and will do make distclean and rebuild
14:36.10razzexill keep ".priority = PJSIP_MOD_PRIORITY_TSX_LAYER - 2 "
14:37.46*** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-svmujsrcsgyffvbp)
14:37.46*** mode/#asterisk-dev [+o bford] by ChanServ
14:48.16*** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-ptzlmnbmkhgesysc)
14:48.16*** mode/#asterisk-dev [+o rmudgett] by ChanServ
14:49.45razzexwow, now its printing out things!
14:50.27razzexis it possible that the MODULEINFO was the problem? Or rather clean build?
14:50.59seanbrightyour module was linking against the wrong pjsip
14:51.11seanbrightthe MODULEINFO + clean build resolved that
14:51.54razzexwrong pjsip? how many are there :D ?
14:52.32seanbrightthere is one included with asterisk, and you have one installed on your machine
14:53.49razzexoh
14:54.54filewithout the MODULEINFO the build system didn't know you were using PJSIP, and didn't do the things to prevent your system one from being used
14:58.44coreyfarrellrazzex: are you using the Asterisk build system by copying your res_modul.c into res next to res_pjsip.c?  or are you building it with your own Makefile?  I ask since the code you posted still has a #define AST_MODULE..
15:04.09razzex<PROTECTED>
15:04.26razzexand im copying my modul into res
15:08.59razzexbut everything works now thanks to you guys, im really grateful
15:10.10razzexits really difficult to learn about pjsip on my own, as nobody I personally know has experience with module development
15:23.16*** join/#asterisk-dev CELYA_ (~Thunderbi@ppp-seco11pareq2-46-193-142-233.wb.wifirst.net)
15:36.12*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
15:36.12*** mode/#asterisk-dev [+o snuff-work] by ChanServ
15:54.37*** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru)
16:03.16*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
16:03.17*** mode/#asterisk-dev [+o snuff-work] by ChanServ
16:23.07*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
16:23.07*** mode/#asterisk-dev [+o snuff-work] by ChanServ
16:47.02*** join/#asterisk-dev fblackburn (~fblackbur@modemcable094.94-70-69.static.videotron.ca)
16:56.57*** join/#asterisk-dev jkroon__ (~jkroon@165.16.204.174)
17:56.57*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
17:56.57*** mode/#asterisk-dev [+o snuff-work] by ChanServ
18:46.51*** join/#asterisk-dev scgm11_ (~scgm11@r186-52-230-215.dialup.adsl.anteldata.net.uy)
18:59.47*** join/#asterisk-dev scgm11__ (~scgm11@2800:a4:176b:d500:e517:4c2c:ca79:9af2)
19:25.13*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
19:25.13*** mode/#asterisk-dev [+o snuff-work] by ChanServ
19:30.12*** join/#asterisk-dev scgm11_ (~scgm11@2800:a4:176b:d500:e517:4c2c:ca79:9af2)
19:38.51seanbrightslackware? am i being punked?
19:40.31jpsharpslackware?  Gentoo for life!
19:48.16*** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n)
19:48.16*** mode/#asterisk-dev [+o cresl1n] by ChanServ
20:01.36*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
20:01.36*** mode/#asterisk-dev [+o snuff-work] by ChanServ
20:11.16bfordseanbright: mind blown
20:11.24seanbrighteh?
20:11.39bfordgerrit, good ideas
20:11.44seanbrightah.
20:11.50seanbrightdon't act so surprised
20:12.16bfordit's late in the day
20:12.30filep.i.z.z.a.
20:17.24seanbrightbford: honestly i just wanted to use the word 'elide' today and this was my first opportunity
20:17.38fileit's a good word
20:18.24bfordthat's fair
20:54.59*** join/#asterisk-dev tzafrir (~tzafrir@62.90.199.247)
20:54.59*** mode/#asterisk-dev [+o tzafrir] by ChanServ
21:08.37*** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il)
21:08.37*** mode/#asterisk-dev [+o tzafrir] by ChanServ
22:16.37*** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102)
22:16.37*** mode/#asterisk-dev [+o snuff-work] by ChanServ
22:17.31*** join/#asterisk-dev Oooohboy (~Oooohboy@2605:6000:1711:c1ff:38b3:5c5e:423a:7c22)
22:43.34*** part/#asterisk-dev kharwell (kharwell@nat/digium/x-spythktrhvtsqufc)

Generated by irclog2html.pl Modified by Tim Riker to work with infobot.