| 01:24.33 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:24.33 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 04:12.39 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 06:12.06 | snuff-work | found another pjsip crash (non assert related i believe..) udp vs tcp issue |
| 06:13.18 | snuff-work | posted on jira anyway |
| 07:10.04 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.166) |
| 07:12.09 | snuff-work | mm.. odd seem to have gotten the assert error when i didn't have devmode enabled.. |
| 07:13.12 | snuff-work | is there easy way to determine if 'devmode' was somehow still on for my pjsip library? |
| 07:55.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:80c3:b558:e1cf:231f) |
| 08:10.00 | coreyfarrell | snuff-work: unlikely if you re-ran configure without --enable-dev-mode. the bundled pjproject is pretty aggressive about rebuilding when options are changed. |
| 08:11.10 | snuff-work | ah well.. we'll see if i fixed it this time.. my last config.log said devmode was off |
| 08:14.52 | snuff-work | hopefully u have enough info for my other new bug.. if not let me know |
| 08:19.24 | coreyfarrell | snuff-work: depends on what the fix turns out being. if pjproject agrees that the assert is excessive we'll just change it to a normal error return and that'll be that. if not fixing it from the Asterisk side might be more difficult, could require figuring out a minimum reproduction test case. |
| 08:19.44 | coreyfarrell | anyways I'm just pretending to be awake.. going back to sleep. |
| 08:20.51 | snuff-work | all good =) |
| 08:21.00 | snuff-work | i'm off to get the train home |
| 08:23.05 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:25.14 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:26.25 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:17.39 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 09:17.40 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 09:57.34 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 09:57.34 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 10:01.58 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@92.184.104.121) |
| 10:12.51 | *** join/#asterisk-dev CELYA_1 (~Thunderbi@2a01:e0a:d:1111:56ee:75ff:fed4:f268) |
| 10:27.13 | *** join/#asterisk-dev skrusty (~skrusty@88.150.145.104) |
| 10:27.13 | *** mode/#asterisk-dev [+o skrusty] by ChanServ |
| 12:55.18 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:49ef:39a9:83cf:46f7) |
| 12:55.18 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:59.15 | *** join/#asterisk-dev tzafrir (~tzafrir@94-224-241-139.access.telenet.be) |
| 12:59.15 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:06.30 | *** join/#asterisk-dev tzafrir (~tzafrir@94-224-241-139.access.telenet.be) |
| 13:06.31 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:22.38 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:56ee:75ff:fed4:f268) |
| 13:25.13 | *** join/#asterisk-dev tzafrir (~tzafrir@94-224-241-139.access.telenet.be) |
| 13:25.13 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 13:58.09 | coreyfarrell | did gerrit make the login timeout even shorter? seems like now it boots me before 24 hours is up. |
| 14:13.20 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-dcrolwqqlsgepkwe) |
| 14:13.20 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:18.45 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-meeylkyoxsbhztiw) |
| 14:18.46 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:28.46 | gtjoseph | coreyfarrell: were you able to verify that OSX builds still work after your "Require __sync or __atomic functions." patch? |
| 14:36.11 | coreyfarrell | gtjoseph: El capitain has both ways (so __atomic will be used instead of __sync). |
| 14:36.34 | gtjoseph | kk, just checking |
| 14:40.37 | coreyfarrell | gtjoseph: I can't speak about other versions, but I think El capitain is not even the most current OSX. I'm not worried about older versions, a few months ago OSX couldn't even compile asterisk. |
| 14:40.49 | gtjoseph | :) |
| 14:41.26 | coreyfarrell | and honestly I don't know if any version of OSX will correctly run asterisk, I just know `./configure && make` succeeds. |
| 14:44.53 | gtjoseph | leedm777: are you still compiling on OSX occasionally? Care to give https://gerrit.asterisk.org/#/c/8049/ a try? |
| 14:47.34 | leedm777 | takes a gander |
| 14:50.04 | leedm777 | There's been some recent breakage with High Sierra/Xcode 9 that I haven't had a chance to fully work through. |
| 14:51.35 | leedm777 | There's a patch I was working on (https://gerrit.asterisk.org/#/c/7778/) but got busy, priorities, etc. etc. |
| 14:52.09 | coreyfarrell | leedm777: gerrit won't let me see that patch |
| 14:52.20 | leedm777 | boo |
| 14:55.05 | leedm777 | https://github.com/leedm777/asterisk/commit/35c1a64e87ca8b58b7ded87da07f432265c343f6 |
| 14:55.27 | leedm777 | Biggest challenge I had was a GCC bug that was failing to include a system header. |
| 14:55.46 | leedm777 | I think I got things compiling using clang, but then something else broke. |
| 14:56.06 | leedm777 | Oh, yeah, the clang pragmas :-/ |
| 14:56.38 | leedm777 | anyways, there's a fair bit of care and feeding needed to get macOS happy again, and time for such things has been scarce :-( |
| 14:59.28 | coreyfarrell | leedm777: I recognize a couple of the fixes traud has submitted to fix issues in BSD. |
| 14:59.54 | leedm777 | makes sense. macOS is kinda BSDish. |
| 15:00.23 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:00.23 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:01.17 | coreyfarrell | leedm777: funny thing, I caused the issue in main/asterisk.c when I fixed a compile error for El Capitain. |
| 15:01.30 | leedm777 | heh |
| 15:02.38 | leedm777 | that whole function is a mess. |
| 15:02.57 | leedm777 | I've tried a couple of times to clean it up so it's less fragile, but never could get anywhere that I was happy with. |
| 15:20.05 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-gbxehepyotvdtcun) |
| 15:20.05 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:38.21 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-mmwandiwttshzsxo) |
| 15:38.21 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:42.01 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:42.01 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 16:01.19 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 16:09.37 | *** join/#asterisk-dev Deeewayne (~dwayne@c-68-32-163-110.hsd1.al.comcast.net) |
| 16:09.37 | *** mode/#asterisk-dev [+o Deeewayne] by ChanServ |
| 17:30.35 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-izxdsmscsqcwivdm) |
| 17:30.35 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:45.19 | kharwell | hrm I just pushed a patch to gerrit and it didn't overwrite the original review even though it has the same change-id |
| 17:45.36 | file | orly |
| 17:46.36 | coreyfarrell | kharwell: that's because you didn't post to newmaster, so it's like you did a cherry-pick. |
| 17:47.04 | coreyfarrell | newmaster and master are both at the same place so the automatic rebase during 'git review' didn't fail. |
| 17:47.05 | kharwell | oh crap yeah that's what I did. ugh I rebased off master |
| 17:47.13 | kharwell | I'll redo |
| 17:47.21 | file | there's ALWAYS a reason :D |
| 17:48.37 | coreyfarrell | if someone wants to remove the -1 verify from https://gerrit.asterisk.org/7989 I just checked locally and I didn't get a failure on the mwi-ext test. |
| 17:50.23 | coreyfarrell | kharwell: could you restore the old review and delete the new one? |
| 17:50.41 | coreyfarrell | that way I can just look at the diff between patches.. |
| 17:50.59 | kharwell | trying. not sure what happened to the old one. It just disappeared |
| 17:54.46 | kharwell | coreyfarrell: I dunno what happened. I removed the others and then uploaded against newmaster. Then the old review just disappeared and I can't seem to find/get it back. It's just gone. |
| 17:56.45 | coreyfarrell | wow that seems like a pretty serious bug in gerrit. not losing stuff seems like the whole point of SCM :( |
| 17:57.20 | kharwell | Looks like in order to the old review back I'll have to manually remove my changes |
| 17:57.49 | coreyfarrell | don't bother |
| 17:58.20 | coreyfarrell | it's the testsuite, if you tell me you addressed all my findings and nothing else I'll believe you. |
| 18:01.02 | kharwell | ya I did. Only two really for this one: I removed the alice.xml from pjsip/transfers/blind_transfer/caller_direct_media and removed the minversion I'd left in apps/page/page_predial |
| 18:01.36 | kharwell | You had two other findings, but I put those in the follow up commit. Moving two tests up a directory level |
| 18:02.04 | kharwell | and apologies about the mess up |
| 18:04.29 | coreyfarrell | no worried it happens |
| 18:07.33 | coreyfarrell | it would be nice if we could figure out how to reproduce the issue so it can be reported to gerrit (data loss is a major bug). |
| 18:08.07 | kharwell | I have a theory. gonna try a test and see if I can dupe it |
| 18:18.29 | kharwell | oh well can't get it to happen again. I thought maybe it had something to do with trying to push a patch with the same change-id into two different branches and then deleting one and it might have deleted the other. |
| 18:19.10 | kharwell | but it give me an error when trying to push a review to the other branch. I have to delete the other before it lets me. |
| 18:20.54 | kharwell | Although it did not give me an error when I had a patch series on a branch. At least the first time I pushed it up. After the first time though it would error out. |
| 18:21.40 | kharwell | So either user error (probably) or some odd super off nominal path that I can't hit again |
| 18:29.44 | coreyfarrell | IMO the ability to delete a review is a bug. once you push something you should have the ability to abandon it or set it back to draft/hidden mode, but gerrit should never allow anything to be deleted once it's posted |
| 18:34.57 | kharwell | I tend to agree. I usually don't delete, but figured it was a mess up so no harm. I could have deleted the wrong review though. Either way if I did or there is a deletion bug maybe it's best to not have it there (think it was added in a recent upgrade) |
| 18:35.49 | kharwell | gtjoseph/file: do either of you know if it is possible to remove/disable the delete button in gerrit? If so thoughts on doing so? |
| 18:36.25 | coreyfarrell | it's attached to some kind of permission, gerrit doesn't give me a delete button. |
| 18:36.41 | file | yeah, it requires a Delete Own Changes permission |
| 18:37.08 | file | a few of us may have it as a result of being admins |
| 18:37.57 | file | I don't think I can take it away, because we don't explicitly have it |
| 18:42.58 | kharwell | okay then note to self don't delete! |
| 18:44.34 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d004c9ca839761e0e04.ipv6.abo.wanadoo.fr) |
| 18:46.27 | rmudgett | Mark found out about delete awhile a go. It deletes more than he thought. It completely deleted the review when he meant to delete one patch revision. |
| 19:00.58 | gtjoseph | it doesn't |
| 19:01.05 | gtjoseph | :) |
| 19:01.27 | rmudgett | prune_on_boot is a good name. It means exactly what is says. :) |
| 19:01.53 | gtjoseph | asterisk isn't an operating system. we don't boot it |
| 19:01.57 | gtjoseph | but fine |
| 19:02.19 | gtjoseph | so what's the issue with "I wasn't wanting to give the transport monitor knowledge of the users. |
| 19:02.19 | gtjoseph | " |
| 19:02.27 | gtjoseph | it doesn't |
| 19:02.45 | rmudgett | The enum ID says who is using it. |
| 19:03.23 | gtjoseph | yes but the code doesn't care what the actual value is |
| 19:03.40 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-aszggverdcnthjoy) |
| 19:03.40 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:03.42 | rmudgett | I do agree that res_pjsip_registrar_expire is a strange module division. |
| 19:04.19 | gtjoseph | i could make the enum just an int and leave it to the caller to make sure there's no conflict |
| 19:05.32 | rmudgett | That's not exactly better. :( |
| 19:05.56 | gtjoseph | well, the only other option is to refactor registrar expire |
| 19:06.01 | gtjoseph | it's not hard. |
| 19:08.12 | rmudgett | Yeah. That module looks like it was written just because we could make it a separate loadable module. |
| 19:08.28 | file | there was a reason back in the day, I forget why |
| 19:08.34 | file | stuff has changed and evolved in that area |
| 19:08.42 | file | sometimes for the better, sometimes for the worse |
| 19:08.53 | file | moving it into the registrar is fine |
| 19:10.14 | gtjoseph | easy enough |
| 19:12.05 | rmudgett | Should be a separate commit to merge them that your patch depends on. |
| 19:12.39 | gtjoseph | that's what I'm doing |
| 20:00.30 | coreyfarrell | gtjoseph: any reason to even keep res_pjsip_registrar_expire in master? the only way it's removal would cause a real problem is if someone had 'require=res_pjsip_registrar_expire' in modules.conf. |
| 20:01.03 | gtjoseph | nope but i'll do it in a followup. right now th erefactor is holding something else up. |
| 20:17.38 | rmudgett | gtjoseph: Modules have appeared and disappeared before. |
| 20:18.10 | rmudgett | Even been renamed. |
| 20:24.43 | gtjoseph | yeah but er just had this dicussion with res_pjsip_session so I opted for the safe thing. we can always toss it later in any branch we wish. |
| 20:43.08 | coreyfarrell | deleting res_pjsip_session would be a pain for the testsuite (not once we get the branched testsuite though). |
| 20:43.44 | gtjoseph | yep. i just didn't want to do this one in a hurry. we'll revisit |
| 20:45.35 | file | I prefer cinnamon sugar coated donuts over deleting res_pjsip_session |
| 20:45.36 | gtjoseph | rmudgett: i'm going to hold off cherry-picking the updated sub-prune review so give the 13 version a look when you can. |
| 20:45.53 | gtjoseph | no-brainer on that one! |
| 21:13.11 | coreyfarrell | Could anyone give https://gerrit.asterisk.org/8046 and https://gerrit.asterisk.org/8049 a look? I'd like to update my PR to jansson for thread safety but I want to make sure the next version is thread safe for all compilers supported by Asterisk 16. |
| 21:14.05 | gtjoseph | well, i could but it'd be pointless since I already +1'd them :) |
| 21:14.16 | coreyfarrell | yeah not you :P |
| 21:14.37 | coreyfarrell | but thanks for the +1 |
| 21:16.17 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:03.51 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:14.19 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:24.38 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:32.32 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 22:32.32 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:34.58 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:45.19 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:55.38 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 22:57.49 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:dcc4:ec8e:e59c:37b3) |
| 22:57.49 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:05.56 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 23:16.15 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 23:26.38 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 23:29.19 | *** join/#asterisk-dev tzafrir (~tzafrir@94-224-241-139.access.telenet.be) |
| 23:29.19 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:36.56 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 23:47.16 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 23:51.10 | *** join/#asterisk-dev Kobaz (~kobaz@its.kobaz.net) |
| 23:57.46 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |