| 01:19.52 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:19.52 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:15.34 | *** join/#asterisk-dev joshelson (~joshelson@67.133.97.98) |
| 05:21.27 | *** join/#asterisk-dev joshelson (~joshelson@206.81.147.110) |
| 07:54.15 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:54.15 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:00.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 08:39.26 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:37.02 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:48.45 | *** join/#asterisk-dev sotoz (~sotoz@095-097-255-066.static.chello.nl) |
| 13:17.15 | seanbright | coreyfarrell: license #6895 |
| 13:29.17 | file | brrrrrr |
| 13:37.36 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 14:31.14 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 14:31.14 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 14:32.39 | file | sorry for the JIRA spam, I have to manually bulk change the old stuff because it is outside of the current workflow |
| 14:39.42 | file | I have more to do >_> |
| 14:49.02 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.222.253) |
| 14:51.49 | file | k done, if anyone wants to "Mark All As Read" |
| 15:20.29 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-cvomlcaxitvborav) |
| 15:20.29 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:35.20 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:35.20 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:43.45 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 15:43.45 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 15:49.52 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 15:49.52 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 16:00.21 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-zatwqeqtdpukzxob) |
| 16:00.21 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 16:27.13 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 16:27.13 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 16:40.33 | coreyfarrell | seanbright: thanks! |
| 17:14.28 | *** join/#asterisk-dev awkwardpenguin (~awkwardpe@172-222-167-081.dhcp.chtrptr.net) |
| 17:21.23 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 17:21.23 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 18:16.24 | rmudgett | coreyfarrell: I gave https://gerrit.asterisk.org/#/c/7784/ a +1 but added a comment. |
| 18:23.54 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00357926286fc52e10.ipv6.abo.wanadoo.fr) |
| 18:37.50 | coreyfarrell | rmudgett: I created a bug to improve the test when I get a chance. |
| 18:38.51 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00b1352878c141280e.ipv6.abo.wanadoo.fr) |
| 18:38.56 | rmudgett | I was wondering how you found the problem if the unit test didn't trigger the assert all the time. |
| 18:43.38 | coreyfarrell | in my own code.. I was originally only using OPT_TIMELEN_T to parse a dialplan app's argument, I just added the ability for it to pull default value from config and since my own module has XMLDOC's it crashed when it tried reading beyond the array. |
| 18:46.20 | rmudgett | The jenkins build agents should have caught the error immediately because of the assert since they supposedly execute the unit tests. |
| 18:47.22 | *** join/#asterisk-dev joshelson (~joshelson@73.98.163.13) |
| 18:51.28 | coreyfarrell | rmudgett: I think the assert is wrong? I think it should be ast_assert(ARRAY_LEN(aco_option_type_string) >= type); |
| 18:52.39 | rmudgett | The expression must be normally true and type is an index into the aco_option_type_string[]. |
| 18:55.51 | coreyfarrell | yes but before my patch and ARRAY_LEN(aco_option_type_string) was 13 and type was 13 (1 based length vs 0 based index). |
| 18:56.54 | coreyfarrell | oh wait maybe I'm looking at it backwards. |
| 18:59.05 | rmudgett | Probably easier to see if the assert were written: ast_assert(type < ARRAY_LEN(aco_option_type_string)) |
| 18:59.51 | file | asserts hurt my head |
| 19:00.40 | coreyfarrell | rmudgett: agreed. for some reason I always get confused by comparisons where the constant is on the left. |
| 19:01.58 | rmudgett | Which is why I prefer comparisons to be related to the number line: If (x < 5 || 6 < x) OR if (5 < x && x < 6) |
| 19:02.11 | rmudgett | :) |
| 19:03.46 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 19:03.46 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 19:05.20 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:05.20 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 19:05.28 | coreyfarrell | for that I'd write if (x < 5 || x > 6), base all comparisons on 'x'. |
| 19:08.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d004468ea634323c541.ipv6.abo.wanadoo.fr) |
| 19:09.23 | seanbright | yes, rmudgett is in the minority |
| 19:09.28 | seanbright | but it's lonely at the top |
| 19:10.03 | seanbright | (and you would want x >= 6 for it to be equivalent) |
| 19:10.28 | seanbright | (errr, or i am talking out of my ass) |
| 19:10.38 | coreyfarrell | rmudgett: I just double-checked the artifacts for the jenkins 'check' and dev-mode / DO_CRASH are enabled so it should have crashed. |
| 19:11.18 | rmudgett | Now, why didn't it. :) |
| 19:22.52 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d006878241187d8fd62.ipv6.abo.wanadoo.fr) |
| 19:32.13 | *** join/#asterisk-dev joshelson (~joshelson@67.214.249.12) |
| 19:38.04 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d000ce8b7a36cecd1cb.ipv6.abo.wanadoo.fr) |
| 19:50.06 | *** join/#asterisk-dev joshelson (~joshelson@67.214.249.12) |
| 20:00.43 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 20:00.43 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 20:01.54 | coreyfarrell | rmudgett: test_config uses CONFIG_INFO_TEST which sets .hidden = 1, this causes link_option_to_types to skip xmldoc_update_config_option(). |
| 20:06.42 | rmudgett | Well that explains it. Probably should put an assert in link_option_to_types() to check that the type is valid for aco_option_type_string[]. :) |
| 20:10.21 | coreyfarrell | rmudgett: I think we should get rid of CONFIG_INFO_TEST and just use the standard macro (after we add aco docs to test_config). |
| 20:10.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d007c4db437c6716886.ipv6.abo.wanadoo.fr) |
| 20:13.40 | rmudgett | Those unit test config options are hidden for a reason. They are phantoms only for the unit test. |
| 20:16.37 | coreyfarrell | test_config is the only place it's used and the aco objects are created and destroyed by the test. so wouldn't it only exist while the test is running? |
| 20:18.00 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 20:18.00 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 20:21.14 | rmudgett | Hmm. That makes sense. However, the XML docs would always be present in the ./doc/core-en_US.xml |
| 20:21.14 | rmudgett | <PROTECTED> |
| 20:21.39 | rmudgett | Calling all file 's :) |
| 20:21.47 | file | hi |
| 20:23.44 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00a0e73234d7f8733a.ipv6.abo.wanadoo.fr) |
| 20:34.57 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip70-180-17-122.ph.ph.cox.net) |
| 20:37.37 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f4d7ddd1bc0987bc.ipv6.abo.wanadoo.fr) |
| 20:37.54 | coreyfarrell | rmudgett: yeah it would be nice if doc/core-en_US.xml only included modules that were built. |
| 21:47.41 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 21:47.41 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 21:57.45 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 21:57.45 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:02.42 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 22:02.42 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 22:11.00 | *** join/#asterisk-dev dadrc (~quassel@unaffiliated/dadrc) |
| 22:47.05 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 22:47.05 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:49.45 | file | coreyfarrell: are you going to work ASTERISK-27540? |