| 00:08.27 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-gkdguurwmmzmiyin) |
| 00:17.46 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0091277cee77aaea42.ipv6.abo.wanadoo.fr) |
| 01:20.36 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:20.36 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:05.15 | *** join/#asterisk-dev joshelson (~joshelson@67.214.249.12) |
| 02:11.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00249074b01116756a.ipv6.abo.wanadoo.fr) |
| 02:24.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d002140e2a58d891bc8.ipv6.abo.wanadoo.fr) |
| 02:32.03 | *** join/#asterisk-dev joshelson (~joshelson@73.98.162.214) |
| 02:37.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00fcc4fb002d019550.ipv6.abo.wanadoo.fr) |
| 02:51.25 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00c8d78910fdd6b2d6.ipv6.abo.wanadoo.fr) |
| 04:44.25 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00d029a81b1a4e29cf.ipv6.abo.wanadoo.fr) |
| 04:55.13 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00bc474029e66ed546.ipv6.abo.wanadoo.fr) |
| 05:30.08 | *** join/#asterisk-dev tzafrir (~tzafrir@62-90-199-247.barak.net.il) |
| 05:30.08 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 05:50.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00256c80035dee20d0.ipv6.abo.wanadoo.fr) |
| 06:45.15 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d008859eed9a4bfcab6.ipv6.abo.wanadoo.fr) |
| 07:00.40 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f1ea7044d46bbcf7.ipv6.abo.wanadoo.fr) |
| 07:18.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00a99cb0f6626c6354.ipv6.abo.wanadoo.fr) |
| 07:51.15 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 08:08.49 | *** join/#asterisk-dev Demon_VoIP (~demon@eoks.ivanovo.ru) |
| 08:14.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 09:27.02 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:34.12 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 09:36.35 | *** join/#asterisk-dev winy29 (~winy29@156.35.221.149) |
| 09:37.40 | winy29 | hi, can anybody help me with this? https://stackoverflow.com/questions/47938769/updateconfig-asterisk-extensions-conf |
| 09:39.01 | winy29 | #asterisk |
| 12:19.20 | file | I apparently have to restart JIRA again |
| 13:10.55 | *** join/#asterisk-dev joshelson (~joshelson@208.186.235.212) |
| 13:37.42 | *** join/#asterisk-dev jkroon (~jkroon@196.23.25.68) |
| 13:43.54 | file | huh |
| 13:47.09 | file | ah |
| 13:52.29 | *** join/#asterisk-dev jkroon (~jkroon@196.23.25.68) |
| 13:53.29 | file | rebase, rebase, rebase |
| 14:10.10 | seanbright | gtjoseph: coreyfarrell: file: we ready to fast track some whitespace only patches through gerrit while the volume is currently low? |
| 14:10.24 | file | it's the holidays, be nice |
| 14:10.34 | seanbright | i am being nice |
| 14:10.37 | seanbright | you're anti? |
| 14:10.56 | seanbright | is serious |
| 14:11.09 | seanbright | i'll fix up the resulting merge conflicts |
| 14:12.01 | file | you can put anything up for review :P |
| 14:12.58 | file | I'm in triage land |
| 14:14.46 | seanbright | k |
| 14:24.10 | seanbright | gtjoseph: coreyfarrell: if we want to do this whitespace thing, the patches are up |
| 14:42.08 | gtjoseph | seanbright: i'm looking |
| 14:44.05 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 14:44.05 | *** mode/#asterisk-dev [+o DivideBy0] by ChanServ |
| 14:46.55 | gtjoseph | seanbright: I've looked. |
| 14:52.24 | *** join/#asterisk-dev joshelson (~joshelson@208.186.235.212) |
| 14:54.32 | seanbright | i've abused my +2 privileges |
| 14:57.10 | file | all is forgiven in this time of December |
| 15:00.15 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-suabcazrzeqhysec) |
| 15:00.15 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:02.11 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:02.11 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:04.58 | seanbright | is excited for the merge conflicts |
| 15:05.26 | seanbright | ugh... i wasn't logged in to gerrit when i viewed the list of open reviews |
| 15:05.40 | file | shhhhhhh |
| 15:05.51 | seanbright | i know |
| 15:46.59 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:46.59 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:50.11 | seanbright | is tests/rest_api/applications/subscribe-all known to be flaky or could this be legit? |
| 15:52.10 | file | known to be flaky |
| 15:52.24 | file | issue is in queue to be looked at soon |
| 15:52.30 | seanbright | ð |
| 15:52.39 | coreyfarrell | no that test failed because you removed trailing whitespace. |
| 15:52.47 | seanbright | oh |
| 15:52.49 | seanbright | shit |
| 15:53.38 | seanbright | but i didn't touch the tests |
| 15:53.43 | coreyfarrell | .. in case it's unclear I'm joking. I think that test failed when I edited README.md. |
| 15:53.48 | seanbright | oh |
| 15:53.52 | seanbright | no, wasn't clear |
| 15:53.53 | seanbright | sorry |
| 15:54.05 | file | clear as bananas |
| 16:21.34 | seanbright | only 1 merge conflict? niiice |
| 16:31.21 | coreyfarrell | doesn't matter that review is dead as it stands. |
| 16:32.37 | file | yes |
| 16:32.39 | coreyfarrell | I moved main/netsock.c and asterisk/netsock.h into the chan_iax2 module (in master) so that patch would not compile in master. |
| 16:44.14 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-shxfzstqrnwhksbn) |
| 16:44.14 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 16:58.01 | coreyfarrell | file / gtjoseph / seanbright: do you have opinions on https://gerrit.asterisk.org/7670 ? |
| 16:58.33 | gtjoseph | i'm off today, so no :) |
| 16:59.03 | coreyfarrell | gtjoseph: well then enjoy your day off |
| 17:01.33 | file | coreyfarrell: personally I'm fine with removing it from 15 tbh but cresl1n should answer |
| 17:03.18 | cresl1n | coreyfarrell: I think we are going to pull it from 15. But wanted to get the latest version of Richard's patch sync'd in before pulling. |
| 17:04.56 | coreyfarrell | cresl1n: latest version of Richard's patch sync'd? sorry I don't understand that part of your comment. |
| 17:10.16 | cresl1n | sorry |
| 17:10.26 | cresl1n | trying to get the code up to date with master before yanking it |
| 17:10.31 | cresl1n | for completeness yo |
| 17:11.31 | coreyfarrell | so you want to merge those 3 reviews then another one to delete the whole thing? |
| 17:11.47 | cresl1n | goes to look more |
| 17:12.09 | cresl1n | That was the idea. |
| 17:12.21 | cresl1n | Although the delete part didn't have a specifc ETA at this point :-) |
| 17:12.44 | cresl1n | Just a general "That seems like a good idea since we're not going to end up using it this cycle" |
| 17:16.55 | coreyfarrell | cresl1n: I don't have a problem with merging Richard's reviews then immediately removing the new SDP, but I don't think it should be done separately. |
| 17:17.48 | coreyfarrell | We are breaking the existing ABI. Fine that we've decided that's OK in this case, I just think we should do everything to avoid breaking it again. so we shouldn't change the new SDP API in 15.3.0, then delete it from 15.4.0 because that's two versions in a row with breaking changes. |
| 17:21.44 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-cvqucmoyyqqurcnb) |
| 17:21.44 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 18:00.37 | *** join/#asterisk-dev Demon_VoIP (~demon@109.60.222.253) |
| 18:06.32 | *** join/#asterisk-dev jkroon (~jkroon@197.96.224.13) |
| 18:41.47 | seanbright | coreyfarrell: my vote is to just remove it. was that the question? |
| 18:59.07 | seanbright | should we add release notes about the whitespace change? |
| 19:00.27 | cresl1n | Alright, let's do it then. |
| 19:01.23 | cresl1n | We'll merge them, then pull it |
| 19:01.36 | cresl1n | or rather, merge them, then remove it |
| 19:03.40 | *** join/#asterisk-dev jkroon (~jkroon@197.96.224.13) |
| 19:15.07 | rmudgett | seanbright: What was the question? ^^^ |
| 19:15.29 | seanbright | file / gtjoseph / seanbright: do you have opinions on https://gerrit.asterisk.org/7670 ? |
| 19:16.34 | cresl1n | I think they're both out for the day |
| 19:16.36 | cresl1n | technically |
| 19:16.41 | seanbright | pffft |
| 19:16.44 | seanbright | slackers |
| 19:16.45 | file | we already responded |
| 19:16.55 | file | it is the past. |
| 19:17.10 | seanbright | yes. |
| 19:17.12 | rmudgett | Was the response to merge and then remove or to simply remove? |
| 19:17.12 | seanbright | i am moving on |
| 19:17.36 | cresl1n | rmudgett I suppose it's not that much different to just not merge and remove, right? |
| 19:17.46 | cresl1n | what was your thought process between sync'ing first? |
| 19:18.12 | file | we've given this more time than it deserves |
| 19:18.16 | cresl1n | I think so too |
| 19:18.24 | cresl1n | Let's just move forward with the proposed plan |
| 19:18.26 | cresl1n | merge and remove |
| 19:19.12 | rmudgett | Well synching first leaves the ast_stream_str2state() in v15 w/ no callers. However, it is a potentially useful function for debug messages. |
| 19:19.22 | cresl1n | meh |
| 19:19.26 | cresl1n | let's wait for a use case |
| 19:19.48 | rmudgett | oops wrong way for that function. |
| 19:19.49 | cresl1n | that's my .02 |
| 19:20.20 | rmudgett | Its only really useful for the SDP code. |
| 19:20.48 | cresl1n | So maybe corey's right |
| 19:21.06 | cresl1n | let's just abandon the sync patch set and instead push up a review to remove the code |
| 19:21.15 | cresl1n | you ok with that rmudgett? |
| 19:21.34 | rmudgett | yep. Almost have a patch to push up that simply removes the modules. |
| 19:21.50 | rmudgett | Was actually working on doing it. :) |
| 19:25.12 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00c1ec645597864150.ipv6.abo.wanadoo.fr) |
| 19:31.50 | cresl1n | Thanks rmudgett |
| 19:36.52 | coreyfarrell | rmudgett / cresl1n: should that removal be mentioned in in CHANGES? |
| 19:37.16 | rmudgett | Don't see why. It is dead code on v15. |
| 19:37.40 | cresl1n | Probably would be good for some sort of explanation |
| 19:38.11 | coreyfarrell | I was thinking since we're removing a module.. |
| 19:38.23 | cresl1n | yeah... |
| 19:38.37 | coreyfarrell | unused or not a packager would notice that and want to know why. |
| 19:38.51 | cresl1n | +1 |
| 19:39.34 | rmudgett | I suppose the res_sdp_translator_pjmedia module is visible. So ok |
| 19:40.25 | rmudgett | Jenkins choked on it for some inexplicable reason. :( |
| 19:40.30 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00b14ca5e2b1792efd.ipv6.abo.wanadoo.fr) |
| 19:41.02 | cresl1n | Jenkins!!!!!!!!!!!!!!! |
| 19:42.03 | coreyfarrell | rmudgett: I think that's a bug in our jenkins check script. it asterisk fails to startup it doesn't tell us anything about why. |
| 19:52.25 | coreyfarrell | rmudgett: main/sdp_srtp.c is not dead code. |
| 19:52.38 | rmudgett | yep |
| 20:23.55 | coreyfarrell | does anyone actually maintain cel_pgsql? I found a bunch of bugs with it but fixing is more work than I'm willing to put in. |
| 20:27.25 | seanbright | coreyfarrell: there is a refactoring patch on jira somewhere |
| 20:27.43 | seanbright | as for who maintains it... <support_level>extended</support_level> |
| 20:27.48 | seanbright | NOT IT |
| 20:29.17 | seanbright | i think both cel_pgsql and cdr_pgsql and res_config_pgsql are all garbage... but what do i know? |
| 20:30.23 | coreyfarrell | seanbright: yeah the cel_pgsql bugs are not trivial. pgsql_log has 3 paths which fail to unlock and among all the 'return' points it has 47 findings of 'resource leak'. |
| 20:30.49 | seanbright | well luckily no one uses CEL, so we're in the clear |
| 20:31.02 | coreyfarrell | IMO modules like that should be more clearly marked in menuselect. <support_level>broken</support_level> |
| 20:31.19 | rmudgett | s/broken/garbage/ |
| 20:31.52 | seanbright | well, given the state of extended support i think those things are synonymous |
| 20:32.05 | file | wild wild west |
| 20:32.09 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00a803ec9ce258e56b.ipv6.abo.wanadoo.fr) |
| 20:32.14 | seanbright | woop |
| 20:32.14 | *** join/#asterisk-dev joshelson (~joshelson@208.186.235.212) |
| 20:33.03 | file | https://www.youtube.com/watch?v=_t_UuTCbCZU |
| 20:53.22 | coreyfarrell | on the plus side of cel_pgsql it shows how asterisk has improved. no way in hell that code would be accepted today. |
| 21:13.32 | seanbright | whitespace whitespace everywhere and not a drop to drink |
| 21:27.43 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0039037a41911345cf.ipv6.abo.wanadoo.fr) |
| 21:40.02 | cresl1n | seanbright: Ha! |
| 21:40.11 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00f8a0559b12e83b4f.ipv6.abo.wanadoo.fr) |
| 21:40.11 | cresl1n | Rhyme of the Ancient Mariner |
| 21:46.43 | seanbright | well, i'm off until tuesday. i'll talk to you guys next week. if you celebrate christmas, have a merry one. |
| 21:51.38 | cresl1n | see you seanbright! |
| 21:51.47 | cresl1n | have a merry christmas to you too |
| 22:48.53 | *** join/#asterisk-dev joshelson (~joshelson@67.214.249.12) |
| 23:02.36 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d002def88047da648e6.ipv6.abo.wanadoo.fr) |
| 23:34.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0060569f9d6a85e979.ipv6.abo.wanadoo.fr) |
| 23:49.23 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0059ceb4af9b66a8f4.ipv6.abo.wanadoo.fr) |