| 00:35.25 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:8d85:44f:e898:c774) |
| 00:35.25 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:06.25 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:8010:36af:5a6d:9a12) |
| 01:06.26 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:18.57 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 01:18.57 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 02:10.07 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:dee:2693:71f0:5bc9) |
| 02:10.07 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:43.48 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:7509:fa63:93ac:b4ed) |
| 04:43.48 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 07:59.54 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 08:00.25 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 09:51.15 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 09:51.15 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 10:19.55 | *** join/#asterisk-dev mvanbaak (~mvanbaak@asterisk/contributor-and-bug-marshal/mvanbaak) |
| 10:19.55 | *** mode/#asterisk-dev [+o mvanbaak] by ChanServ |
| 10:23.46 | *** join/#asterisk-dev spditner (~simon@45.72.214.116) |
| 12:31.47 | *** join/#asterisk-dev Worldexe (~Worldexe@95-107-33-134.dsl.orel.ru) |
| 12:45.19 | gtjoseph | coreyfarrell: |
| 12:45.20 | gtjoseph | [Dec 18 05:39:43] ERROR[2539]: chan_alsa.c:974 load_module: Unable to read ALSA configuration file alsa.conf. Aborting. |
| 12:45.20 | gtjoseph | Aborted |
| 12:45.27 | gtjoseph | that can't be right. |
| 12:45.43 | gtjoseph | chan_alsa does a DECLINE not FAILURE |
| 12:49.25 | gtjoseph | hmmm. might not me related to your loader work. |
| 12:49.31 | gtjoseph | s/me/be/ |
| 12:52.24 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:d095:a731:5990:f17) |
| 12:52.24 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:55.13 | file | gtjoseph: kaboom! |
| 12:55.32 | gtjoseph | yeah. it's weird. |
| 13:20.03 | gtjoseph | heh, the abort was actually coming from pjproject cancl_timer (despite the Aborting message from chan_alsa). |
| 13:20.20 | gtjoseph | it's still odd though. |
| 13:20.43 | gtjoseph | the timer was from outbound_registration. |
| 13:47.03 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-pslmgnezhlqefgmi) |
| 13:47.03 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:51.38 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-gyrprvprmsyvbyxl) |
| 13:51.38 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:58.59 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-uktfneqswepsltxd) |
| 14:58.59 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 15:38.51 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 15:38.51 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 15:41.44 | seanbright | file: jira cleanup day? |
| 15:41.54 | file | day... |
| 15:41.55 | file | week... |
| 15:41.56 | file | year... |
| 15:41.57 | file | eternity. |
| 15:42.02 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:42.02 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 15:42.07 | seanbright | :/ |
| 15:42.07 | cresl1n | jiracleanup4life |
| 15:44.55 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-bplivlomuayskfdd) |
| 15:44.55 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:45.12 | file | the way I had to get the list is just silly, but leedm777 showed me the way |
| 15:45.20 | file | it involves 3 filters. |
| 15:45.36 | file | go go JIRA. |
| 15:45.44 | leedm777 | And unnatural abuses of JQL |
| 15:46.13 | file | yes. |
| 15:57.28 | *** join/#asterisk-dev gtjoseph_ (~gtjoseph@unaffiliated/gtj) |
| 15:57.28 | *** mode/#asterisk-dev [+o gtjoseph_] by ChanServ |
| 16:01.12 | *** join/#asterisk-dev jkroon (~jkroon@mwb-sil-gw.megs.co.za) |
| 16:19.02 | coreyfarrell | file: the issues you are tagging with 13.18.4 are those the ones you suspect are still valid? |
| 16:19.09 | file | yes |
| 16:19.18 | file | or they are patches which would still be applicable |
| 16:22.06 | cresl1n | file: tell me about what you think about the dundi review⦠|
| 16:22.51 | cresl1n | seems like you might be on the fence about it |
| 16:23.11 | file | you always want something when I'm lunching or done work :P |
| 16:23.15 | cresl1n | osnap |
| 16:23.16 | cresl1n | ok |
| 16:23.25 | cresl1n | Let's save this until later then |
| 16:23.51 | file | cresl1n: any code we take in is code we are supporting in some capacity - the netsock2 support has gotten used in lots of places, is understood, and we know it works |
| 16:24.00 | cresl1n | yeah |
| 16:24.12 | file | duplicating it is something I'm not keen on, we don't know what other gotchas or bugs it may have |
| 16:24.18 | coreyfarrell | looks like gerrit/jenkins/whatever automerge is down...? |
| 16:24.36 | gtjoseph_ | no, waiting on parents to merge |
| 16:25.00 | gtjoseph_ | which they have now... |
| 16:25.34 | coreyfarrell | I was going to say it looks like the parents are already merged but the last 2 loader-work patches are just sitting for all branches. |
| 16:26.14 | gtjoseph_ | yeah, there was also a conflict earlier that may have caused that |
| 16:26.26 | file | cresl1n: if there were a well defined problem with using netsock2 then I'd certainly reconsider, but I don't see or understand one personally |
| 16:27.09 | coreyfarrell | cresl1n: re: the dundi review I'm not a fan, I was actually considering proposing that we move netsock.c / netsock.h into channels/iax2. as far as I'm concerned (as someone who does not use chan_iax2) netsock.c is deadcode. |
| 16:28.11 | cresl1n | Ok, so that's two prominent votes against |
| 16:28.23 | cresl1n | at least in its current state |
| 16:28.38 | cresl1n | I can't see it going into anything other than master as well |
| 16:28.48 | cresl1n | because of no tests |
| 16:28.58 | cresl1n | But that's a different layer of the problem |
| 16:32.02 | coreyfarrell | even with tests I'd be concerned about any big change to an extended support module going to release branches. I don't use dundi so I don't care that much but if it were chan_sip for example I'd be loudly resistant. |
| 16:34.39 | cresl1n | yeah |
| 16:34.42 | cresl1n | understand |
| 16:35.09 | cresl1n | sounds like they're using it though⦠|
| 16:38.37 | file | there are people using it, and it "just works" for them |
| 16:38.42 | cresl1n | yeah |
| 16:38.44 | file | harming that would be... ermph |
| 16:41.28 | coreyfarrell | cresl1n: them using it doesn't mean that they will have the ability/motivation to deal with issues other users face as a result of the patch (I've never seen the author's name on gerrit before).. |
| 16:47.00 | cresl1n | yeah |
| 16:47.23 | cresl1n | So from this discussion, this is kind of what I'd like to see from them: |
| 16:47.27 | cresl1n | 1.) It go into master only |
| 16:47.31 | cresl1n | 2.) it come with tests |
| 16:47.41 | cresl1n | 3.) it's converted over to netsock2 |
| 16:47.47 | cresl1n | Did I miss anything? |
| 16:48.50 | cresl1n | Because just saying that there are no conditions under which we'd accept merging doesn't seem right |
| 16:48.55 | cresl1n | we can always revert it too |
| 16:48.56 | coreyfarrell | cresl1n: on #2 I'm not necessarily trying to hold them to higher standard than others. policy is that tests are not required for master so .. |
| 16:49.05 | cresl1n | Well |
| 16:49.11 | cresl1n | Yeah. |
| 16:49.32 | cresl1n | So stick to 1.) and 3.)? |
| 16:49.52 | coreyfarrell | +1 |
| 16:49.56 | cresl1n | And if there are significant issues, it could get just get reverted one day? |
| 16:50.03 | cresl1n | Unless they want to fix it |
| 16:50.21 | gtjoseph_ | doesn't like " policy is that tests are not required for master" |
| 16:50.33 | cresl1n | yeah.... |
| 16:50.38 | coreyfarrell | gtjoseph_: I'm not a fan of that policy either but it is the policy... |
| 16:50.44 | gtjoseph_ | i know |
| 16:50.52 | gtjoseph_ | we've debated it a lot |
| 16:51.15 | coreyfarrell | personally I'd prefer asterisk take a more test driven approach / always require tests but that's not how it is so I'm just saying we should enforce policies fairly |
| 16:55.03 | cresl1n | I think that's not a bad direction to head in. Maybe something we could consider after next release. |
| 16:55.09 | cresl1n | (major release) :-) |
| 17:01.16 | coreyfarrell | cresl1n: we'll need some kind of lcov reporting, maybe a weekly job to publish coverage reports for each branch. I tried adding --enable-coverage to jenkins once, I don't fully remember but I think it took too long (caused job timeout). |
| 17:10.03 | cresl1n | That'd be pretty neat if we could make it work |
| 17:20.07 | coreyfarrell | honestly I've found working with the infrastructure repo to be very cumbersome. the inability to test changes is difficult because a change has to go through review and get merged, then a few days later we have a problem and the change gets reverted after it's no longer fresh in mind. |
| 17:22.39 | coreyfarrell | I know it's a mostly unfixable issue but still mentioning it anyways |
| 18:03.57 | *** join/#asterisk-dev jploh (~textual@118.211.111.163) |
| 18:07.13 | jploh | How far are we from the Docker rollout? I read on the blog post that it got delayed from a comment reply by George Joseph. |
| 18:12.03 | file | Docker rollout of what? |
| 18:12.06 | gtjoseph_ | i'm hoping for sometime in January |
| 18:12.15 | file | if you mean the testsuite then yeah |
| 18:22.36 | file | everyone, you can rest easy for the rest of the day on JIRA emails for my eyes can't take anymore today |
| 18:22.57 | file | tomorrow though... that's different |
| 18:25.18 | rmudgett | file: coreyfarrell's core set verbose patch shouldn't go in yet. :) |
| 18:26.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0028959fff53ec0674.ipv6.abo.wanadoo.fr) |
| 18:29.31 | coreyfarrell | rmudgett: see my response on gerrit |
| 18:30.10 | rmudgett | Yes that should do it. I thought I scrolled for other changes in that patch but only saw the code removal. :) |
| 18:37.06 | jploh | @gtjoseph_ Thank you! I read on the blog it's still internal. Is that correct? I can't run it myself yet? |
| 18:37.46 | gtjoseph_ | Oh no, you can run asterisk and the testsuite in Docker right now. |
| 18:38.13 | jploh | Oh I get it. Will check it out. Thanks again! |
| 18:38.25 | gtjoseph_ | It's just the infrastructure around the Jenkins Continuous Integration that's the issue. |
| 18:38.33 | jploh | I see. |
| 20:04.33 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d009dc91a5333c2e4e5.ipv6.abo.wanadoo.fr) |
| 20:28.31 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0065f61c42cf66caaa.ipv6.abo.wanadoo.fr) |
| 20:59.59 | rmudgett | We might be in the eye of the coreyfarrell review storm. :) |
| 21:01.49 | *** join/#asterisk-dev ChanServ (ChanServ@services.) |
| 21:01.49 | *** mode/#asterisk-dev [+o ChanServ] by cherryh.freenode.net |
| 21:04.49 | coreyfarrell | rmudgett: yeah I have a dozen more patches for the module loader but they need another round of tweaks before they're ready for serious review. thankfully those patches will all be master only so a dozen won't turn into 3 dozen. |
| 21:10.58 | coreyfarrell | can anyone take a look at https://github.com/asterisk/asterisk/blob/master/main/xmldoc.c#L1440-L1444 ? comments indicate that all but the first should be prefixed by a tab, but count is never incremented from 0 so tabs are never used. |
| 21:12.22 | coreyfarrell | it was identified because 'count' is constant in that function. I was going to remove the variable/conditionals but I'm thinking maybe count should be incremented by the loop instead |
| 21:13.35 | gtjoseph_ | are you asking if that's a bug or feature? :) |
| 21:14.34 | gtjoseph_ | i'd say ignore the comment and just make it work correctly. |
| 21:15.14 | coreyfarrell | I'm asking if we should fix that function by adding 'count++' to the loop or just get rid of count and the conditionals (never print tabs in that loop). current behavior is that we never print tabs in the loop |
| 21:16.15 | gtjoseph_ | does printing the tabs make the output look better? cuz it's awful now :) |
| 21:16.40 | gtjoseph_ | make |
| 21:23.51 | coreyfarrell | hmm guess not. took a while to find an example where it made a difference but adding the tab made it worse. |
| 21:27.28 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0074c5afac33604a1d.ipv6.abo.wanadoo.fr) |
| 21:40.17 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 21:40.17 | *** mode/#asterisk-dev [+o DivideBy0] by ChanServ |
| 22:20.34 | rmudgett | coreyfarrell: I can't say much about chan_skinny video either. :) |
| 22:40.51 | coreyfarrell | rmudgett: I can say I don't really care but it was flagged by a scan and it's easier to fix than suppress |
| 22:47.40 | seanbright | file: is there a tentative release date for 13.18? |
| 22:47.45 | seanbright | err, 13.19 |
| 22:48.05 | file | next task in queue is to cut an rc |
| 22:48.15 | seanbright | k |
| 22:48.23 | seanbright | where is my OPTIONS patch? hrmmmm? |
| 22:48.38 | file | it's a big release, so personally I'd rather we have a long rc for it and do an actual release post-Christmas |
| 22:48.51 | file | I finished it up this weekend, need to add some more tests, but it seems to work |
| 22:48.55 | seanbright | good man |
| 22:49.56 | file | taking a break from it at the moment, some time away will let any ideas re: possible bugs come to mind |
| 22:56.24 | seanbright | coreyfarrell: while you're cleaning stuff up... include/asterisk/channel.h:4233 in master |
| 23:00.47 | coreyfarrell | seanbright: looks like that comment is mostly inaccurate, those functions are used by channel drivers |
| 23:04.12 | seanbright | hmmmm |
| 23:04.29 | seanbright | well then, carry on |
| 23:06.09 | file | carry on my wayward sonnnnnnn |
| 23:22.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00dd6953e7f0440fae.ipv6.abo.wanadoo.fr) |