| 00:13.17 | *** join/#asterisk-dev Bordr (~Bordr@c-24-9-55-138.hsd1.co.comcast.net) |
| 00:13.52 | *** join/#asterisk-dev Bordr (~Bordr@c-24-9-55-138.hsd1.co.comcast.net) |
| 01:03.31 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:e85f:9c09:c01b:1094) |
| 01:03.31 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:21.45 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:44a3:5b2f:e2c8:adda) |
| 03:21.45 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:31.45 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:d46:28c8:f279:af8e) |
| 04:31.45 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 06:03.18 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 06:30.47 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 06:34.16 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 06:34.19 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 06:52.30 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 08:40.59 | file | beep boop |
| 10:16.21 | skrusty | hey |
| 12:06.37 | file | Hello |
| 12:43.54 | *** join/#asterisk-dev tuxd00d_ (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 12:55.05 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-xjalhebfvjcmedqa) |
| 12:55.05 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:19.51 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 14:12.57 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:12.57 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:13.44 | *** join/#asterisk-dev stefan27 (~stefan27@static-212-247-4-149.cust.tele2.se) |
| 14:21.46 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-dodtirxkqnutfsxh) |
| 14:21.46 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:54.47 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-bjdygynuqdzdgevg) |
| 14:54.48 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:05.22 | JunK-Y | flying later to AstriCon. |
| 15:07.23 | *** join/#asterisk-dev newtonr (newtonr@nat/digium/x-abcswfbbbiwsnyqu) |
| 15:07.24 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 15:08.51 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.164) |
| 16:15.33 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-wtlldmwmicrukbjh) |
| 16:15.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:35.47 | *** join/#asterisk-dev tzafrir (tzafrir@nat/redhat/x-fstwudqmmlkcruno) |
| 16:35.47 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 16:43.50 | *** join/#asterisk-dev Bordr (~Bordr@c-24-9-55-138.hsd1.co.comcast.net) |
| 16:52.13 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-typxlojiazrqpirj) |
| 16:52.13 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:56.01 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-kybghvwydismpqhj) |
| 16:56.01 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 17:07.39 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-dodtirxkqnutfsxh) |
| 17:53.56 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-icqctjqtnvgpvvbm) |
| 17:53.56 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:48.31 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-86-98.dhcp.nwtn.ct.charter.com) |
| 19:48.31 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 19:49.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00b42b21f5eff65a22.ipv6.abo.wanadoo.fr) |
| 20:13.25 | stefan27 | Hello rmudgett I updated 6634 with a new comment |
| 20:14.05 | stefan27 | if you would like to discuss it less formally here, I'm here :) |
| 20:15.33 | *** join/#asterisk-dev zerohalo (~zerohalo@2601:199:417f:8a6d:6c42:a05e:8558:7cfe) |
| 20:20.22 | rmudgett | stefan27: announce-to-first-user was created by https://issues.asterisk.org/jira/browse/ASTERISK-21782 expressly because of the duplicated announcements you were removing. People were seeing that those duplicated announcements were happening right when the queue agent answered the call. |
| 20:21.08 | stefan27 | Aha, you're better at digging into git history than me |
| 20:21.17 | rmudgett | I think all along the makeannouncement code should have been fixed by the patch that added the duplicated announcements. |
| 20:22.15 | rmudgett | Even then the patch that was reviewed on reviewboard was not what actually got committed. |
| 20:22.18 | stefan27 | Let me think |
| 20:23.12 | rmudgett | git blame apps/app_queue.c helps find the commits. :) |
| 20:23.16 | stefan27 | hmm... in either case we have two spuriously named variables in app_queue.c |
| 20:28.42 | stefan27 | announce-to-first-user and makeannouncement may confuse the next read of app_queue.c as much as me... |
| 20:28.48 | stefan27 | reader* |
| 20:29.56 | stefan27 | We have to keep the attribute announce-to-first-user around just to surpress the first iteration say_position calls? |
| 20:30.02 | rmudgett | The original https://issues.asterisk.org/jira/browse/ASTERISK-27216 patch was mostly a code optimization to remove the redundant announcements. |
| 20:31.09 | rmudgett | Yes we would need to keep the option to preserve historic behavior. |
| 20:32.28 | stefan27 | In light of the information "stefan27: announce-to-first-user was created by https://issues.asterisk.org/jira/browse/ASTERISK-21782 expressly because of the duplicated announcements you were removing." I agree with your change |
| 20:35.15 | stefan27 | But It makes the code very confusing to read to anyone not involved in this commit history |
| 20:35.44 | stefan27 | With or without your patch code is confusing* |
| 20:37.11 | stefan27 | Hmm.. But it still doesn't add up. Why was there such a description of announce-to-first-user in queues.conf.sample? |
| 20:37.31 | rmudgett | app_queue is very old code and has been modified by many people over the years. Entropy does creep in. :) |
| 20:37.36 | *** join/#asterisk-dev scudella (~libardi@187.64.235.152) |
| 20:38.10 | stefan27 | It looks as if whoever wrote that description thought the purpose of the parameter was a kill-switch for all announcements for head callers |
| 20:38.27 | rmudgett | I think announce-to-first-user was named because that was the original intention of the duplicated announcements. |
| 20:39.25 | stefan27 | There might have been some misunderstanding at that point as well |
| 20:39.39 | rmudgett | Another part of the description mentions that the announcements delay connecting to the queue agent. |
| 20:39.43 | stefan27 | Matthew Jordan 2013-06-10 14:36:15 |
| 20:41.50 | stefan27 | right |
| 20:42.02 | rmudgett | It was a kill switch for the added problem announcements. :) |
| 20:43.13 | rmudgett | It is also very difficult to have good names for obscure corner case options. |
| 20:44.48 | stefan27 | We have 100s of asterisks running for many years, noone ever reported the problem prompting me to make the first patch until a few months ago |
| 20:45.15 | stefan27 | it's something that happens once to end user and then not again for a long time so it looks random |
| 20:50.22 | stefan27 | You typically do not add lots of comments to your asterisk source code? I've seen code projects flooded with "cf issue https://blaboo/444" |
| 20:50.49 | stefan27 | comments regarding hotfix/issues |
| 20:52.31 | stefan27 | Anyways, your commit will preserve all the behaviour I want, and the confusing variable names is another problem. Non digium-users never upvote commits right? I'm gonna to sleep if I contrary to expectation think of yet another angle of this I'll get back |
| 20:52.46 | stefan27 | good night |
| 20:55.31 | rmudgett | Commends to the effect of: "cf issue https://blaboo/444" don't add any value. That's what version control such as subversion and git is for. |
| 20:55.50 | rmudgett | s/Commends/Comments |
| 22:04.54 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 22:04.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 23:02.20 | *** join/#asterisk-dev dadrc (~quassel@unaffiliated/dadrc) |