| 00:56.24 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 01:44.07 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:8011:6d23:3854:5e02:e1ec) |
| 01:44.07 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 03:56.25 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 04:08.46 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 06:50.05 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:07.34 | *** join/#asterisk-dev tsearle (~tsearle@2a02:2788:1004:636:d74:308a:80ff:9c6c) |
| 07:07.34 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:17.14 | *** join/#asterisk-dev tzafrir (~tzafrir@local.xorcom.com) |
| 07:17.14 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:43.41 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:45.02 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 08:45.02 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 09:20.56 | *** join/#asterisk-dev tsearle (~tsearle@2a02:2788:1004:636:d74:308a:80ff:9c6c) |
| 09:20.56 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 09:22.00 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 09:22.00 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 09:31.45 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 10:44.04 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 11:15.22 | *** join/#asterisk-dev tsearle (~tsearle@2a02:2788:1004:636:d74:308a:80ff:9c6c) |
| 11:15.22 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 11:56.43 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 12:02.55 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 12:31.27 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-ybwkubjhzijojfhv) |
| 12:31.28 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 12:59.08 | *** join/#asterisk-dev newtonr (newtonr@nat/digium/x-bvrwzahcawsvggtf) |
| 12:59.08 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 13:05.29 | seanbright | what is the magic setting that makes asterisk rewrite it's own Contact? |
| 13:05.39 | seanbright | not talking about rewrite_contact |
| 13:06.05 | seanbright | is it 'domain' on transport? |
| 13:06.15 | file | local_net and external_signaling_address? |
| 13:06.56 | seanbright | hmm. those are both set. |
| 13:09.13 | seanbright | file: https://pastebin.com/raw/d41CxwPG |
| 13:09.17 | seanbright | that look right-ish? |
| 13:09.33 | seanbright | asterisk behind nat, srbtest behind another nat |
| 13:09.58 | file | yes, seems right-ish |
| 13:10.03 | seanbright | k |
| 13:11.44 | gtjoseph | what happens if you bind to a specific address? |
| 13:13.50 | seanbright | gtjoseph: no change |
| 13:14.14 | gtjoseph | what are you seeing? Still local ipv4? |
| 13:14.36 | seanbright | gtjoseph: https://pastebin.com/raw/KgT5hKkf |
| 13:15.08 | seanbright | yes, the Contact header that asterisk sends back to the client has the local UP |
| 13:15.11 | seanbright | IP* |
| 13:15.23 | gtjoseph | ew. the filter is setting it _back_ to a local address? |
| 13:15.31 | seanbright | allegedly |
| 13:15.49 | seanbright | this is the master branch |
| 13:17.13 | gtjoseph | looks |
| 13:18.18 | seanbright | watches gtjoseph look |
| 13:19.40 | gtjoseph | can you test to see if it works before commit 8bac9a83ed06611c8dce3d6293227f4a3cc82c5b |
| 13:19.51 | gtjoseph | oops |
| 13:19.53 | gtjoseph | wrong hash |
| 13:20.09 | gtjoseph | d178f497d2657361374abaa92d517bcdc8a81f97 |
| 13:20.28 | seanbright | ugh |
| 13:20.35 | seanbright | ok, will try |
| 13:25.02 | seanbright | gtjoseph: yes, it works on d178f497d2657361374abaa92d517bcdc8a81f97^ |
| 13:25.24 | gtjoseph | it works ON or before? |
| 13:25.26 | seanbright | (or e9455d22646fbe9b54c08cd9f1824010cb71ec40 if you don't grok the ^ nonsense) |
| 13:25.33 | gtjoseph | yeha ok |
| 13:25.37 | gtjoseph | now try that commit |
| 13:25.46 | seanbright | yessa |
| 13:26.45 | seanbright | borker |
| 13:26.48 | seanbright | borked* |
| 13:27.06 | seanbright | no worky |
| 13:27.17 | gtjoseph | crap. that was my "fix" for non sip/sips uris |
| 13:27.24 | seanbright | you son of a bitch |
| 13:27.32 | gtjoseph | can you open an issue and I'll look right now. |
| 13:27.34 | seanbright | well, at least we caught it |
| 13:27.38 | seanbright | UGH |
| 13:27.44 | seanbright | why do i have to do work |
| 13:27.47 | seanbright | ok, hold on |
| 13:27.57 | gtjoseph | i can open it if you're busy |
| 13:28.03 | seanbright | not busy - lazy |
| 13:28.08 | gtjoseph | :) |
| 13:28.18 | gtjoseph | did you send your pjproject patch to Teluu btw? |
| 13:28.52 | seanbright | no, i was told it would happen |
| 13:28.57 | seanbright | but it is correct |
| 13:29.10 | seanbright | i thought digium had a back channel |
| 13:29.39 | gtjoseph | no problem, i'll send it in |
| 13:30.24 | seanbright | https://issues.asterisk.org/jira/browse/ASTERISK-27295 |
| 13:30.39 | gtjoseph | thanks |
| 13:51.50 | seanbright | gtjoseph: fixed yet |
| 13:51.51 | seanbright | ? |
| 13:51.53 | seanbright | :P |
| 13:52.08 | gtjoseph | just one second.... |
| 13:52.23 | gtjoseph | ok, maybe one hour |
| 13:52.27 | seanbright | heh |
| 13:52.37 | seanbright | so something i discovered yesterday after many hours of debugging... |
| 13:52.48 | seanbright | SRTP doesn't encrypt the RTP header, just everything else |
| 13:53.06 | seanbright | so wireshark still knows it's RTCP |
| 13:53.13 | seanbright | but all of the data is bullshit |
| 13:53.30 | seanbright | and one could waste countless hours trying to figure out why the data was wrong |
| 14:09.42 | gtjoseph | seanbright: are you sure it works in commit e9455d22646fbe9b54c08cd9f1824010cb71ec40 ??? |
| 14:09.54 | seanbright | gtjoseph: why would i lie to you? |
| 14:09.59 | seanbright | want me to test it again? |
| 14:10.12 | gtjoseph | no, that's ok |
| 14:10.19 | gtjoseph | my install may just be messed up |
| 14:10.55 | seanbright | let me do a distclean |
| 14:10.59 | seanbright | give me a few |
| 14:15.05 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-rhrdwsvhivuxsttl) |
| 14:15.06 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:16.56 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:16.56 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:22.29 | seanbright | gtjoseph: confirmed that e9455d22646fbe9b54c08cd9f1824010cb71ec40 works |
| 14:22.33 | gtjoseph | ok |
| 14:22.38 | gtjoseph | it be me |
| 14:40.29 | *** join/#asterisk-dev acidfoo-_ (~nbouliane@24-212-247-229.cable.teksavvy.com) |
| 15:03.16 | seanbright | are the following two lines equivalent: |
| 15:03.21 | seanbright | char foo[100] = { 0 }; |
| 15:03.25 | seanbright | char foo[100] = ""; |
| 15:03.27 | seanbright | ? |
| 15:04.30 | gtjoseph | you would think so |
| 15:05.03 | seanbright | k |
| 15:05.34 | acidfoo-_ | in sip_hangup() in chan_sip.c in Asterisk 11, the state of the channel is not set to DOWN, if I want to set it to DOWN myself because I'm tracking the state of the channel somewhere else.. what should I should be aware of ? a 2 line brainstorm of what Im thinking of doing : http://www.paste.org/flat/86255 |
| 15:07.51 | acidfoo-_ | easier to read: https://pastebin.com/raw/gQzbYsR4 |
| 15:16.36 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-tmwjzdldwqhbpunt) |
| 15:16.36 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:18.02 | *** join/#asterisk-dev jameswf (uid27319@gateway/web/irccloud.com/x-vzwwdkabajcpeqkn) |
| 15:18.39 | jameswf | file: https://gerrit.asterisk.org/#/c/6152/ this is going to be 15.x + only or is it going in to older stuff |
| 15:18.57 | seanbright | 13+ |
| 15:19.01 | jameswf | ugh |
| 15:19.10 | seanbright | ? |
| 15:19.14 | jameswf | kicks kitten |
| 15:19.21 | seanbright | ? |
| 15:19.26 | seanbright | use your words |
| 15:19.57 | jameswf | I don't like it but people want it I guess... IMHO it is a terrible thing |
| 15:21.09 | seanbright | what is terrible about it? |
| 15:21.21 | jameswf | Using "hacks" for business phone lines is so horrible. People open 20 accounts to have 20 lines. Somehow that is easier than even going to a super cheap provider like voip.ms |
| 15:21.46 | seanbright | gotcha |
| 15:21.58 | seanbright | you aren't commenting on the technical merits, just the implications? |
| 15:22.01 | jameswf | I wish google kept to their word and just killed it |
| 15:22.24 | jameswf | no, more ummmm philosophical |
| 15:22.35 | seanbright | gotcha |
| 15:24.14 | jameswf | One concern is that google has been slowly changing refresh token policies to make them "less permanent" so having a static token may not work at some point. I also think they expire when you update your password |
| 15:24.23 | gtjoseph | seanbright: can you double check a pcap for contact. I'm getting the internal address in the debug but external in the actual packet |
| 15:25.08 | seanbright | ok, give me a few |
| 15:25.14 | gtjoseph | no problem |
| 15:29.41 | seanbright | gtjoseph: i see the internal address in the outgoing Contact header in the pcap |
| 15:29.53 | gtjoseph | ok, must be me again |
| 15:29.58 | gtjoseph | thanks for checking |
| 15:30.01 | seanbright | sure |
| 16:00.50 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00d43e807b83dabc3f.ipv6.abo.wanadoo.fr) |
| 16:13.54 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-mcsqswlduxodbfxq) |
| 16:13.54 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 16:42.42 | gtjoseph | seanbright: fixes up for review |
| 16:45.24 | seanbright | file: question when you have a minute... https://pastebin.com/raw/gjYM3iLe |
| 16:45.43 | seanbright | gtjoseph: you have some cruft in the commit message |
| 16:45.47 | seanbright | after the 'Reported by' |
| 16:45.52 | seanbright | before the Change-Id |
| 16:45.53 | file | what is le question? |
| 16:45.59 | gtjoseph | eh |
| 16:46.15 | gtjoseph | Ha! |
| 16:46.18 | seanbright | file: so this is my CMP2Kue test |
| 16:46.31 | seanbright | my local video/audio, and then 4 echo'd streams |
| 16:47.02 | seanbright | the first SR for "their ssrc" = 1234681572 |
| 16:47.09 | seanbright | has a highest seq no and all that |
| 16:47.11 | seanbright | the others do not |
| 16:47.19 | seanbright | i'm wondering if that is a bug |
| 16:49.07 | file | from the perspective of sequence numbers we don't preserve it, we do preserve gaps and out of order representation though |
| 16:50.08 | seanbright | i think i may not be asking the right question |
| 16:50.13 | seanbright | or i do not understand your answer |
| 16:50.22 | file | oh |
| 16:50.26 | seanbright | if you look at the pastebin i posted, all 5 of those packets are sent at the same time |
| 16:50.29 | file | I re-read again |
| 16:50.31 | seanbright | k |
| 16:50.36 | file | I don't remember RTCP that much |
| 16:50.51 | file | so, dunno! |
| 16:50.54 | seanbright | fair enough |
| 16:50.56 | seanbright | thanks! |
| 16:51.37 | seanbright | WHAT GOOD ARE YOU!@? |
| 16:52.00 | seanbright | who is the resident RTCP expert then? |
| 16:52.04 | seanbright | eyes up rmudgett |
| 16:52.59 | seanbright | gtjoseph: fixes my issue |
| 16:53.01 | seanbright | thanks! |
| 17:07.28 | rmudgett | seanbright: That is using app_stream_echo? |
| 17:11.00 | file | yes |
| 17:15.07 | rmudgett | We may not be putting stats in the right buckets or reading them from the right buckets when using bundled. |
| 17:16.14 | rmudgett | It's RTCP so asterisk doesn't care that much since asterisk doesn't use the information. |
| 17:38.42 | seanbright | well asterisk should card godamint |
| 17:38.56 | seanbright | i'll mess around and see if i can find anything interesting |
| 18:04.47 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.171) |
| 18:14.03 | JunK-Y | when there's a Payload Type changed in the RTP stream, we shouldn't create a new SSRC when the rate is not the same? |
| 18:15.12 | rmudgett | That wouldn't be a reason to change the SSRC. |
| 18:17.15 | JunK-Y | RFC 7160, `One way of managing multiple clock rates is to use a different SSRC |
| 18:17.18 | JunK-Y | <PROTECTED> |
| 18:17.21 | JunK-Y | <PROTECTED> |
| 18:17.23 | JunK-Y | <PROTECTED> |
| 18:17.26 | JunK-Y | <PROTECTED> |
| 18:21.45 | seanbright | i think the more relevant text would be: |
| 18:21.46 | seanbright | Schulzrinne, et al. [RFC3550] lists using |
| 18:21.46 | seanbright | <PROTECTED> |
| 18:21.46 | seanbright | <PROTECTED> |
| 18:21.46 | seanbright | <PROTECTED> |
| 18:21.48 | seanbright | <PROTECTED> |
| 18:21.51 | seanbright | <PROTECTED> |
| 18:23.32 | seanbright | i'm not reading anything that suggests we are "wrong" |
| 18:24.12 | seanbright | short RFCs ftw! |
| 18:38.49 | JunK-Y | the remote RTP implementation refuse RTP packets if the clock rates is different. it may be them. |
| 18:42.28 | seanbright | what is the remote RTP implementation? |
| 18:42.43 | seanbright | gtjoseph: when we migrating to 2.7? |
| 18:43.13 | gtjoseph | we have an internal issue to verify all our submitted patches are included and that nothing went into 2.7 thatmight break us |
| 18:43.34 | gtjoseph | i'll probably do some work on it next week while everyone's at astricon |
| 18:43.42 | seanbright | you won't be there!? |
| 18:43.47 | gtjoseph | not this year |
| 18:43.52 | seanbright | i might have to bow out then |
| 18:43.55 | seanbright | why bother? |
| 18:43.59 | gtjoseph | have to go to a wedding in boston this weekend |
| 18:44.03 | gtjoseph | he :) |
| 18:44.38 | gtjoseph | it's me, rmudgett and newtonr holding down the fort next week |
| 18:45.36 | rmudgett | that's me: fortholder |
| 18:45.59 | gtjoseph | hey, i spelled it right |
| 18:57.48 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-mvbafrvbbwonblzw) |
| 18:57.49 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:28.52 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 19:44.55 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-mjnsgppxfjutmujl) |
| 19:44.55 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 19:47.25 | *** join/#asterisk-dev acidfoo-_ (~nbouliane@unaffiliated/acidmen) |
| 19:59.56 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-xtexxcmwusbvdmeo) |
| 19:59.56 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 20:06.24 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 20:06.24 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 21:47.31 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-dkkxdagktpzzgpqe) |
| 21:47.31 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:51.41 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-dgyiefifcbwwnjdv) |
| 21:51.42 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:42.51 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-rhrdwsvhivuxsttl) |
| 23:50.48 | *** join/#asterisk-dev dakudos (~dakudos@c-174-51-19-4.hsd1.co.comcast.net) |