| 02:02.57 | *** join/#asterisk-dev luckman212 (~luckman21@unaffiliated/luckman212) |
| 04:21.52 | *** join/#asterisk-dev Bordr_ (~Bordr@c-24-9-55-138.hsd1.co.comcast.net) |
| 06:24.39 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 07:11.09 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 07:17.47 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:44.21 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:44.21 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:52.43 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:52.43 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:54.59 | *** join/#asterisk-dev tzafrir (~tzafrir@31.154.35.146) |
| 07:54.59 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 08:02.24 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:55.21 | *** join/#asterisk-dev tzafrir (~tzafrir@31.154.35.146) |
| 08:55.21 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 09:02.24 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 09:33.19 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.58.37) |
| 09:42.26 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 10:41.39 | *** join/#asterisk-dev tzafrir (~tzafrir@31.154.35.146) |
| 10:41.39 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 11:18.46 | *** join/#asterisk-dev jkroon (~jkroon@vc-nat-gp-n-41-13-108-17.umts.vodacom.co.za) |
| 11:23.29 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 11:58.35 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 12:19.03 | *** join/#asterisk-dev CELYA_ (~Thunderbi@80.12.59.200) |
| 13:38.32 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 13:38.32 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 13:52.07 | *** join/#asterisk-dev newtonr (newtonr@nat/digium/x-gxbogwjfvjkenmvn) |
| 13:52.07 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 14:19.19 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-udeiaizotjflpmge) |
| 14:19.19 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:21.20 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:21.20 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:22.00 | wdoekes | A-HA, found the discrepancy in the sdp-nat-stuff. in session_outgoing_nat_hook() we don't compare the remote IP to localnet, but the local-IP to localnet; which is a rather inverted check. for that to make sense, it should check *both* the local sdp and the remote sdp to localnet. or.. ugh |
| 14:33.42 | *** join/#asterisk-dev zerohalo (~zerohalo@c-73-123-44-170.hsd1.ma.comcast.net) |
| 14:47.51 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-udetnegxhuihonrw) |
| 14:47.52 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:26.51 | *** join/#asterisk-dev jsmith (~jsmith@fedora/jsmith) |
| 15:26.51 | *** mode/#asterisk-dev [+o jsmith] by ChanServ |
| 15:33.58 | *** join/#asterisk-dev dakudos (~dakudos@c-73-153-12-13.hsd1.co.comcast.net) |
| 17:12.41 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LFbn-1-11898-226.w90-93.abo.wanadoo.fr) |
| 18:29.40 | kharwell | Anyone have any thoughts about https://gerrit.asterisk.org/#/c/6459/ with regards to allowing it into the main code base? I'm concerned about the feasibility of being able to maintain that part of the code moving forward. |
| 18:36.28 | kharwell | Do we want to take on the onus of supporting another database server at this time? |
| 18:37.41 | kharwell | I can't remember. We currently don't have any continuous integration testing for alembic scripts correct? |
| 18:38.17 | file | not for different databases |
| 18:38.18 | rmudgett | We have alembic branch checks but that's it |
| 18:38.36 | file | the SQL gets generated as part of release, and then the branch checking like rmudgett mentioned |
| 18:39.20 | file | do we have any issues against MS-SQL and PJSIP besides alembic related? |
| 18:40.31 | kharwell | I'm not sure. I'd assume if using ODBC it should all act the same |
| 18:40.53 | file | that's "the dream" |
| 18:41.55 | file | stares at JIRA |
| 18:42.44 | file | looks like just Oracle |
| 18:42.52 | kharwell | I'm sure every time someone makes an alembic change they test it against all the databases...okay maybe not |
| 18:43.21 | kharwell | but it's good to do that every once in a while or when we get a report of something is broken |
| 18:43.41 | file | I always use a different rev as a base, so provided other people aren't always writing from scratch... it could be fine |
| 18:43.48 | kharwell | we'll just need a sql server to be able to do that. Which Express I believe is free, so not outside the realm of impossible |
| 18:46.34 | file | I dunnnnnno, anyone else? Bueller? |
| 18:52.35 | rmudgett | alembic is great when you have one target database. With multiple target databases and their variations... |
| 18:52.39 | rmudgett | not so much |
| 18:56.41 | kharwell | Seems like it is more a lack of features and/or bugs in sqlalchemy. Ideally at our abstraction layer we should be able to write database agnostic code and the layer(s) below take care of the nit picky differences |
| 18:57.22 | kharwell | But alas that is not the case so we riddle our scripts with database type specific checks. |
| 18:58.11 | kharwell | That being said would it make more since to push things like this into alembic or sqlalchemy instead of our layer? Or is that a pipe dream too |
| 19:20.10 | *** join/#asterisk-dev dakudos (~dakudos@c-73-153-12-13.hsd1.co.comcast.net) |
| 19:23.54 | *** join/#asterisk-dev tzafrir (~tzafrir@bzq-179-40-170.cust.bezeqint.net) |
| 19:23.54 | *** mode/#asterisk-dev [+o tzafrir] by ChanServ |
| 19:27.12 | file | kharwell: that... I do not know |
| 19:30.56 | rmudgett | for now it is a pipe dream |
| 19:48.12 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 22:16.22 | *** join/#asterisk-dev newtonr (~newtonr@216.186.174.249) |
| 22:16.22 | *** mode/#asterisk-dev [+o newtonr] by ChanServ |
| 22:27.33 | *** join/#asterisk-dev leedm777 (textual@nat/digium/x-umqkrelbdigyjbzh) |
| 22:27.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:33.34 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-udeiaizotjflpmge) |